summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-11sc: rowcol: tdf#50916 initial conversion of Valid* methodsNoel Grandin
just default the params for now Change-Id: I13ee78aeaa1133a167d57520b334d5e644e28ece Reviewed-on: https://gerrit.libreoffice.org/84926 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11convert SwLabelType to scoped enumNoel Grandin
Change-Id: I7e842ad3446e0209732f1eb49f2f78da89db18b7 Reviewed-on: https://gerrit.libreoffice.org/84921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11do not allow both read and write bitmap access to the same bitmapLuboš Luňák
Since BitmapBuffer stores a copy of the bitmap's palette and the bitmap can update its state only when SalBitmap::ReleaseBuffer() is called, setting a palette using write access and then reading the bitmap before the write access is completed could result in inconsistencies. I wrote this while debugging tdf#129077, which eventually turned out to be a different problem, but it still makes sense to check this. Change-Id: I56e9e36c02f2da652cedb3bbc6eb5b630ebaf3ae Reviewed-on: https://gerrit.libreoffice.org/84771 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-11do not store 8bpp bitmaps as Skia's SkBitmap (tdf#129077)Luboš Luňák
Skia does not support paletted images, so it only supports grayscale 8bpp. But whether a bitmap is grayscale depends on the palette, and that can change merely by assigning a different one. Change-Id: If55d31e46e79ef32f08ecd196ba7a6091d05a13f Reviewed-on: https://gerrit.libreoffice.org/84770 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-11tdf#129321 add specific ids for header/footer pagesCaolán McNamara
Change-Id: I8ca6a0067d714b802c1923a7cbc5403d5087a169 Reviewed-on: https://gerrit.libreoffice.org/84939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Removed duplicated includeAndrea Gelmini
Change-Id: Ife9ab434888bfbcdc6ff4446b92f2aa83e6cb449 Reviewed-on: https://gerrit.libreoffice.org/84913 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Related: tdf#129300 add ScVerticalStackCell to provide a descriptionCaolán McNamara
Change-Id: I8ed99f19ff6f4751c0867147fc1a60ac917f083b Reviewed-on: https://gerrit.libreoffice.org/84876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Fix typosAndrea Gelmini
Change-Id: I89ff5493c70d6e64ee6ab65b1b789a0db543c0aa Reviewed-on: https://gerrit.libreoffice.org/84917 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Fix typoAndrea Gelmini
Change-Id: Ia35bd38c40ec65025ab4f43bea71745f15a548c8 Reviewed-on: https://gerrit.libreoffice.org/84915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Fix typoAndrea Gelmini
Change-Id: I3f547719ba9bc335dcaa8be6cfb4c1286eb840fc Reviewed-on: https://gerrit.libreoffice.org/84916 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Fix typo in codeAndrea Gelmini
Change-Id: I64a4c33658d3e75108be1e5f869b024a6100440e Reviewed-on: https://gerrit.libreoffice.org/84899 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-12-11Fix typoAndrea Gelmini
Change-Id: Idbcf73ea3034b62e283537e052c17a9fb3988a8b Reviewed-on: https://gerrit.libreoffice.org/84918 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Fix typoAndrea Gelmini
Change-Id: I4a98f3c835564bd9cb667ce6f3425ce0a5223784 Reviewed-on: https://gerrit.libreoffice.org/84940 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Fix typoAndrea Gelmini
Change-Id: I72f8f3b6ace69f69cdfb2b4ee6de280edbb4291a Reviewed-on: https://gerrit.libreoffice.org/84941 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11tdf#128824 Keep multiselection in style list on right clickSamuel Mehrbrodt
Change-Id: I196f8c7d3a1a0b3267498f6cde55069ba3a60523 Reviewed-on: https://gerrit.libreoffice.org/84882 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11lok: Support per-view help dataTamás Zolnai
Used for showing tooltip windows in LO online. Change-Id: I8b6a7272c75025e717923c839fa8fd9f4cab2903 Reviewed-on: https://gerrit.libreoffice.org/84717 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84803 Tested-by: Jenkins
2019-12-11tdf#128230 (related) Correct wording for the CT disabling dialogGabor Kelemen
Current text is incorrect as already recorded tracked changes will not be lost upon turning off CT, only new ones will not be recorded. Change-Id: Ie8a992438aced3995a51b7fb6cc45ca3d5db79c6 Reviewed-on: https://gerrit.libreoffice.org/84849 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-11Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - tdf#129321 add specific ids for header/footer pages Change-Id: Ie40f10cf09c7501c5babfb1d6825d881c0fd5fd2 Reviewed-on: https://gerrit.libreoffice.org/84938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 make Automatic/Distributed state what is automaticCaolán McNamara
Change-Id: Ib246479761556858e92052edf86a18753d44c583 Reviewed-on: https://gerrit.libreoffice.org/84893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11tdf#129300 If it would create no change, don't force itCaolán McNamara
otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update icon repplacement table (Colibre) Also, replace all ref of .png to .svg Change-Id: Ib2c9d0281cb5bfe3e016f69f2879d2fc90f08181 Reviewed-on: https://gerrit.libreoffice.org/84934 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#129171 more on _XCL and _EXCEL2003 Change-Id: I8892d7534f4a67e4756209f0bbee3cb95d36c59a Reviewed-on: https://gerrit.libreoffice.org/84928 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-11Add commit to ignore listSamuel Mehrbrodt
Change-Id: Ieb0ac6b432c163f2beea8833fd948b6123ae422d Reviewed-on: https://gerrit.libreoffice.org/84929 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11clang-format for infobar filesSamuel Mehrbrodt
Change-Id: Iba097ebe214a6904caf01bfb880b34fdccf673ea Reviewed-on: https://gerrit.libreoffice.org/84570 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11Related: tdf#129267 format numbers with the UI localeCaolán McNamara
Change-Id: I70d8cc48869073596c101eec6a6d3a79db044a78 Reviewed-on: https://gerrit.libreoffice.org/84883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129267 draw also has a similar panel comboboxCaolán McNamara
Change-Id: Icde8c951ba3a0672cbc20989c90783e7c1606965 Reviewed-on: https://gerrit.libreoffice.org/84880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11this is a new source fileCaolán McNamara
Change-Id: I1b86e221b1234fafa2ff1fbf7117c082fb799075 Reviewed-on: https://gerrit.libreoffice.org/84891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Sidebar: Don't expand table design styles verticallyMuhammet Kara
Otherwise, they become veeery high in Online. Change-Id: I2572eb6ac94ad5e46aa596095cd718aef63eed6c Reviewed-on: https://gerrit.libreoffice.org/84868 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-11tdf#105518 F6: Skip infobar when it has no childrenJim Raykowski
Change-Id: Id5375d9acfd20844a56da20fcf08c709423f75e0 Reviewed-on: https://gerrit.libreoffice.org/83636 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11tdf#129005 Make Infobar push buttons keyboard accessibleJim Raykowski
Also indicate infobar has keyboard focus by shading the close button when infobar gets focus. And as a bonus shade the close button on mouseover. Change-Id: Ie714f3e6d1f13d44ced94a02af398c5c75607b94 Reviewed-on: https://gerrit.libreoffice.org/83639 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-11Direct cursor fillmode as comboboxHeiko Tietze
UI only update of many radio buttons into one combo box to comply with HIG Change-Id: If96ee339159def4c3dfa5d3b2f9adb218d1faee3 Reviewed-on: https://gerrit.libreoffice.org/84864 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-11this union not necessary anymoreNoel Grandin
the nSize field is never used Change-Id: I5186999a48152606de721ee96f71ccfa9ed27df3 Reviewed-on: https://gerrit.libreoffice.org/84856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11rename Prc->Percent in swNoel Grandin
Change-Id: I011eb59cf40abc6ff62dd541beb1ebbc50725a05 Reviewed-on: https://gerrit.libreoffice.org/84855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11Fix crash in report builder after 1efeb17837c22499f00299c033ae59ba3910f7d7Mike Kaganski
These expressions depend on evaluation order, and when arguments are constructed from right to left, std::move(xBuilder) has already reset xBuilder to an empty value prior to xBuilder dereference calling weld_*. Change-Id: I89f8ab04aeeab684e8f2edd90310515b2256f9fd Reviewed-on: https://gerrit.libreoffice.org/84912 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-11convert SwSortDirection to scoped enumNoel Grandin
Change-Id: I20eea9b1addf0f7483d1b48a3d74eb342b479d04 Reviewed-on: https://gerrit.libreoffice.org/84854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11tdf#105225 Use new background tab page in Base:Report BuilderJim Raykowski
Section Setup, Page Setup, and Character Settings dialogs Change-Id: I31275ba45f5659fa7fe3988ae0f8ed3978196425 Reviewed-on: https://gerrit.libreoffice.org/64673 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-11convert SwSortOrder to scoped enumNoel Grandin
Change-Id: I24f982749a94e32d388663cc3a518d919bad96ff Reviewed-on: https://gerrit.libreoffice.org/84853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11basegfx: fix assertion textChris Sherlock
Change-Id: Ibfcc30327d2f55b994e3d8aa485bbb5499ed7f22 Reviewed-on: https://gerrit.libreoffice.org/84141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11convert LinkCreateType to scoped enumNoel Grandin
Change-Id: Ia31648d2dbd6eb5d878d7dcc904d1b05b6c1619c Reviewed-on: https://gerrit.libreoffice.org/84852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11convert SectionType to scoped enumNoel Grandin
Change-Id: Ib05b88b05c90b835107128f42c70170660788d00 Reviewed-on: https://gerrit.libreoffice.org/84851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11convert SwFrameSize to scoped enumNoel Grandin
Change-Id: I7e1e641ff180035c7dcefdcfdd185eadbae32142 Reviewed-on: https://gerrit.libreoffice.org/84850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11lok: fix welded dialogsHenry Castro
In the tiled rendering case the dialogs, run asynchronous due to multiple user access. In order to send the messages to the client side, the dialog has to hook a LOKNotifier in the constructor of the SfxViewShell. However, the new weld wrapper classes use the Frame Window, (i.e. Window::GetFarmeWeld()), as a parent of the dialogs. On the other hand, in order to avoid getting the interface implementation inside implementation classes, it has been created a new method Window::GetFrameWindow(), otherwise I have to do a bureaucratic conversion between Interfaces to Implementations ( i.e. UnoWrapperBase::GetUnoWrapper() ) Change-Id: I32c34d82a89211a025250e65a05ce47d30efa0b8 Reviewed-on: https://gerrit.libreoffice.org/84215 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-12-11lok: evaluate assertion if LOK Windows container is emptyHenry Castro
It has defined a map container for every LOK windows assigned a notifier to the client side. However the map container has elements with VclPtr (reference counter) and it is a global data, so when global data are disposing, the VclPtr will destroy the Window when the VCL framework was destroyed that will lead to undefined behavior. So this commit adds an assert inside DeInitVCL to ensure, if someone forgot to Release the LOK Notifier. Change-Id: Ib7f20751af2931f7b0ba3e3d526e734ffc33f171 Reviewed-on: https://gerrit.libreoffice.org/84792 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84909 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-12-10lok: don't show tooltip for popup menus inside dialogsTamás Zolnai
Check Character Properties dialog -> Font Effects -> Font Color popup button. Moving the mouse above the colors, a tooltip is shown with the color name. However when the tooltip window is displayed LO online closes the popup window unexpectedly. Change-Id: I4bb8611640e122fc8187271c8c843c9f29fc0ce0 Reviewed-on: https://gerrit.libreoffice.org/84716 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84802
2019-12-10Calc add Extension support to Tabbed NBandreas kainz
Change-Id: I2a6e17d8c9a126155ec599fe50d6d84d074c8ddc Reviewed-on: https://gerrit.libreoffice.org/84878 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-10LO extension Dialog fill updateandreas kainz
Change-Id: I60c6beb3c0ff869653c21c9d933ea1f449b4318e Reviewed-on: https://gerrit.libreoffice.org/84904 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-10Removed duplicated includeAndrea Gelmini
Change-Id: I4db0983e3ab249fbde8c7db0d895ee4e8bb20c7f Reviewed-on: https://gerrit.libreoffice.org/84877 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-10Fix typosAndrea Gelmini
Change-Id: I73f1f48272a95232658458dff1dc750112a4667e Reviewed-on: https://gerrit.libreoffice.org/84898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-10Fix typoAndrea Gelmini
Change-Id: Ie01e25b3fd2eac9b3902febc2b584b9517bd6f3d Reviewed-on: https://gerrit.libreoffice.org/84897 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-10missing include (Windows --disable-pch; Translate::ExpandVariables)Stephan Bergmann
Change-Id: Iab20b7e8d7975615c128deb8d02940ede1e8ddd7 Reviewed-on: https://gerrit.libreoffice.org/84862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>