summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-14XMLPropertyState needs to be a complete type here nowStephan Bergmann
...at least with VS 2022 Preview 17.6.0 Preview 3.0 and --with-latest-c++, > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(78): error C2036: 'const XMLPropertyState *': unknown size > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(73): note: while compiling class template member function 'std::_Span_iterator<_Ty> &std::_Span_iterator<_Ty>::operator --(void) noexcept' > with > [ > _Ty=const XMLPropertyState > ] > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1414): note: see the first reference to 'std::_Span_iterator<_Ty>::operator --' in 'std::iter_move' > with > [ > _Ty=const XMLPropertyState > ] > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(474): note: see the first reference to 'std::iter_move' in 'std::ranges::_Iter_move::_Cpo::operator ()' > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\__msvc_iter_core.hpp(392): note: see reference to class template instantiation 'std::_Span_iterator<_Ty>' being compiled > with > [ > _Ty=const XMLPropertyState > ] > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(602): note: see reference to variable template 'bool input_or_output_iterator<std::_Span_iterator<XMLPropertyState const > >' being compiled > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1778): note: see reference to variable template 'bool input_iterator<std::_Span_iterator<XMLPropertyState const > >' being compiled > include\xmloff/txtparae.hxx(390): note: see reference to class template instantiation 'std::span<const XMLPropertyState,18446744073709551615>' being compiled Change-Id: Ib5f32df4a696dd1077c171662da48909dad09e33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150386 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 62b337a3d6650b8b3045dd98f59a8c0188f0a6fa "Unit test for removeTextContext." (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Id80b031625134ea6b4d679bfb774fc253206ae18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150374 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14Latest VS 2022 Preview is 17.6.0 nowStephan Bergmann
...while latest proper VS 2022 is 17.5.4 Change-Id: I7d3ff3dea730cf1490a0198922281792e524ed9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150382 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14sw floatable: teach the DOC import about SwFormatFlySplitMiklos Vajna
- add a new DOC/ImportFloatingTableAsSplitFly setting, replacing the old (enabled by default DOCX/ImportFloatingTableAsSplitFly) one - clean up old uses of SwModelTestBase::FlySplitGuard - if SwWW8ImplReader::StartApo has a table position, then map that to SwFormatFlySplit=true in the ImportFloatingTableAsSplitFly case - testcase for this Change-Id: Ibd798ea7eb79d7ec00620dd8921797232f4732d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150381 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-14lok: draw textboxes under editSzymon Kłos
This fixes bug in impress: - open in 2 views - start editing textbox in 2. view on 2. slide - start editing textbox in 1. view on 1. slide Result: slide 2 textbox was dissapearing We need to allow drawing textboxes edited by other views so if we select non-editor for rendering we will see the full content. It was regression from commit e496b55a592caf0ca07f5477285a72d50cee6501 lok: masterpage: don't render text edits from different mode Change-Id: I7645496aec77d11d16621129dd6644d3b54a6010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146999 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150096 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150348 Tested-by: Jenkins
2023-04-14lok: setup LOK notifier for invalid range errorSzymon Kłos
Change-Id: I63fc6fcdec873a9d0c8d54dd6a6f3783f2c15251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147200 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150043 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150347
2023-04-14sw layout xml dump: extract SwFootnoteFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about footnote frames. Change-Id: I3bfdc9d16a5940f6fa2af4b85ad4261d7d10c3f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150375 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Apparently left behind by 36e62098c8c541c4a3fb63eced591cf29ac56e4a "CppUnittest: sw: simplify code. use getShapes and getShape". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I17adb18fc8a054dd2f2c26181c5d1ab4273c5411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150365 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in ea358f5d5b04a2a8e11a73d35643cd0afc5cb63b "CharBrd 8.2: Tests for UNO API and ODF filter". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Id30adc7bb05855316f59e7b0cba9c6e401dc9fcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150367 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Unused ever since the two variables got introduced in a825e23a2980fcb3d970834c4ce1f8403fb93054 "DOCX export: fix not-well-formed XML when hyperlink end is a textbox anchor" and 87e82f80e87bb4a216ea83383864d494f3e92eea "docx: export symbol characters correctly", respectively. (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I89b8324633d598b06c8aa206747f9213d4634cac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150361 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc "tdf#139737 sw_fieldmarkhide: add unit test". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: If9281585d081c58bd1a32159a403989af7fec621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150369 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14Fix what looks like copy/paste typosStephan Bergmann
...introduced in 398275ba9f4d65bebcc78864e70eee6212a84397 "tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashes". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly to report xSect2 and xSect3 as unused.) Change-Id: Ie0eb38e0011b2b457f640ade67c6e615731f165f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 0101c7918bb735d796bc1bc0d1705f995e41ee98 "Add simple unit test for recent fix to take layoutInCell into consideration". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Ibba11e910433769a72a7c1e8e1419d07cb8968a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150360 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14loplugin:stringviewparam improvementsNoel Grandin
improve the check by checking for methods that exclude using string_view, rather than checking for methods that __can__ use string_view, which leads to exposing some holes in our o3tl/string_view.hxx coverage. Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-14tdf#154501 - Fileopen PPTX: Table with rotated text wrongNoel Grandin
regression from commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value where some of code I converted needed to be mutating the OutlinerParaObject that something else held, rather than mutating a local copy. Change-Id: Ib91dddb3fc0d4190868f9fd59becb0d366af5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 18bfaed6e90eb353d17fc837162e9ad9924bec04 - tdf#153903 corrections to "caption" format descriptions remove <xml-lang> from <bookmarks> Change-Id: Ic8d18453ea14a1e0c482749c0713d7bb2ec61811 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150139 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-14tdf#154703 docx export framePr: merge para/frame FormatBoxJustin Luth
Now that export knows about both frame and para border spacing, we can remove an import hack. When exporting the paragraph properties, not only do the direct border settings and the paragraph styles settings apply, but also (uniquely for framePr) do the frame properties. The most significant property is the border spacing. On import only the paragraph keeps the spacing (with the purpose of keeping paragraph shading looking right) and the frames itself has no border spacing. [That is also good, because the frame size is specified as the size without border spacing, and LO does not expand the frame when borders spacing is added.] One exception of course is if the user adds spacing during editing. Another (theoretical) situation comes during an ODT->DOCX export. Fortunately, both of these situations should be handled by just adding the frame and paragraph properties together. It is emulation, but it seems to work pretty good. I modified the unit test from 7.1 commit 49e2bd6103669ca94d4e308fc08beed57f85c7e2 Author: Tibor Nagy on Mon Aug 10 10:51:20 2020 +0200 tdf#131420 DOCX export: fix missing border of frame because we should _not_ have two pBdr entries, just one, non-empty entry. Table import and export are already a mess. See ooxmpexort5's fdo 60957-2.docx for a great example, and tdf104394_lostTextbox.docx is also fascinatingly complex. Change-Id: I011100ee2790de6b8573d6a8bc99b9455f65e76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150242 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-14tdf#154703 docx export framePr: export frame backgroundJustin Luth
[This bug report is about exploring when Writer can export in a way that imports as Writer frames instead of Draw objects. Exporting the background is one of the most crucial pre-requisites.] The framePr background always imports as fully transparent. In that case it should just be ignored on export. However, in the (theoretical) case of ODT->DOCX framePr, or in the (practical) case where a user modiifies a framePr's background colour, then that background should be transferred to the non-backgrounded paragraphs in the frame. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154703_framePr2 Change-Id: I1f59267030810b56d2701822b7004069e02eb46d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150355 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Apparently left behind by 36e62098c8c541c4a3fb63eced591cf29ac56e4a "CppUnittest: sw: simplify code. use getShapes and getShape". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Ib8bb03116c2323e76321259f423b19af678e09f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150362 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 912336f3c85d9a631fa0ac0f270bab04b204f619 "tdf#154599 sw: fix crash at drag & drop table columns". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Ic297b850eab488e22f0477f58c2c62523d58f299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since the two variables got introduced in 19b0171bbb6c2bcdab998b74a212dc68b1884e84 "tdf#108494 fix regression". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Idb06de376cf5bed273f0ebb46c00b9f6f675b223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Looks like it got added by mistake in 8a776fecda43db0bebf5f0028adacce8c2c6afd2 "sw_uiwriter2: Unify code and use createSwDoc everywhere". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I441dceeea14152a2c84c46ed2c349cf320e3d439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150371 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since the two variables got introduced in 22a77cb83a3769a8b43d80565282988a74214866 "tdf#134436 sw: fix SwUndoDelete::RedoImpl() with section at end..." (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I53777c67da8e384d8f1ed2cd2840ce0c6abeeb5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150370 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since the three variables got introduced in 504d61697bac45236da27fba23c7189daf8c171e "tdf#149206: sd_import_tests2: Add unittest", 59cf9a433e1ea74ccdb1abe080511353a6c0af08 "tdf#149785: sd_import_tests2: Add unittest", and 93b07a377b93875b28464546f1292e4aa5f9e17d "tdf#149985: sd_import_tests2: Add unittest", respectively. (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I0f5520255cb400eee7a860212b42190c66cdb239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150359 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in e11c51eefe8c3210cef2b5850f401ba67a401d01 "tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I00585e7aae5c869ccd32d8edfc319f027050e6b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150366 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
It apparently also wants to be "disabled temporarily, next commit enables it again" (whenever that will actually happen) since a9ba8e57a41c5ddf3597272bddab30e51fb3fd38 "Revert 'tdf#118947 sw tablestyle: manually scan parents for ::SET'". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Ie280fda9948c3b1730e13b53db5e288d0a651f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150364 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 84fefd7c295fc05499ca222dff50c2fe4e0fb27e "tdf#120145 ww8import: ignoreCols if section is inserted". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: Ifdf83006d244abe92025fed528f9b1546142ce82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150363 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13BinaryDataContainer: hand out shared_ptr's to SvStreams.Michael Meeks
Hide the SvMemoryStream implementation detail better - this could be served from a file in future. Also couple lifecycle of the SvMemoryStream to the vector backing it. Change-Id: Ia9b28b57b8df4ce57286effd4d1753bf345fc10e Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149917 Tested-by: Jenkins
2023-04-13BinaryDataContainer: pure re-factor - encapsulate cbegin/cendMichael Meeks
Change-Id: Ic8dbf0afdb96a0f1be210eedfbd12ef6467dd29f Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149916 Tested-by: Jenkins
2023-04-13NFC tdf#154703 docx export framePr: cleanup prep before patchJustin Luth
This sets up the building blocks for a series of patches. Lets get this formatting/renaming stuff out of the way first so that we can focus on the actual logic changes later on. Change-Id: I20aa333080d9f31af4f4b9e89a51eafba1d39530 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150354 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in ea331fa8b498c66ec687c6611c69ffc61e58bc79 "tdf#131553: Add unittest". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I9841713baf718be5b19d25acb35f3b856a94e1cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150358 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13sal_uInt16 is not a good choice to store SwTwipsMike Kaganski
The latter is tools::Long, which is even 64-bit on most platforms. Just use auto here. Change-Id: I5b45220b79cd4798bafdb416ad7a44eb4d5d1f99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150320 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-13add some debugging on failure to find impress_allCaolán McNamara
Change-Id: I4d303f7f60bb0f086fad8f3883dee1393a5d6eb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13Resolves: tdf#152619 crash inspecting uninserted XFieldMasterCaolán McNamara
Change-Id: I765dd5d7e1ed2c1749841491a50216a6afe903c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13pointer is always dereferenced make it a referenceCaolán McNamara
Change-Id: I77c5dc3a4d4f290f5020019f3f455b1fec2497ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150350 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13use more string_view in PrinterInfoManagerNoel Grandin
Change-Id: Ib0173b1a33be7156c27c81b0804ac7c4d3373857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13remove unnecessary exportStyleFamily methodNoel Grandin
Change-Id: I59c75494ffd3f132a041beebb4336714c1e94143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13use more string_view in SwHTMLParserNoel Grandin
Change-Id: I49675277766146c948886b58c8eeaecb7e41b90b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13tdf#154451 uitest: use more oneprocess modeMiklos Vajna
Execution time changes: - UITest_writerperfect_epubexport: 20,023 -> 6,083s - UITest_svx_table: 15,214s -> 14,378s - UITest_cui_tabpages: 13,561s -> 12,503s - UITest_math_demo: 19,737s -> 13,578s Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-13tdf#154481 sw DOCX import: fix page loss and freezing at ODT exportAttila Bakos (NISZ)
Disable TOC creation in case when field context stack is empty but TOC creation is in progress in textboxes. Before if TOC creation failed because it is already existed, the TOC creation member (mbStartTOC) kept true resulting in broken textbox handling. Textbox and TOC import use the same text append stack but the TOC was not removed from the stack so content have been written into the TOC instead of the textbox, resulting page loss, and because of the broken structure, freezing at further ODT export. Change-Id: If27aa477c49f276d4e538b6e125798d89f0ac423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150099 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-13query getUserAllowsLinkUpdate for the case of content in a floating frameCaolán McNamara
similarly to how it works for the more common "normal" embedded objects Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13adjust IFrameObject so it could reuse mxFrame for a reload of contentCaolán McNamara
Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13use parent window as dialog parentCaolán McNamara
it makes no odds, but is more convenient for upcoming modification Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13extract a OCommonEmbeddedObject::SetInplaceActiveState for reuseCaolán McNamara
no behaviour change intended Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13Content Control Properties dialog alignmentSzymon Kłos
Make explicit that ok/cancel buttons should be the last row Change-Id: If22da5222fc9dc1c1c5f94fd08c945364284daee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146904 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150095 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-04-13use more string_view in SwHTMLParserNoel Grandin
Change-Id: If1dcb2e4207b15eb71bd79469f89526c76f05772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13fix SwHTMLParser::InsertCommentTextNoel Grandin
which went wrong in commit 7a504c8752bf7c5accbb9bcc33a98f79b31b8bf2 Author: Palenik Mihály <palenik.mihaly@gmail.com> Date: Fri Aug 9 13:51:08 2013 +0200 Change String to OUString in SwHTMLParser class Change-Id: I7623e5fe1f4ca07adff8de11d7c01b1cea3733d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150334 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13deduplicate o3tl::trimMike Kaganski
Change-Id: I5d4b3555b59b5abf622c389662e83cbd0f7d142d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-13lok: trim glibc allocator's pending heap when called.Michael Meeks
Change-Id: I8d1bda01a0e6ccff0fa868013c67c0fbbf78a836 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150299 Tested-by: Jenkins
2023-04-13no need to allocate these separatelyNoel Grandin
Change-Id: Icc24e0aaf1762e5b318b8364dd9fdb496edfb77c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-21 21:58:04 +0000