summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-18tdf#143148 Use pragma once in embedserv and helpcompilerDiane Leigh
Change-Id: I006bbcea9ea69ffcf7c789691583430c9154af2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136058 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-06-18cid#1506305 Big parameter passed by valueCaolán McNamara
and cid#1506307 Big parameter passed by value Change-Id: I7386eeea04f73a4ec9fe0fe09ff2981b2022be89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-18cid#1506306 Uninitialized scalar fieldCaolán McNamara
Change-Id: I2daf370dc68dff19f1be538744d7241c080d8149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-18cid#1506304 Uncaught exceptionCaolán McNamara
Change-Id: Ib4bc9b08982b1fe2f5130ef4e56489f366c01081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8fee25674c3bdb0cf3cee4a7dfcc2a814431549b - tdf#149525 Update Writer-View-Toolbars + Added 2 extra files for undocumented toolbars + Still work in progress on main0200.xhp Change-Id: Ida0b1fd2c69cb48ce0cd39ef890e53e5f2b4f056 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136068 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f8357004d5a93f001e27db9491b9d9f56634054a - (related) tdf#148941 update label in Imagemap properties page Change-Id: Id9754b97eb51a7db5b159fff76512880ef59629e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136049 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 345a9ecdd1d744f97a7281a49ef6940824089fd4 - (related)tdf#148941 update label tdf#148941 changed label from "Text" -> "Text Alternative" as part of making consistent usage across the UI. This patch updates the relevant help file. Also, introduces a variable for a sentence that is repeated across several options, and which uses the new label. This makes it possible to use <embedvar> instead of retranslating the same sentence with the label change. Change-Id: I3be6a3863f74790732682abd8228c47cd907b0b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136044 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-18Related: tdf#142293 tdf#141495 Allow additional symbols in externals mapEike Rathke
... to repair broken saved as Excel documents with saved Add-In programmatic names, by adding them as upper-cased symbols. Previously, adding such name was rejected if the Add-In already existed in the reverse map. Now multiple one-way aliases are accepted. The upper-case programmatic name was already attempted to be added for all Add-Ins of the collection (for the non-UI case via fillFromAddInCollectionUpperName()) but the pre-known Add-Ins are mapped before so existed already and those names were rejected, as they shouldn't be necessary. Except for broken documents.. Change-Id: I3cb6848779362de3446581528d2f6e6f19af9ec8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136072 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-18qt a11y: Handle special value of -1 for text offsetMichael Weghorn
As the note in the Qt doc for `QAccessibleTextInterface::textAtOffset` says [1]: > An offset of -1 is used for the text length and custom implementations > of this function have to return the result as if the length was passed > in as offset. Without this, LO happened to crash quite frequently with Orca enabled when moving the cursor between paragraphs in a Writer doc when using the qt6 VCL plugin in a WIP branch including more changes to qt5/qt6 a11y. [1] https://doc.qt.io/qt-6/qaccessibletextinterface.html#textAtOffset Change-Id: I5c6ca69f8a9b2edad204bb1af740d4de17668f18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136073 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-06-18Qt move most X11 specifics into QtX11SupportJan-Marek Glogowski
Just some refactoring. Change-Id: I5b2ef531778d4d43d2fdc32fe7da59edffa3c02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136061 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-18Related: tdf#142293 Use the same locale to lowercase as was to uppercaseEike Rathke
... so a #NAME? bad token isn't mixed up like it was with the stored loaded from document com.sun.star.sheet.addin.Analysis.getEdate upper-cased in tr-TR to COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE and then lower-cased in en-US to com.sun.star.sheet.addİn.analysİs.getedate which confusingly was the user-visible token string. Change-Id: I341648fcf34fa1cae164d24ad2023bd74573bd3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136071 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-18Related: tdf#142293 Do not use locale's uppercase for Add-In programmatic nameEike Rathke
... so in a tr-TR locale com.sun.star.sheet.addin.Analysis.getEdate is not upper-cased to COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE Which didn't matter as long as it was consistent and only used for lookup and mapping, if so.. Additionally, the programmatic name does not need the CharClass overhead and toAsciiUpperCase() is sufficient and faster. Change-Id: I1c987cc56dc3a62b5285a0bc367c754e7acb6815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136070 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-18tdf#126109 calc slow when replacing string to numberNoel Grandin
Store SharedString inline in ScCellValue. Shaves 10% off time. Use std::variant to handle the complexities of correctly calling constructor and destructor of SharedString. Change-Id: I820de5339e31434fbdbde1a72e25abe207bf008d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-18-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Ife1958a39a7cf673b745a7724ee963e868b21432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136064 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-18o3tl: ensure that the initializer of enumarray contains enough elementsMichael Stahl
Currently this silently succeeds. Turns out oox already contains some too-short initializers, let's guess the missing properties are all invalid. One downside of the templated parameter pack approach in the enumarray ctor, as witnessed in vcl/win/window/salframe.cxx, is that argument types can no longer be implicitly deduced and thus need to be spelled explicitly now in certain cases. There were also three uses of enumarry with V being unsigned short (aka sal_uInt16) that started to cause narrowing conversion errors now and needed to be adapted: In editeng/source/uno/unonrule.cxx the obvious fix was to use the proper type for V. In sw/source/core/unocore/unosett.cxx with its odd mix of saL_Int16 and USHRT_MAX, lets keep things that way for now (probably awaiting later clean up) and use casts to avoid the implicit narrowing. And in sw/source/filter/ww8/wrtw8esh.cxx the ESCHER_Prop_* values, while presumably conceptionally of type sal_uInt16, are plain #defines (thus of type int), so rather than changing V to int it looked more consistent to explicitly cast the ESCHER_Prop_* vlaues to sal_uInt16. (And in tools/source/fsys/urlobj.cxx the poor loplugin:redundantfcast started to unhelpfully kick in for (only) the first argument now.) Change-Id: If06c29e673ec7e565e283c6f447889cf1f777cb7 Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-18create getter for ScCellValue::mpFormulaNoel Grandin
so we can assert that it has the correct tag type Change-Id: Iab13a6d6ea1783c69395f06f28732769e5fe8b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-18Breeze: tdf#138400 update General Format iconsRizal Muttaqin
Change-Id: I7daad09129c505e300d84634768f4bcf14653500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136069 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-06-18Remove comment of long removed MapDupToInternal fieldEike Rathke
Change-Id: I0fd78eb1ff1fedf0ddb9728b06a3ee6de7973329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136066 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 65290dc95fe2efb330ac54ecf9d771984b4e5c9d - TDF#147862 (part) Update toolbar contents Help pages + Upgraded the Tools toolbar help page + several fixes in embeded files + bug147862 still work in progress Change-Id: I35238075f6a917a8d7c39bfb5cbf6a5a6ebc783b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136063 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a - Refactor table into list in redlining_enter.xhp Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-17tdf#149431 Fix the sidebar's widthxuenhua
When click the wider sidebar and then go back to the narrow one in Writer, the narrow one becomes the same width as wider one, it's not suitable and doesn't look good. Fix the width to smallest width unless you drag the splitter. Take the maximum width from the smallest width and mnWidthOnSplitterButtonDown. Change-Id: I60aaab84593d59ac28b96c2d3c3bd62a4bbddbbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135220 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-17Rectangle: split SetSize into SetWidth/SetHeightJan-Marek Glogowski
... and inline the functions. Change-Id: I9285c72e8524f8f0a2d242bfd4cd29edf6d1ed73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135811 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-17Fix and add ostreams for vcl::WindowPosSizeJan-Marek Glogowski
... and inheriting classes. Follow-up on commit ea5a0918c8c32309821ab239c4b95f4d6a3b5c12 ("VCL add vcl::WindowPosSize abstract class"). Change-Id: I4733cd4619f91fe1ba05c208a650be591ecf5d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135806 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-17WIN drop window state redundanciesJan-Marek Glogowski
So on Windows a window's state is stored in: - maGeometry, inherited from SalFrame - maState, which is the same type then maGeometry - mnWidth and mnHeight, which are just set, never read - mbFullScreen, which can be encoded in the vcl::WindowState IMHO we can get rid of mnWidth, mnHeight and mbFullScreen. Which leaves the mystery of the extra maState. But at least it looks like we can simply cache an vcl::WindowState instead. And this is a little start to make WinSalFrame variable members private; it'll be a long way... And it also changes a SW_SHOWMAXIMIZED to SW_SHOWMINIMIZED in the cleaned UpdateFrameState(), which looks like an error. Change-Id: I5895313d87a6f81371e2b77af6c813d35f591725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135809 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-17qt a11y: Forward STATE_CHANGED event as suchMichael Weghorn
Handle `AccessibleEventId::STATE_CHANGED` by sending a corresponding `QAccessibleStateChangeEvent`. The previous way of sending a `QAccessible::ForegroundChanged` event looked rather arbitrary and had no effect in practice, since that type of event is currently ignored in Qt's AT-SPI adapter anyway. At this point in time, the Qt library doesn't forward changes of all states to the AT-SPI layer. Most notably, it ignores changes to the focused state. (Qt itself uses events of type `QAccessible::Focus` instead of `QAccessibleStateChangeEvent` with the `focused` state set to notify about focus changes, but that's not exactly the same, and e.g. causes Orca to ignore some focus changes). I have submitted a change to Qt to implement forwarding of `QAccessibleStateChangeEvent`s for the focused state to the AT-SPI layer, currently awaiting review. [1] With that Qt change in place, Orca still ignored these events in LibreOffice message dialogs, since those use a11y role `ALERT`, which wasn't previously considered when trying to retrieve a potential dialog that an a11y object belonged to. The corresponding Orca merge request [2] has just been merged. With these two in place, Orca now announces the focused button when switching focus using the tab key e.g. in the "Save document?" dialog when using the qt6 VCL plugin. (Most other things in the LO UI are still usually not announced.) For some reason, forwarding changes to state `AccessibleStateType::ACTIVE` resulted in Orca becoming unresponsive (stop talking) quite quickly. That needs further analysis, so that state change isn't forwarded to Qt for now. [1] https://codereview.qt-project.org/c/qt/qtbase/+/416510 [2] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/127 Change-Id: I81c9a0f5ec8c74f95943d3073bba5b304f995d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136057 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-06-17Convert ImplWindowStateFromStr to WindowData(str)Jan-Marek Glogowski
To have a constructor as the counterpart of the toStr() function. Better then some unrelated independant function. Change-Id: Iba4cb3d400a92704753db6b35d12f2189b23077e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135807 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-17Drop a bogus slashMike Kaganski
... added in commit eae791e82c8e138cc983c3e7058cc4e9dafa4002 Author Jens-Heiner Rechtien <hr@openoffice.org> Date Wed Jun 27 11:30:00 2007 +0000 INTEGRATION: CWS awttree01 (1.1.2); FILE ADDED where it was misplaced (intended to be <TRUE/>, not <TRUE>/). Commit 1501e17b889b28e7394596ce4f98eab1c5b00d8f Author Rüdiger Timm <rt@openoffice.org> Date Wed Jan 30 07:20:16 2008 +0000 INTEGRATION: CWS dba24d (1.2.92); FILE MERGED added '/' before the '>', but kept the incorrect initial one. Later commit 928b8640c0d1a9c49249100efbdd70f8c1090b07 Author Michael Stahl <mstahl@redhat.com> Date Sun Apr 28 00:44:31 2013 +0200 *api: convert <TRUE/> <FALSE/> <VOID/> <NULL/> removed the correctly placed slashes. This is a leftover. Change-Id: I800f28de02dd8447509bc236614cab05c2b8c0df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136037 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-17Qt use QEvent::type to handle the event correctlyJan-Marek Glogowski
No need for an extra function parameter. Change-Id: Iedb949b45ad3f161121110e2db2132b6c3cb706e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135894 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-17create getter for ScCellValue::mpEditTextNoel Grandin
so we can assert that it has the correct tag type Change-Id: I984c22ae2527d652f2d4194227dc1173793300c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-17Drop wrong '@returns' documentationMike Kaganski
Caused this warning: /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/view/XMultiSelectionSupplier.idl:60: warning: found documented return type for com::sun::star::view::XMultiSelectionSupplier::removeSelection that does not return anything Change-Id: Iee156519c2075293b8305627ed22d586143c8688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136033 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-17create getter for ScCellValue::mpStringNoel Grandin
so we can assert that it has the correct tag type Change-Id: I8933919aefc2bb22694a283b54dc3de11d16e5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-17Change '@returns' into '@param'Mike Kaganski
That was causing the warning: /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/embed/XInplaceObject.idl:85: warning: found documented return type for com::sun::star::embed::XInplaceObject::translateAccelerators that does not return anything A similar 'translateAccelerators' is in XInplaceClient.idl. Change-Id: I9abcb22ce8f460e2d26202542fef74b7e6a27ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136032 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-17Drop useless '@returns `VOID`'Mike Kaganski
... which caused the warning: /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/sheet/XDataPilotTable2.idl:62: warning: found documented return type for com::sun::star::sheet::XDataPilotTable2::insertDrillDownSheet that does not return anything Change-Id: I028820dc11ed8110278f2a655f1ad0c26d7b91cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136031 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-17tdf#134210: Reimplement cropping from srcRect and fillRectMike Kaganski
This avoids the scaling after the crop, since scaling is performed anyway when applying BitmapMode_STRETCH. This improves resulting bitmap quality. Also consider the "crop to zero" case (when the sum of cropped parts is equal to 100%). In that case, just use an empty graphic as the fill bitmap. This makes the differences between srcRect and fillRect processing explicit, simplifies the code, avoids extra rounding inaccuracies, and takes care of the edge cases that were considered in commit 2859ec288f2c1323ea3123d82cb1684b349ff598 Author Miklos Vajna <vmiklos@collabora.com> Date Wed Jun 15 15:52:18 2022 +0200 oox: fix div by zero in lclCalculateCropPercentage() The change in SdImportTest2::testTdf134210 is because we now don't scale the cropped image. The previous value was an interpolated color, while the new value is the actual color of pixel [0, 41] of the original image. Change-Id: I24fa9928cff32bcaa6a7b3e34def14700fddd7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135917 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-17upstream Skia fix for Vulkan crash on texture binding (tdf#148624)Luboš Luňák
Change-Id: Ic16a516bfde04aba0336baca58f605d6cf9fd413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136011 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-17tdf#125040 Ignore the default contextMaxim Monastirsky
This isn't a meaningful context, but a way to represent a lack of context. Typically it's a temporary state, followed by a proper context being set. The problem becomes apparent when a context deactivation is caused by switching to another document window, as the further activation will happen only when the former window is focused again. This makes the contextual controls disappear in the meantime. Change-Id: I96c8356acb2434c579dc74407043b55eb5374a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136010 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-06-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 665f218e5e027ab3ad56bf6066d98d8323555ab3 - Mute l10n Change-Id: Ie3f063c53f424293da59e85e4a34334f37d4324c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136021 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-17tdf#149579: sc_vba_macro_test: Add unittestXisco Fauli
Change-Id: I2cb673d9b42ea28b19fc408f2be86456258fcbe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136013 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-17tdf#149529: sc: Add UItestXisco Fauli
Change-Id: I21a20c2d9d5922ac622d6b5858d500cdb3fc65ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136012 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-17CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()Miklos Vajna
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1 (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing, 2022-04-07) for motivation. Change-Id: I0336c35df7b9b9d1704cc6611b8ffe1f111977a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136004 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-17tdf#149575 UnoControlTabPageContainer: Handle tab imageIlhan Yesil
Setting a tab page's image in the tab button is done via method 'XTabPageModel.setImageURL'. Change-Id: Ideb096f88037dac26abe90fccae2251dcce84659 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135900 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-06-17Another "One call to XCellRangeAddressable::getRangeAddress() is enough"Julien Nabet
See https://cgit.freedesktop.org/libreoffice/core/commit/?id=e44e418783d101c530c916db0b0f72c376188fdf Change-Id: I1106d1777690c27b9e4765a3a94145bb73609005 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136005 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-17handle GC* pixmap functions on Mac reading past pixmap (tdf#145843)Luboš Luňák
The code passes adjusted position for pixel data in order to create a sub-rect of the pixmap without copying, but at least on Intel Mac the GC* functions then try to read the entire pixel row even though it shouldn't be necessary. Since that may cause reading past the pixmap data if the last line is involved, use entire pixmap width to avoid that. Change-Id: Ia08059b363d39dd465b2cadde5138ee045628f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136003 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-17Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 9f035d777141d5f039a85d6f64b627eaf73b8079 - (related)tdf#138844, (related)tdf#149018 "Type" -> "Position and Size" tdf#138844 changed the "Type" tab in the Properties dialog for Image and Frame to be labeled "Position and Size" and tdf#149018 did the same change for OLE Object. This patch updates relevant help pages to reflect the change in the tab name. Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-06-16rhbz#2097411 Avoid obsolete PyThreadState_Delete crashing Python 3.11Stephan Bergmann
1fb53a637597f76bea86514b62ddfad34f60c889 "pyuno_loader::CreateInstance: delete the initial PyThreadState" had added the PyThreadState_Delete for claimed benefits but whose details appear lost to history (cf. the comment thread starting at <https://gerrit.libreoffice.org/c/core/+/3452/2#message-602ff52abdd1c95fd5c13cfe405b5fadd0048c5f> "pyuno_loader::CreateInstance: delete the initial PyThreadState"). And at least a recent master Linux --enable-python=fully-internal build with the bundled Python 3.8.12 appears to succeed `make check` just fine with the PyThreadState_Delete temporarily removed. But on the other hand, building against upcoming Python 3.11 now started to make CppunitTest_services fail with > Fatal Python error: init_threadstate: thread state already initialized > Python runtime state: initialized > Thread 0x0000ffff81c8b020 (most recent call first): > <no Python frame> > Fatal exception: Signal 6 > Stack: > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37c28)[0xffff81be7c28] > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37e40)[0xffff81be7e40] > linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffff81ccb7ec] > /lib64/libc.so.6(+0x82878)[0xffff81742878] > /lib64/libc.so.6(raise+0x20)[0xffff816fae00] > /lib64/libc.so.6(abort+0xe8)[0xffff816e72b8] > /lib64/libpython3.11.so.1.0(+0x104e28)[0xfffee4de4e28] > /lib64/libpython3.11.so.1.0(+0x105200)[0xfffee4de5200] > /lib64/libpython3.11.so.1.0(PyThread_get_thread_native_id+0x0)[0xfffee4ed6764] > /lib64/libpython3.11.so.1.0(PyThreadState_New+0x14)[0xfffee4ed6628] > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpyuno.so(_ZN5pyuno14PyThreadAttachC2EP3_is+0x78)[0xfffee4c8c52c] > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpythonloaderlo.so(pyuno_Loader_get_implementation+0x5c)[0xfffee5243060] > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_cppuhelpergcc3.so.3(+0x544b4)[0xffff815544b4] because of the PyThreadState_Delete. (The deleted PyThreadState, while not reused again directly, is still recorded in the state obtained from PyInterpreterState_Head() later.) So conservatively keep the PyThreadState_Delete of unclear benefit for older Python versions and only drop it for 3.11 where it is known to have negative effects now. Change-Id: I9b99f1e947f0b165ddc95c2bfbd764858dda39db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136006 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-16Resolves: tdf#147822 ScUnoListenerEntry container must be std::listEike Rathke
... instead of std::vector to not get invalidated iterators when the container is resized. Regression from commit f8defe59ff75df2b516ee407f1dac22b0ac72a19 CommitDate: Wed Sep 6 22:45:10 2017 +0200 Replace some lists by vectors in unoobj (sc) which was bad for this case. Change-Id: I8d3a001242865cadc82b359a3198906d26373a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136007 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b01904aabf78c6981d4c3b3953483bea9e86c2b3 - Mute l10n Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-16create getter for ScCellValue::mfValueNoel Grandin
so we can assert that has the correct tag type Change-Id: I0d626130cb014e19239e88a6988018c83d061f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16pass EditTextObject by unique_ptrNoel Grandin
to make the ownership passing obvious Change-Id: Icf4b94a422b91da3082fe1ce56eff149d390a649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 51cfc9a957eec7be595e8b667a528cbe749992a0 - (related) tdf#149414 change in Impress Format menu command name Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
generated by cgit (git 2.34.1) at 2025-01-13 08:57:55 +0000