summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-21tdf#147166 EditTextObjectImpl copy ctor doesn't exactly copy EditTextObjectImplCaolán McNamara
and this is apparently relied on, so eliding the copy gives unexpected results. EditTextObjectImpl::Clone returns a copy of *this, but the EditTextObjectImpl copy ctor explicitly does not copy the "PortionInfo" member, so in: commit fb8973f31f111229be5184f4e4223e963ced2c7b Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Oct 10 19:21:38 2020 +0100 ofz#23492 the only user of this ctor throws away the original of the clone so we can take ownership of the original instead where the copy was optimized away we want from a state where there was a new EditTextObjectImpl with an empty PortionInfo member to one where the PortionInfo of the EditTextObjectImpl was retained. So explicitly clear this unwanted info. It's very hard to make rational judgements about code if a copy behaves differently than the orignal :-( Change-Id: I642d60841d6bdccbf830f8a2ccdbd9f542a8aa18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130158 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-21fix Writer key event delayed compression (tdf#145963)Luboš Luňák
SwEditWin::KeyInput() was stopping the flush timer on every invocation, which means that as long as key events kept coming the timer would be started again and again and would not time out, and so the input buffer would not be actually processed. It seems that AnyInput(KEYBOARD) there actually does not normally manage to return true ... except for Win11 where it seems that now GetQueueStatus() detects even key-up events even though it didn't before (I've not debugged this enough to be certain). I think it still makes sense to have the compression in case Writer get overloaded to help it process the pending input events, so fix this (but if there are problems, I think an easy solution is simply to drop it, it doesn't seem to be that necessary). Also decrease the timeout from 200 to 20ms, as 200ms is a very visible delay. Change-Id: I760ad9c4f58726a80bd6a9fbf93f2771f10cbdb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130083 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130122 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-21Sukapura: tdf#138400 General Number Format iconsRizal Muttaqin
Change-Id: I71005bb44e407bdbc48654f7399a397d03ef86a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130248 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-21Colibre: tdf#138400 General Number Format iconsRizal Muttaqin
Change-Id: If1ee2bb381b2b27f4f6a405cdde5dc58a35b0f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130166 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-21Colibre: Update Template Manager iconsRizal Muttaqin
Change-Id: If1d0101990fec60df0fc32f511d6d6e7cb8bff5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130165 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-21elementary: Fix unused icon definition in links.txtRizal Muttaqin
Change-Id: I5ef56e9bac0c42d514839dc6f6dca522743ae584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130225 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit 205a94e7ac14569e535f47ed21cdf181a088e37f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130164
2022-02-21Sukapura: update small Subscript & Superscript iconsRizal Muttaqin
Change-Id: I59e4255312410d5d190b5034440fe059a866689d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130161 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-21Sukapura: tdf#144036 add UNO Object Inspector iconsRizal Muttaqin
Change-Id: I1b16ecb118df59add4b9d39118cf5b22afb4c6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130208 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit 2b80f5a1646308ed43d1d7fee6ce3cefdc9e05e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130160
2022-02-20Missing initialization of SVGActionWriter::mbIsPreviewStephan Bergmann
...introduced with f609a16a52f1ac37f1edd297cf1d9e5f2a294724 "lok: render image preview with lower resolution", > /filter/source/svg/svgwriter.cxx:2949:9: runtime error: load of value 190, which is not a valid value for type 'bool' > #0 0x2b2ee3c573d5 in SVGActionWriter::ImplWriteBmp(BitmapEx const&, Point const&, Size const&, Point const&, Size const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*) /filter/source/svg/svgwriter.cxx:2949:9 > #1 0x2b2ee3c3b670 in SVGActionWriter::ImplWriteActions(GDIMetaFile const&, unsigned int, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*, GDIMetaFile const*) /filter/source/svg/svgwriter.cxx:3782:25 > #2 0x2b2ee3c5b3a8 in SVGActionWriter::WriteMetaFile(Point const&, Size const&, GDIMetaFile const&, unsigned int, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*, GDIMetaFile const*) /filter/source/svg/svgwriter.cxx:4015:5 > #3 0x2b2ee3a86ae2 in SVGFilter::implExportShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, bool) /filter/source/svg/svgexport.cxx:2227:42 > #4 0x2b2ee3a7e1e2 in SVGFilter::implExportShapes(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool) /filter/source/svg/svgexport.cxx:2050:20 during CppunitTest_sd_svg_export_tests (<https://ci.libreoffice.org/job/lo_ubsan/2291/>) Change-Id: Ied5a2cc8599466949f57caae05f9fb90c92266b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129582 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-20lok: render image preview with lower resolutionSzymon Kłos
renderShapeSelection callback is used to render image previews which are later used during eg. rotation. Do not render preview with original size which slows down app a lot. Use 1280x720 max. Change-Id: Ia8365a67d87cea869ef74cb70ce4830439a523b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129497 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-20tdf#146690: pptx export: fix endParaRPr size value for empty paragraphsSarper Akdemir
Fixes paragraphs made from a single new line, not getting the correct sz(text size) value in EndParagraphRunProperties on pptx export Change-Id: I31ebb5735ad392e081aa2f43b0b60a845e4de9c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128265 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-02-20[cp] Restore light document border for writer part2Pedro Pinto Silva
- Make shadow not so harsh - Add border radius fixes https://github.com/CollaboraOnline/online/issues/3403 Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I5a46915ca4db7b484d5e816985e834b2777a9786 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123672 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-20[cp] Restore light document border for writerSzymon Kłos
to apply use make postprocess.clean && make postprocess fixes https://github.com/CollaboraOnline/online/issues/3403 Change-Id: I3d0d12a60eacc73ace3f614360bc86a8a44f28a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123572 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-20lok: sc: focus gridwin before useSzymon Kłos
commit ef29f8c57dbb73ee3bd2e09ea557b86bf3eacfa6 lok: sc: update ScModelObj::postMouseEvent introduced Drag&drop for online. One missing thing was getting the focus for gridwin before mouse event processing like it is done in LOKPostAsyncEvent Change-Id: I4063340985f7dcc91cf5382631615119e28ea3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123391 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129471 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: unit test drag & dropHenry Castro
.. Change-Id: I774ece93e5c439c65df50e6a67d1447a062708b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121898 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129470 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: update ScModelObj::postMouseEventHenry Castro
It is intended to process the drag & drop functionality in Calc. Change-Id: I501cd94e309dabf8472e5c5aa9661e7273cd0dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118879 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117733 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: reset and cancel properly Drag & Drop actionSzymon Kłos
used patch from Henry as a template: https://gerrit.libreoffice.org/c/core/+/118844/17 but without custom actions invocation Change-Id: I8bce66deffee0de16f3c24f009cfee077eb26e82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129469 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: test: fix testSheetSelectionsHenry Castro
The unit test is selecting again range, it will conflict with the drag & drop because it will drop to new cell address. The unit test will fail, the removed code will be used to a new unit test for drag & drop. Change-Id: I896f5cd7e6b671f3fac95c8ae76e7558fa8dd1d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123062 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129468 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: send drag overlaySzymon Kłos
Change-Id: I1e134fd99dffc4962bacbba97456365ab9347e37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123242 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129467 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: deglobalize SetDragObjectSzymon Kłos
and other Drag and Drop related functions Change-Id: Idbaec91c0ed396da9888c8ed562d2eff35686cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123209 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129466 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: simplify drag & drop functionsHenry Castro
The ScDragData is a global use for private drag & drop in a desktop case, it will be used by tiled rendering case to pass its own local ScDragData per user. Change-Id: I0bca8e6d5c0eab82b69374a67425e2a8d746ef4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118990 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129465 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20sfx2: introduce SfxBindings::QuerySlotIdHenry Castro
In order to invoke QueryState with the slot id, which it is easier to invoke UNO command states in unit test. Change-Id: I36d72a4381ff8386b1f1af33284ce674cf26acd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123063 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129464 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: handle all local mouse tracking for CalcHenry Castro
Change-Id: I11f3477c0f966d403e076fc73b7e5507ad6597f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117779 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: apply local mouse tracking only for CalcHenry Castro
Change-Id: I6c3d4c3c59652f20596e32d3f31c5357b7ed61eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118873 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117778 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: fix sending mouse pointerHenry Castro
The ScGridWindow is a document window, but the Parent is not the notifier, fix it to send mouse pointer when action is drag & drop. Change-Id: I5071dce2566331ce0268a96e023ffd61a1f09e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118870 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118139 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20lok: sc: introduce LocalStartDrag methodHenry Castro
Update the mouse mode to start drag, otherwise it will conflict with normal cell selection. Change-Id: I6d4939b704114e7de1c9c051459fd02100a7536c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118874 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118203 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-20LOK: don't segfault when reporting errorAshod Nakashian
Change-Id: Ia6d614eb15b15f43ddd3e0b5742b888060dfd581 Reviewed-on: https://gerrit.libreoffice.org/69069 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 9fa568dced78011072390320f64eae28dd06d2b9) Reviewed-on: https://gerrit.libreoffice.org/78443 (cherry picked from commit fa18cdce824525ebd76b542a44741a35062741ce)
2022-02-20upgrade expat to 2.4.5Caolán McNamara
CVE-2022-25235 CVE-2022-25236 CVE-2022-25313 CVE-2022-25314 CVE-2022-25315 Change-Id: I1cb0449411fe938fe47ab47cead685fd04e137dd
2022-02-20Breeze: add Calc's Edit > Select > Select Sheets.. iconsRizal Muttaqin
Change-Id: Ide474cd818217f24ec144de00eab58f01f8d2575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130159 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-20svg filter: google chrome doesn't render white spaces correctlyMarco Cecchetti
In Google Chrome white spaces at the beginning of a text line are not rendered at all. Change-Id: Idd3b1bc5a383b21a54cc1629173bbe26a6da83bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129918 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5eec28d86a5953de3aa0d5f0c424e92334860270) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129939 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 76a98fa478ac8e75cf3f982e4f65548d69371b39) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129944 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-02-20Resolves: tdf#147393 SpinButtons should be can-focusCaolán McNamara
Change-Id: I092ed9c3421267ea3b2c671020e7079c3f792e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130131 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-20fix range checking in calls like ScDocument::GetNote()Luboš Luňák
Change-Id: I5612e765b3484b0515f4a16030ee19133ae3126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130076 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 957d99a539df6e21fd40370938ca5dab1613cf8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130104 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18boost: use utf-8 encoding for unknown locales.Michael Meeks
More exotic locales like es-419 cannot be parsed by boost, so we fall-back to the default encoding. This avoids an exception: invalid_charset_error of the form: "Invalid or unsupported charset:us-ascii or UTF-8" for this case. Change-Id: I6796dd893ec774b221956ea9febbcc19495d47b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130101 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-02-18Better handling of terminalsRenwa Hiwa
LIBREOFFICE-3MQTR80G Change-Id: Ifa52d7f65aae473056202b46788c5870a8ce38c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130089 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-18tdf#143817 Fix HUD deleting text contents in WriterRafael Lima
Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3c94a0f7729f1638ab3b273a186c48de859cfb49) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130092
2022-02-18Refetch in case SwTextNode::InsertItem causes it to be deletedCaolán McNamara
Change-Id: Ie189ae4d37ffc33e58bb405f2521d1ae02a9997b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130025 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-18tdf#147086 OOXML export: don't save the empty editing passwordTünde Tóth
Saving with opening password, but without editing password resulted read-only documents (only on their original path: saving, i.e. copying the file in a different path was a workaround for the lost permission). Regression from commit 1b53c1dfc76f08ca7df40a0673aa50eca700d072 (tdf#144374 DOCX: export the password for editing). Change-Id: I2759dc876ee7668d00eee0aa81490c9d1e0c272b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129593 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130060 Tested-by: Jenkins
2022-02-18libxslt: upgrade to release 1.1.35Michael Stahl
Fixes CVE-2021-30560 Change-Id: I334662ddc40955780321133be9aee23858e04dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18Resolves: tdf#147398 Test Intersects() instead of Contains(), tdf#119083Eike Rathke
Regression from commit 8406139062d9ffe1daed32aefe4e261c6c55d63e CommitDate: Mon Dec 6 15:45:35 2021 +0100 process broadcasts for adjacent cells together (tdf#119083) that changed single cell broadcasts to blocks of rows broadcasts and - if (rAreaRange.Contains( rAddress)) + if (rAreaRange.Contains( rRange)) but a block of rows may be distributed over several broadcast areas so rRange is not contained within one rAreaRange and thus was not broadcasted. Testing for intersection instead fixes this. Change-Id: I10700296ebc897e4b7b7752e0e6bcb480085b487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit a1f21d7094deb6f1ae5388718f2bc28eecd5737a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130012 Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-18configure.ac: Update kf5 include/lib check to work with KF5 >= 5.91Michael Weghorn
The 'kcoreaddons_version.h' header was moved to the 'KCoreAddons' subdirectory in kcoreaddons commit commit d971ba9bb27a3e8f18a116692fdf98c1729ac244 Author: Ahmad Samir <a.samirh78@gmail.com> Date: Sat Jan 15 14:14:13 2022 +0200 Install kcoreaddons_version.h in /usr/include/KF5/KCoreAddons/ Instead of /usr/include/KF5/kcoreaddons_version.h. For more details see: https://invent.kde.org/frameworks/kservice/-/merge_requests/79 GIT_SILENT Adapt the KF5 check to check for the 'KFileWidget' header and the 'libKF5KIOFileWidgets.so' library instead. This is more exact anyway, since we require KIOFileWidgets, and the previous check didn't ensure that. (So in case only KF5CoreAddons but not KIOFileWidgets was installed, configure would previously pass, but the build fail.) [1] https://invent.kde.org/frameworks/kcoreaddons/-/commit/d971ba9bb27a3e8f18a116692fdf98c1729ac244 Change-Id: I7ecf7f29dce85e1a6e6b0d4f2519fa37ab04ca84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129996 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 5fd5e42bf28a7910321c6b6d76257e7386839fbc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130007 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-18for unallocated columns check default column attributes (tdf#132057)Luboš Luňák
The problem was that this was returning false for the protected attribute just because a column was not allocated, but the default attributes had the flag set (so if the column had been allocated first it would have the flag set too). Change-Id: I2ef1ef40cafb7e8fc6f7b561c0a376af63f2ad26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129984 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit a717029e217621482ef799731f945090c6d6be4b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130015 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-18sw: layout: allow keep-with-next paragraph with fly to move backMichael Stahl
The problem is that a paragraph that has the fo:keep-with-next="always" and also a fly anchored at-char or at-para with style:flow-with-text="true" will never move to the previous page, even with space available. In SwContentFrame::MakeAll() it will first MoveBwd() and then go into the special case "if ( bKeep && bMoveable )" which calls Calc() on the next frame. But this fails to move the next frame because of SwFlowFrame::IsPrevObjMove() finding the fly with a mis-matching mpVertPosOrientFrame - that will not be fixed until the first SwContentFrame::MakeAll() is done and SwObjectFormatter::FormatObjsAtFrame() is called. But SwContentFrame::MakeAll() first detects that the frame is not on the same page as the next one despite bKeep, so it MoveFwd() again. This happens already in OOo 3.3. IsJoinLocked() should be a reasonably good heuristic for "is the previous frame being formatted". Change-Id: I86996dcb3d0c46fcb99ec9ad463569abbb8b99f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130033 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 38e7c18188f1c5310898181db87686774be3c040) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130014 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-02-18tdf#146622 sw crash fix: don't delete already deleted rowsLászló Németh
Delete tables and rows removed also tables and table rows with tracked row deletion/insertion. This resulted not only lost change tracking, but a crashing Undo. Crash regression from commit 99059a1ececa3621c2fe46fabdd79eed9d626c42 "tdf#143359 sw: track deletion of empty table rows". Non-tracked deletion of the tracked row changes was a temporary solution for the missing UI of tracked row changes, implemented in commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Note: UI was added in commit f348440e17debacbcba9153e238e010e8c020bdc "tdf#146120 sw: show tracked table changes with different color", commit 95c003d75e0f8b255344715a35358072b5eba99d "tdf#146145 sw: 1-click Accept/Reject of table row changes", commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535 "tdf#146144 sw: add tooltip to table rows with change tracking", commit eebe4747d2d13545004937bb0267ccfc8ab9d63f "tdf#144270 sw: manage tracked table (row) deletion/insertion", commit f481c2c8e74bded11fac754e493560391229dbcd "tdf#144057 sw track changes: hide deleted table rows" and commit 23846867ea32667ccf328c36142394dd6aaee8ba "tdf#147182 sw: accept/reject all changes of a table selection". (cherry-picked from commit 95213407dfcbf34056037d60243ff915340d1a2e) Change-Id: I384b750b0d3626fa8b3f256c7eaf5b93f382e4e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130011 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-18Resolves: tdf#147421 Do not use OUString::replaceAll() to strip null-bytesEike Rathke
It reallocates and concatenates for each replacement so for massive amounts takes ages. Change-Id: Ibe1673fd4775c5b95833000669c1a24e718fd77c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129971 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4b0c17609c2cca326bbcc9e8488a327a4a9ea952) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129938 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-18tdf#104902 - Handle embedded newline in Calc's .uno:EnterStringAndreas Heinisch
Change-Id: I6377aebb06b6e6873ce61984a887d9e16eecd361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127766 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 44d237c375b7ef9a5a61a2f752bd19b57649ffbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129932 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-18tdf#147435 sw: enable Accept Change for table selectionLászló Németh
Accept/Reject Track Change options were only enabled for table selections, if the first cell of the selected cell range contains a redline. Now they are enabled, when arbitrary cell of the table selection contains a redline. Note: if the selected columns don't contain any redlines and any tracked row changes, but the adjacent not selected columns contain a redline, there is a false Enable. Follow-up to commit 23846867ea32667ccf328c36142394dd6aaee8ba "tdf#147182 sw: accept/reject all changes of a table selection". Change-Id: I1d7af04aa3fe5232bb1ff7f9af6116bcdc621ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129811 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit c4f6fee3bea0d8618b5815e60304ff9359ccd21c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129934 Tested-by: Jenkins
2022-02-18tdf#146704 sw: fix regression of endnote layout in sectionsAttila Szűcs
Endnotes collected at the end of sections moved to a new page. Regression from commit 4c31b4ef2083087a822c3ae648fd09acc67d2f88 "tdf#139336 sw: fix extra pages of multicolumn sections with footnotes". Co-authored-by: Tibor Nagy (NISZ) Change-Id: I36568e33b04ba8024ceef6b3ea84b71fb375e2a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129896 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 9a457c24ab2731c99f1a5fa1d28f68788e6977f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129936 Tested-by: Jenkins
2022-02-18Update git submodulesEike Rathke
* Update dictionaries from branch 'libreoffice-7-3' to d5c7b77c5828e3e7ded8bd09dbb0a59665f30523 - There is no EO country, eo-EO is a bad language tag Change-Id: Ia96d31b61d3eab009609f3d8cd8d78228449ccc4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/129973 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5314824424e7efbba66df57cafafa7ae246b5b31) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/129937 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-18tdf#143709 - Create repaint rectangle with the old text sizeAndreas Heinisch
Otherwise, the repaint rectangle uses the new text size, which may lead to visual artifacts, if the old text size exceeds the new one. Change-Id: I9b49755bf6b8c453e319e2a4081d58bf2e433cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129920 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 7c00544d672f0fc0f08c12f5fd9cd53fdbe96733) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129935 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-18tdf#146848 sw: fix assert about input field in undo nodesMichael Stahl
These should not be updated. soffice.bin: sw/source/core/txtnode/atrfld.cxx:713: void SwTextInputField::UpdateTextNodeContent(const rtl::OUString&): Assertion `IsFieldInDoc() && "<SwTextInputField::UpdateTextNodeContent(..)> - misusage as Input Field is not in document content."' failed. 3 SwTextInputField::UpdateTextNodeContent(rtl::OUString const&) 4 SwTextInputField::NotifyContentChange(SwFormatField&) at sw/source/core/txtnode/atrfld.cxx:669 5 SwTextField::ExpandTextField(bool) const 6 SwFormatField::UpdateTextNode(SfxPoolItem const*, SfxPoolItem const*) at sw/source/core/txtnode/atrfld.cxx:407 7 SwFormatField::SwClientNotify(SwModify const&, SfxHint const&) 10 SwFieldType::UpdateFields() (this=0x7f7ff2d654b0) at sw/source/core/fields/fldbas.cxx:220 11 sw::DocumentFieldsManager::UpdateFields(bool) 12 SwFEShell::Paste(SwDoc&, bool) at sw/source/core/frmedt/fecopy.cxx:1117 Somehow this causes testTdf139843 to go from 7 to 6 pages, but opening the bugdoc shows it as 6 pages too, not sure what's going on there. Change-Id: Ie25b2b2c4d8fd262850da31cbade5e121e9ec361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129919 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 71e8a947753d359bd5b4d1174f4d6332eaf4a309) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129933 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-10 15:54:39 +0000