summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-10related tdf#138925 sw inputwin: get correct cell formulaJustin Luth
The problem was that repeatedly pressing F2, or any non-mouse movement between cells was getting a "random" formula returned. The only thing that worked was moving the mouse, because on every pixel change, it re-loads the RequestHelp tooltip that displays the formula, thus loading it as the most current formula. The example bug document easily crashes, and everything about this is terribly imprecise, so I'm not attempting to make any unit test here. The code is modeled from GetContentAtPos, which also does an unconditional const_cast. Change-Id: Iecaf2e9a56bccef9a1e05bc0667caad6c3aeb109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151550 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-10sw: fix crashtesting assert on moz386569-2.odtMichael Stahl
itrpaint.cxx:434: SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed. The list item has the soft hyphen as a bullet char. Surprisingly this creates a SwSoftHyphPortion followed by an empty SwNumberPortion. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: Id58687c7e968a8a77ed5fab85d4c20d239174569 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151608 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-10sw: fix crashtesting assert on fdo38226-1.odtMichael Stahl
frmpaint.cxx:804: SwTextFrame::PaintSwFrame: Assertion `!oTaggedLabel' failed. This is similar to what was fixed in commit 0913da454e2dd88fb8fc83cddd20c735b79f73ca except that the last numbering portion is now in a subsequent line that isn't painted at all due to the "aLine.Y() <= nBottom" check in SwTextFrame::PaintSwFrame(). (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: I16cd8bd254457b81e74cb02a46ddf0e2167f11ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151607 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-10ImplPrintTransparent is always called with an empty maskNoel Grandin
which we can use to simplify it Change-Id: I8fa38a9f414d8d720e31bd1f71fd722f6a95fdbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151635 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10tdf#143148 Use pragma once instead of include guards in chart2gilssonn
Change-Id: I6227accbaf35ea810828b018f0f7349f5404778f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151604 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-05-10Related: ofz#58781 insist on presence of office:mimetypeCaolán McNamara
reject here what full office will reject to generate easily reproducible findings. Change-Id: Ia9a2f7fd3ae32b2623caa8eb9964a8fbd7ee09b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-10sc: improve test a bitXisco Fauli
Change-Id: I26e06d76b6af1221fdfad1ae2c8dda4f10c70e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151632 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-10tdf#142249 EMF Implement EMR_POLYDRAW recordBartosz Kosiorek
The EMR_POLYDRAW record specifies a set of line segments and Bezier curves. Change-Id: I93d846d2fbb7a60b0565668a17ee092da30ef21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151424 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2023-05-10Double name 'liststore1' fixedJuergen Funk
Change-Id: Idd4ab5d64ab58ddbe13c412f5684ab7db8af8224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-10AlphaMask::BlendWith wants an AlphaMask parameterNoel Grandin
so make it so Change-Id: Ia5a91c78d2fd10f22eb19e4ebbd753151149190f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10tdf#76258: sc: Add UITestXisco Fauli
Change-Id: I670950f499ebc268318913f3f3743e8d99d9ab84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151631 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-10Revert duplicate shortcut definitionJuergen Funk
This reverts the Accelerators.xcu part of b6af287527d42f8cf4bc43047fe0ed6130420d6b The key combination for Ctrl-F is already defined in the global section, it is not necessary to define it in other modules. Change-Id: I44047f998487b58185ceb19c19f06ee44797c5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151503 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-05-10use comphelper::WeakComponentImplHelper in DocumentEventNotifier::ImplNoel Grandin
Change-Id: Ife4222b3f485969351565145554a51e4bed199df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10Add view options class in DrawParis Oplopoios
Add SdViewOptions class in Draw to hold the view state and manage view separation in tiled rendering mode Change-Id: I1546fa536555b3262217ff4be163a48b958b7a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150249 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit fa2fdc90d5fba9420cbb475f8c88423124c158ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151519 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-05-10Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 4a35dde9e2066bb0f5fe9ebd14114282a6e3866b - update translations for master and force-fix errors using pocheck Change-Id: I002f6217ab064ef3895d3c7ca0ebf3a28a7c936e
2023-05-10chart2: remove duplicated codeXisco Fauli
Change-Id: I1bd92230e9fba8b562e57dbc3e269913dc3942e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151605 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-10desktop : remove useless using namespaceArnaud VERSINI
Change-Id: I23a2932402120d9097ab6bd9793d4b4e92be03e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151538 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2023-05-10Revert "Resolves tdf#134941 - Fix size issue on start center"Heiko Tietze
This reverts commit 77ed6380dda73a9716f48f73c3ff730380557a09. Reason for revert: Scolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens Change-Id: I2fb9759d55e28169508f33a822241efe955d5699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151525 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-10Revert "Resolves tdf#155167 - Start center app pane issue under gtk3"Heiko Tietze
This reverts commit b7632b68c5398fce8a22ec09414e0075709fbc32. Reason for revert: Scrolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens Change-Id: I1c908dfc801a3867597feefa2a8852b871f7df3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151526 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-10tdf#154499 spell checking: allow phrases in custom dictionaryLászló Németh
Adding phrases, i.e. space separated word sequences is allowed in custom dictionaries and in replacement text of the negative custom dictionaries. Follow-up to commit 5619fc438273cd15e78539e78b8af751bca24b1a "tdf#154499 sw spell checking: add 2-word phrase checking". Change-Id: Id82dafcd5ca41842e78f2121579f5b46857bfca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151596 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-10CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfTableMiklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: I2edb1dfd8fa7d756ce34b747659d9cfbe18b49ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151600 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-10re-enable typeid checking in exceptionToStringImplNoel Grandin
now that we have valid RTTI tables for the UNO proxy objects generated by the bridge code. (We won't get a useful typeid for them, but for all other objects, we will, so this is still worth doing) Change-Id: I32bfa0099a242021f353fc4065e8660eb6c7cd93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151585 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10use WeakComponentImplHelper2 in Bootstrap_MacroExpanderNoel Grandin
Change-Id: I49f051d9c9da46ec877e4f611836c7a3548f9f10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151581 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10use WeakComponentImplHelper2 in ServiceManagerNoel Grandin
Change-Id: I0f141398effbd2673c02f9d1f4378fd4e67af655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10Remove duplicated includeAndrea Gelmini
Change-Id: I324844e4ff628c6a72621a2b1511cc5b7f390901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151588 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-05-10Fix double wordAndrea Gelmini
Change-Id: I72a951275fc0e3ff16be6c2f4cefae7949dea9be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151594 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-09CppunitTest_sc_opencl-2: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
Avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I3a6253d259bac58f8d8ca78cd5d4f9e357a2c315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151589 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09comphelper/servicedecl.hxx is unusedNoel Grandin
Change-Id: I3ddb06a31c746bfd7da72368a51266d688b1230b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09tdf#155210 FILESAVE ODT Default chart row labels disappear from Writer chartNoel Grandin
revert commit 6500106dff0f0cd86f509ffd01542aab77c21596 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Apr 19 13:48:55 2022 +0200 tdf#148635 no need to init ChartDataWrapper more than once Change-Id: I28f078731bd8bfedbde63d0bb2e5fe40f0a4ff46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09Typo: tapstoplabel->tabstoplabel in sd/optimpressgeneralpage.uiJulien Nabet
Change-Id: Ie271244eb971fc8180984b7a2723e2c780a9fb0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151486 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-09Resolves: tdf#142176 under GNOME inhibit logout if there are modified docsCaolán McNamara
and if we are forced to quit anyway, unset modifications on documents and terminate. Change-Id: If4a3aed48a4621950e2d630fdfef34b28ba1b089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09drop unused ImplPrepareExitMsgCaolán McNamara
Change-Id: I9254328829ac051524fbfdf6a3b5b2f72b12c427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09Resolves: tdf#138512 don't crash on removing already Disposed a11y contextCaolán McNamara
Change-Id: I2a8f3d10a1349de233e11d841f7f244e4e513b2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09const -> constexprMike Kaganski
Change-Id: Ibeeba1862d84e43fa659cb2a97ef3498674f0d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151590 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-09CppunitTest_sc_opencl: factor out common codeXisco Fauli
Change-Id: I5da3d3a0e0f9f18033d8695081501a52aea5bd60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151586 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09tdf#95520: sc: Add UItestXisco Fauli
Change-Id: Ia4e30a1e4dea3dbd9eb40c29c96e5ab3d700e54e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151578 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09Fix typoAndrea Gelmini
Change-Id: I38877f928fd6943afa1a6c17d8225caef8411d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151338 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-09use WeakComponentImplHelper2 in TypeManagerNoel Grandin
Change-Id: I2358006a069ea4e8cdeeeafb8384ad8d47fba50a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09move a toolkit header inside the moduleNoel Grandin
It is only used inside the module, no need to be public Change-Id: Ibd8445ecbb67624569ee7225f0bdf6d9c041dab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09inline GalleryStorageLocations allocation into GalleryFileStorageEntryNoel Grandin
no need to allocate this separately Change-Id: I01795ac459c5b65b5c143dc081e5b7cf74c2e6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09tdf#154282: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I48b0dd636f50bf0b4d08ee0d43593f6142babd3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151566 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09sc: use the current cell's numfmt to format...Dennis Francis
to format the values in the validation list when the items are numbers. This is better than applying no formatting since we lost track of the source formatting when values are passed through a matrix. Change-Id: I06432bd93ef8d01181dd16d2f5ee99eb0477c094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151313 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 2f6d1cefc184fda3ba292f1718b034202989d7b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151386 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-05-09tdf#104487 - Function wizard: remember last used function categoryAndreas Heinisch
Change-Id: I978dd63553e3528e7b9b853dbb438304f1f680cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151565 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-05-09sc: add theme colors to the color pickerTomaž Vajngerl
Change-Id: Iae8f502a24187f4d41f60fbb727066f214d1cf70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151449 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-09increase max_len for fodt2pdffuzzerCaolán McNamara
Change-Id: Ib8c3c0e35c6a7cc8b3b40fce4f89c038e819f088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151587 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09tdf#154451 uitest: use more oneprocess modeXisco Fauli
Execution time changes: - UITest_autofilter: 4m39,519s -> 3m10,079s - UITest_autofilter2: 2m11,254s -> 1m32,543s Change-Id: Ibeb22b46a4ccaa1d560a4d82288ba9f2351b8f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151576 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09CppunitTest_sc_opencl-2: re-enable testXisco Fauli
Disable in 836abd393d126cfbba6b0bd1fdda5b03095516c9 "GPU Calc: temporarily disable Kombin unit test" Change-Id: I311caae5450874c61a6bf5e40940513f614da965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151572 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-09NFC sw edtab.cxx: remove do ... while (false) without breakJustin Luth
Since original import in 2000, the clause was while(false) (although at that point it still had a commented out condition). The next change to this function remove the commented out stuff, leaving only a pointless do while bracket that has no early exit uses. Change-Id: I4e0c083a52677c3116e6d008a860b1473418d1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151549 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-09MCGR: Correct interpolate TextureMap due to possible zero valueArmin Le Grand (allotropia)
Change-Id: I5b2fe354077bea659f522e5b5c839be1f4cae1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151568 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-09move include/svx/legacyitem.hxx inside svxNoel Grandin
it is only used from there Change-Id: I12065d4e2db142d50c403310ea4a7bb23412884e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>