summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-12-22Separate core drawinglayer func. into drawinglayercore libraryTomaž Vajngerl
This separates the drawinglayer core functionallity into a separate library, to keep a strict separation what is backend dependent and what is not. More strict separation can be done at a later date. This will make it possible to push part of drawinglayer (part of processor2d) directly into VCL. Change-Id: Ibc26580067e50bf20d7cdd37fa0e44eb10200878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22CppunitTest_sw_rtfexport: rework to avoid mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I3937b6e91b5889f4ca0d7b2e9e66f09f505e7af2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127278 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-22tdf#144862 explore alternatives to writer's on-screen glyph positioningCaolán McNamara
writer does glyph position adjusting to try and split the difference of the "printing" positions and "screen" positions. it seems to have been there from the initial import commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 Date: Mon Sep 18 23:08:29 2000 +0000 initial import we seem to sync with the printing positions after each whitespace so each initial glyph after whitespace is a stable position and is the 'printing' position while each following glyph is in a position which is somewhere between the 'printing' position and 'screen' position. Which leads to noticeably unstable positions of text during editing at various zoom levels and without a clear rationale for the heuristic. GlyphPositioningMode::Classic, the original mode which remains the default. GlyphPositioningMode::PreferLayout, takes the vcl provided print positions and just uses those unmodified for screen layout like editeng does. GlyphPositioningMode::ClassicInspired, which is similar to GlyphPositioningMode::Classic in using 'printing' positions for the start of runs, but using 'screen' positions for run content. GlyphPositioningMode::PreferReadability, replace the 'printing' positions with the screen-optimized positions for all content. use tools, options, writer, view, glyph positioning to change Change-Id: I6677af973268bc586d825c7fbf0b483aaf651ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-22loplugin:flatten in filter..includeNoel Grandin
Change-Id: I74c1ea8b9b490eaa9508a885758224063e39051b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22loplugin:flatten in package..reportdesignNoel Grandin
Change-Id: I2da242fcb59709ebdd0819ec04d051d794da71e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22loplugin:flatten in l10ntools..lotuswordproNoel Grandin
Change-Id: Ie6de142db1987094fdf538148ac5ee33379a3e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-22ucb: webdav-curl: update READMEThorsten Behrens
Change-Id: I3b72183fc367875f8ebce6f3fffc7efc32ca6c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127285 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-22tdf#133713: sd: Add UItestXisco Fauli
Change-Id: Ibeaf5fe2c6302de4b01be9b38fcc9c2cf482d3c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127241 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-21tdf#109390 Warn about empty New Document only on Apply, not OKGabor Kelemen
Creating new document type hyperlink shows a warning about empty file name only when pressing Apply, and closes silently on OK Change-Id: I00e7b20a12df8e35e154e3cf532067cbad72c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127010 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-21Fix typoAndrea Gelmini
Change-Id: I0b441f47062a45395777b609d71ea0fa978bffc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127279 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21Fix typo and removed duplicated commentAndrea Gelmini
Change-Id: Id8dd9ff12fe62f5225112eebc681bf840e69f7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127280 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21Fix typoAndrea Gelmini
Change-Id: Iefc9cb27f6ac84958a002e395bd631eb0590f022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127274 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21merge the two places we adjust the kerning arrayCaolán McNamara
no logic change intended Change-Id: I39aa616b9ec3ba40ad9d0d2a2d6bbafe9d3db984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21split the two reasons aKernArray values are changed into two blocksCaolán McNamara
no logic change intended Change-Id: I4305ecc865ff18f29278e78afc6e995ad095e803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21Typo remaining "bSelected"Julien Nabet
Change-Id: Ic0cede117753cf1f7cad6c1fcb1649864cb18254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127268 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-21move variable to where its setCaolán McNamara
Change-Id: Iff9c47766f325a382198311392c087b2ee150711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21format these two related blocks the sameCaolán McNamara
no logic change intended Change-Id: I0bb7f2c5f8ec1c2ff7c8af14f5a62f77411660d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127244 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21both branches start with the same codeCaolán McNamara
no logic change intended Change-Id: Ic15315bd44e7e718aacac188500f755e7fd0bec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21split out the block where we add extra space from the kerning adjustment blockCaolán McNamara
so the two independent things are seperated from eachother no logic change intended Change-Id: I55532b58974077286a6b062144eb4872d2c40328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21move this variable to where its usedCaolán McNamara
Change-Id: Ib0559558ddea395c66149813ad6fb84d3531cab6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to f506a2490665212eeefb5934d6d4346a8a8c1856 - update translations for 7.3.0 rc1 and force-fix errors using pocheck Change-Id: Iaf5f970103a9ace669ee6019b2362031e34cbdf0
2021-12-21update creditsChristian Lohmaier
Change-Id: Ibc9821175f53f57773e91877224c6b1d9e57f409
2021-12-21Keep GUI with --enable-avmedia and --disable-guiJan-Marek Glogowski
So I thought I could come up with a rich MediaItem and can get rid of all the GUI elements. But all the still needed features require a MediaWindow. Probably not for real, but there are multiple levels of createPlayer (some static) in MediaWindow and priv::MediaWindowImpl. Untangling this will require more time, so just return to the old --disable-gui state with actually keeping all the GUI elements. Regression from commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31 ("Fix --disable-avmedia for DESKTOP build")... Change-Id: I2b04459003d474cd3abf8b086f2f20f17274a7ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127226 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-21Don't build clucene if not neededJan-Marek Glogowski
Just build it if HELPTOOLS or XMLHELP are in BUILD_TYPE. And simply tets for clucene just in this case. And since XMLHELP is not in the list of PERMITTED_BUILD_TARGETS, disable it. Change-Id: I13fdbf096c60191a428e23c22344f7e22e8c5d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127231 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-21loplugin:flatten in desktop..drawinglayerNoel Grandin
Change-Id: Ie6594c9961aba5517c6ff61fb3bc1142081b1197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21loplugin:flatten in filter..frameworkNoel Grandin
Change-Id: I15a577b3c6da03001bbbf2c2b43b29b41c4007c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21loplugin:flatten in editeng..extensionsNoel Grandin
Change-Id: Ica8f0a6e3d30dba3b5a083e3c04522073de8303f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21filter: try to detect 0-byte DOC files based on extensionMiklos Vajna
Commit ae1f51b4888a3aa14837ac6e4083f33b2176ca45 (tdf#123476 filter: try to detect 0-byte files based on extension, 2020-10-28), already implemented this UNO-based import filters, do the same for built-in filters as well. Another problem in filter/ was to pick the WW6 filter for .doc -- require export+preferred support in the filter to get WW8 instead. An additional filter that may kick in is MS Word 2003 XML: this is avoided by requiring "preferred". Change-Id: I46e280beb5341213b0fe7a09a549b52c0c1ea3f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127219 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-21Use sal::systools::CoInitializeGuard and sal::systools::ThrowIfFailedMike Kaganski
Change-Id: Ifb40e7672671df03b5ffc89905ad1e7b68451b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127232 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-21Fix typos in mdrivermanager.cxx (connectivity)Julien Nabet
Change-Id: Ib5c115faf0dcff61be806b538c4f93bc16b9928b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127230 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21tdf#127989 OOXML: fix import of transparent hatchingTünde Tóth
Set FillBackground property of hatching fill to false, if the alpha value is 0 in the <a:bgClr> element, i.e. if it's a transparent hatching. This way the previous non-transparent hatching is transparent now. Change-Id: I483d5c654be55e74c9073769b06f185526429635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126550 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-21loplugin:flatten in canvas..cuiNoel Grandin
Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21tdf#146244 sw: fix Undo of accepting table row insertionLászló Németh
Fix Undo of accepting table row insertion to get back the "false" value of HasTextChangesOnly property and the associated light blue table row background. This fixes also the missing update of the table row background at accepting the table row insertion. Follow-up to commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12 "tdf#146244 sw: update HasTextChangesOnly in modified rows". Change-Id: I8e2436b6b7b67f06037481955ff22cdbc2b22dc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127228 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-21Typo: "seleted" instead of "selected"Julien Nabet
Except "getSeletedPositionStart" and "getSeletedPositionEnd" defined in offapi/com/sun/star/accessibility/XAccessibleTextSelection.idl since e5618f1707626a8c096ea2ca8da3cbe2c5f3db16 author Steve Yin <steve_y@apache.org> 2013-11-16 23:58:19 +0100 committer Michael Meeks <michael.meeks@collabora.com> 2013-11-19 10:02:25 +0000 commit e5618f1707626a8c096ea2ca8da3cbe2c5f3db16 (patch) tree de014d37b3de5a7ab505a86a6e6ce46ade4bdc1f parent 1263b20f56d896706c982ad1b91d2936abf5d617 (diff) Integrate branch of IAccessible2 Change-Id: I814923003bb247c4ef66f296ac4033bae9073988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127227 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-21Use sal::systools::COMReference in getAdoDatalinkMike Kaganski
Change-Id: If0c474209da5390c0c6e28c11ca26a1c915ab51f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127218 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-21loplugin:flatten in accessibility..basicNoel Grandin
Change-Id: If2cc282c2b135d634daf393a082c29049b10a677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21tdf#131467 Qt set default position on first resizeJan-Marek Glogowski
Setting the position in Show() is too late, because LO will try to set the mouse pointer to the default button, if configured. That obviously needs the window position. And also take the menubar offset into account. Change-Id: Ia280539c082ff6f675966869fb6643a41a17d696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127154 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-21Fix loplugin:unusedvariablecheckStephan Bergmann
...on macOS, where it started to cause false positives like > vcl/inc/osx/a11ywrapper.h:89:98: error: unused parameter 'anAccessibleContext' [loplugin:unusedvariablecheck] > -(id)initWithAccessibleContext: (css::uno::Reference < css::accessibility::XAccessibleContext >) anAccessibleContext; > ^ after a214369f14d3f53d45b1889827057882c0ffd62e "loplugin:unusedvariablecheck improve" Change-Id: I450df3a6d768b4452d0975b5920ea0b3ce53ce13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-21provide a "make vscode-ide-integration" targetChristian Lohmaier
to be consistent with the other ide integrations and to take care of the extra step of running "make vim-ide-integration" to create the compile_commands.json file required by the vscode integration. Not using the autogenerated file created by configure directly might also spare some users from having their own additions overridden Change-Id: Ibb269197dc84f607b28ddad03adc919864e0c040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126860 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-12-21Fix formatting (wrong indentation)Samuel Mehrbrodt
Apply clang-format to this method Change-Id: I67fbdc4ca8b9c602ed85a57dbbde8ed47bdd45c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127215 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-21sd theme: allow setting color effects in the chardlgMiklos Vajna
Which means not only the 12 colors from the theme are offered (which comes from the current master page), but also lighter/darker variants. And once these are selected, their theme index and luminance modulation / offset is also remembered. This means if you pick light blue and later change accent1 from blue to orange, you get light orange out of the box. Change-Id: Ia83b8971ad894d02ed4ec5ca914684fc9cf9a677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127211 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-21no point in release solar mutex before calling PostUserEventNoel Grandin
which will just acquire it gain Change-Id: I62b0d43e15f93994a53d64b24f9765c5e7b676ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21no point in release solar mutex before calling PostUserEventNoel Grandin
which will just acquire it again Change-Id: If483a74ccac762f288bcd05956066ce726a96516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21no need to take solar mutex hereNoel Grandin
Application: :Post* will already do that Change-Id: If116ddd79b4ba30ce983d467161b8fab32dbd1cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Transfer preferred DPI into SfxTabPage with additional propertiesTomaž Vajngerl
This adds to SfxTabPage a new member maAdditionalProperties, to make it easier to transfer additional properties into a tab page. This is then used to transfer the preferred DPI into the tab page, which was previously done by user data, which is less than ideal and always doesn't work. Change-Id: Ia4daa72093d96310009b0065f8a0e26be6bedec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127205 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-12-21we already have the glyph positions in this caseCaolán McNamara
Change-Id: Ie3c1a84cf7c33e8bf758a4b849ded6f2a31bd81b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-21SAL_WARN->SAL_INFONoel Grandin
this method is often speculatively called, so the warnings here are not that useful Change-Id: Idc9460b365dac955d1ced4c1bc2c9d2f49fbe540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21tdf#90805 sw tables: use veryThin instead of hairline bordersJustin Luth
This keeps it consitent with tdf#99027 which was fixed on the same day. Change-Id: I03d8a9c2ab1e7f6cf8a7c95d7600d549138e414e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127165 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Justin Luth <jluth@mail.com>
2021-12-21Use sal::systools::COMReference in connectivity/adoMike Kaganski
Change-Id: Ic3c59f70cf0e1ed0020bf4f11d7dee14c69f2119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-21also handle SVG_COMPAT namespace hereNoel Grandin
Noticed an "unknown element" message while doing some unrelated debugging Change-Id: I1c6d4c9cddb340d892ba63d6d209bf8f72e2203d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127210 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>