summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-23loplugin:unusedfields,can-be-const in xmlsecurityNoel Grandin
Change-Id: I271b1d69d5231ab76cb49fb0101c09d7c0ef6b79 Reviewed-on: https://gerrit.libreoffice.org/57779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23tdf#72560 writerfilter: check my style, not default styleJustin Luth
The default style is only relevant if no style is defined for the paragraph, so it should not be hard-coded into any general operation. The intention of that code was to look for an inherited value, which can properly be found with GetPropertyFromStyleSheet(). Change-Id: Ie2805d2516b43b45e702ee860deabe89d50ec031 Reviewed-on: https://gerrit.libreoffice.org/57804 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-23Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: If68a45523242a30d5bc8122818b36f0babc70dcd Reviewed-on: https://gerrit.libreoffice.org/57828 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I2715bcbaf642fd24d61f61dbf4e978e06afbf102 Reviewed-on: https://gerrit.libreoffice.org/57824 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-22Fix typosAndrea Gelmini
Change-Id: Ia78310bd85c9a582245074bd46154516a1f21c86 Reviewed-on: https://gerrit.libreoffice.org/57826 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-22fix oss-fuzz buildCaolán McNamara
Change-Id: I166d5f675d1b807e023cc19f72071fc77d3dd036 Reviewed-on: https://gerrit.libreoffice.org/57823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-22coverity#703935 Unchecked return valueCaolán McNamara
Change-Id: I31ce141955a3beadb60368fc8238bfe0507b1566 Reviewed-on: https://gerrit.libreoffice.org/57782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-22Fix typos in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I5140beaf2115005c197c1e47f4d2df073a761ed4 Reviewed-on: https://gerrit.libreoffice.org/57773 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Move bookmark target out of list Targets <a> inside a list breaks formatting. No impact on translation. Change-Id: I58aecd307f4156f0fb84ee0b5b06b497ca28c1d2 Reviewed-on: https://gerrit.libreoffice.org/57818 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Restore 'GLOBAL' label in Index GLOBAL is the external nam of the SHARED bookmarks. Change-Id: If4a877cc26dddb3fa99e5369ef63c7333aa53ffe Reviewed-on: https://gerrit.libreoffice.org/57815 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#118844 Add missing icons in Help pages Apply strategy #1 described in tdf#118844 comment #3 Change-Id: I072bf837217acc8dc84ff1104324df69e33a22bd Reviewed-on: https://gerrit.libreoffice.org/57801 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-22tdf#37223 Writer: insert 1-cell tables as text instead of OLE objectLászló Németh
to get a user-friendly solution to copy Calc cell content to a text document and to its native tables. NOTE: MSO does the same for copying 1-cell tables, while LibreOffice was able to do this only with paste special as RTF. Change-Id: I6156333055aa9bed4cf56ff12f913e89d3f5700c Reviewed-on: https://gerrit.libreoffice.org/57783 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-07-22tdf#98074, using the same builtinId maps the styles to the same oneMarkus Mohrhard
Additionally, using customBuiltin for all styles is a bad idea as well. Change-Id: I788a3c5b9164f79aa65ded2fc3e6a556e44ee0a8 Reviewed-on: https://gerrit.libreoffice.org/57807 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-21Removed executable permission on (odp|pptx) filesAndrea Gelmini
Change-Id: I6180c01c45c3336192d4e95cc943ad9f4bc38f4e Reviewed-on: https://gerrit.libreoffice.org/57730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-21Fix typosAndrea Gelmini
Change-Id: I8dd681eebf5534224d1b5e886d6a0600767f9c98 Reviewed-on: https://gerrit.libreoffice.org/57600 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-21Fix typosAndrea Gelmini
Change-Id: Ifc804e33afa160943d7b5634f8ccf4e3af4d26e5 Reviewed-on: https://gerrit.libreoffice.org/57806 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-21writerfilter: default style is the last oneJustin Luth
Documentation states, and the examples confirm that "If this attribute (w:default) is specified by multiple styles, then the last instance of a style with this property shall be used." Change-Id: I17f06ab8944a39341a00c479117e978a01d6af7a Reviewed-on: https://gerrit.libreoffice.org/57510 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-21sd: fix closing document twice in testTdf118768.Mark Hung
Change-Id: I07def80070d8109b9d54ef19a841e3091f743b9c Reviewed-on: https://gerrit.libreoffice.org/57791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-21sc: Compare vectors by simpler codeTakeshi Abe
Change-Id: I5efac4a449b388c2d8a6e47beb4a6a8fbfed909a Reviewed-on: https://gerrit.libreoffice.org/57797 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-21Remove useless self-assignment of sHelpPathMuhammet Kara
Change-Id: I4ba4a19a45ade62e65ae987cadb8ba07d4a5e006 Reviewed-on: https://gerrit.libreoffice.org/57794 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-21fix shutdown crash when SfxApplication has already been destroyedMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7 Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea Reviewed-on: https://gerrit.libreoffice.org/57789 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-20Remove dead code from textwindowaccessibility.cxxMuhammet Kara
Seems like commented out during some refactoring/rewrite in 2013 with commit efb23f29983f8, and then forgotten Change-Id: I59148b7fd9ee8a68bfdb0609dc3a13634b29db5f Reviewed-on: https://gerrit.libreoffice.org/57785 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-20tdf#118150 Fix displaying of chart where Legend is set manuallyBartosz Kosiorek
By default Legend's position is automatic and it is located at the right side of the chart. Unfortunately even if layout with manualLayout is set: http://www.datypic.com/sc/ooxml/e-draw-chart_manualLayout-1.html the empty space for the automatic legend on the right side of the chart, was left. This is issue with opening of the OOXML charts by LibreOffice, as MS Word is opening the same document properly. This patch fixes issue with wrong chart displaying, when manual position of the legend is set. Change-Id: Id5363d48b049c469b6761b43cecfbb56514bf7d8 Reviewed-on: https://gerrit.libreoffice.org/57762 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-20Import ODF with data transformationsVikas Mahato
Change-Id: Iee76ed28d0dcd4ee57115ec951a181b2cf8d35fd Reviewed-on: https://gerrit.libreoffice.org/57239 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-20Remove commented-out code from bastypes.cxxMuhammet Kara
Was last touched in 2012 by a mass find&replace in commit d3e08f257437f Change-Id: Id62c0ce4680afa1febca01d54734f11dd026a58f Reviewed-on: https://gerrit.libreoffice.org/57786 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-20tdf#118662 Cleanup old hack with cloned SdrCaptionObjArmin Le Grand
XclObjComment formally cloned the SdrCaptionObj for a single reason - to suppress functionality of the UNO API implementation in SvxShape::GetBitmap - non-inserted SdrObjects did not create Graphic return values. Changed this to use an exclusive flag at SdrCaptionObj, only accessible for XclObjComment. Due to bad/undefined behaviour of SdrObjects that are not iinserted anywhere (see old comment in XclObjComment) there is no way to return to cloning the SdrObjects just to have them without being added to a SdrPage. Also improved the time eater UNO API implementation SvxShape::GetBitmap to use more modern stuff to create the Graphics needed. All the time constructing a full E3DView and setting SdrObjects selected and getting the selection as graphic is way too expensive. That way save may even get somewhat faster. Last was to cleanup the bInserted flag in SdrObject. It is no longer needed, being inserted now depends on being a member of an SdrObjList (Group or Page) - sounds normal anyways and is a synergy effect of already done AW080 cleanups. Checked now on linux. Problem is UnitTest 'testN777345' which checks file "n777345.docx". First point is that this only happens #if !defined(MACOSX) #if !defined(_WIN32) so it's clear why I detected no problem on Windows. Second point is that this test takes a checksum of a Graphic that is created using getReplacementGraphic() this value *will* change - of course - every time creation of that graphic is even *slightly* modified, so from my POV this UnitTest is defined to fill quite often. It may even create different results on different systems (!). Adaption of the test value will be needed quite often and makes this test questionable. Change-Id: If0918831a9cbd61b31298aeac7342e1913ee6c7a Reviewed-on: https://gerrit.libreoffice.org/57758 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-20Fix typosAndrea Gelmini
Change-Id: Ia3e6f17217b837517faa588ea7f2e72dc5aff6aa Reviewed-on: https://gerrit.libreoffice.org/57767 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-20implement pdf export of underline for outlined fontCaolán McNamara
just the simplest case of a straight solid line which is outlined, i.e. border in font color and filled with white Change-Id: I7d670a543475b6457cb2827e74a05bba6c4a91ea Reviewed-on: https://gerrit.libreoffice.org/57778 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-20gla11y: Enable warnings for all orphan labelsSamuel Thibault
This completes enabling all gla11y warnings Change-Id: I791de2f03ec09098bd52bfff515270d15584d70d Reviewed-on: https://gerrit.libreoffice.org/57609 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-20undef more vcl_font_feature test on windowsNoel Grandin
Change-Id: If8697d13b8fa87fd07e8fef9cb6fdcb0f444fa71 Reviewed-on: https://gerrit.libreoffice.org/57775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20tdf#118107 canvas opengl: avoid assertion failure with negative widthsMiklos Vajna
In case an Impress shape has a "Fade in and Swivel" animation attached, canvas calls OutputDevice::DrawBitmapEx() with a negative width. This results in a call to OutputDevice::DrawDeviceAlphaBitmap(), which asserts that the height/width is not negative. Fix the problem by transforming the bitmap before calling OutputDevice::DrawBitmapEx() in the GL case, similarly to how "complex" transformations are handled already. Change-Id: I65ccc8a984132c5921d6096bfe9c7a8fcfacd8dd Reviewed-on: https://gerrit.libreoffice.org/57774 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-20tdf#103961 writerfilter: parentless styles need pPrDefault(s)Justin Luth
It is possible for paragraph styles to be based on -none-. In those cases, the DocDefaults must be applied. Change-Id: I5b3458384c6473f3aaf64e5f274372d291ff824d Reviewed-on: https://gerrit.libreoffice.org/57371 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in HTMLTableNoel Grandin
Change-Id: I46ece073659444e802bf480996a5797c9f1ec9e8 Reviewed-on: https://gerrit.libreoffice.org/57754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20forcepoint#51 anchor location deleted before graphic anchor processedCaolán McNamara
try deferring to after anchor stack is cleared Change-Id: Iaa42d19635968d1656e171a7e0c5e473879cd8f3 Reviewed-on: https://gerrit.libreoffice.org/57772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-20loplugin:unusedfields - look for fields that can be const, in comphelperNoel Grandin
idea from tml. Extend the unusedfields plugin to find fields that are only assigned in the constructor. Change-Id: I258d3581afbe651d53ce730c9ba27a4598cd9248 Reviewed-on: https://gerrit.libreoffice.org/57733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are not working 6 writerperfect and uui modules Change-Id: Ic5534fc23a8f631c82e39def337a867d355cb93f Reviewed-on: https://gerrit.libreoffice.org/57702 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are not working 5 vcl and xmlsecurity dialogs Change-Id: I538af5bf6f54a629e4d39a9a0f153bf97c7d8329 Reviewed-on: https://gerrit.libreoffice.org/57701 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-20loplugin:useuniqueptr in SvxCSS1PropertyInfoNoel Grandin
Change-Id: Ia78db6e7ab74a6f2f15280aff65857e2f97cb578 Reviewed-on: https://gerrit.libreoffice.org/57755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20tdf#118402 Add ellipsis to New -> TemplatesAbhyudaya Sharma
Change-Id: Id79036d8d96748525fedcf366dc6f92b03360e69 Reviewed-on: https://gerrit.libreoffice.org/56926 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-20Fix typosAndrea Gelmini
Change-Id: I1048bea42c66b81244021aa2188e5dfe2ce6e83d Reviewed-on: https://gerrit.libreoffice.org/57768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-20Fix typosAndrea Gelmini
Change-Id: I1450de6d00f52bbe1f4fdebb375f505243e1eba9 Reviewed-on: https://gerrit.libreoffice.org/57769 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-20tdf#118521 DOCX import: style sets unset left/right/hanging marginJustin Luth
followup to commit 480ac84f2f5049fb4337b36f12fd6796e005761b which nicely paved the way by doing this for top/bottom. Change-Id: I61b4e298e8732391b4f0467b459d9c15298925fa Reviewed-on: https://gerrit.libreoffice.org/57742 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-07-20Don't search for old (<= 2.0) .NET SDK anymoreAron Budea
Try to find >= 4.6 .NET SDK first. +allow .NET SDK 4.7.2. Change-Id: I64084e894ee829ecff091fe16a45f309a51eb4d5 Reviewed-on: https://gerrit.libreoffice.org/57550 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-20writerfilter, xmlsecurity: various small cleanupsMiklos Vajna
That call in the RTFSprms copy ctor to the parent non-copy ctor was a bit odd. Change-Id: Ic219ec22c0b63472766a668406585dbbeebae2f7 Reviewed-on: https://gerrit.libreoffice.org/57763 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-20Fix typoAndrea Gelmini
Change-Id: Ieea98a4e02096fcc28b7dff32fd2cbaedc7483cd Reviewed-on: https://gerrit.libreoffice.org/57740 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-20loplugin:useuniqueptr in SwHTMLParserNoel Grandin
Change-Id: Id8a9bc8b0190e1c469ea5cec71d465c9025ac5d0 Reviewed-on: https://gerrit.libreoffice.org/57757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in SvxCSS1ParserNoel Grandin
Change-Id: I586e6047f6723453801958e2d8f69ffbc4c47dcf Reviewed-on: https://gerrit.libreoffice.org/57756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in XclObjNoel Grandin
Change-Id: I2995dfe5fb39ae2e7f3c37992cb3e2147381784e Reviewed-on: https://gerrit.libreoffice.org/57753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20loplugin:useuniqueptr in ScTpContentOptionsNoel Grandin
Change-Id: If19da8d2d7ffe1d245e67466fa55166b76774013 Reviewed-on: https://gerrit.libreoffice.org/57752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-23 16:50:56 +0000