summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25sw: various small cleanupsMiklos Vajna
Change-Id: I1eb56649fb9913cb32397c1ef49634a0d202f1a1
2017-01-25Resolves: tdf#104598 make bright theme shadow the same as it always wasCaolán McNamara
The shadow color was originally set via StyleSettings::Set3DColors taking the background color as the input, and doing DecreaseLuminance(64) on it to make the shadow color So, continue to follow that mode if the "dark shadow" is darker than the foreground, and IncreaseLuminance the equal amount the other direction for dark themes. This way under a dark theme the problem of impossible to see rulers of tdf#90214 is still fixed, while the bright theme colors are the same as they always were, which avoid the wearing-on-the-nerves "regression" problem. Change-Id: I33133ff180ecadce3a14ee45bd33db73c56c0225
2017-01-25use rtl::Reference in SwView_ImplNoel Grandin
instead of storing both raw pointers and uno::Reference Change-Id: I75fbb279c5698a1d29b989a03c7daf5d279e869e
2017-01-25Bypass some lines that cause problems with Clang 3.8.1 at leastTor Lillqvist
Change-Id: I05202ee6b2f083e8aacf0a2a8f8d7b8b361a5df8
2017-01-25embedserv/source/embed/xwin.cxx is goneStephan Bergmann
...since f2abfdb94e111ba551bb97ec06fa5b57be3f6299 "embedserv: convert to gbuild" Change-Id: I932da3595e0d7150ef320c2fa892ea8d5286991c
2017-01-25ofz#463 unable to mmapCaolán McNamara
Change-Id: I509faeda019f42bbe7cdc5fc249f2ea2076bb702 Reviewed-on: https://gerrit.libreoffice.org/33519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25Reduce usage of memory-leaking Context objectaleksandar-stefanovic
Huge refactoring of the methods to use the passed instance of the Context object instead of using the static one. I couldn't completely remove the static object, because it requires restructuring of the workflow so that it originates from the activity, and not from some other random place. The way it was refactored is: 1. Find a place where the static object (LibreOfficeMainActivity.mAppContext) is used. 2. Add a LibreOfficeMainActivity object to the method signature. 3. Repeat the process with a method that calls it, and repeat until the LibreOfficeMainActivity object isn't available, so that it can be passed through all the methods, to the place where the static object was used. 4. Replace that static object with the parameter of the function. The commit looks pretty huge, but it's basically just the simple refactoring explained above. The memory leak isn't completely gone, but this a progress towards it. Also moved the "global" objects of Handler and LOKitThread from an Activity to an Application, which is the correct place for "global" variables. Can someone explain why Handler and LOKitThread are used? They seem to mostly do nothing, but steeply increasing the complexity of the application. Change-Id: Ib2be77fa3adea94d6b7849d0e2afa90bf318d68b Reviewed-on: https://gerrit.libreoffice.org/33073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-25use rtl::Reference in SwXTextDocumentNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I94746e7fafcc7d2206ac0c1a6481e6006421529b
2017-01-25loplugin: unnecessary destructor oox..saxNoel Grandin
Change-Id: Ie12bfabc92bce04d702f3e77aa5896366e49245e Reviewed-on: https://gerrit.libreoffice.org/33509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25loplugin: unnecessary destructor scNoel Grandin
Change-Id: I877bc0927aff7d175c1978fdf3db55d2e048d3b9 Reviewed-on: https://gerrit.libreoffice.org/33510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25loplugin: unnecessary destructor scaddins..sdextNoel Grandin
Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25gbuild-to-ide: moduleDict targets -> all paths replaced with relativeFederico Bassini
in moduleDict[<module>][<target>] all absolute paths are replaced with a relative path: -include/libs relative to core(contained in json) directory -json objects, makefile, relative to <module> directory Change-Id: I5dd64942c2a4d6fc2f01037ee7417de91c41906a Reviewed-on: https://gerrit.libreoffice.org/33506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-25move GetPosByValue from SfxEnumItemInterface to SfxAllEnumItemNoel Grandin
which is it's only use-site Change-Id: I35943282ad4f5fd5ad297831d63e8abee9a2ddff
2017-01-25-DOPTIMIZE appears to be unused, since foreverStephan Bergmann
Change-Id: I56c91974a27cf100bc0faa1b009f4bf6358b47f5
2017-01-25Minor loplugin:stringconstant improvementsStephan Bergmann
Change-Id: I0b39526c0f0854ddbb29e77ece303cf2bdd842c4
2017-01-25cleanup css includes and using namespacesJochen Nitschke
Change-Id: I29c3f89c50f858ff4592d0058f15d856de465d77 Reviewed-on: https://gerrit.libreoffice.org/33490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25tdf#105511: use LO language settings to set default RTF languageMike Kaganski
... when file containd ansicpg0/cpg0 This allows user to change this setting and get proper document language. Similar technique is used currently for DXF and WMF. Change-Id: I884a973d98384c92d45a1d2e19720ffe3e6aa20d Reviewed-on: https://gerrit.libreoffice.org/33505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-25Default -ferror-limit=20 doesn't make sense for CompilerTestStephan Bergmann
Change-Id: Ic535de878c17749cdb2e7a6eadeb27dd2194810e
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-25use tools::SvRef in ScSpellDialogChildWindowNoel Grandin
since it is a ref-counted object Change-Id: I14a2c666a8fe8ab0ccb55f91f7573e7d3c8caf47
2017-01-25use rtl::Reference in SwChartDataSequenceNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I828ad411c989f14a9175ab173f1a4fe75fed535f
2017-01-25loplugin: unnecessary destructor forms..idlcNoel Grandin
Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25uitest: some pep8 fixesMarkus Mohrhard
Change-Id: Ib889604f1b6d11e874c27fb5d2757a792a687366
2017-01-25uitest: document more UNO helper methodsMarkus Mohrhard
Change-Id: I941f5ba20a7e3176e8d9f5f64c64ada6551d533a
2017-01-24gbuild-to-ide: replacement of the codeFederico Bassini
this patch do 2 things: 1a) create class testide, a duplicate of VisualStudioIntegrationGeneration to work on it without touch the real one 1b) place xcodeintegrationgenerator under testide, and under this last one all of generators that work yet Change-Id: Ib678134678ed19de9dcd9d1f47e8e7c16ae59f74 Reviewed-on: https://gerrit.libreoffice.org/33495 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-24tdf#105466: Add uitestXisco Fauli
Change-Id: I21ba4b716b3b7d2c1c23db816701331ba462b379 Reviewed-on: https://gerrit.libreoffice.org/33494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-01-24Move two include files to oox/inc as they are used only in ooxTor Lillqvist
Change-Id: Ie13614c1977f45aa8086f4db65ca86b7d9212735
2017-01-24Use proper check for FunctionProtoTypeStephan Bergmann
...as at least MSVC SAL_CALL-annotated functions have an AttributeType wrapped around the FunctionProtoType. Change-Id: Ic085e2e3649e6b2fc8ca380047133a8edbe20589
2017-01-24Resolves: tdf#104552 table properties dialog drops previous border colorCaolán McNamara
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f
2017-01-24loplugin: unnecessary destructor jvmfwk..lotuswordproNoel Grandin
Change-Id: Iaa4f9b178ab265342255066af7fff09f5b33ab37 Reviewed-on: https://gerrit.libreoffice.org/33496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-24tdf#105467 new color widget doesn't support XStringListControlCaolán McNamara
so this threw and mangled the dialog. New color dialog doesn't need to be told the name of colors, it figures that out itself. Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616
2017-01-24adjust the hide of the zoom so its dynamic on docking/undocking navigatorsCaolán McNamara
Change-Id: I525d0abf5618ffc2f614857a29e530f7140c0de7
2017-01-24Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when dockedCaolán McNamara
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c
2017-01-24add psd fuzzerCaolán McNamara
Change-Id: I8969e9f5020a6c1957b7f326e5dcca52915ddd4f
2017-01-24coverity#1242895 Untrusted value as argumentCaolán McNamara
Change-Id: I1f0d8aee19d2723861aa70f31176db08299cd9b9
2017-01-24coverity#1399021 Unchecked dynamic_castCaolán McNamara
Change-Id: I3befc9be20f8d414ec786f1a94f1f85ce94fb44b
2017-01-24Drop incorrect "artistic" prefix from some token namesTor Lillqvist
Apparently copy/paste mistakes in the 642a252cf1a2f1d08c4bbfcae15527bb82c7664d and 21d4cfe19e2796ebf89c408e292c4473924b2bc4 commits from 2014; most of the picture effect type tokens added in that commit do have names that start with "artistic" but not all. Does not break any unit test. (Does not fix the bug I am investigating either, though.) Change-Id: I2c3bb7243e1feaa3fa949b58d3acf34825d6987b
2017-01-24Probably makes more sense to return DONTKNOW if the element is DONTKNOW ...Tor Lillqvist
... and not the namespace token without any element token ORed in. DONTKNOW is what the two callers look for. Does not break any unit test. (Does not fix the bug I am investigating either, though.) Change-Id: Ibd75ee06797d7b62476d4bf2302338b2bb3266d4
2017-01-24tdf#105382 Set URL-decoded default filename for minimized presentationTakeshi Abe
See mailing-list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076702.html> for a discussion on the original presentation file's URL. Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f Reviewed-on: https://gerrit.libreoffice.org/33261 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-24AccStatisticsObject is apparently dead codeStephan Bergmann
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
2017-01-24manage SvRefBase-subclass by tools::SvRef in ScXMLTableRowCellContextNoel Grandin
ScXMLTableRowCellContext Change-Id: Ia624e971f31cc517f65b6ae15729476cea091d86
2017-01-24just build the hunspell lib, not the restCaolán McNamara
might hack around link failures of the hunspell tools under arm Change-Id: Ib5db702c2898e909e2bb91f4c4bc6b91bd08f47b
2017-01-24teach unusedvariablecheck plugin about SfxPoolItem subclassesNoel Grandin
which can all be treated as SAL_WARN_UNUSED The eehtml.cxx change probably fixes some CJK/CTL bug somewhere Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24loplugin: unnecessary destructor cppcanvas..filterNoel Grandin
Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676 Reviewed-on: https://gerrit.libreoffice.org/33491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24can use memcmp here, for hopefully a little import boostCaolán McNamara
Change-Id: I5084eff570a66cc2596b400cbb83d1eb24889f0b
2017-01-24return earlyCaolán McNamara
Change-Id: Ic95f968bcd7acdde170a1128a512f03f77e334cf
2017-01-24loplugin:useuniqueptrStephan Bergmann
Change-Id: I502ebf4024cd9b0ee61d58d6b6a8e342c7ceac08
2017-01-24Related: tdf#105426 upgrade to hunspell-1.6.0Caolán McNamara
Change-Id: I275222d1a7d78cbfb1ca046562fc8a3c314b0fae Reviewed-on: https://gerrit.libreoffice.org/33454 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-24tdf#104334 DOC import: don't map STYLREF with switches to SwChapterFieldMiklos Vajna
Commit d635b351849b8b576c907abf22500d0fa89ab54f (tdf#99100 DOC import: handle subset of STYLEREF natively, 2016-04-06) started to import the STYLEREF field code as SwChapterField in case it had \[a-z] switches after the field argument. The bugdoc has a \s switch, which is not documented in ISO/IEC 29500-1:2012 17.16.5.59 "STYLEREF", nor is really clear what it would do. The original use-case was for the " STYLEREF 1 \* MERGEFORMAT " syntax, so just keep using fieldmarks for the " STYLEREF <field argument> \[a-z] " case. Change-Id: Ibd094e72be4e179c779a79a75769b599d4d9bba8 Reviewed-on: https://gerrit.libreoffice.org/33489 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-28 07:36:22 +0000