summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-15loplugin:finalclasses in basicNoel Grandin
Change-Id: I3ec4ccb58dc3823eee8b6ab8bda31b128ee24569 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15loplugin:virtualdead HasExtraRedlineTable always returns trueNoel Grandin
Change-Id: Ibc703b4c2adc6c6579cc4be50d274504ba957f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15wina11y: Forward-declare XAccessible in AccObjectWinManager.hxxMichael Weghorn
instead of including the header, as suggested by Mike Kaganski in the Gerrit change for commit 6bf771f0a5ba7be9955f05b307c190fb157adb47 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Sep 9 11:36:57 2021 +0100 wina11y: Use XAccessible* instead of void* Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (The header had actually been included previously, so the above commit had added it to the same header a second time...) Change-Id: Id6a6c5e2426bf07e41f29e1473ec1694970272c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122132 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15gtk4: remove text-button css property on setting a child image widgetCaolán McNamara
I suspect this happens automatically > 4.2.1 Change-Id: I1b752ee5cec00005fe0f552548f38eab40249087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15remove stray track-visited-linksCaolán McNamara
and add truncate-multiline for consistency Change-Id: I5a6fc0f0ac97a0f96739f2383b6d3eb474e776fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15No need to check if nDX is 0 for atan2Mike Kaganski
We rely on IEEE floating-point arithmetic anyway, and then even both arguments equal to 0 do not result in an error. Even if it was different, it would be better to check id both nDX and nDY are 0, and return 0 early. It was so ever since "MWS_SRX644: migrate branch mws_srx644 -> HEAD" commit fd2cf3dc7cd9c73070fa4d70c8ca99c9fc1ce135. Change-Id: I5b8e2a359374dd1500b149d74eba4c0b0e5cd8d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122115 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Fix broken ui fileStephan Bergmann
...after 45c4caff685b15a0f1b87ef05436a7e6aca96851 "tdf#144483 sw mail merge: save ranges in a single document", causing CppunitTest_sw_dialogs_test to fail with > warn:vcl.gtk:2759211:2759211:vcl/unx/gtk3/gtkinst.cxx:21611: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: ~/lo/core/instdir/share/config/soffice.cfg/modules/swriter/ui/mmresultsavedialog.ui:165:49 Invalid property: GtkCheckButton.group Change-Id: Ib846f3cb1883de50c28c13441aaf880ae1a480fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122153 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-15sw: add a DisableBuiltinStyles API settingMiklos Vajna
The built-in Writer styles (e.g. Caption) are written to each & every document to help compatibility: this way if the built-in style changes, existing documents are not changing. While this is a good default, sometimes document conversion workflows want to ensure that no new styles are added to the document during conversion. This new settings allows to opt in for this behavior in case not polluting the doc model is more important than the negative effects of changing built-in styles. Change-Id: I43130a215ee10ee6952724dbef2caab7174ff77f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122154 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-15No need to check for x = 0 in atan2 hereMike Kaganski
The guarantee is that either x or y argument is non-0. It was this way ever since "initial import" commit 8ab086b6cc054501bfbf7ef6fa509c393691e860. Change-Id: I2f5ccbbc9a4f00aafef151ef3dd008eddeef0e78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122114 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 323c851c00559631e9e2ee1098d9aed89ca1d2ff - tdf#133851 connect help page to certificate path dialog Change-Id: I5a96785f32b81c6a8dd347b5665e1f5d0c7b84b2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122152 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-15Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to d599028d4f126c8a2badc3787e3fdf8277219c96 - Improve another frankly inaccurate statement… ... and fix a couple of typos done in core commit 5e86949c479af5ef443f77b978fcb2b9021de848 Change-Id: Ie7ed9da3a3858434ae9ff086d61587c8ffdcd02b
2021-09-15CppunitTest_sw_core_text needs some more RTTI now in UBSan buildsStephan Bergmann
...presumably since 0c3e47cc2f0570a7cd8ff4889763991a86b29f26 "tdf#144305 sw: fix rendering of ruby portions with non-default ruby alignment", > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI13SwLinePortion" and > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI14SwMultiPortion" Change-Id: Iaebffc3c9c0245d6092ef1dfc58213fd2d38d303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122143 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-15Resolves: tdf#143487 don't draw a border at all for DrawFrameStyle::NONECaolán McNamara
Change-Id: I7794376c9475a32276d23135365c99a3f6fb7d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Fix some assorted mistakes in translatable stringsAdolfo Jayme Barrientos
Thanks Mihail Balabanov, Olivier Hallot and Tuomas Hietala for your keen eyes. Change-Id: Ibceeae6d82e39079c02140ac99729be1a1ab0407
2021-09-15default Aliasing of secondary mpAlphaVDev to the same as its ownerCaolán McNamara
when its created, as noted in... commit e1a5bcb20e15400320f926165b6d798fa36c564e Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Sep 14 20:30:58 2021 +0100 tdf#143831 fix black background appearing on spellchecking wavy lines ... OutputDevice::SetAntialiasing only mirrors its arg to the secondary mpAlphaVDev if it exists, and it doesn't exist until the size is set so move that call down a bit (this is probably another preexisting bug maybe worth following up on to set that when mpAlphaVDev is created) Change-Id: I8ef27aae4dcabe529327224bfc6cd7b4bb2a5af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15loplugin:unusedfieldsNoel Grandin
m_pSoftMaskStream is dead since commit 581e7d7057afa87036d84e42c0e0a8a7368e20c7 Author: Joseph Powers <jpowers27@cox.net> Date: Thu Sep 1 20:51:15 2011 -0700 unusedcode.easy: PDFWriter cleanup Change-Id: If397981fb09a7b74ba2294513c13186cc51ad5fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15gtk4: allow combobox text width to shrink smaller than natural requestCaolán McNamara
Change-Id: I9648097ca9f77494ec4ddb2662dbc0372b998cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ia7617a0fd4413cbaafaae8fbfee2b2ea819fde8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ebe05a0be7226d4e35ed1cf96e60aaa2703234eb - extra bookmark in help Change-Id: I0f78b497a2f8921b75a73570e2799948997b48a3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122113 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-09-15loplugin:constvarsNoel Grandin
Change-Id: I9b35d6333afa6b305bf73fc55a7e60c8365674e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-15ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5ae6f55789eebdc688ead4524a7af7a7739314bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Uninitialized data memberStephan Bergmann
...introduced in d467cd0dd9e9cf3b018859a592e2638527bc7add "tdf#135683 speedup DocumentRedlineManager::GetRedlinePos", causing isssues like > [_RUN_____] SwDocTest::testFileNameFields > /sw/inc/docary.hxx:238:50: runtime error: load of value 190, which is not a valid value for type 'bool' > #0 0x2b89dcc7897e in SwRedlineTable::HasOverlappingElements() const /sw/inc/docary.hxx:238:50 > #1 0x2b89dcc40efc in sw::DocumentRedlineManager::GetRedlinePos(SwNode const&, RedlineType) const /sw/source/core/doc/DocumentRedlineManager.cxx:2624:25 > #2 0x2b89df2a4e8c in SwScriptInfo::selectRedLineDeleted(SwTextNode const&, MultiSelection&, bool) /sw/source/core/text/porlay.cxx:2653:44 > #3 0x2b89df285fbe in SwScriptInfo::CalcHiddenRanges(SwTextNode const&, MultiSelection&, std::__debug::vector<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind>, std::allocator<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind> > >*) /sw/source/core/text/porlay.cxx:2687:5 > #4 0x2b89df29359b in SwScriptInfo::GetBoundsOfHiddenRange(SwTextNode const&, int, int&, int&, std::__debug::vector<int, std::allocator<int> >*) /sw/source/core/text/porlay.cxx:1917:9 > #5 0x2b89dfa1c1e6 in SwTextNode::CalcHiddenCharFlags() const /sw/source/core/txtnode/ndtxt.cxx:4522:5 [...] during CppunitTest_sw_uwriter at <https://ci.libreoffice.org/job/lo_ubsan/2135/> Change-Id: I42c8801f83d2e92a826864494b1f0f4c63f30f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122109 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-09-15Related: tdf#143831 the svp aliased case ends up overly washed outCaolán McNamara
as seen under gtk3 Change-Id: I0bcea49f8c24e9f773b357483cea78e58bb07e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Related: tdf#143831 add guards to ImplDrawWaveLineBezierCaolán McNamara
seeing as the mpAlphaVDev ImplDrawWaveLineBezier sub call is not protected otherwise now that it can be called from the outer case Change-Id: I66f0fea134aa177bd7493720670c4724311752a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122098 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15tdf#143831 fix black background appearing on spellchecking wavy linesCaolán McNamara
SetBackground() doesn't fill the outputdevice automatically, Erase() has to be called to do that. Then the way the horrible transparency split 24bit rgb + 8bit alpha thing works is that the same thing has to be drawn into the 24bit surface and the 8bit surface with black used as the line/fill color in the 8bit surface. OutputDevice::SetAntialiasing only mirrors its arg to the secondary mpAlphaVDev if it exists, and it doesn't exist until the size is set so move that call down a bit (this is probably another preexisting bug maybe worth following up on to set that when mpAlphaVDev is created) Change-Id: I39f71def6b51d78746b41ed2e30a36dc150370bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15Save with Glade 3.38Samuel Mehrbrodt
Change-Id: Ib32cd43d83828b6f28fc193fd77a9def742e0384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122088 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-09-15sw layout xml dump: show SwParaPortionMiklos Vajna
Towards showing details of multi-portions. Change-Id: I3afb84731ae716557279d6253347c57fada710af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122094 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b8e1cd0bed6eb458e028a251408d97895e419c67 - typo Change-Id: I906462045e1fbeb6daa4dafbdeb6d7e2ac444dd8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122070 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 5Mike Kaganski
- Revise uses of getSomething to use getFromUnoTunnel Where that is impossible, use getSomething_cast to unify casting, and minimize number of places doing low-level transformations. The change keeps the existing tunnel references that last for the duration of the pointers' life, because sometimes destroying such reference may destroy the pointed object, and result in use after free. Change-Id: I291c33223582c34cd2c763aa8aacf0ae899ca4c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122101 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4Mike Kaganski
- Change implementations of getSomething to use getSomethingImpl Or where that's impossible, use getSomething_cast to unify this and reduce number of places where we reinterpret_cast. All static methods getting tunnel ids were renamed to getUnoTunnelId, to comply with the convention used in <comphelper/servicehelper.hxx>. TODO (in separate commits): - Revise uses of getSomething to use getFromUnoTunnel Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]Mike Kaganski
- Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> OImplementationId uses broken double checked locking; additionally, it uses it at the first call to getImplementationId, not when the object is constructed. This implementation can't be changed, cince it's part of published API; it can't rely on C++11, which would be required for use of thread-safe statics and move the initialization to ctor. The class has obsolete _bUseEthernetAddress member, that is unused and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need to implement it when replacing its uses to UnoIdInit. The deprecation is the API CHANGE. No published API is introduced to replace it; 3rd-party code should seek alternative solutions, or just keep using the deprecated functionality. TODO (in separate commits): - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 2Mike Kaganski
Replace uses of sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation with respective comphelper::getSomethingImpl and comphelper::getFromUnoTunnel. Drop the former from sw/inc/unobaseclass.hxx. TODO (in separate commits): - Replace all uses of OImplementationId in core with UnoTunnelIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: I1e350a88260277a67b833af56b285ac2277f433a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122075 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-15Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1Mike Kaganski
The header got some changes: 1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace 2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace of uses of OImplementationId with it, including in XTypeProvider 3. Introduce convenience functions 'getSomething_cast' to cast between sal_Int64 and object pointers uniformly. 4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make it a bit shorter, and to reflect its function better. Templatize it to take also css::uno::Any for convenience. 5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it handle cases both with and without fallback to parent. 6. Adjust UNO3_GETIMPLEMENTATION_* macros TODO (in separate commits): - Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation - Replace all uses of OImplementationId in core with UnoIdInit - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx> - Change implementations of getSomething to use getSomethingImpl - Revise uses of getSomething to use getFromUnoTunnel Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-14Untabify odk/util/check.plStephan Bergmann
(trying to change the actual content of those lines would otherwise trigger our "indent with Tab" git commit hook) Change-Id: I97449056eb7850d3993fa5ac565e342d0bcbf200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122093 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14tdf#135683 speedup DocumentRedlineManager::GetRedlinePosNoel Grandin
use binary search Change-Id: Icd442ba18cb27cdcb5955fa8bbce421b26d5ad44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121205 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-14Drop some useless conversions to sal_Int32Stephan Bergmann
These started out as sal::static_int_cast<xub_StrLen> in 1b9a6329fcda25fd738bd0e0a36663a6e745cab8 "INTEGRATION: CWS calcwarnings", presumably to silence some signed-to-unsigned conversion warnings, then morphed into the completely useless sal::static_int_cast<sal_Int32> with the String -> OUString changes (where the length parameter changed from unsigned xub_StrLen to signed sal_Int32), which then started to hide erroneous overflow (see e.g. 4a4be7a1edead11b48e1a8598e52a3246e6744bb "tdf#144106 Don't proceed ptrim_i past ptrim_f") from tools like -fsanitize=implicit-integer-sign-change with the OUString -> std::u16string_view changes (where the length parameter changed from signed sal_Int32 to unsigned std::size_t). If there were demand to prevent signed-to-unsigned conversion warnings here, that should be done with o3tl::make_unsigned instead. Change-Id: I9b078658500b6ed5dcd0e860d2f0b725133188f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122092 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d098ee2b7fba8b173fd718490c8e537c13d936b0 - fix path of embed Change-Id: I99168be951490a532ca7cc0ab2be906584bd7290 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122068 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-14tdf#144483 sw mail merge: save ranges in a single documentBalazs Varga
In the Save mail merged document dialog, it wasn't possible to save mail ranges in a single document, because of the bad UI of the dialog window: grouping range selector as a radio button with the single document/individual documents radio buttons. Moreover, commit f3993912ec4b526aa57cb4bfb4745d7298a4da82 "tdf#144427 sw mailmerge: fix merge all document" removed the hidden workaround: setting range at the third radio button, and selecting the first radio button. Using checkbox for the third option solved the problem as proposed. Change-Id: I43798fb036de07d1001bcb8d72c20de2d9c577b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122078 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-14sw: fix undo manager de-registration from editeng on shutdownMiklos Vajna
editeng/ asserts in the ImpEditEngine dtor that the undo manager it owns is indeed an EditUndoManager, and not a subclass. This means that if a subclass is set as the undo manager of editeng, then SetUndoManager() should be called in pairs: once to set it and once to unset it. The unset should happen before destroying the EditEngine. This normally works because SwView either has an active text edit and then its dtor calls SdrEndTextEdit() or it doesn't have an active text edit. The broken case was when the text edit was already ended, but the draw view still had a text edit outliner, which has an EditEngine, which knows the sw undo manager. The product build deleted the sw undo manager when deleting the EditEngine, and then later when the SwExtTextInput dtor wanted to access the sw undo manager, it crashes due to use-after-free. Fix the problem by explicitly disposing the undo manager of the draw view in the dtor of SwView. Also fix a couple of more places where an SdrObject* is returned and we didn't check if the result is a nullptr. Caught by the loolstress tool in online.git: cp test/data/hello-world.odt /tmp/test.odt ./loolstress ws://localhost:9980 /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-mash-text-table.txt /tmp/test.odt test/traces/writer-mash-text-table.txt Change-Id: Ib838b2adf900b4f3bec63d2d62d432327bc0c6c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122086 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-14wina11y: Use XAccessible* instead of void*Michael Weghorn
Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-14tdf#141704 PPTX import: fix hyperlinks on imagesTibor Nagy
Hyperlinks on images pointing to the "first/last/ previous/next" slides and "exit presentation/go to the website/go to the slide" weren't imported. Note: images added via the Content placeholder will be fixed later. Change-Id: Idda1ff6fd3243b06262637c7c8e579e78309e317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121369 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b7491d7d5cd174d4100c3de5f46cff20d7840809 - typo Change-Id: I1b26b14b3fdcf47351601ce5ea7bbdbadb65d887 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122067 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-14Adapt to Bison 3.8 internal yyn -> yyrule renameStephan Bergmann
see <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=f30067ed51f23802fc91761ede1506dfa72b2865> "glr2.cc: log the execution of deferred actions" including "Rename argument yyn as yyrule for clarity." YYBISON was defined as 1 rather than as a representation of the Bison version prior to <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=21c147b6e5372563b7c4741deadaddb9354f4b09> "yacc.c: provide the Bison version as an integral macro", which shouldn't be a problem here. And YYBISON is apparently completely undefined with /usr/bin/bison on macOS. (The preceding comment always mentioned "yyi" and "yyrmap" in apparent mismatch with the actually used "yyn" and "yyr1" ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it untouched.) Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-14ofz: Null-dereference READCaolán McNamara
Change-Id: I4f6d93943bd0c9e5834952b56beb6bd84411a55d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib3afba47155bc70f579284244514d745f1075f7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14tdf#143854: Revert "tdf#57585 Add new bullet behaviour to impress"Xisco Fauli
This reverts commit 070a5b039b181c380b1b9724a015314ff78c30ed. Reason for revert: Many PPT files are affected when saved to ODP. I waited a while before reverting it but not reaction from the developer Change-Id: Ibfd2f508930e1a3ef56961536454ea1eda55f8c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122061 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-14tdf#144057 sw track changes: hide deleted table rowsLászló Németh
and tables in Hide Changes mode. Previously it was possible to "hide" them only by accepting all the deletions, because Hide Changes mode hid only the cell content, but not the deleted rows and tables, leaving empty rows and tables in the document. Follow-up of commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Change-Id: Ib0424f5a17f2213fc7466e966d8ce6812ffde5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122079 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-14ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5906dc1f9f0295d406c01871e5fed1da0025682f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-14configure: test_curl is always "yes"Michael Stahl
Presumably this should check enable_curl instead. Change-Id: Ifc0b871e9c34bdb43ef14b8002d4997860266a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122040 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-14tdf#42982: improve UNO API error reporting4k5h1t
Change-Id: I1252c89f23e70eb88744585bb2abd4fe3794e1d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121918 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-02 05:44:25 +0000