summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-26ValueSet doesn't use WB_NOPOINTERFOCUS anymoreCaolán McNamara
Change-Id: I5d1b1240518aa97d229d56545e353259d226f1e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26let focus enter calc sheet bg color dialog's valueset on clickCaolán McNamara
Change-Id: I884c8209e6b26e6c99654c4126ba81cf7e46c69f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124236 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26Related: tdf#145296 use last spacing value as default for customCaolán McNamara
so its not always 100% in the custom value dialog, but whatever is the current spacing value Change-Id: I7a2690b2a38d2c49652830ad65d5dcf7bc80ba90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124171 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26grab focus if clicked on anywhere, not just on a specific valueCaolán McNamara
Change-Id: I03b47080707c469d49e6cd9148573522d7f79da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124232 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26don't do any work if we'll ignore it afterwardsCaolán McNamara
Change-Id: Id8a8dbeb2164e291324ddcb2409c0d7f05d5774a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26use boost flat_map for faster mapLuboš Luňák
setUpdatedTypePerViewId() gets called so often that even unordered_map lookup and allocations show up in profiling. It seems that flat_map can do better. Change-Id: Id2e4f0c40d6973b51e557f84a08bf12feb58b3ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124210 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-26tdf#144513 improve perf when breaking long linesNoel Grandin
use the clip rectangle to stop early when the text exceeds the height of the cell Change-Id: I63dadc5b63c1f6c0852e0ba86a58f18c2b207cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124221 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to c94585cd933b70a844719985ea63f70928e6d365 - Add example to help description of Calc's SERIESSUM function. Change-Id: Ie3c95990e2ec75d439405d8fb79d9fde8d852bdd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124192 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-26there is no WB_RADIOSEL anymoreCaolán McNamara
Change-Id: I6b6573c8d9ad09a7087ddbb5fb673265c6af456b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#131025 swtable: don't apply number format to non-number textJustin Luth
Applying a numbering style to text causes export to save that out as a number (valued as zero). That is not good because the ODF spec says that a number overrides a string. So don't accept a numbering format on non-number text. Why is this change good? -the cell previously had no direct formatting (by definition). -the cell's previous old format was text (tested). -any numbering format applied obviously isn't correct (by definition). -any previous formatting has already been overwritten with numformat. -the default numbering is appropriate for text. -empty cells still get the numbering format (tested). -odd human-designed formats are accepted as intentional (tested). What are the concerns? -the scope of this change is HUGE, way beyond this bug. -on both my dev box and patch box I saw occassional crashes. -the bug was "fixed" by a different import commit that ensured different languages were treated consistently. So this patch is no longer critical, just nice to have to avoid exporting out-of-spec content. Change-Id: Id3dc5f803c3cf4875bc0cab52d1019a18679da77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123904 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-10-26Using .md extension for vcl README filesHossein
* Renaming all README files inside 'vcl' to use .md extension * The content was previously converted into Markdown format in dc984e7fed26ed26a2cafecb0c5b27feca56bfe2 Change-Id: If55d363b418ff14864297d02a6986c4fc3625ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113531 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-26Update emfio documentationHossein
* Added information about dumping metaactions using mtfdemo * 'sax' dependency was removed in d49900e5a3aae75a4c673f593e99fbc296f67cee * Listing indirect dependencies from 'emfio/Library_emfio.mk' Change-Id: I5ee7e20c872aff388424930a23c9a17614b5e3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124180 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-26gtk4: get correct rectangle for custom renderer areaCaolán McNamara
Change-Id: Ic7a1bd818a308f5caff5923ff30a0741ffec7f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124177 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26Use LO repo for mkdocs git linksHossein
* Use git.libreoffice.org instead of cgit.freedesktop.org for the git links generated by mkdocs scripts Change-Id: Iac6e9ea1b73dcd0155786798c0ec162865299ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124186 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-26Add documentation for the 'svgio' moduleHossein
The module 'svgio' is used to read SVG. This is the list of topics discussed in the documentation: * Introduction * How does it work? * Known Bugs * Dependencies * Related Software * References Change-Id: If42e9c2e10145c12cd5d74019b36bc5d78dd5bb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124178 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-26tdf#145225 sw track changes: fix bad insert at movingLászló Németh
Moving up a list item over a tracked paragraph insertion changed non-tracked text to tracked insertion. Manual test: - Create a 3-element list; - switch on Record Changes and Show Changes; - at the end of the list item 2, press Enter to insert a new list item, and type some text: Item 1 Item 2[ New item] Item 3 where parenthesis shows the boundaries of the tracked insertion; - move up the last list item over list item 2 (the unmodified paragraph text with a tracked paragraph insertion at the end). Paragraph text before the tracked paragraph insertion changed to tracked insertion joining its tracked insertion with the moved list item, resulting only 2 tracked changes: Item 1 [Item 3 Item 2 New item] [Item 3] instead of the requested 3 changes: Item 1 [Item 3] Item 2[ New item] [Item 3] Change-Id: I4716b2d244b57cf86d7d14d972452191549f5fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124144 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-26uitest: rearrange tests to avoid "close_doc: no active frame"Xisco Fauli
Change-Id: I92bf81801797821c9ec4aa73c005f1d6c6f6da62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124182 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26-Wunused-but-set-variableNoel Grandin
sw/source/uibase/uiview/viewsrch.cxx:97:13: error: variable 'textSelection' set but not used Change-Id: I67a37e9440343a34147dd5be82cfc3dfb1282419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 18465d2e19be235388020137629ab3ed67f103fb - Fix typos Change-Id: I1186621eb7159896828a0fa33e12f58dd4acf598 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124207 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-10-26gtk4: some fonts have pango_font_description_get_size_is_absoluteCaolán McNamara
and are too large, convert back to points Change-Id: I34aafb0a0678397c1c3c5780d67bdcea405a3866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#136715 sw: fix table Undo to update table styleBalazs Santha
Applying table styles works by applying direct formatting on the table. Some of the built-in table styles, like "Box List Red" specifies boldness for the last row of the table. After selecting and deleting the last n rows of a table, which has a table style which specifies formatting for the last row, the new last row gets these formatting as expected. However before the fix, after undoing the deletion of the rows, this formatting were still applied on that row which previously became the last row. Change-Id: I3ad086dd9b5e4111b3f019ca3d23f1db8b348637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123730 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-26tdf#144374 DOCX: export the password for editingTünde Tóth
The password for editing wasn't exported in DOCX, resulting unprotected documents in Writer and in MSO 2019 or newer. Change-Id: Ieb8a339795635bc1c4223ccbe2a40ea85222cc2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123543 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-26tdf#141908 - CppUnittests: replace usage of sal_Int32 with color4k5h1t
Change-Id: Iaff808a86a8b3ea8f760402faded81d8b8081ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121316 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26tdf#145129 XLSX import: round down default row heightAttila Szűcs
like table layout of MSO does, e.g. 20 pt to 19.5 pt. Same as tdf#144642, but with default row height. Follow-up to commit 537cb82be8fa021fd9382cca874645c75daaef20 "tdf#144642 XLSX import: round down row height to 0.75 pt". Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iefb615b56e5ddc11a5e839cf6d90516b18646045 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123655 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-26Update git submodulesMartin Srebotnjak
* Update translations from branch 'master' to 569442292afe8da0847d542276cdddea3d1728a1 - Update Slovenian translation (xml tag fixes) Change-Id: I351bd95533d1b9e2e4b369c3edb1aa34140997c8
2021-10-26flatten ImplGetTextLinesNoel Grandin
Change-Id: Iefbbcb186b2811748abf49546351a2c68e8af462 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124155 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26Related: tdf#145296 we have spacing images we can reuse hereCaolán McNamara
Change-Id: Id511f8b272f1b1460f9c6c6d5c2ed835780ee806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#145296 use a 'clickable' widget for custom spacingCaolán McNamara
Change-Id: I7c0b609a074a68dcc7ca4f6a775743e836a6caa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#145296 use a 'clickable' widget for custom depthCaolán McNamara
Change-Id: Ifb64e1bef2a0b216f97fe112115a997973201268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26ofz#1493240 Unchecked return valueCaolán McNamara
Change-Id: I17ffbd28d56513ed7b39c29f74598c7517f44190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26tdf#142010 XLS import: fix bad calculation after editingLászló Németh
Inserting a column messed up formulas in the test document of tdf#142010. This was a regression resulted by the tdf#89281 fix for a performance regression in XLS import related to shared formulas. Revert of commit ba686b9bd2596811141e4028947334f10799c356 "tdf#89281 fix performance regression of XLS import - cleanup" and commit b18b5b7edf3d14ef5f0efe53e367f88a423088c4 "tdf#89281 fix performance regression of XLS import". Change-Id: I96636fb1d84939385efbe7054a4271ff10b88907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124151 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-26Revert "tdf#57308 - Basic IDE: Watching of a variable does not work"Andreas Heinisch
This reverts commit f9ce4b2d04b58843d7986acd9382864b0b30d617. Reason for revert: Cast to SbxVsriable instead of SbxMethod causes the code to start over Change-Id: I8f00f8f13faef8cb8c6db4e8c2a096a921f8714b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124187 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-10-26Make sure that self-assign test checks typesMike Kaganski
This may be important with static empty sequence cppu::g_emptySeq, that is common for sequences of different types. The changes in sd/qa/unit/data/xml/*.xml fix places where anys with empty Sequence<OUString> used to wrongly take 'if(aAny >>= aPropSeq)' branch in dumpPropertyValueAsElement (drawinglayer/source/dumper/XShapeDumper.cxx). Change-Id: I5b0544ca94b30437c01dd46f376408f91510bcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-25resave with latest gladeCaolán McNamara
to normalize the property names and grid row/col comments. Taking care not to lose the non-standard explicitly empty labels for the GtkMenuButtons Change-Id: I015560f8b7eaa814e0540fbfbff9cfcb920b44b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25Resolves: tdf#145297 assert on Docking3DEffects launchCaolán McNamara
(git show -w is your friend on commits like this) Change-Id: Ie3a11986f98d196b6134fdc69e76a627e87d137b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25tdf#138531: sw: Add UItestXisco Fauli
Change-Id: I953948a5d10e8fbb6610ea0bf49ae7e8308e83eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124157 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-25bsd (as used by macOS) ar does not support '@' optionCaolán McNamara
so gb_LinkTarget__command_staticlink should use the same workaround for that as gb_LinkTarget__command_dynamiclink does Change-Id: Ied9d8a3b99f09d6ea1b705e0c1ce3ef3b2d14190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25ofz#40305 Divide-by-zeroCaolán McNamara
Change-Id: Ib865d880d51d5beef1f235e4a8d5d0c17adf8499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25use pull model also for LOK text selectionLuboš Luňák
Make LOK_CALLBACK_TEXT_SELECTION, LOK_CALLBACK_TEXT_SELECTION_START, LOK_CALLBACK_TEXT_SELECTION_END and LOK_CALLBACK_TEXT_VIEW_SELECTION also use pull model, i.e. LO core will only set a flag and when CallbackFlushHandler needs the actual data it'll use getLOKPayload(). This again avoids a large number of messages passed to CallbackFlushHandler only for them to be sooner or later discarded. Change-Id: Ia7528039be996a6e9e8491b4eba3f4133582fa56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124146 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 56638af603a79cd9330752fab99a7769ace9ffaa - tdf#140779, tdf#140780 filter params for CSV, lotus... Change-Id: Ie439889bd8dc4bd630187e253d3689c8e644b2a7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123901 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-25Fix toolbar button's currency list's number format for default localeEike Rathke
Always resulted in the currency's LCID being omitted in the number format for the default locale, which doesn't immediately harm but loses the context (what currency a $ sign is actually), and also lead to the "real" default currency format never matching the one being generated for the list so no entry was selected if that format was applied. Change-Id: I7963e4d3701092d6e227705fc0e8282448f075b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124152 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-25uitest: execute setActiveFrame in load_file firstXisco Fauli
In 4839b7ca3b5a730edf90ebebc749db145efec098 < Fix UITests that use File Open dialog to load documents > the order of execution of load_file method was changed, making the code after the yield keyword to be executed after the test code is run, which is not what the original code did. We need to execute that code before running the test code, specially setActiveFrame Change-Id: I4ba436cbdf4fe2261589527f8d38a916d47b94aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124154 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-25replace friend access with functionsLuboš Luňák
Change-Id: I11cb916285c72f7cd85ea5d5c943f23d0a4f6bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124148 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-25loplugin:indentation (macOS)Stephan Bergmann
Change-Id: I7a180a79dff11816e1504bdd1803102325aa365d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124149 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-25Restore behaviour SvNumberFormatterServiceObj keep LANGUAGE_SYSTEM unresolvedEike Rathke
Semantics were temporarily changed with commit bba6a4ed92a0feb288a9dedd648d623bee02a3ce CommitDate: Mon Oct 25 11:18:31 2021 +0200 Get rid of fuzziness in MsLangId::Conversion::convertIsoNamesToLanguage() Change-Id: I8bbf77998bea81c5691ba518c7ae25093b0df421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124141 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-25Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 41974fc7ebdc4d8d6d8d017a6e68753fd5a049e3 - update translations for master and force-fix errors using pocheck Change-Id: Ic6888555f22c4e961c0734fa685969b43f89c02e
2021-10-25tdf#145312 xmlsecurity: prevent from crash when cannot receive pdfium annotationSzymon Kłos
Change-Id: I6adc2cb0a07eb08a50c610958983493f4f8031ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124021 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-10-25uitest: fix indentXisco Fauli
Change-Id: I7034ab2b7933f248a0d6929bd11497ff3098dd3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124138 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-25tdf#57308 - Basic IDE: Watching of a variable does not workAndreas Heinisch
Watching a variable which returns a value from a function always shows "out of scope" in the watch window of the Basic IDE. In order to resolve this issue, the name of the variable being watched will be searched also in the current method instance. Change-Id: Id383e03925956056931d199fe86d1b352cf8e4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124075 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-10-25Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to cae1ccb6137d03cada0e187756e9197a897ba94b - tdf#131563 VBA color constants - VBA color constants addition - Aggregation of spreaded constant definitions in this page Change-Id: I5f4045256e5e03c6b11247c9bb0442e9e63d738d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124013 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-29 17:25:23 +0000