summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-02-28Remove compilerplugins/clang/test/cppunitassertequals.hxxStephan Bergmann
...which isn't needed anymore to suppress warnings from other plugins like loplugin:external ever since 45c06838e95c94445359536d84c6328fa8b17a66 "only unit-test one loplugin at a time". Also, the declaration of the function test in cppunitassertequals.hxx had already started to deviate from its definition in cppunitassertequals.cxx. Change-Id: I3fbc8a9a805bd5bc4d8afbf958edff04b89add3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148010 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-28tdf#143311 writerfilter: import decorative flag on as-char flys tooMichael Stahl
Change-Id: I9704d35a8286b92169dffd8de7e57e286884f607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148016 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28tdf#114773: only add space between entry number and textMike Kaganski
Modify the hack from commit ce95e39f8e952159844e9dc04a1df402bb103634 (tdf#44282 fix missing space for numbered lists in TOC, 2016-08-16), which added the space after entry numbers unconditionally. There are other possibilities, like custom separators between the entry number and text (e.g., [E#][T][E][T][#]); or the entry number (maybe with limited depth) used with page number (like in [E#][E][T][E#]-[#]). Generally, when entry number is not immediately followed by entry text, the space is not needed. Additionally, the space is not needed when the number text already ends with a space character. Change-Id: Ifa6c474574bfb74466ab721eca49f421a3750942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147997 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-28no need to allocate XMLTextColumnsArray_Impl separatelyNoel Grandin
an empty vector is only 2 words big Change-Id: I3e4a9d42b9ecb44c57ce11c400a17a4c8b053eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28no need to allocate tabstops vector separatelyNoel Grandin
an empty vector is only 2 words big Change-Id: Ib8309d0819c88fe6a4f7cd322c37dd52190bd060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28Fix iOS build breakagePatrick Luby
There were a few remaining DeviceFormat::DEFAULTS in remaining in IOS blocks after commit 00659bcdbbb167596e6fd18e283a54819dd6fe91 Change-Id: I29e1f2bd6d4ce20dea7a45ce17bc6f3b929859c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148008 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-02-28add ipv6 enabled maven repositoryChristian Lohmaier
maven central so far doesn't support ipv6 on the primary URL (see https://issues.sonatype.org/browse/MVNCENTRAL-658 ), it is only enabled on a dedicated ipv6.repo1.maven.org URL currently. Add that one to the list of repositories so that ipv6-only hosts can also fetch the dependencies. (when using internal ipv4 as well, you'll also need to export JAVA_OPTS="-Djava.net.preferIPv6Addresses=true" since otherwise the gradle wrapper fails to download gradle) Change-Id: I22f0e07fd4e6bb518396f76db20c174e45588372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147917 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-02-28sw: RTF export: fix assert on fdo37077-1.rtfMichael Stahl
soffice.bin: /home/ms/lo/master/svl/source/items/itempool.cxx:822: const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const: Assertion `!"unknown which - don't ask me for defaults"' failed. Because editeng doesnt have RES_MARGIN_TEXTLEFT yet and it's mapped to a slot id so the dialog works... Looks like this TABS_RELATIVE_TO_INDENT doesn't exist in editeng anyway. (regression from commit db115bec9254417ef7a3faf687478fe5424ab378) Change-Id: I64169a4d6f4663adaa2a17786836c2dcc7e1f394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148006 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28Fix typo in XComponent doc: "there" -> "their"Michael Weghorn
Change-Id: I1e7be83bffc17d6887ecb9ac43afe82aae6d661e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147973 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-28Fix typoAndrea Gelmini
Change-Id: I1c66185917844bb9b5ee2478a8bae90bb292408d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-28tdf#153681 RTF export: fix extra cell regression at nested tablesCzeber László Ádám
Table rows exported with an extra empty cell, if there was a nested table in them (and not in the last cell). Partial revert of commit 1f77a5e8d5bf8a7f1b7bd7206996d2b2efc59462 "n#203704 fix RTF export table output for subtables". Note: the partially reverted code was for the old table format (used before OOo 2.3). This old format is partially converted to the new table format since commit e366c928819c44b5c253c45dca6dae40b71c9808 "sw: ODF import: convert the simplest sub-tables to rowspan tables". Change-Id: I63ebefbb99e1a95cd60ce8d8dc34c307573d4b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147887 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-02-28tdf#143148 Use pragma once instead of include guardsniket1322git
Change-Id: I0f531280f4d85de3eae6de36bfba975e96d8e7fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147661 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-02-28no need to allocate SfxDdeDocTopics_Impl separatelyNoel Grandin
it is just a vector, only 2 words big Change-Id: I88ca1befea1fc3dba05f7628e4319aedb3250751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28no need for pimpl in TableNameNoel Grandin
Change-Id: I23ec068c5e4297a3e7451ccaa2e43ae5572f9050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28upgrade to libjpeg-turbo 2.1.5Caolán McNamara
Change-Id: Ia6355beaf19765e6255f9388d60e2179206ddc5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-28Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/0b06d2638bf0a1f1707229e7b15e73fbe4c96537> "Update gvfs to the current master" Change-Id: I23cbf8aec7771eda59f66733bcde6cdbed3d0ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147994 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-28tdf#153874 writerfilter: fix anchoring of decorative shapesMichael Stahl
Turns out as-char flys can be decorative too. The confusing GraphicImport takes a GraphicImportType by value but everything else is a reference to a DomainMapper_Impl member. The latter appears to work better so handle GraphicImportType the same way and remove the function parameter. (regression from commit 31084ebb59093be7dfe5ab53a20fdb3bcfde34b6) Change-Id: I18c1d47d39751e8ddcaa52498077d89c43a934e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147998 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28tdf#114287 xmloff: ODF import: fix text:list override of list styleMichael Stahl
The problem is that the list element applies a list style, which should override the list style that's set in the common style "myStyleWithNumbering" of the paragraph, but these happend to be the same list styles and so the override was skipped, resulting in bad text formatting. <text:list xml:id="list3425910577850" text:continue-numbering="true" text:style-name="Numbering_20_123"> The same problem exists if the list-item element has a style-override. This is similar to bug i#101349 which fixed it for an automatic paragraph style applying the same list style as its parent style. Change-Id: Idc6f10f93976de7e7bdceccbe3012c4157f61ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147930 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-28ScriptForge (SFWidgets) new Toolbar and ToolbarButton servicesJean-Pierre Ledure
Each component has its own set of toolbars, depending on the component type (Calc, Writer, Basic IDE, ...). In the context of the actual class, a toolbar is presumed defined statically: - either by the application - or by a customization done by the user. The definition of a toolbar can be stored in the application configuration files or in the current document. Changes made by scripts to toolbars stored in the application are persistent. They are valid for all documents of the same type. Note that the menubar and the statusbar are not considered toolbars in this context. A toolbar consists in a series of graphical controls to trigger actions. The "Toolbar" service gives access to the "ToolbarButton" service to manage the individual buttons belonging to the toolbar. The "Toolbar" service is triggered from next services: Document, Calc, Writer, Base, FormDocument and Datasheet. All those components might host toolbars. Proposed properties in the Toolbar service: BuiltIn Docked HasGlobalScope Name ResourceURL Visible (r/w) XUIElement Proposed method: ToolbarButtons() Proposed properties in the ToolbarButton service: Caption Height Index OnClick (r/w) Parent TipText (r/w) Visible (r/w) X Y (The Height, Width, X, Y properties allow for easy hook of a popup menu to tye button) Proposed method: Execute() Both services are available both from Basic and Python user scripts. An update of the dcumentation help is required. Change-Id: I43cb523b52e3d6362994557d74c4ef9faa220507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147925 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-02-28tdf#153848 Update Sukapura icons in Start Center to match new brandingRizal Muttaqin
Change-Id: I6be2739b551f1dd26265a26d4476658e5a85b3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147965 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-02-28tdf#146168 tdf#150613 list attributes: limit hack to RTFJustin Luth
This fixes an ODT regression from LO 7.2's commit 0a32371cc2f93fad7954e0fe9c48976aae6c5b9f. The hack applies the last character formatting in the paragraph to the numbering characters. This was a hack that existed for DOC and DOCX and RTF in various troublesome modes for quite a while. However, recently since 6.4ish era there have been some improvements for DOC and DOCX, so these have been excluded and now only RTF remains. Most of the time an RTF file also looks like a DOC (from a compat settings point of view), so even RTF files usually don't have this clause apply. In fact, I looked for the RTF files that this hack still applies to, but couldn't find a single example. Really? Did something change? I also looked for examples of files I will be excluding (!isOnlyRTF) and only found tdf135973.odt and tdf146955.odt. Neither one has character formatting on their numbered lists, so they can't be used effectively for a unit test. It is somewhat pointless to make a test. I don't even think we can round-trip an RTF that has these characteristics. Likely the best thing is to just drop the hack altogether, especially since it would pass the unit tests now. (I'm sure it was failing before.) If we can't round-trip it, is there any point in having this non-import hack in place? Change-Id: I2f95c10e1d0a9dc53b01027e9c97e5ded29c6750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147939 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-02-28CppunitTest_chart2_export3: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I8f0017eccadf2ca5ea57ea3c1f8bea357b0c05f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147961 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-28CppunitTest_sw_uiwriter*: use uno commands for copy/cut/pasteXisco Fauli
In order to unify the code and to make sure Scheduler::ProcessEventsToIdle() is always called afterwards See 9027920783dd04db925c41b559abe6442cedf39e "improve reliability of CppunitTest_sw_uiwriter3 something in the paste stuff seems to need UI events to be processed" Initially, these uno commands were replaced in 9d08a0cea018226ce155104d8df146dc2a412aac "avoid uno:Paste in tests clipboard is a shared resource (except for svp) so interleaved tests are not guaranteed to get out what they put in" However, this is no longer a problem since e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3 "use a dummy clipboard when running unit tests so the multiple unit tests don't stomp on each other. This fixes a couple of things in my earlier attempt (*) actually set the env variable on Windows (*) don't use a global variable to test the env var, because that variable might be initialised BEFORE the env var is actually set" Change-Id: Ifae66e522b0a1e57fa1fa6d16980c6491b397f7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147957 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-28BaseMutex->std::mutex in oglcanvas::TextLayoutNoel Grandin
Change-Id: I76b95eb8444c057d94f5653769e23047c019b139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28CppunitTest_chart2_export: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I29efb96151d06fe19ec50a8c6cd363ae052d421f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147962 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-28no need to allocate SvgUnits separatelyNoel Grandin
it is only one pointer big Change-Id: Iad5444ed6783abc2916510fd83c5b5a11d17e8f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28flatten OWriteStreamNoel Grandin
no need to use pimpl pattern here Change-Id: Iebc412aaad83c2f1fc149cc320729ce25030cbc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28no need to allocate OTypeCollection separately in OStorageNoel Grandin
it is only one pointer big Change-Id: I4af56814be106026515aee6c09caa14e0f3eb09a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to dfd3deea6691715db33c13bdc639bac22dbf88f3 - Fix broken links in help Change-Id: I77413b0a66d7851d7c79e5f83ed72dd5f42f1c00 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147975 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-28flatten basctl::docs::DocumentEnumerationNoel Grandin
no need to use pimpl pattern here Change-Id: I289f545ff237b9770f3a193460a943e91b86fadb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28tdf#148966: pptx: workaround for multiline fields followed by linebreaksSarper Akdemir
In Impress after fields that span multiple lines, a linebreak is already forced. (PowerPoint doesn't have such behaviour) Therefore if the imported pptx file has a line break after the multiline field - Impress ends up displaying an extra line break. This patch implements ignoring of a linebreak that follows after a multiline field during paint (when not in EditMode), using a compatibility flag. (IgnoreBreakAfterMultilineField) Change-Id: I1e6772424cc0eead06b53d104b06820038a81ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-28tdf#153105 PPTX export: fix "Custom position/size" background imageTibor Nagy
Map size and the 9 preset positions of the ODF background image style "Custom position/size" to the OOXML a:stretch/a:fillRect with the appropriate left/top/right/bottom arguments. Note: it seems, applying a:stretch or a:tile was not mandatory, but missing a:stretch resulted non-editable document in Office 365. Note: the import of the PPTX mapping hasn't been implemented, yet. Follow-up to commit e8335bac5690b6beccb5ca9b36281c89fb2f28f5 "tdf#153107 OOXML export: fix scale of tile of shape background". Change-Id: Ie940ebc2610c5b75126da05678a04ed1552cacb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147337 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-02-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7498da277dcf8545fd2a96720ca56921589c3041 - Remove duplicate reference to wiki pages Change-Id: I645d4c5195e28ef54535bd70bb65277397fb5b77 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147963 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-28Drop 'using namespace ::std' in Windows-specific filesGabor Kelemen
Change-Id: Id66d42f2139fbcac0fed56fe534107f65d198f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147877 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-02-28InputStreamToXInputStreamAdapter.readBytes() should read...Damjan Jovanovic
until the buffer is full, or the file ends. It shouldn't care about available(). (cherry-picked from f04910427d25ede98b84b90df7cc5a12d1adc695) Change-Id: I4ad17c614ba336ff21883248715861f6af1fbc2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147934 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-02-28cid#1521506 silence Thread deadlockCaolán McNamara
and cid#1521510 Thread deadlock annotation is getting a bit spamy Change-Id: I3120562c0f7ca996f53d14965efe7af506be6d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-28Sukapura: Add initial preparation for dark mode supportRizal Muttaqin
Change-Id: Ida7c68864c0ecb3bbd00cb6b87e4657b29447ec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147870 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-02-28no need to allocate OTypeCollection separately in WSInternalData_ImplNoel Grandin
it is only one pointer big Change-Id: I291b1c0aaba2f46aebabefa0341a9e24cf20eeff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147947 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28no need to allocate Date separately in ImpSvNumberInputScanNoel Grandin
it is only one pointer big Change-Id: I8b0b7ea0cf69cecabc2ddfb7e5d134037221057c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28no need to allocate ucbhelper::Content separately in UCBStorage_ImplNoel Grandin
it is only one pointer big Change-Id: Id60710eca9a170733ebba4120359e03f384f9962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28flatten some vba classesNoel Grandin
no need to allocate ShapeHelper separately, it is only one pointer big Change-Id: Ie4981ca81ac1dd430f22ba32357fcabbbd47bd09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147944 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 9ce008461498f499ea8d524bfa7faf66ee194f14 - tdf#153747 correction about what tips are shown in a document also, refactor to <h1>,<h2>,<tip> Change-Id: I6698ebc60ff40046267db7ffcbaa6ad8cb77e713 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147911 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-28Fix the java.lang.NullPointerException in readBytes() and readSomeBytes()...Damjan Jovanovic
methods in InputStreamToXInputStreamAdapter when called from the inter-process UNO bridge. XInputStream::readBytes() documents how the buffer is an "out" parameter, and isn't passed to the implementing end, which is why we get the buffer as a "byte[][] b" and b[0] == null. Its role is to box a byte[] array to be returned the client. Thus, allocate the buffer if it is missing or too small. Additionally, virtually all other readBytes() and readSomeBytes() implementations trim this sequence to the actual number of bytes read. This presumably reduces the inter-process traffic, but some callers even rely on the sequence to be trimmed, eg. main/sax/source/expatwrap/xml2utf.cxx. Thus trim our returned array too. (cherry-picked from 6cb06142790376a2c58e6392182eb071420a4221) Change-Id: I42eb209b68f7c13a34670d03c2ca61d76672385b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147933 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-02-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d94ca17c8d62af3286d84ceb8166cad1f8cd8446 - Fix "D'oh! you found a bug" in Help page Change-Id: I15d47f59bb75d6c4f31450d227b78d88a8b9b384 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147956 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-02-28fix up misleading mismatching indent and add mode linesCaolán McNamara
Change-Id: Id0abfc6d2962223bd0f7f0864a53e94bb7ec5052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-28Extend loplugin:cppunitassertequals to CPPUNIT_ASSERT_LESS etc.Stephan Bergmann
(Just in case, even though this doesn't find any actual issues in the code for now.) Change-Id: I80b8b0a647e89fdb6a4f0f4363fa1c3df8e5ddeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147942 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-28sw floattable: fix fly pos invalidation in follow anchor framesMiklos Vajna
The problem was that in case a row split moved the 2nd half of the row to a new page, the follow fly frame had a wrong position (top left corner of the page). What happened was that the follow anchor (text frame) was not yet positioned by the time the follow fly was positioned, and there was no invalidation once the follow anchor got its position. Fix the problem by improving SwTextFrame::MakePos(): it already had code to invalidate the position of follow flys when the position of the anchor changes, but it assumed that the flys of a follow anchor are in the follow anchor, while in fact flys are always nominally anchored in the master, so we didn't find the relevant fly frame and no invalidation happened. Once we use FindMaster() to look up the master and filter based on FindAnchorCharFrame(), we find the relevant fly to invalidate and the position is correct. Change-Id: Ic485527bb9dd05b3d5aed383eb5fa1c4f9f6a76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147943 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-28move sanitizing of Size inside GenericTypeSerializerNoel Grandin
I cannot see a useful application of a Size that is negative (at least not in a file format). Change-Id: I0c5bd8c7d3987a5c7803af2a6ae0543c4a6d7754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-28Avoid extra newlines in HTMLMike Kaganski
SwHTMLWrtTable adds SAL_NEWLINE_STRING itself calling SwHTMLWriter::OutNewLine explicitly, so the LFs inserted by HtmlWriter::end() just add noise. Change-Id: I67f3ef6b315185e9df33e3a21f3ea4a4d045e296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147941 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-28flatten some internal classes in dbaccessNoel Grandin
no need for the pimpl pattern here Change-Id: I6e15dd7b68104b2848871c338d5560cb70c9c88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147869 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-23 15:55:33 +0000