summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-27tdf#123990 sc condition: use GetTransliteration, not GetCollatorJustin Luth
Thanks Eike Eike said "This should not use collation (which should only be used in sorting context) but ignore case transliteration instead." I had just copied ancient code from commit 952c2b02c73b30b011306faf2f0d6f2b4a935955 Author: Eike Rathke on Date: Wed Mar 14 14:57:39 2001 +0000 use CollatorWrapper instead of International Apparently that code should also be changed in a follow-up commit. Interestingly, a \x000 - \x008 etc must be isEqual(""), so an attempt to ScGlobal::getCharClass().lowercase all variables at the beginning and use regular OUString comparisons didn't work. Also, a "" startsWith and endsWith each string. In Excel, a "" is also contained in every string, but not (yet) in Calc. Change-Id: I44a07c482d2d67a76a939ba2d593a003398d52c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140633 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-27sw: fix inserting fields between 2 adjacent input fieldsMichael Stahl
Primarily this is achieved by using GetTextAttrMode PARENT in SwCursorShell::CursorInsideInputField() and SwCursorShell::PosInsideInputField(). But this requires some refactoring to make this parameter available. Change-Id: I1a0ef4e3d93a6733d972544abfe07ddf929eb62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140661 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-27sw: SwFieldDlg disable Insert button if shell cursor is in input fieldMichael Stahl
Lots of content including fields cannot be inserted into an input field, and if there is already a selection when clicking the insert button, the selection will be deleted but then inserting the field will fail. Just disable the button, as is already done if the cursor is in a protected section. Change-Id: Ib01cf378441582668a9dd4c76900062b906ff09c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140660 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-27Revert some string_view pessimizationStephan Bergmann
This reverts the configmgr part of 0a7eac8576f313dcaf27ee45326d71fd6b5aea1e "use more string_view in accessibility..configmgr": All calls to Data::parseSegment (either directly, or indirectly either via Access::getSubChild or via parseSegment in partial.cxx) pass in an OUString path, and in some cases (see below) > *name = path.substr(index, i - index); in Data::parseSegment reconstructs an OUString from the full path (i.e., index == 0 and i == path.size()). And I see no code that actually benefited from the switch to string_view. One example call stack for such an expensive reconstruction of an OUString from full path is > #0 in configmgr::Data::parseSegment(path=u"ooSetupSystemLocale", index=0, name=0x7ffff5299280, setElement=0x7ffff52992a0, templateName=0x7ffff52992b0) in core/configmgr/source/data.cxx > #1 in configmgr::Access::getSubChild(this=0x619000028f80, path=u"ooSetupSystemLocale") in core/configmgr/source/access.cxx > #2 in configmgr::Access::getByHierarchicalName(this=0x619000028f80, aName="ooSetupSystemLocale") in core/configmgr/source/access.cxx > #3 in utl::ConfigItem::GetProperties(xHierarchyAccess=uno::Reference to (configmgr::RootAccess *) 0x619000028fb8, rNames=uno::Sequence of length 6 = {...}, bAllLocales=false) in core/unotools/source/config/configitem.cxx > #4 in utl::ConfigItem::GetProperties(this=0x61100000cad0, rNames=uno::Sequence of length 6 = {...}) in core/unotools/source/config/configitem.cxx > #5 in SvtSysLocaleOptions_Impl::SvtSysLocaleOptions_Impl(this=0x61100000cad0) in core/unotools/source/config/syslocaleoptions.cxx [...] Change-Id: I51127d82aea927dd9aaf374880c406dbafaddcde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140658 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-27Fix typoAndrea Gelmini
Change-Id: I269be7184ceeb34fd6d0c4e0311f7b4d5758e382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140643 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-27crashtesting: assert on converting ooo64499-3.sxc to odsCaolán McNamara
a problem since: commit 776ea34deefe7bdce2fb8a06e5c55ef27ec87ea7 Date: Wed Sep 21 11:09:46 2022 +0200 use more string_view in xmloff Change-Id: Ifec0f4c84373aa4501acfde2fd357fd749f836c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-27Update git submodulesAndras Timar
* Update helpcontent2 from branch 'master' to 3e01f85525f194ed75ae25eae6e7061efd32e147 - remove empty paragraphs Change-Id: I42a12141e42c286e2d3398e8d05d19567ea0ca03 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140652 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-27DOCX export: fix not-well-formed XML when hyperlink end is a textbox anchorMiklos Vajna
We failed to save a document which contained anchored text and the anchor position was inside a hyperlink. The problem was that the hyperlink covered content which has anchored text, so when the text inside the shape ended its paragraph, it wanted to finish the hyperlink that was started outside the shape, which is not well-formed XML. This was a problem since 7246e57216bb20c15af0ecf6a0183f5ffa81e780 (tdf#143591 DOCX import: handle anchored objects as at-char, 2021-09-20), previously we lost the character position of such anchor positions, so in practice this problem was not visible. Fix this similarly how we stash away the current state when entering a table cell: just save / restore the number of hyperlinks we have to close, that'll close the hyperlink outside the shape. Note that the source document has the hyperlink outside the shape's anchor, while we include the shape inside the hyperlink, but that doesn't cause problems in practice. Change-Id: I711fad2336fd78e2ba709c3fc0a4f75de32aae8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140650 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-27tdf#151071 Revise Sifr (Pivot Table, Table actions, autowizard etc)Rizal Muttaqin
Change-Id: I9eb241b96a3160b4d4a17f7f6b7b454d0b63e916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140634 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-09-27sufficient at this point to silently allow MissingJustBulletCaolán McNamara
to not assert that there are unexpected glyph substitutions Change-Id: Ie4231c84fc1a509f86eac4242270c9e496bf7e35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-27tdf#150916 make unselect in combobox dropdown same as initially unselectedCaolán McNamara
a similar issue as seen in tdf#148197 Change-Id: I3848fe7b48f6148a5ae13d484c866953fed83c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-27use more string_view in filterNoel Grandin
Change-Id: I75c98f1da8898840bb882c17c7f1e59ec11ae8af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27use more string_view in cui,extensionsNoel Grandin
Change-Id: I76253ae06af53f63206a47a84035317c6a5058b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27use more string_view in packageNoel Grandin
Change-Id: Ia38b2784222701d669f244523ce9a27c4068c5ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27use more string_view in accessibility..configmgrNoel Grandin
Change-Id: Ie16d36faac7d06e275348ed68e6c6b2518534fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27Fix some headless window sizes on Windows, to make `make check` more reliableStephan Bergmann
...by making it more resilient against varying screen sizes. On my 2560x1600 Windows laptop, three `make check` tests systematically failed, and apparently all of them were caused by that larger-than-average screen (similar to what has been detailed in the commit message of 3db6a93c558c55eed085b4386228f9951bb08936 "Compute a better GetDefaultCenterPos"): * CppunitTest_sw_layoutwriter > test/source/xmltesttools.cxx:191:testTdf134298::TestBody > equality assertion failed > - Expected: 2 > - Actual : 3 > - In <>, XPath '/root/page' number of nodes is incorrect * CppunitTest_sw_ooxmlexport12 > sw/qa/extras/ooxmlexport/ooxmlexport12.cxx:526:testObjectCrossReference::TestBody > equality assertion failed > - Expected: Text 2 > - Actual : 2 * CppunitTest_sw_uiwriter2 > sw/qa/extras/uiwriter/uiwriter2.cxx:2702:testTdf122942::TestBody > equality assertion failed > - Expected: 2 > - Actual : 1 Those tests are all run with both SAL_USE_VCLPLUGIN=svp and --headless. But svp is only present on Linux and is thus ignored on Windows. And --headless, while preventing any windows from actually being shown, nevertheless uses the GUI code to set up window sizes. So the idea here is to hack the Windows backend in strategic places so that it uses "appropriate" window sizes in --headless mode to make `make check` succeed. The Linux svp backend has a single place in vcl/headless/svpframe.cxx where it hardcodes the number of monitors to 1 and the screen size to 1024x768. However, for the Windows backend, code determining and using those values is somewhat spread, but it turned out that there is one strategic place in ImplSalGetWorkArea that does what we want (without touching the reported number of monitors at all), without (it appears) negatively affecting other scenarios. (It appears that macOS, also not supporting an svp backend, is similarly affected. But it looks harder there to come up with such a strategic place to hardcode --headless window sizes, and at least my own macOS build's `make check` is unaffected as I use a default scaled 1829x1080 screen resolution there instead of the "raw" 3840x2160.) Change-Id: I822241f81497b9f6bed8e9688eddbe7d798c6b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140588 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-27tdf#144348: Remove EmojiOne Color fontKhaled Hosny
The EmojiFont setting is now a comma-separated list of the three common color emoji fonts, it should fallback to the next font if the first is missing. Change-Id: I7aa134f914ab829704e9b707f511f166a81a0089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140623 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-27Reduce number of static objects a bitMike Kaganski
Change-Id: I80f0e8edeb4aa0b6a2179745ae9eda37cac278d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140641 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-27crashtesting: crash in DocxAttributeOutput::TableCellPropertiesCaolán McNamara
on converting ooo59560-1.sxw to docx Change-Id: I616b254c83ae168806f08a80c07b14de696cc87b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-27cid#1500540 use check_after_deref instead of reverse_inullCaolán McNamara
Change-Id: I9f33d2681865b4a8200549b962d76f5babedfa3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-27rtl uuid : remove useless endian conversionArnaud VERSINI
Change-Id: I65a4dad0aceb83f2449c86c438cb478937c8b90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138229 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-27A bit of cosmeticsMike Kaganski
Change-Id: If7440ea4e99ce33948a1c040f9f0345b18d18c42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140635 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-27sw: document SwDropCapsDlgMiklos Vajna
It works with the current view in the SwDropCapsPage ctor, which is a bit poor, probably could figure out the relevant view via the parent it gets. Change-Id: Idc7641e1c56c6fbe2038115573db76b28c0375e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140626 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-27use more string_view in dbaccessNoel Grandin
Change-Id: Id0b41d57015e8e2542b47d3a09ca8f13d090dbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27use more string_view in connectivityNoel Grandin
Change-Id: I313fe10ce3166a0cd96ae0a98e571fd4356da3b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27Prevent erroneous fraction detection of not yet accepted dateEike Rathke
May had happened if the locale's date separator is not '/' but a preset format uses it (for example DD/MM/YYYY) and the locale's date acceptance patterns do not contain D/M/Y so the first '/' did not already lead to a possible date before a match against the format is to be tried. Change-Id: I7f91130da52564496a2b1369741328236dde10e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140632 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-09-26Fix typoAndrea Gelmini
Change-Id: I0a2bab10b739a5e2462f53826cc77dd25abd9959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140625 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-26Fix typoAndrea Gelmini
Change-Id: Ib35b1ce171e655e2dfbca2ed996b7e212813b8f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140622 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-26sw HTML export: fix PNG export of Writer images containing metafilesMiklos Vajna
We attempted to export SVM metafiles as SVM+PNG, but then the SVM was turned into GIF. A GIF+PNG pair is not useful, just write PNG. This is similar to commit c8a9396e5695675ffe92935a9ba40354fc76ed79 (sw XHTML / reqif export: fix PNG export of shapes, 2021-06-03), which did the same for non-SdrGrafObj shapes. Change-Id: I1a0ab266473787d263573b4813dc19426e272435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140619 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-26Related tdf#132398 - Remove Hicolor Assets for Future Revampinggaljit
- Removed all 32x/64x/128x/256x/512x/1024x svgs as their corresponding pngs can be created by using the svgs found in scalables directory - Removed 22x22 assets as they were used only within KDE apps but KDE has its own LibreOffice 22x22 icons anyway - Moved extensions.svg as it was probably misplaced - Removed math.png that was not meant to be in a mimetypes directory - Renamed 1024x1024 to 512x512@2x (for HiDPI) directory as 1024x1024 is not a standard hicolor directory Change-Id: I6fe333abb5de6d403e43fc4aa5c7c2a1326c4250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139715 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-09-26crashtesting: don't assert on bogus font name in embedded ttfCaolán McNamara
seen with kde156448-1.pdf, fontforge also warns about the fontname. Looks like the name starts in little endian (wrong) before switching to big endian and/or is initially out by one. 䄀爀椀愀氀-BoldItalic should have been Arial-BoldItalic Change-Id: I4cd9f8bc6bc70d6e9a91c24801629ba140a3b675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-26tdf#117173 wina11y: Send EVENT_SYSTEM_ALERT when notification showsMichael Weghorn
Together with Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6 ("tdf#119788 tdf#117173 add accessibility NOTIFICATION role") and Change-Id Id62b3942dc17c3a1ed6a08d23438406e5a19c39d ("tdf#117173 a11y: Send SHOWING state change event on Window{Show,Hide}"), this makes NVDA announce the notification in the Search and Replace dialog as an alert, similar to what browsers do e.g. in the alert on empty input for the input validation example at https://www.w3.org/WAI/tutorials/forms/validation/ . Change-Id: I3263df4711f84a6dd9e178aaaaad340b128aa074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140091 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-26tdf#117173 a11y: Send SHOWING state change event on Window{Show,Hide}Michael Weghorn
When a `vcl::Window` becomes visible, `Window::ImplSetReallyVisible` calls the registered event listeners with a `VclEventId::WindowShow` event. Likewise, a `VclEventId::WindowHide` events is sent in `Window::ImplResetReallyVisible` when the window is no longer visible. Handle that event in `VCLXAccessibleComponent` by sending a state change event for the SHOWING state, so assistive technology gets notified about this. (Similar handling can already be found e.g. in `AccessibleTabBar::ProcessWindowEvent` or `AccessibleTabBarPageList::ProcessWindowEvent`.) While doing so in `VCLXAccessibleComponent::ProcessWindowEvent` for the object itself would generally seem like a more straightforward and conceptually nicer approach, this would have the problem that the event wouldn't get propagated to the platform-specific a11y integration layer (like winaccessibility) for the `VclEventId::WindowShow` case, since the a11y event listeners are registered and unregistered as a response to the CHILD event (at least for winaccessibility and gtk3, qt6 doesn't do that (yet?)), and if the accessible event listener is not (yet) registered, the event is simply ignored. Since the CHILD event is sent in `VCLXAccessibleComponent::ProcessChildWindowEvent` and that gets called on the parent *after* `VCLXAccessibleComponent::ProcessWindowEvent` gets called for the object that became shown/hidden (s. `Window::CallEventListeners`), also send the state change event for the SHOWING state of the child from there, so the proper order can be made sure. The reverse order (first the state change event for the SHOWING state, then the CHILD event which results in removal of the a11y event listeners) is used for the case where the window gets hidden. In combination with Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6 ("tdf#119788 tdf#117173 add atk notification role") and commit 155e8b1683f10847ff18e75287e2466220242bb1 ("tdf#117173: qt a11y: Forward changes to SHOWING state"), this makes Orca announce the label with notification role in the Search and Replace dialog for the qt6 VCL plugin as well. The gtk3 case already works with just Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6 ("tdf#119788 tdf#117173 add atk notification role") in place, because that one uses native gtk widgets in the Search and Replace dialog, and the Gtk library then takes care of sending the object:state-changed:showing event when the label with notification role gets shown. Side note: There are also comments that suggest to rework the a11y event handling for the show/hide changes more fundamentally, e.g. this comment in `Window::ImplSetReallyVisible`: // the SHOW/HIDE events serve as indicators to send child creation/destroy events to the access bridge. // For this, the data member of the event must not be NULL. // Previously, we did this in Window::Show, but there some events got lost in certain situations. Now // we're doing it when the visibility really changes if( bBecameReallyVisible && ImplIsAccessibleCandidate() ) CallEventListeners( VclEventId::WindowShow, this ); // TODO. It's kind of a hack that we're re-using the VclEventId::WindowShow. Normally, we should // introduce another event which explicitly triggers the Accessibility implementations. Similar ones can be found in `Window::ImplResetReallyVisible` and `Window::Show`. Change-Id: Id62b3942dc17c3a1ed6a08d23438406e5a19c39d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139813 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-26tdf#151143 Fix the size of Template Manager in ListView modeRafael Lima
A previous patch (410bff99a708371eed6a82677b44e2151a4a990a) fixed the size of the ThumbnailView in the Template Manager. However it did not fix the size in ListView mode. So when the Template Manager opened in ListView, the height of the ListView the same as the number of available styles (rows in the list). The problem was most noticeable in Draw, which has just one template, but it actually affected all modules. This patch fixes this issue in ListView. Change-Id: Id6bf00b63e276b057ee191b191f57f295e9801cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140502 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-09-26use more string_view in sfx2Noel Grandin
Change-Id: Idf80ebfe6fb72c4b61eca15a4aee5da7621ffa48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140591 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-26use more string_view in chart2Noel Grandin
Change-Id: I2afe0b5f82d1704a29bc80a969ee099eec90d3a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-26crashtesting: forum-de2-1635.odsNoel Grandin
regression from commit b52fd544b9c128d3e28de6355286f6480b618e93 Date: Tue Sep 20 15:48:38 2022 +0200 avoid some string refcounting with sheets with lots of conditional formatting Change-Id: If1414221aef0b227200cfb6ffb8e87abb48a90c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-26uitest: sc: check 'all' button in autofilterXisco Fauli
Change-Id: I9a64701446512178cc8deda64f94c293d939ec3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-26Add some missing @since tagsStephan Bergmann
...for constants introduced with 4917430c1c5e8105987e81d65d31df21955ad60e "tdf#116542 a11y: introduce STATIC role" and 947fe0d89dee75ee43515ef7dfb43837d65a45bc "tdf#119788 tdf#117173 add accessibility NOTIFICATION role", resp. Change-Id: I1533f3bfcac5e7014078dd891dc05571f1186bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140587 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-26lok: create sidebar on demandSzymon Kłos
Change-Id: I5393bba647aa4667643262e77acc6b6873afb571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139729 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140580 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-09-26jsdialog: send action not update for spin button valueSzymon Kłos
This will help us to reduce payload and fix bug where in Chrome regenerated spin field always focused "arrow down" button after click on the "arrow up". Use value from formatter - the same as generated in widget update JSON. Change-Id: I6ace90eb532e894daacb563bc9fb93332fd755ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140579 Tested-by: Jenkins
2022-09-26Be sure the number format dialog content is in correct placeSzymon Kłos
- use special container for content which is always above action area (place where ok/cancel buttons are) Change-Id: I53dea3d98e7c74d0b571fdc8a35932deb48a8ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138668 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140578 Tested-by: Jenkins
2022-09-26android: add Grammar Checker component to native-code.pySzymon Kłos
Change-Id: I87e6e74393d387beb254291e668ca7eb56e5370b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136823 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140577 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-09-26tdf#151104 correct missing ColorModificationArmin Le Grand (allotropia)
Presentation still uses Metafiles as transfer for Graphic content, so uses VclMetafileProcessor2D. Unfortunately processPolyPolygonGraphicPrimitive2D does not support an active BColorModifierStack, so use the default as working fallback to create correct GraphicData for the Metafile. Change-Id: Ia439b241cb414667263ef653b507ad8b7fecde61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140550 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-26introduce sw::SectionHidden as plain SfxHintBjoern Michaelsen
Change-Id: I7412c16d0ffd4cf38a1b4186f81703443cdf6fbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140576 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2022-09-26sw: prefix members of SwInsTableDlg, SwRenameXNamedDlg, SwSaveLabelDlg ...Miklos Vajna
... and SwSectionPropertyTabDialog See tdf#94879 for motivation. Change-Id: Id622c7880e978e1631d235a8fe04cb2976bbcd2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140583 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-26tdf#150762 RTF import: fix missing left margin on numbered paragraphMiklos Vajna
The bugdoc has a numbered paragraph with a custom left margin, but this left margin is missing in Writer. This went wrong in commit 61b7034824dead1635f9e9c6ec996297e10f6910 (tdf#104016 RTF import: deduplicate before text indent from numbering, 2017-12-05), and now it's broken because the numbering properties are applied before paragraph properties in the DOCX case, but the RTF tokenizer didn't do this ordering. This behavior of sw core somewhat makes sense, users expect the margins from direct formatting to go away if you apply a new numbering. So fix the problem by tweaking the RTF tokenizer to emit the numbering tokens first and only then the paragraph tokens, which is an order that's closer to the working DOCX tokenizer. This only affects the old (WW6-style) paragraph numbering markup, not the newer (WW8-style) numbering markup. Change-Id: I39698f57684d47c03ea4848fc8eb6b2e855c4fbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140584 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-26tdf#150726: Fix previous fixKhaled Hosny
Fix regression from: commit 092e37a284ea8b8bc1e8dabbbeb001c98012a996 Author: Khaled Hosny <khaled@aliftype.com> Date: Sun Sep 25 11:37:05 2022 +0200 tdf#150726: Pass full string to DrawTextArray() when drawing bullet Since we are no longer copying the string, we need to use the actual rInf.GetIdx() here as well. Change-Id: Ic68593407cb313785c9d734e4a3a3687e2ba4eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140582 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-26tdf#119788 tdf#117173 add accessibility NOTIFICATION roleJim Raykowski
and use it to make screen readers announce notifications from the 'Find and Replace' dialog Change-Id: Ifcf9304883e2e824ea1b7998d7767e474b87c8b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139709 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-26tdf#151071 Revise Sifr (Sheet, wizard etc)Rizal Muttaqin
Change-Id: Ieeb1513ad2ddeca022180e9dc8e7c37b647fa59a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140581 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-12 09:53:54 +0000