summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-24Avoid calling java.lang.Class.newInstance()Stephan Bergmann
For one, it is deprecated since Java 9, and for another it causes a NullPointerException when called from the JNI Invocation API (i.e., without a Java caller frame) at least with some Java 12. (Found when doing a test build with Java 12 and JAVA_SOURCE/TARGET_VER explicitly configured as 7 with d365f36331874f94bbd9832fbd19ace90fafefec "Allow to pass JAVA_SOURCE/TARGET_VER into configure".) I have entered information about the NullPointerException at <https://bugreport.java.com/bugreport/start_form.do>, but haven't heard back yet, so duplicate that information here: Issue Type: > Bug Component: > Core Libraries Operating System: > Linux 64-bit Java Release: > 12 Synopsis: > Calling java.lang.Class.newInstance from JNI Invocation API causes NullPointerEx Description: > I can reproduce this with the OpenJDK 12 RPMs on Fedora 30, but from looking at <https://hg.openjdk.java.net/jdk/jdk12/file/06222165c35f/src/java.base/share/classes/java/lang/Class.java> it looks plausible that it is a common issue that Reflection.getCallerClass() returns null when java.lang.Class.newInstance is called from the JNI Invocation API, and that null is propagated to jdk.internal.reflect.Reflection.verifyMemberAccess as parameter currentClass, which dereferences it at <https://hg.openjdk.java.net/jdk/jdk12/file/06222165c35f/src/java.base/share/classes/jdk/internal/reflect/Reflection.java#l130>. > This is known to have been working with older OpenJDK (at least 1.8). Steps to Reproduce: > Compile the provided test.cc with `g++ -I/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/include -I/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/include/linux /usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/lib/server/libjvm.so test.cc` and run it with `LD_LIBRARY_PATH=/usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc30.x86_64/lib/server ./a.out`. Expected Result: > exit 0 Actual Result: > Exception in thread "main" java.lang.NullPointerException > at java.base/jdk.internal.reflect.Reflection.verifyMemberAccess(Reflection.java:130) > at java.base/java.lang.reflect.AccessibleObject.slowVerifyAccess(AccessibleObject.java:673) > at java.base/java.lang.reflect.AccessibleObject.verifyAccess(AccessibleObject.java:666) > at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:638) > at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:490) > at java.base/java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:166) > at java.base/jdk.internal.reflect.ReflectionFactory.newInstance(ReflectionFactory.java:404) > at java.base/java.lang.Class.newInstance(Class.java:590) > Aborted Source code for an executable test case: > #include <cstdlib> > > #include "jni.h" > > void handleError(JNIEnv * env) { > if (env->ExceptionCheck()) { > env->ExceptionDescribe(); > std::abort(); > } > } > > int main() { > JavaVM * vm; > JNIEnv * env; > JavaVMInitArgs args{JNI_VERSION_1_2, 0, nullptr, true}; > if (JNI_CreateJavaVM(&vm, reinterpret_cast<void **>(&env), &args) != JNI_OK) { > std::abort(); > } > auto const c1 = env->FindClass("java/lang/Class"); > handleError(env); > auto const id = env->GetMethodID(c1, "newInstance", "()Ljava/lang/Object;"); > handleError(env); > auto const c2 = env->FindClass("java/lang/Object"); > handleError(env); > env->CallObjectMethod(c2, id); > handleError(env); > } Workaround: > Call via JNI the suggested replacement of clazz.getDeclaredConstructor().newInstance() instead of the deprecated java.lang.Class.newInstance(). Change-Id: I85ff7102a18b98561f188e609873753546bc050d Reviewed-on: https://gerrit.libreoffice.org/71240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-24tdf#124791: Fix Gaelic (Scotland) (gd-GB) LCID in MSI installerMike Kaganski
... which was obviously omitted in commit 6b678c135da07f34da1bf7b19562366361e95085, which introduced the correct value of 0x0491 (1169) in addition to the pre-existing 0x043C (1084). The new value is used when user sets relevant entry in Region and Language control panel applet (intl.cpl); having the old value in MSI summary information blocks auto-detection of proper installer language. [MS-LCID] Appendix A mentions that the new code is available since Win7, so we are good with the fix. [MS-LCID] https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/a9eac961-e77d-41a6-90a5-ce1a8b0cdb9c Co-authored-by: Eike Rathke <erack@redhat.com> Change-Id: Ic03b0e8eaf145c662fde48846cd5307e362d4d63 Reviewed-on: https://gerrit.libreoffice.org/71242 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24Proper shell quotingStephan Bergmann
Had found > sh: -c: line 0: syntax error near unexpected token `(' > sh: -c: line 0: `file /Users/stephan/Software/lo/core/instdir/LibreOffice.app/Contents/Frameworks/LibreOfficePython.framework/Versions/3.5/lib/python3.5/site-packages/setuptools/script (dev).tmpl' in workdir/CustomTarget/instsetoo_native/install/install.phony.log on macOS. Change-Id: I4b01b5f0a292424a60558cdb8b431a3d8dbdf1d4 Reviewed-on: https://gerrit.libreoffice.org/71234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-24tdf#89522 PERF FILEOPEN xlsx, part 2Noel Grandin
re-arrange the conditions so we avoid the dynamic_cast most of the time. This takes the file-open time from 40s to 29s for me. Change-Id: If65a63502fd545003137747605332be65d5e91ca Reviewed-on: https://gerrit.libreoffice.org/71229 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#89522 PERF FILEOPEN xlsx, part 1Noel Grandin
Inherit from tools::WeakBase non-virtually, so that we can use a static_cast in tools::WeakReference::get instead of a dynamic_cast. This takes the file-open time from 1m21 to 40s for me. Add a clang plugin to make sure we don't accidentally end up inheriting from tools::WeakBase more than once. Change-Id: I9c7c36403333f99094e1f9d8cce2ecd9200377f9 Reviewed-on: https://gerrit.libreoffice.org/71231 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24The iOS sv_SE dictionary surely works for sv_FI, tooTor Lillqvist
(I know Swedish, this is not guesswork, there are no orthography differences.) Change-Id: I6f652f01dc95aa3a89fec1964c2a49109eb5e30b
2019-04-24tdf#124909: Assume the iOS de_DE dictionary works well enough genericallyTor Lillqvist
On macOS, the system says it has a generic "de" dictionary. But on iOS, it says it is specificaly "de_DE". Assume it is good enough for the other German variants, too, for now. Change-Id: I745cc02c1ffa774dbcbfdc1d775ce358957f04f8
2019-04-24crashtesting: imported junk as form field textCaolán McNamara
spec says "An unsigned integer that MUST be 0xFFFFFFFF" for version so at least insist on that Change-Id: I8c11659d86fe122b1c8f61b1bf99e7b4b53ff306 Reviewed-on: https://gerrit.libreoffice.org/71227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-24simplify condition (remove always true part)Mike Kaganski
Change-Id: If846bb08ec6eceb307228bc628a4b186a3058051 Reviewed-on: https://gerrit.libreoffice.org/71230 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24tdf#124923: Remove unneeded iOS ifdefferyTor Lillqvist
Now with "Unipoll" this actually caused the app to hang. Unclear whether this ifdef had ever been strictly needed. (But before "Unipoll" it did not cause any harm.) Change-Id: I5cc399f76fcdb267eb96bf7790474c14f2ce9955
2019-04-24tdf#124923: Need to call InitVCL() on iOS before using SolarMutexGuardTor Lillqvist
Change-Id: If5781ae101e58c26368e57787cb301f84ffa82a5
2019-04-24workdir/UnpackedTarball/languagetool/build.xml uses ${source}, ${target}Stephan Bergmann
in its javac invocations, so we apparently need to set those variables instead of ant.build.javac.source/target (which are documented at <https://ant.apache.org/manual/javacprops.html> to be supported since Ant 1.7, but are apparently not used here). (Found when doing a test build with Java 12 and JAVA_SOURCE/TARGET_VER explicitly configured as 7 with <https://gerrit.libreoffice.org/#/c/71218/> "Allow to pass JAVA_SOURCE/TARGET_VER into configure", which caused building external/languagetool to nevertheless complain about unsupported 1.6 source/target switches.) Change-Id: I624f77b65ef81bc592a78559e67062a42cfff05a Reviewed-on: https://gerrit.libreoffice.org/71219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-24tdf#42949 Fix IWYU warnings in sd/source/ui/f*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I07d78df2d5aacbdaff7344a09812db91de17d535 Reviewed-on: https://gerrit.libreoffice.org/71113 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-24Allow to pass JAVA_SOURCE/TARGET_VER into configureStephan Bergmann
...for those who pretend they know what they are doing (e.g., to experiment with building against Java 12 which no longer supports Java 1.6 source/target, even though that results in a build that is not baseline compatible). Change-Id: I6e8617bc5b90212473652bdfac40bb48e9623a08 Reviewed-on: https://gerrit.libreoffice.org/71218 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-24simplify call sites of SfxItemPool::PutNoel Grandin
use template to make return type match input type, so we don't need to cast at the call sites Change-Id: I1e65f362c67f74c9a230cdbc1db12545b28eb499 Reviewed-on: https://gerrit.libreoffice.org/71216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124896 CRASH: deleting sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3913e14cadc11efa1d9e7405cdbaf96fe094508a Reviewed-on: https://gerrit.libreoffice.org/71220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124893 Validity check on new dialog creation.Rtch90
Change-Id: I5f94c8204a4c35470e891eb89cfbe74aad852bf4 Reviewed-on: https://gerrit.libreoffice.org/71084 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-24tdf#124127 improve Arabic icon theme supportandreas kainz
Change-Id: I3114afc6856f2a44127b2959408337c464d9ff88 Reviewed-on: https://gerrit.libreoffice.org/71147 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-24tdf#124197 Improve "Unexpected error" user-visible error message wordingDarkByt31
Change-Id: I11c2ac4855a5fec2d26255ec3ab14ffe50e0fbbe Reviewed-on: https://gerrit.libreoffice.org/71066 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24fix filename of a test file in writerperfectLuboš Luňák
Was broken in d077b19a3f617f5ef. Change-Id: I5f0e0ca7c60f0f09381ee7eebd7d49d5533e07af Reviewed-on: https://gerrit.libreoffice.org/71145 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-04-24disable some more pdfexport testsNoel Grandin
Change-Id: Ifdee7c4bd9ed3306530c7bc4ecf3017008e90c3d Reviewed-on: https://gerrit.libreoffice.org/71215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124741: export default column width to XLSXMike Kaganski
For some reason, we have never exported the default column width to XLSX, although we have such export for XLS. This led to bugs like tdf#100946. Workarounds applied to those bugs have made LO to export columns which shouldn't have been exported, abusing "customWidth" attribute in XclExpColinfo::XclExpColinfo depending on if the column has size different from an app-global default; after that, sheet-local default was determined, and then columns which have mbCustomWidth set (i.e., different from app default), as well as those different from sheet-local default, were stored. Effectively, the hack had disabled the removal of defaults from maColInfos in XclExpColinfoBuffer::Finalize. We even had unit tests explicitly testing that we export those columns that Excel skips. The effect of that is not only unnecessary data in the file; the data was actually wrong (customWidth actually means that the width was edited manually by user, even if equal to the default, thus changing Excel handling of the column); and also Calc initializes all columns to the right of last used column for such a file. Only in case when app-global default happened to match sheet-local one, columns would have properties allowing them to be removed from maColInfos in the end of XclExpColinfoBuffer::Finalize, which still resulted in problems similar to the workarounded one. This patch implements proper export of the default column width to XLSX, thus partially reverting changes made for tdf#100946 in commit 40d892a2db4d750aaf0562c63004e693c028273c. Actually, our export to XLSX does not depend on the 5-pixel correction (see ECMA-376-1:2016 18.3.1.81), since the exported default depends only on most-used column width. XclExpDefcolwidth implementation was edited to only take the correction into account when exporting to XLS (to keep status quo; it's clear that XLS widths export and import implementation is incorrect: some empirical formula is used in XclTools::GetXclDefColWidthCorrection, that was introduced in commit 555d702903fb0857122024e1ab78a72d122d3f16 for i#3006, that doesn't match any documentation, and changes widths of columns in exported XLS - something to be fixed independently). Change-Id: I227aca17e56247cbb839444717066a898987c4f1 Reviewed-on: https://gerrit.libreoffice.org/71132 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24lazy image loading shouldn't read the entire .xls file (tdf#124828)Luboš Luňák
b11188835d3b87cd changed msfilter to use GraphicFilter::ImportUnloadedGraphic() to lazy-load images from the document. However, that function in some cases simply reads the entire rest of the passed SvStream, which in this case is the entire .xls file. And the document from tdf#124828 is ~50MiB and contains ~4000 images => 100+ GiB memory required. Change-Id: I74926383204ec642eabb28b62e2cf2e1ff8054a9 Reviewed-on: https://gerrit.libreoffice.org/71136 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-24extern: update xmlsec to 1.2.28Miklos Vajna
Meant to fix the build problems reported in the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2019-March/082340.html> "Build failure with latest ICU 64.1". Change-Id: I006b92f4737f5e56e50527dd954e8c0d339e75dc Reviewed-on: https://gerrit.libreoffice.org/71143 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-24tdf#81765 slow loading of .ods with >1000 of conditional formats, part 4Noel Grandin
This takes the loading time from 13s to 10.5s Avoid expensive text-invalidation while we are loading Change-Id: Ia74b84575fbf635b5ab5618c74ea2efc9f6ad827 Reviewed-on: https://gerrit.libreoffice.org/71043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24Fix typosAndrea Gelmini
Change-Id: I9cc5e13681b047fe772704b42796e210ad070601 Reviewed-on: https://gerrit.libreoffice.org/71148 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-24tdf#124787 mso-spt143 (RingOutside) has angles in degreeRegina Henschel
When reworking command U the shape 'RingOutside' was not considered. Although it is a 'mso-' shape, it has angles in degree and not in fixed-point number in its defaults. The patch removes in addition the changes introduced by Symphony, which erroneously used total width and height instead of radii for the ellipse size. Change-Id: Iede8e346681796fb3e147dbcfaaa08ed8fe87c54 Reviewed-on: https://gerrit.libreoffice.org/70941 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-04-23Skip clipboard queries while the document is still loadingKatarina Behrens
Use-case here is .ods document with 16k tracked changes. For every tracked change, Calc generates a formula cell. For every formula cell, clipboard content is queried (via ScDocument::IsClipboardSource, ScModule::GetClipDoc respectively). This is dog-slow on Windows Therefore don't query clipboard content while the document is in the process of being loaded. Instead return from ScDocument:: IsClipboardSource early and return 'false' because at this point of time it can't be reliably determined whether this doc is a clipboard source anyway Change-Id: If5aa62cbfb62fb326a3c73b4d9be839127d3c03b Reviewed-on: https://gerrit.libreoffice.org/71121 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-23multiple concatted AcceptChgDatCaolán McNamara
Change-Id: I4ab78f35cb5a6ea31235662b6fad8d1e6c5d33b5 Reviewed-on: https://gerrit.libreoffice.org/71140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23tdf#124635 MountOperation::Mount can be called with SolarMutex unlockedStephan Bergmann
Change-Id: I7a36dd235a100b0d283eec86646dc167ac224ba7 Reviewed-on: https://gerrit.libreoffice.org/71133 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-23Revert "tdf#122280: Hide Block selection mode from Calc"Jim Raykowski
This reverts commit 220ce1a5b1db6e456afe04b7e9002c524dcf1044. Including a header file of another module and even a module that is above is a no-go. Change-Id: I3c8107d8c667c34259bdfee9d83afb2651f5e11c Reviewed-on: https://gerrit.libreoffice.org/71142 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-23fix bad comparison in StrCmp/StrLessNoel Grandin
comment from Miklos: > Won't this do a comparison of two null-terminated strings, while > the strings here are utf16, i.e. abc is a\0b\0c\0? That would mean > in practice you compare the first char only. introduced in commit 003d11f410b7e515981b3efbd65d936d94d87121 Date: Sat Apr 20 08:32:33 2019 +0200 tdf#81765 slow loading of .ods with >1000 of conditional formats Change-Id: I60ea18772753f50f880c65d8cff594267d724e76 Reviewed-on: https://gerrit.libreoffice.org/71114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23tdf#124886 Toolbar button icons are off by oneNoel Grandin
regression from commit 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 Date: Thu Apr 18 15:13:19 2019 +0200 optimise find/insert pattern Change-Id: I24edd5a89beed392c86058cd60155caf94bcf9ca Reviewed-on: https://gerrit.libreoffice.org/71137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23multiple concatted AcceptChgDat stored in configCaolán McNamara
FillInfo is called more often than Initialize, so we've ended up with multiple AcceptChgDat strings Change-Id: I99e9398757d63e2c6315ec9c3101910d5978b13b Reviewed-on: https://gerrit.libreoffice.org/71119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23move RefButon 'button-no-label' from .suppr to .falseCaolán McNamara
because we know all these get a label/tooltip set at runtime Change-Id: Icdcb341db6fe26b0a451c3b7229e8c0c4b0b2f86 Reviewed-on: https://gerrit.libreoffice.org/71109 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23sw: prefix members of SwAttrCheckArrMiklos Vajna
Change-Id: I3b1929d591fb3c44504b4818330a4e59aa3d587f Reviewed-on: https://gerrit.libreoffice.org/71125 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-23std::call_once needs -lpthreadStephan Bergmann
...at least on Fedora 29: > [LNK] Library/libsvllo.so > ld.lld: error: undefined symbol: pthread_once > >>> referenced by gthr-default.h:699 (/usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/x86_64-redhat-linux/bits/gthr-default.h:699) > >>> /data/sbergman/lo-clang2/core/workdir/CxxObject/svl/source/crypto/cryptosign.o:(__gthread_once(int*, void (*)())) and the call to std::call_once was introduced with d43cc00cf97fa1151560aa6fe0a3fef38e7507f6 "crashtesting: tdf#122599 NSS_CMSMessage_CreateFromDER asserts". Change-Id: If14b8cc704dbb806c61edabb8f5621527965ceb2 Reviewed-on: https://gerrit.libreoffice.org/71118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-23tdf#113266 slow opening XLS with 45 MB drawingNoel Grandin
Some hot-spots around dynamic_cast of SdrHint, so avoid that by creating special SfxHintId::ThisIsAnSdrHint The most common CPU hot-spot was in SvxShape::Notify, the other changes are just for consistency. Also remove some dead code in ScShapeChildren, the Notify method was doing nothing useful. Change-Id: I696db1fcafc09bb10bf23ac673de292746141491 Reviewed-on: https://gerrit.libreoffice.org/71108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23Update git submodulesRoman Kuznetsov
* Update helpcontent2 from branch 'master' - tdf#105848 Change EFFECTIVE function name to EFFECT Change-Id: Id2bd603a0330f1d85e665c0524635e0369061a18 Reviewed-on: https://gerrit.libreoffice.org/71079 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-23tdf#123043 make type character detection unicode-awareTomoyuki Kubota
Change-Id: I98886a7d13a43cc3202d45f96ceb5062f76f0784 Reviewed-on: https://gerrit.libreoffice.org/71013 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-23tdf#42949 Fix IWYU warnings in include/editeng/[f-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic14d2e66434817bcb7bd1e2b707f81d720d596b6 Reviewed-on: https://gerrit.libreoffice.org/71007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23LOK: support creating view with optionsAshod Nakashian
This adds a new API createViewWithOptions that make createView similar to documentLoad, which also has documentViewWithOptions version. This is primarily to support setting per-view language and similar settings. Change-Id: I0ae5a5b2410cf9e053aee8f7c8a6204af9038a31 Reviewed-on: https://gerrit.libreoffice.org/68261 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/71111 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-04-23tdf#123968 Test that imported field is editableSamuel Mehrbrodt
Change-Id: I2dbcc6fa8ee9c469cfc038a2622962b8939ec174 Reviewed-on: https://gerrit.libreoffice.org/70921 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-23tdf#113076 vcl windows opengl: specific italic set font was clipped on ...Miklos Vajna
... right edge in presentation mode. This seems to be a problem since commit a51b7a1c3a7e7cf7b0c733e1dec40288278c1884 (tdf#103831, tdf#100986: Force using GDI when needed, 2017-03-03), which blacklisted DirectWrite in the OpenGL case for both vertical text and horizontally stretched text. I tested that the overlapping characters problem from tdf#103831 is not re-introduced, and switching to DW (in the horizontal stretching && OpenGL case) fixes the unwanted clipping of glyphs for the tdf#113076 bugdoc. This also simplifies the situation, since the general rule since commit d436065bc1c68fc2d90e73253d8c00503c72dfd0 (tdf#103725: Default to GDI even with the new layout engine, 2016-11-15) is that non-OpenGL defaults to GDI rendering and OpenGL defaults to DirectWrite rendering. Change-Id: I44d035ab0890614be393599a5492e42e09231d86 Reviewed-on: https://gerrit.libreoffice.org/70945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23tdf#123684 PPTX import: fix wrong background color for <p:sp useBgFill="1">Miklos Vajna
Regression from commit 59339dec1ce56213dc74a06af2f0d35ac1c534d7 (tdf#105150 PPTX import: try harder to handle <p:sp useBgFill="1">, 2017-01-06), the problem was that we gave a white solid fill to a shape which is meant to be transparent. Fix the problem by limiting the scope of the mentioned commit to solid colors only, and also extend to code to look for background fill from the masterpage as well. This allows not hardcoding the white solid fill and leaves the fill style of shapes as transparent where the slide background is a bitmap or other more complex fill type. Change-Id: I0063e88d510250652d2b14856df3bd431681422d Reviewed-on: https://gerrit.libreoffice.org/71107 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-23Update git submoduleshimajin100000
* Update helpcontent2 from branch 'master' - fix forgotten LANG->LANGUAGE Change-Id: Idcfd73213452510f769854062d0916a3c871b548 Reviewed-on: https://gerrit.libreoffice.org/70982 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-23Fix typoAndrea Gelmini
Change-Id: Ia2a03b59b177ca74c5726db568013949a4a1d1cb Reviewed-on: https://gerrit.libreoffice.org/71082 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-23Fix typoAndrea Gelmini
Change-Id: I9fa72190a843d1f229deec8dad7f8ef0d5dd5570 Reviewed-on: https://gerrit.libreoffice.org/71081 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-23Fix typos in codeAndrea Gelmini
Change-Id: I5a39d89ad33d447f952d6c4c32923d387c47fd06 Reviewed-on: https://gerrit.libreoffice.org/71083 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-23tdf#123228: Disable Firefox theme searchMuhammet Kara
We can't use the MOZ API anymore. Let's disable it instead of showing a broken search window. Then we can spend some time on moving on instead of answering the -This is not working!- bug reports. Change-Id: Ice10bde804d1d9a7a13cd4781813fc794b1b0967 Reviewed-on: https://gerrit.libreoffice.org/67917 Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-15 13:12:17 +0000