summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-13At least VS 2022 Preview 17.8.0 Preview 3.0 needs the fix tooStephan Bergmann
...from 3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022 17.7.5" Change-Id: I36a7d02959c5ad04781c3d484966727c3283cbbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157932 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-13tdf#150262 Split Autosum button: refactor to deduplicateMatt K
This change refactors the recent checkin that split the autosum button into a default clickable button. We just use the existing function "AutoSum" in place of the copied code. Change-Id: I9a0e6fce047165c927746f0f87df4de905d2f8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155058 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-13add LibreOffice_settings.xml_config-items.fods to document settings.xmlMichael Stahl
Change-Id: Idede15529ed60e49e08e6e9f986cd198ca4a68a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157930 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-13Make sure __cpp_lib_source_location is consistently definedStephan Bergmann
...following up on 9c5f597fc80a8a910c1f898556ef2a3226dfe40c "use std::source_location instead of std::experimental::source_location". __cpp_lib_source_location is defined in both <source_location> (but which we can apparently not rely on here, trying to figure out whether to #include it in the first place) and <version>, so lets hope that all our toolchains support C++20 <version> by now and #include that. Change-Id: I7ba41cae60dbbf6b3ec275edb06af66f184daf93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-13sc: ui: fix cell bidi layout stringsHenry Castro
The default constructor OutputDevice can set the layout text to "vcl::text::ComplexTextLayoutFlags::BiDiRtl" for all strings if the UI locale is a RTL locale, however each cell string can be mixed LTR and RTL. Set the defaults to auto detect the correct text layout mode. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I0c451e8014fd13490db4213adca3d83ea4572819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157880 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-13cool#6893 disable undo for editengine when rendering cell textNoel Grandin
We don't need undo functionality when performing pure cell text rendering, shaves some CPU time off Change-Id: Icfc688122af7e77c874dd984555b2b0951e9e134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157900 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-13tdf#143148: Use pragma once instead of include guardsFederico Gallo Herosa
Replace include guards in favor of #pragma once. First task for beginners Change-Id: I0ead6e955c953ec0e9113174797ffb8b9938999f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157901 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-13sw floattable, wrap on all pages: add layoutMiklos Vajna
The anchor text of a floating table is normally wrapped around the table only on the last page of the table. This compat flag requests to wrap on all pages instead. First, disable the SwTextFrame::FormatEmpty() optimization in this case, so not only the last page has portions inside the text frame. Second, improve SwTextFrame::FormatAdjust(), so that anchor content from the last page can flow to previous pages. Note that having a dedicated SwFlyAtContentFrame::IsWrapOnAllPages() means that later it'll be possible to do per-frame decision on this if there is demand for that (this came up on the mailing list, but it's not something Word would support). Change-Id: I75df539df859aaa6c7eaaeddb33f004639b1c004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157902 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-13tdf#157465: getBytes may trigger an exception with hsqlJulien Nabet
So test the SQL type of the column and: - if it's css::sdbc::DataType::BIT treat it specifically - otherwise, use plain getString method Thank you Noel for the idea! Change-Id: Ib5003d96c1b5ce541fb17e6e31592858f8cd61d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157849 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-13CppunitTest_sw_core_text: fix --disable-pdfium failureMiklos Vajna
Change-Id: I6e0727a60491aa108c949836ebc6fd52a77984c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157868 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-13tdf#157636: sd_png_export: Add unittestXisco Fauli
Change-Id: I76ec68fb6482d7c348a08021413c640cf640d7f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157836 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-12tdf#157696 a11y: Map "CharEscapement" text attr to IA2 "text-position"Michael Weghorn
While the gtk3 implementation (see `Escapement2VerticalAlign` in `vcl/unx/gtk3/a11y/atktextattributes.cxx`) bridges numeric values to ATK/AT-SPI, the IAccessible2 text attribute specification [1] only allows the 3 values "baseline", "super" and "sub". With this in place, Orca with the qt6 VCL plugin on Linux and NVDA on Windows (with the WIP branches to switch both LO's winaccessibility and NVDA to the IAccessible2 text attributes) announce the subscript and superscript text in the tdf#157696 sample document as expected. (For Orca, announcement of the "vertical-align" text attribute is off by default, so that first needs to be enabled in the "Text Attributes" section of the Orca configuration dialog.) [1] http://www.w3.org/TR/REC-CSS2/visudet.html#propdef-vertical-align Change-Id: I1e4ea014cf818fefd009089be183615abf67aada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157867 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12tdf#141828 svx: Use pointing hand for custom shape handlesMichael Weghorn
Use the *pointing* hand cursor (`PointerStyle::RefHand`) instead of the hand symbol cursor (`PointerStyle::Hand`) for handles for custom shape interaction. (S. how `SdrHdlKind::CustomShape1` is only specified in `SdrObjCustomShape::AddToHdlList`, except for read-only switch/cases elsewhere). As mentioned in tdf#141828, this has the advantage that the user can see where the handle is being moved. For gtk3, this doesn't make any difference in practice, because it's using the same cursor type for both, `PointerStyle::RefHand` and `PointerStyle::Hand` (s. `GtkSalDisplay::getCursor`, but the Qt-based VCL plugins (`QtData::getCursor`) and macOS (s. `AquaSalFrame::getCurrentCursor`) make a distinction between them. Change-Id: I5d35481e5c5edc1895a7c4a973315ee6b187b983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157891 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12use std::source_location instead of std::experimental::source_locationNoel Grandin
https://en.cppreference.com/w/cpp/compiler_support says that this is supported in GCC >= 11 CLANG >= 16 Visual Studio >= VS 2019 16.10 And our Visual Studio baseline is now 2019. We still need to make the ifdef conditional check clang, because __has_include will happily return true even if the current clang does not support the necessary builtins. Change-Id: I5f2743e204b8ed22d4651053f3ae579a4a192a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157515 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12tdf#42787 SwNavigator: Add ability to delete SectionsJim Raykowski
Change-Id: If259772d6b84cdae48b75083c569fcf862416baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157802 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-12tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroDeepika Goyal
Change-Id: I4c655d7700373636cc00c42d6214976b8aa9aee4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157790 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-12Fix build against VS 2022 17.7.5Stephan Bergmann
After af9c3ed6f748781f2a77e676ffe740992788969b "__cpp_char8_t is generally available now" (which Jenkins built successfully against some VS 2019 version), various people using at least exactly VS 2022 17.7.5 (--with-visual-studio=2022) started to experience issues like > include\rtl/stringutils.hxx(251): error C2065: 'char8_t': undeclared identifier when compiling e.g. cli_ure/source/climaker/climaker_app.cxx (i.e., in /clr mode). This is similar to the VS 2019 16.11.30 /clr issue discussed in the commit message of 5a40abc86b94c0be5b4a252c6ab5b0b0df6e520d "Drop some newly obsolete __cplusplus version checks", just that it apparently hits with a different set of VS versions. The fix here is similar to the fix there, just conditionally disable char8_t functionality for certain VS versions in /clr mode, and keep fingers crossed. Change-Id: I8c4ed2e3d290dc1c94f329d314407a56170564f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157866 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12sw floattable: add an AllowTextAfterFloatingTableBreak compat flagMiklos Vajna
Word and Writer normally only wrap the anchor text around the split fly frame on the last page, but as <https://bugs.documentfoundation.org/show_bug.cgi?id=61594#c33> points out, Word has an allowTextAfterFloatingTableBreak compat flag that allows wrapping on all pages. Map this to a Writer compat flag for now, which affects all floating tables in the document. The mailing list thread at <https://lists.freedesktop.org/archives/libreoffice/2023-July/thread.html#90670> suggests that possibly there will be demand to control this on a per-frame level: that's not something Word supports, but we could do an OR of the two settings in the future if wanted. This is just the compat flag itself, layout still has to actually handle it. This compat flag is probably quite rare, so only write it to documents if it's true (the default is false). Change-Id: Ibc431f7dc11710926c115d8e03f760b7f0784304 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157855 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-12Make NC_ constexpr-friendlyStephan Bergmann
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr paths into a new TranslateId::getId. And demonstrate constexpr'ability by making the aCategories var in OApplicationIconControl::Fill (dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more such cases that could now be made constexpr.) Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12loplugin:unusedmethodsNoel Grandin
Change-Id: I27782fb4b912d8b0d5f19cbe296c2a3b98b2bfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12split up the backtrace implementations into separate filesNoel Grandin
Because I cannot keep what is inside what #ifdef straight in my head Change-Id: Ie986a6928df179fc0e30ca12c6d2a6866ed82078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Fix Windows x64 buildMike Kaganski
...after 6f45c0cf86b21772740bb0cafb3d462b058523f3 "cool#7318 Calc rendering acceleration" caused > sw/source/core/txtnode/fntcache.cxx(540): error C2672: 'std::min': no matching overloaded function found > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(108): note: could be '_Ty std::min(std::initializer_list<_Elem>)' > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>)': expects 1 arguments - 2 provided > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(105): note: or '_Ty std::min(std::initializer_list<_Elem>,_Pr)' > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>,_Pr)': could not deduce template argument for 'std::initializer_list<_Elem>' from 'sal_Int32' > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(98): note: or 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': template parameter '_Ty' is ambiguous > sw/source/core/txtnode/fntcache.cxx(540): note: could be 'tools::Long' > sw/source/core/txtnode/fntcache.cxx(540): note: or 'sal_Int32' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': could not deduce template argument for 'const _Ty &' from 'tools::Long' > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(88): note: or 'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)' > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)': expects 3 arguments - 2 provided Change-Id: I9af33041a81190998303aec2795fe03da7e2f119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12tdf#145832 Typo when missing objectBogdan B
Change-Id: Ifc26d17aaf3d280f4eaefb94c4ef8009c11c3bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157773 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-10-12tdf#157696 a11y: Escape commas in IAccessible2 color text attributeMichael Weghorn
The IAccessible2 text attribute specification [1] says: > These characters need to be escaped with a backslash: > backslash, colon, comma, equals, and semicolon. So adhere to this. Otherwise, the NVDA screen reader is unable to announce the text foreground or background color properly in local WIP branches of both LO and NVDA to use IAccessible2 text attributes on Windows as well. With this change in place, the backslashes are also contained in the corresponding AT-SPI attributes when using the qt6 VCL plugin on Linux. That seems undesirable there (s. e.g. the ATK text attribute spec [2] and how the Gtk variant of LO and also the gtk4-demo "Hypertext" example" expose it), but I think this should rather be handled in Qt's AT-SPI adaptor's mapping of the IAccessible2 attributes to the AT-SPI ones. Pending Qt Gerrit change implementing this: [3] (At least Orca still announces the colors just fine with the additional backslash in place, so having an extra platform-specific handling here doesn't seem to be urgent for now.) [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes#formatting [2] https://gnome.pages.gitlab.gnome.org/atk/AtkText.html#AtkTextAttribute [3] https://codereview.qt-project.org/c/qt/qtbase/+/511132 Change-Id: I51780f44930089249a769522d7130e97ac5446b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157845 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12tdf#157696 vcl a11y: Move qt's translation to IA2 text attrs for reuseMichael Weghorn
Qt expects the text attributes to be reported as IAccessible2 attributes. Therefore, there is a translation/conversion from the LO-internal text attributes to IAccessible2 text attributes in `QtAccessibleWidget::attributes`. Move the logic from the qt-VCL-specific code into a new VCL helper class `AccessibleTextAttributeHelper`, so it can be reused in winaccessibility in following commits. Change-Id: I434481faa53c74bae95cae5b2c9f0907b87fb1bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157804 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-12drawinglayer,svx: PDF/UA export: put Form SE into anchor paragraph SEMichael Stahl
This is like commit d467f1aa3d028f399826c97e2eecedcd79efcf65 and commit 6e5d59c2ca6969e9491f97cd7a00d094fc62cfb3 but for the form controls, which have their own special ControlPrimitive2D. Change-Id: I4b4ac45e81f490a7b625acd9e8753300d10bf119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157847 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-12tdf#157397 vcl: PDF export: fix CreateControl replayMichael Stahl
The problem is that the CreateLink and CreateControl actions are replayed in a different order than they are recorded, because CreateLink is a global action, and CreateControl a page action. This means that the mCurId at the time when PDFExtOutDevData::CreateControl() is called does not correspond to a position in mParaIds when CreateControl is replayed; it will be inserted too early and bump all the CreateLink ones to later indexes. Avoid this by adding another global action CreateControlLink that is added when CreateControl is being replayed, which appears to work. (Another subtle problem is that, in case of PDF/A-1, the page actions could be discarded completely; this should work in that case too.) (regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0) Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-12SwTextFly::GetAnchoredObjList never returns nullCaolán McNamara
Change-Id: Icd8a2aa356de24d977a72dc64825a03ed2f5b16d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-12COWASM-02 - Fix wasm build for co-23.05Balazs Varga
"Undeclared identifier mpParent in GetParent()" Change-Id: Ib613b2cf303b0ac50c6e899deda25d99c7e22343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157245 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 21554305046e7faeb6d64c4eea622b968db1f474) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157778 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-12Fix typos in C++ feature test macrosStephan Bergmann
...that were accidentally made in e6fe048ded34a322007547d4d31e32c598aa4993 "Some more string_view use, add o3tl::starts/ends_with" Change-Id: I06470f705d1f51f98daffabe544c0194dfc34ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-12writerfilter: clean-up PushPageHeaderFooter method impl.Tomaž Vajngerl
in addition change m_aHeaderFooterTextAppendStack to use enum PagePartType for the "second" value in pair, instead of a bool to denote if it is an entry for header or footer. No change in functionality. Change-Id: I2aa75494c9b3337dd51bf79e282291cdca9d8547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157839 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12no need for these enums in BroadcasterStateNoel Grandin
the std::variant already knows which alternative it stores Change-Id: I3838d83959cf6a97876aba3543179338ba088ccc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Update to pdfium 6060Miklos Vajna
- external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git diff' Change-Id: I9258d6d0130620523d64fcd0854c4d96fc98a4bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157846 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-12cool#7318 Calc rendering acceleration (part2)Noel Grandin
we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs, and most of that is inserting into the GlyphsCache, which has a very very large key. Shrink that key a little bit Change-Id: I6f27c147652521502dba4517afd9a2ae2a6daebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12tdf#157636 FILEOPEN: PPT: Images have no backgroundNoel Grandin
regression from commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: Ia0ed01e7c0d41bd909fe48666bc9aca5ff31d2bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-12Do not compare SwContentIndex instances from different nodesMike Kaganski
It fires an assert in dbgutil builds; and it doesn't make sense anyway: we must use the index from the beginning, not a strange minimal value between indices in start node and end node. Change-Id: I4a2b6062f5524703737ca6029f428f30555d25b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157842 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12sw: prepare tests cases for first, left, right headers and variantsTomaž Vajngerl
This prepares the test case for first, left, right headers, only first and non-first headers, only left and right (no first) headers and make them run for ODF, where they should work as expected. In a follow up commit, the OOXML implementation should be fixed so that the same tests pass for OOXML documents. Change-Id: I1e7f610324c14dd9eb285ff9d46829610de5b1b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157838 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12editeng: move the methods into Test class definitionTomaž Vajngerl
This makes makes all the Test class methods contined in the class definition body, so more readable and less noise for the actual test definitions. Change-Id: I3ea177f27aa868a396e537b1682ce91d93c1208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12change PageType (first, left, right) enum to enum classTomaž Vajngerl
Change-Id: I45bb7947266de1e18028c7ed460149c609e430b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157834 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-12tdf#138440 sc notebookbar: add right-to-left to home tabJustin Luth
The UI is pretty packed here, so for non-RTL languages having it on the toolbar would be distracting. So I decided to make it hidden - meaning a RTL user would need to customize the notebookbar to reveal it. However, adding it unconditionally to the dropdown menu is fine, so at least it is readily available there. It already existed in the paragraph menu of groupedcompact. Change-Id: Id4dc2de9c0922428fc44501c4eb2d7e3e51dea82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157851 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-12prefix some members of ImpEditEngineTomaž Vajngerl
Change-Id: I9975bed2af853374a10b87c468840ff22b230157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157833 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-11tdf#157613 make sure surface is not a null pointerPatrick Luby
Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848 Reviewed-by: Patrick Luby <plubius@neooffice.org> Tested-by: Patrick Luby <plubius@neooffice.org>
2023-10-11Drop o3tl::span, can use C++20 std::span directly nowStephan Bergmann
Change-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11drop empty accessibility descriptionCaolán McNamara
Change-Id: Ib2e4524ba668ce59ba1c5fad3e3180df396254a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11InitAnchoredObjList never returns nullCaolán McNamara
Change-Id: I01b6accc5974caaa0533c95e50aa27c78af3ae0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11__cpp_lib_char8_t is generally available nowStephan Bergmann
...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20" Change-Id: I45aa7538174a0c62ad5a4871e2914b30580546c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157827 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to e7ec227d83792bdaf88cb53be5a5a8849f7f576a - tdf#155044 Help: Description -> Alt Text and Text Alternative -> Text Change-Id: I3c8317f4b747b05c7fbbf7119f9210627aaacd48 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157643 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-11tdf#155044 Missed one Description to Alt Text spotIlmari Lauhakangas
Change-Id: I4e454b1e3966007b04d6f50acf4249b9b80f5526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157840 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-11FocusManager::IsPanelTitleVisible is deadNoel Grandin
ever since commit df2c41859287282501c8ebd7b3c67465455a457c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Sep 23 21:01:50 2023 +0200 MoveFocusInsideDeckTitle is dead Change-Id: I641622453b35526c7654c84d25d9d7c873249b43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11both branches set mpAnchoredObjList the sameCaolán McNamara
Change-Id: I0a41bc4cee141b2a375be3d84f67367ef8d7a2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-04-27 09:31:40 +0000