summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-24loplugin:unusedfields,can-be-const in xmloff(1)Noel Grandin
(*) When passing a part of a global static data to XMLPropertiesOOoTContext_Impl, just store a reference to it instead of copying (*) Simplify the OOo2OasisTransformer constructor and call sites to make the const-ness work Change-Id: I012d638cfd9266ed3514164e84b381d0d577f821 Reviewed-on: https://gerrit.libreoffice.org/57853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24crashtesting: infinite recurse with moz609361-1.svgCaolán McNamara
Change-Id: I18c2dd159dd7a64c3627abdb472d65013453b1b9 Reviewed-on: https://gerrit.libreoffice.org/57891 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24crashtesting: infinite recurse with moz384637-1.svgCaolán McNamara
Change-Id: Ia4bbc9d471c63812dc3ef490f32e8490bda72bfe Reviewed-on: https://gerrit.libreoffice.org/57888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24Fix semantic of sentenceJens Carl
Follow up of ad7d72f0381f6a16db5c6c7bee538c475c233555. Change-Id: I188e96fd9d71dce5ebd83200b9d8212e5f13b948 Reviewed-on: https://gerrit.libreoffice.org/57894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24tdf#118517: Use xStg before resetting itXisco Fauli
Regression from 0f166ef5240ee155bf2544e6bc3c985b1e3bf646 Change-Id: I083951700895a00be8d4407871c27804ca3e5f30 Reviewed-on: https://gerrit.libreoffice.org/57881 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24sw: Change TextPortions to std::vectorTakeshi Abe
as its usage does not require std::deque. Change-Id: I047e31972325a28f5ff92153e34893821e80fe57 Reviewed-on: https://gerrit.libreoffice.org/57898 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24use regular destructor for AnchorOverlayObject and ShadowOverlayObjectNoel Grandin
no need for static methods Change-Id: I8de3bf41183ef592f9c08d8d227834fa64d772fa Reviewed-on: https://gerrit.libreoffice.org/57849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwSpellDialogChildWindowNoel Grandin
Change-Id: Ib79e4672b7857aaacef15cd55c8633523df4d26b Reviewed-on: https://gerrit.libreoffice.org/57877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwAnnotationWinNoel Grandin
Change-Id: I0a4844898a85f0513da3e3fd7a977e35a9250f1e Reviewed-on: https://gerrit.libreoffice.org/57878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwInsertConfigNoel Grandin
Change-Id: I5f39956e529b98f4114139b8c3ba1391e45440ef Reviewed-on: https://gerrit.libreoffice.org/57876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in ScValidationDataListNoel Grandin
Change-Id: Icbf8eb814e7d3bd57e78d2d1a97eb44bbfd2a432 Reviewed-on: https://gerrit.libreoffice.org/57874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SfxViewFrameNoel Grandin
Change-Id: I1edd00a184d8ffab4cf327aefc4e786458ccce52 Reviewed-on: https://gerrit.libreoffice.org/57873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in ChartControllerNoel Grandin
Change-Id: I224db5ab179bfd84125617e643441fd9a2872e67 Reviewed-on: https://gerrit.libreoffice.org/57872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr fix check for DELETEZ inside compound stmtNoel Grandin
Change-Id: Id748b8b0c9cfe8c288dfafb5d0c2a83a8de2c91c Reviewed-on: https://gerrit.libreoffice.org/57871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwDBConfigNoel Grandin
Change-Id: Ibf9cdf4e09275325a876b81067245f76597ae08e Reviewed-on: https://gerrit.libreoffice.org/57870 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwModuleNoel Grandin
Change-Id: I37f4df7d309e83b3232dab8268c3b7557b259ae8 Reviewed-on: https://gerrit.libreoffice.org/57869 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwImplShellActionNoel Grandin
Change-Id: Iab0844b8ad5bbe57c4f1fb5a706bc742abf4cdb5 Reviewed-on: https://gerrit.libreoffice.org/57868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr inSwDocShellNoel Grandin
Change-Id: I9b834406b391695a18c9fdcdad9a6dd13be34c9e Reviewed-on: https://gerrit.libreoffice.org/57867 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwXMLImportNoel Grandin
Change-Id: I0c90d39c87bbd4a6edaa70b2413a64a41585a944 Reviewed-on: https://gerrit.libreoffice.org/57865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwXMLExportNoel Grandin
Change-Id: Id0354b73b0ff14b6a168b672f25483c07988494e Reviewed-on: https://gerrit.libreoffice.org/57864 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwHTMLWriterNoel Grandin
Change-Id: I67f3dd615e798f8ac865b57332f6153530d81929 Reviewed-on: https://gerrit.libreoffice.org/57863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:unusedfields,can-be-const in xmlreaderNoel Grandin
Change-Id: I762a749b858063a1c063ee918bb6d33e06328876 Reviewed-on: https://gerrit.libreoffice.org/57852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:unusedfields,can-be-const in xmlscriptNoel Grandin
Change-Id: Ibd733b822bb2eee9de6319b5ea9e4d8dd3641cdc Reviewed-on: https://gerrit.libreoffice.org/57850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24Fix variable nameAndrea Gelmini
Change-Id: I6e5bef8840730f61ca976c72a808b9ffd21fe8dc Reviewed-on: https://gerrit.libreoffice.org/57883 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-24Fix typosAndrea Gelmini
Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356 Reviewed-on: https://gerrit.libreoffice.org/57884 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-24Fix typoAndrea Gelmini
Change-Id: I2f9f532890bedf4aa3d86bf2aa4b6961846a915a Reviewed-on: https://gerrit.libreoffice.org/57886 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-24Fix typosAndrea Gelmini
Change-Id: I8758872f6a5270de3f9b9dea750b9d40c7a446db Reviewed-on: https://gerrit.libreoffice.org/57800 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-24tdf#72560 ExchangeLeftRight shouldn't use DefaultParaStyleJustin Luth
MS Word's UI is a bit confusing for RTL because the only place you can set it (at least in Word 2003) is on the Normal paragraph style - everywhere else the control is grayed out. Add a test that very specifically tests the impact of Normal style. The document does not use the "default" style at all, because the style used is based on -none-. Normal is set to RTL - does that mean that the whole document should be RTL or that Left/Right should swap? No. Parentless style provides LTR in MSWord, and thus the LO code that ExchangeLeftRight() based on DefaultStyle's bidi setting was wrong. Yes, it is determined by style/DocDefault settings, but not by DefaultStyle in particular. Change-Id: I000953e51d3d919f73aa1e97df63f266d15447b2 Reviewed-on: https://gerrit.libreoffice.org/57859 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-24tdf#72560 writerfilter: StyleProperty - also check DocDefaultsJustin Luth
Styles without parents still have inheritance - from the DocDefaults. So, make sure to check those properties too in GetPropertyFromStyleSheet() (and therefore also in GetAnyProperty). Currently, this should only impact when InStyleSheetImport(), but if the docDefaults ever find a way to naturally migrate into LO as doc defaults and not into the style itself, then this will also be useful to check for paragraph properties etc. Change-Id: Ic02cd10c104c0330684308f1380a77009206a664 Reviewed-on: https://gerrit.libreoffice.org/57805 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-07-23Fix typosAndrea Gelmini
Change-Id: If6e6df9ac592c77f19e381e50b7eb26fbf429f61 Reviewed-on: https://gerrit.libreoffice.org/57831 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: I22c02c9d4e121d3cb3b68be9a5c845e9e45cc123 Reviewed-on: https://gerrit.libreoffice.org/57603 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: Ia11646ac8f2f57225a1cf37725c5e0742a8489d9 Reviewed-on: https://gerrit.libreoffice.org/57605 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: I1cc2b1f63326d1d0e1f6e452b93af11e59a2d674 Reviewed-on: https://gerrit.libreoffice.org/57799 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef Reviewed-on: https://gerrit.libreoffice.org/57822 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23crashtesting: infinite recurse with moz455984-5.svgCaolán McNamara
Change-Id: Idef368c44454ae144b091132cd0d6103f92a6dde Reviewed-on: https://gerrit.libreoffice.org/57854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-23Notebookbar: Now no white background is visible behind areafillstyleKshitij Pathania
Change-Id: Ida903be094861991fe36792caa9a6b75738e4f15 Reviewed-on: https://gerrit.libreoffice.org/57847 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-23Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Fix a typo found by Andrea Gelmini -reformatting part Change-Id: If12a0361a9b47878b7df0f562154931437e59fc6 Reviewed-on: https://gerrit.libreoffice.org/57827 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-23uitest for bug tdf#65686Zdeněk Crhonek
Change-Id: I4c50618d0f570978873c13c9e503d5c3d32f9f9d Reviewed-on: https://gerrit.libreoffice.org/57830 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-23Missing includes (--disable-pch)Stephan Bergmann
Change-Id: Ie3427dfbbdf6ecf96b4fc36c534022dc881b3957
2018-07-23Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I1a926f45510e18cf399aa2eb7e1bf0ad8f4f0226 Reviewed-on: https://gerrit.libreoffice.org/57836 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-23tdf#118760 Inconsistent label "Select font scripts to embed"heiko tietze
Fixed also alignment and accelerator issues Change-Id: I3182b98a793ebc3d2e9d11975842bf7aac010d7c Reviewed-on: https://gerrit.libreoffice.org/57848 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-23Qt5 just release the SolarMutex for Qt eventsJan-Marek Glogowski
Just like the other backends, just release the SolarMutex when processing Qt events and keep it for user events. Change-Id: I0c4a7149f1541607b546a99e51e790836bc9b2f9 Reviewed-on: https://gerrit.libreoffice.org/57844 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-07-23Fix typosAndrea Gelmini
Change-Id: I9671ad7c9e75b9e10abf46bc6b53fcd760acecbf Reviewed-on: https://gerrit.libreoffice.org/57599 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-23tdf#118716 Inner border of an embedded table can't be dragged aroundNoel Grandin
regression from commit f14b9d30293f180500fc56d81e5390021758e7c1 convert (a>b?a:b) to std::max(a,b) In this code int a; std::max<sal_uInt16>(a,0) std::max will first convert a and b to sal_uInt16, therefore potentially converting a negative number to a positive number due to the conversion rules. Then it will take the larger number. While this code int a; static_cast<sal_uInt16>(a > 0 ? a : 0) will compare first, and then convert the larger number to sal_uInt16, which might result in making a "a" that is larger than 2^16 into a smaller value, but which will never convert a negative "a" value into a positive value. Change-Id: Id4f6df0089b1a74ea4ac1c5d05655e7c1d8f0c7f Reviewed-on: https://gerrit.libreoffice.org/57846 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23Fix typos of commit 26f1fc7Andrea Gelmini
Thanks to Noel Grandin and Juline Nabet Change-Id: Ie12c7bd7e2b6c6a1f2c3e7173f11a84f19137568 Reviewed-on: https://gerrit.libreoffice.org/57851 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23crashtesting: ooo72057-1.docNoel Grandin
fallout from commit 65e41592a650887c pass SvStream around by std::unique_ptr The backtrace where it was was freeing the SvStream we need is below, the code seems dodgy because it is re-creating the underlying SvStream. Before 65e41592a650887c, it just leaked the SvStream. 0 SvStream::~SvStream() at tools/source/stream/stream.cxx:369 1 SvFileStream::~SvFileStream() at tools/source/stream/strmunx.cxx:300 2 SvFileStream::~SvFileStream() at tools/source/stream/strmunx.cxx:298 3 std::default_delete<SvStream>::operator()(SvStream*) const 4 std::unique_ptr<SvStream, std::default_delete<SvStream> >::reset(SvStream*) 5 std::unique_ptr<SvStream, std::default_delete<SvStream> >::operator=(std::unique_ptr<SvStream, std::default_delete<SvStream> >&&) 6 SfxMedium::GetMedium_Impl() at sfx2/source/doc/docfile.cxx:2603 7 SfxMedium::GetInputStream() at sfx2/source/doc/docfile.cxx:3329 8 ImportExcel8::ReadBasic() at sc/source/filter/excel/excimp8.cxx:391 9 ImportExcel8::PostDocLoad() at sc/source/filter/excel/excimp8.cxx:425 10 ImportExcel8::Read() (this=0x4727a10) at sc/source/filter/excel/read.cxx:1298 11 ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) at sc/source/filter/excel/excel.cxx:142 Change-Id: I4fb769a7da71ef9a27ddef1581448efb3d303bde Reviewed-on: https://gerrit.libreoffice.org/57843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-23HandleIIOpCode: testing for ForceArray is not sufficientEike Rathke
There are also other "force to array" context modes in which a range reference does not result in an implicit intersection. Change-Id: I3f4d85f73ecde5bbf9f011deeac2936d5f43949b
2018-07-23Fix typosAndrea Gelmini
Change-Id: I4bb060a6a65ca27bba8d16c268660bedef8b0ed5 Reviewed-on: https://gerrit.libreoffice.org/57821 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23make some fields in StgCache privateNoel Grandin
Change-Id: Ia44131f2ebee0c162b05c8019cf3600181aea5e0 Reviewed-on: https://gerrit.libreoffice.org/57842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ie28001cf1eb5259f479caecdfb50355f98b80b7f
generated by cgit (git 2.34.1) at 2025-02-19 19:44:17 +0000