summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-14optimise SfxFilterMatcher::GetFilterForProps a littleNoel Grandin
- avoid repeated construction of SequenceAsHashMap - avoid construction of OUString Change-Id: I62560dad26d3433e7c379669da437261b5fe0238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 789bc6e2c10536e5a876c5c4fb0126dbffe4dcbf - Bump Prism.js to 1.28 + Add SQL coloring syntax Change-Id: I3a68a54dee211d791da72b459647315395e17658 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134326 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5c82eb12e524d454c02798994d08d50548c9734c - Fix bad filename and links in Query Desing Help page + Remove internal links that breaks reading comfort. Change-Id: Ic417bfa2dd8f2b904575d69e6d3e98f0b8a8ce37 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134324 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Ic5163d9b570b907c6e7c840a8f6cc9dc73a8f958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134270 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 5cc5cbc6aefae06f547529bc0d417e14dc486fc4 - Fix typo Change-Id: Ia62d016ffacbeb4a9cac6a27f52843432c29e755 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: I1454a649ab434fe4d34a181bc572472a2784c1df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134321 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: If7581fbc808b985cbf6d81a2e66571ddc465f16e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134320 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Ib0913aef00cd252d3f082ec5e8b39064df63a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134319 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14simplify initialisation in ToolBarManager::CreateControllersNoel Grandin
Change-Id: I2e876f0bff180e569394e2fe3c102b658a55d170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14use more string_view in getNameNoExtensionNoel Grandin
to avoid some allocation Change-Id: Ic8d42af03a4ffd15414e3458b5b08e04ded43114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14cheaper to let Any do the comparison in isSubSetNoel Grandin
rather than constructing temporary OUStrings Change-Id: Ibb083e3fab8a465ae5288359424b297faac83617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14elid some OUString construction in SmXMLExportWrapper::ExportNoel Grandin
Change-Id: Icc091a7fab3c9ce368bd45536de1e75d29431c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14bypass some unnecessary wrapping in Any in SfxEvents_ImplNoel Grandin
Change-Id: I96d1194253207642e7abe83b0b18c82eb3782824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14Add extended tips for Direct SQL dialogOlivier Hallot
Change-Id: I0b46222ed60084544d6271fba258f02955baaa0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134295 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a6b0ba3babd4f6ed7aa55d9ccd85361970857977 - tdf#149086 Fix Help page for Direct SQL command Add target bookmark Update page content with latest UI enhancements Change-Id: I88ec6bf787d7e4bb5df24b8e1652e5f176afdbf9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134296 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-05-14Bump directsqldialog.ui to latest Glade versionOlivier Hallot
No changes in dialog. Change-Id: I478e43aadd5c92363a514e32245a17cbabd17da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134294 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-14Only obtain these after trying the cacheMike Kaganski
Change-Id: Ia1ce426bb4734b669e3715776561cb94a1c6292f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134192 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-14require libmwaw >= 0.3.21Luboš Luňák
File writerperfect/qa/unit/data/writer/libmwaw/pass/ScriptWriter_1 causes CppunitTest_writerperfect_writer to fail here with 0.3.20. Change-Id: Id5e66b7c4531287357502b7b5ff7880af7186016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134306 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-14pass-by-value in TaskManager::MyProperty::setValueNoel Grandin
cheaper to move a temporary from some call-sites rather than copy-construct Change-Id: Ic1f994d0253c8368548295a08e83dfbbfae0a008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134307 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14reserve space in map in ZipFile::readCENNoel Grandin
Change-Id: I4d7764f00b7d05ba5d43a3fb35596f5ec4653da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14cache some OUString in GetEnglishSearchFontNameNoel Grandin
rather than allocating them repeatedly Change-Id: Ie0f751f589b512a97534d193e1401312ae2f2afe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14reserve space in vector in ImpEditEngine::CreateTextObjectNoel Grandin
Change-Id: I4fd49ab81808b3912445b4037a50a5cd85c74144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14Partially resolve: tdf#149010 rename section "Names" -> "Accessibility"Seth Chaiklin
Change-Id: I2f9f38ae79f0f05b42e6f209d504c5f8a5896ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134182 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Iebbecfbd395aa001d82dc00c7ef9b9587b4755fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134048 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-05-14elide some OUString construction in GetViewSettingsAndViewsNoel Grandin
Change-Id: I4d0e6444e939731e9b109f961d36d9a2b8f00d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14skip some SetResizeProtect work during constructionNoel Grandin
unnecessary to do all the work of firing ActionChanged etc at this stage Change-Id: I20aad96e16d7a1ae5176e868d3699080aa0bf6a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14pthread_mutex_t->std::mutex in lookupThreadIdNoel Grandin
Change-Id: Ic9dfcfef5c604e778dfe527d627137042c8deb49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14osl::Mutex->std::mutex in framework::GateNoel Grandin
Change-Id: I72f0ed62a65dbd487a29f409d1941a50cecb894f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14use std::mutex in LocalProcessFactoryNoel Grandin
which much faster than osl_Mutex, and especially for this simple case Change-Id: I4e8ba221649587af76c7f7cac5f308821490980a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14use more string_view in ooxNoel Grandin
Change-Id: I7c6d201cfbfb577ef53e685df245997e5ec8f134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14simplify constructionNoel Grandin
Change-Id: Ib8a28575fe813a909ce5429732a60ae77f92b6ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14less OUString construction in SfxDocumentMetaDataNoel Grandin
rather than calling createFromAscii all over the places, just start out with the values as OUString Change-Id: I7f051fcf9fcbd9555462fa721c76dc867a84a706 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14elide temporary OUString in SvXMLExport::initializeNoel Grandin
Change-Id: Ibf1b99042ccae1fcf5fb21ab7e60bb30a9ad74f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14use comphelper::WeakComponentImplHelper for TerminateDetectionNoel Grandin
Change-Id: I6184bdef7b487f71549cd50c96c764a93ef791de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-13std::mutex->std::recursive_mutex in SvtUserOptionsMike Kaganski
Since commit ac511d90cdf9d28eb8809c30be9fa08b42ea0bd3 Author Noel Grandin <noelgrandin@gmail.com> Date Thu Dec 23 19:42:19 2021 +0200 osl::Mutex->std::mutex in SvtUserOptions non-recursive std::mutex is used. However, it looks like recursive locking is possible here, as shows the debugging that I made during the work on https://gerrit.libreoffice.org/c/core/+/134251. The call stack looks like this: utllo.dll!SvtUserOptions::GetToken(UserOptToken nToken) Line 318 utllo.dll!SvtUserOptions::GetLastName() Line 294 sclo.dll!ScChangeTrack::ConfigurationChanged(utl::ConfigurationBroadcaster * __formal, ConfigurationHints __formal) Line 2166 utllo.dll!utl::ConfigurationBroadcaster::NotifyListeners(ConfigurationHints nHint) Line 85 utllo.dll!utl::detail::Options::ConfigurationChanged(utl::ConfigurationBroadcaster * __formal, ConfigurationHints nHint) Line 112 utllo.dll!utl::ConfigurationBroadcaster::NotifyListeners(ConfigurationHints nHint) Line 85 utllo.dll!SvtUserOptions::Impl::Notify() Line 251 utllo.dll!SvtUserOptions::ChangeListener::changesOccurred(const com::sun::star::util::ChangesEvent & rEvent) Line 116 configmgrlo.dll!configmgr::Broadcaster::send() Line 168 configmgrlo.dll!configmgr::Access::setPropertyValue(const rtl::OUString & aPropertyName, const com::sun::star::uno::Any & aValue) Line 714 utllo.dll!SvtUserOptions::Impl::SetValue_Impl<rtl::OUString>(UserOptToken nToken, const rtl::OUString & sToken) Line 183 utllo.dll!SvtUserOptions::Impl::SetToken(UserOptToken nToken, const rtl::OUString & sToken) Line 200 utllo.dll!SvtUserOptions::SetToken(UserOptToken nToken, const rtl::OUString & rNewToken) Line 325 test_sc_subsequent_export_test.dll!ScExportTest::testTrackChangesSimpleXLSX() Line 3072 ... So getting the token may happen during notification of the listeners after setting the token, in the same thread. So let's use recursive mutex. Change-Id: I9be82f307a9948bcbc76d7d90632a0307c5dc4f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134190 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-13tdf#149074 SvHeaderTabListBox not handling lack of preset column widths wellCaolán McNamara
Change-Id: Ibd33fe5c5168850eca1bdc7242afc38ed08b5fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d9880014fd80f412d10b2f7536c45941552c4760 - Fix YouTube display for Help online/offline + Enhance button CSS display + Refactor XSLT + Refactor XHP Change-Id: I58e46c31a97ad49eb25a4489994aae5dac62dbc3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134207 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-13Related: tdf#148197 gtk_tree_view_scroll_to_cell needs either path or columnCaolán McNamara
so a null path is invalid here Change-Id: I1958e9695e3290e0c513bce89c9548908860754f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-13Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 11bafb045eecef25e05dca0dbc1f693410812056 - Fix bookmark semicolon Change-Id: Ie36fce4ad7aed7908cd66449044ccc3acf812576 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134285 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-13make ScSortedRangeCache-based queries work with mbMatchEmptyLuboš Luňák
Change-Id: Ifc8195222568184dc4f337b23f00e315e22febe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134218 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-13officecfg,stoc: allow running JVM UNO components out-of-processMichael Stahl
The problem is that 32-bit Win32 applications have very little VM, and soffice.bin can run out, so try to move the JVM to a separate process (uno.bin) and connect to it via pipe. Add a new config to enable this: "org.openoffice.Office.Java/VirtualMachine/RunUnoComponentsOutOfProcess" If enabled, ServiceManager instantiates *all* JVM components out-of-process, by instantiating "com.sun.star.java.theJavaVirtualMachine" out-of-process. To ensure that the remote connection is disconnected at shutdown (and thereby prevent crashes with remote calls during late shutdown), JavaComponentLoader is now a "single-instance" service; this change should be harmless for the default in-process configuration case. Tested with these extensions: Wiki Publisher smoketest TestExtension.oxt odk CalcAddins.oxt Inspector.oxt ToDo.oxt Also passed "make check" on Linux when enabled, if the variable URE_BIN_DIR is set properly for CppunitTest_services. Change-Id: I76bf17a9512414b67dbd20daee25a6d29c05f9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133218 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-13CppunitTest_sc_uicalc: simplify code a bitXisco Fauli
Change-Id: I65f32c3f308f7ac9a416026efaf0648ff6457ddc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134272 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-13tdf#148863: sc_uicalc: Add unittestXisco Fauli
Change-Id: I15e692ed42445821e8fa65c955916c43f58072e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134271 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-13Add mold linker temp files to .gitignoreIlmari Lauhakangas
Change-Id: I8c3d27cae524b30be601cefb78dca9c4139b2602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134263 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-05-13sw content controls, dropdown: add an initial properties dialogMiklos Vajna
- read the doc model: show if a content control is a placeholder or not - work with a shared pointer in the dialog, which avoids lifetime issues in case the content control we edit in one view gets deleted in an other view - write the doc model: set the placeholder mode of the content control based on the checkbox state and mark the doc as modified if any widget is touched when pressing OK - handle command state: allow this dialog only inside content controls Change-Id: Ie0b9075ccd3450dd403cc7f8bbf93fc04de3b234 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134278 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-13Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 9567d477807671d7fe5b8379b13cbace2b9a0f22 - Document new CompactLeft and CompactUp methods from the Calc service Change-Id: I6bc2a4d80fb94f7158c60e107252e112cee83c44 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134073 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-05-13use vector as backing for stackNoel Grandin
which is a little faster Change-Id: Id086b67eba3ec00dc86a48a0fdec1a467b600d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-13tdf#121740 cheaper to clear namespacemap rather than allocatingNoel Grandin
a new one Change-Id: I413de3a61744400f5582f7e090c161ea21bf0b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-13tdf#142261 EMF+ Add support for Miter LimitBartosz Kosiorek
With this commit the Miter is properly implemented, according to [EMF-PLUS] documentation: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-emfplus/5ef071f3-f503-4f16-b027-7c4bcf2d1d81 The formula for stroke miter limit is described here: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit Change-Id: Ida87063cc045460e61ffae118f64cf133c810dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134164 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-05-13Advanced Diagram support: Secure Redo, evtl. flush Redo-StackArmin Le Grand (Allotropia)
Change-Id: Iade4ea85289377774e51671f1e9848c19d757633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134245 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>