summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-27tdf#99469 remove obsolete BlockList.xml entriesAndras Timar
Change-Id: I88bd4777e973b43edfc7e6d1123cef5c6bb2d7ea Reviewed-on: https://gerrit.libreoffice.org/62423 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-10-27tdf#120703 PVS: variable is assigned values twice successivelyMike Kaganski
V519 The 'aToken.aText' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1147, 1163. Change-Id: I9bcb9a302a182932d7b15f25ee64005158d50a46 Reviewed-on: https://gerrit.libreoffice.org/62422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120703 PVS: variable is assigned values twice successivelyMike Kaganski
V519 The 'mbDesignMode' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 731, 737. Change-Id: I20cb70e050f194e7ab02de92dff4db35cade7386 Reviewed-on: https://gerrit.libreoffice.org/62421 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27pocheck: don't choke on plural formsChristian Lohmaier
Change-Id: I51a82ce5fc09d44ebc6f7c06c67b475ee2adf68b Reviewed-on: https://gerrit.libreoffice.org/62419 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2018-10-27tdf#120703 PVS: V519 variable is assigned values twice successivelyMike Kaganski
V519 The 'm_nFetchDirectionPropertyHandle' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 489, 493. It was this way since 2000 (commit d3329bacd8a925ec070ad06ea3d9a6a026a3696b) Change-Id: Ia6ade4355bbfac799f8b32069f27a0c439300030 Reviewed-on: https://gerrit.libreoffice.org/62414 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120703 PVS: V530 The return value of function is required to be utilizedMike Kaganski
Change-Id: Ifc170a45e25b3fd5b7f561cc50afb6452bb359bd Reviewed-on: https://gerrit.libreoffice.org/62420 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for master and force-fix errors using pocheck Change-Id: Ib2c4218faaa153151595024d052cc93d32037d4b
2018-10-27uitest: integrate the calc input bar into the ui testingMarkus Mohrhard
Change-Id: Ib73d09b648c0663de57e4b205e7154d6af1366f8 Reviewed-on: https://gerrit.libreoffice.org/62412 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-27tdf#120703 PVS: V524Mike Kaganski
V524 It is odd that the body of 'GetRef2' function is fully equivalent to the body of 'GetRef1' function. Was that way since 2007 (commit 6002b49955c75135489a4f2af0eab14eaeaaf31b) Change-Id: Iff75ebafd13ce47c23c80be8bc6b5995954b524f Reviewed-on: https://gerrit.libreoffice.org/62415 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120906 - Option to use Header/Footer not working correctlyheiko tietze
Now with storage capabilities too Change-Id: Iaf9050b38ce356d80c26f339caf61267c1fb3c3b Reviewed-on: https://gerrit.libreoffice.org/62360 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2018-10-27tdf#120703 PVS: V519 variable is assigned values twice successivelyMike Kaganski
V519 The 'hResult' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1097, 1098. Change-Id: Ib6f9c3467578ebc68b3a15f8dbea4054af45707d Reviewed-on: https://gerrit.libreoffice.org/62411 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120703 PVS: V519 variable is assigned values twice successivelyMike Kaganski
V519 The 'aNewTextBoundingBox.Y2' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 409, 411. I have tried to check if that could possibly be a typo, and X1 was meant, but it seems to be not the case here (doing that, or putting anything to X1 instead of 0, just displaces the notes in the presenter console wrong vertically). Change-Id: Ie686b69bddc193568c1b5c0d18b9b7bf547313d1 Reviewed-on: https://gerrit.libreoffice.org/62410 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120703 (PVS): V519 variable is assigned values twice successivelyMike Kaganski
V519 The 'xFontCharMap' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1673, 1674. Change-Id: I008c268bd2440e489d4cd50f94b4f04129589448 Reviewed-on: https://gerrit.libreoffice.org/62408 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120856 sync shape, graphic, frame and ole contect toolbarandreas kainz
in writer and calc Change-Id: I36458c27027748c790a5e6ef768fcd19986b656d Reviewed-on: https://gerrit.libreoffice.org/62336 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-27use comphelper::SequenceAsHashMap to avoid manual iterationJustin Luth
Thanks for the suggestion Miklos Change-Id: Ie37259a1f05919fa50194afde7171efbe5473771 Reviewed-on: https://gerrit.libreoffice.org/62409 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120453 Preserve literal '&' in Qt menu textsMichael Weghorn
As described in the QMenuBar documentation, a single ampersand in a menu item text is used to set the shortcut for the menu, while "&&" is used to get a real ampersand character. Change-Id: Idf510641c8919ff8223114413851cb3ee7d7b4a2 Reviewed-on: https://gerrit.libreoffice.org/62405 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-10-26tdf#120861 move paste special to a submenu in menubarandreas kainz
Change-Id: I4b6a2eb32ff155855bb9e5d1638f7239252278f3 Reviewed-on: https://gerrit.libreoffice.org/62301 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-26fix build --without-java - CppunitTest_dbaccess_tdf119625 uses hsqldbChristian Lohmaier
introduced with 4d7dd4e1e4e072db8bcfe4d52b8c185187353e74 Change-Id: I118b6185fc01b2234d2a20da76b0e19929f9812a
2018-10-26tdf#119719: Move the window to the requested screenKatarina Behrens
According to Qt doc, setScreen by itself is ineffective and this additional step is needed. It still wouldn't work w/ dual screen on older KDE Plasma (<= 5.12) but tests positively in GNOME and Plasma 5.13.5 Change-Id: I080b6f93aa3c21411f606ade6df42e9bc3f6f299 Reviewed-on: https://gerrit.libreoffice.org/62351 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-26oox smartart, linear layout: take horizontal position from constraintsMiklos Vajna
Both horizontal size and position looks sane now. Change-Id: I6f040e4f0ff49be74420fafc4bcc5e899b6e94f7 Reviewed-on: https://gerrit.libreoffice.org/62397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-26elementary+KJ: Fix for tdf#120918Rizal Muttaqin
Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc6 Reviewed-on: https://gerrit.libreoffice.org/62392 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-26oox smartart, linear layout: take width from constraintsMiklos Vajna
Finally the "parent text" of the test document now has correct width. Change-Id: I05c552dda66ad91f19cfc335b464549920269f69 Reviewed-on: https://gerrit.libreoffice.org/62395 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-26unopkg: Make logging to default location work againSamuel Mehrbrodt
Change-Id: Ie0b476164b370f58e0b220cee56ed52896753ade Reviewed-on: https://gerrit.libreoffice.org/62394 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-26unopkg: Log deployment output with the same logger as unopkgSamuel Mehrbrodt
This prevents overwriting the existing logfile by using the same logger as unopkg does. Change-Id: Iaad4c5b99a4f428d3a4ad8a046c88404aecb5652 Reviewed-on: https://gerrit.libreoffice.org/62393 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-26unopkg: Write to console when no UNO availableSamuel Mehrbrodt
Change-Id: I159b7e85f53e33c5359cca83aa958387d888f6a2 Reviewed-on: https://gerrit.libreoffice.org/62391 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-26Use CheckStringResultLen() also for CONCATENATE(), CONCAT() and TEXTJOIN()Eike Rathke
Change-Id: Ifbc2b127998e037be3f014bebf8721bef15ef53b Reviewed-on: https://gerrit.libreoffice.org/62385 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-26LibreLogo: support backslash escape sequence for apostrophesLászló Németh
(ASCII and typographical) and for enclosing quotes of string literals. Change-Id: I3caf3b707afa1fb41ba3afe9ff12ebce7ce63847 Reviewed-on: https://gerrit.libreoffice.org/62384 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-26missing includeStephan Bergmann
Change-Id: I57dfc006d849918179a2398ef22be7585cb0993f
2018-10-26Let REGEX() return #N/A instead of #VALUE! if no match, tdf#113977 follow-upEike Rathke
So match can be checked with IFNA(REGEX(...);...) and IF(ISNA(REGEX(...);FALSE();TRUE()) Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc5 Reviewed-on: https://gerrit.libreoffice.org/62386 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26Don't read past end of string in Guess ctorStephan Bergmann
<https://ci.libreoffice.org//job/lo_ubsan/1082/>: > ==26422==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000accc72 at pc 0x2ae43e63f4b6 bp 0x2ae43e600510 sp 0x2ae43e600508 > READ of size 1 at 0x604000accc72 thread T70 (cppu_threadpool) > #0 0x2ae43e63f4b5 in Guess::Guess(char const*) /lingucomponent/source/languageguessing/guess.cxx:95:28 > #1 0x2ae43e667f2f in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:169:19 > #2 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12 > #3 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24 [...] > 0x604000accc72 is located 0 bytes to the right of 34-byte region [0x604000accc50,0x604000accc72) > allocated by thread T70 (cppu_threadpool) here: [...] > #7 0x2ae43e65350a in std::string::operator+=(char const*) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/bits/basic_string.h:3355:16 > #8 0x2ae43e667e6e in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:168:21 > #9 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12 > #10 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24 [...] shows, during UITest_librelogo, the Guess ctor making wrong assumptions about the structure of guess_str and skipping over the terminating NUL. Locally I could see that while most inputs do have the expected syntax of starting with "[" and containing two "-", one input is indeed just "[haw-utf8" without a second "-". I don't know where the strings passed into the Guess ctor in the two places in lingucomponent/source/languageguessing/simpleguesser.cxx ultimately come from, and what their guaranteed syntax and their semantics is. So from the existing code and the non--well-formed "[haw-utf8" sample (where the second segment shall apparently designate an encoding, not a country), construct rules how to robustly parse any input into potential language/country/encoding parts. (What is obvious from the call sites is that for one each input will start with "[", and for another the item to parse need neither be "]"- nor NUL-terminated.) (Guess::encoding_str and the local enc variable have effectively been unused ever since the code's introduction in 0762811922c4e1a3474bdd91daf308baafbc18e4 "INTEGRATION: CWS languageguessing". Guess::encoding_str, but not the local enc variable, got later removed with b275246c30ce3796cd22f72cd82c58b5cf4c86f0 "loplugin:unusedfields in formula..registry".) Change-Id: Icbedc05ed5b119ee4efbc3118cc17076a4d80c74 Reviewed-on: https://gerrit.libreoffice.org/62390 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-26Towards solving tdf#120747: Remember the preview file of personaMuhammet Kara
Change-Id: I9230421a98ea5d1ec61bf1500b24949635db68d3 Reviewed-on: https://gerrit.libreoffice.org/62387 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-26use unique_ptr when Clone()'ing PoolItemsNoel Grandin
and fix a handful of small leaks in the process Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c Reviewed-on: https://gerrit.libreoffice.org/62389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26loplugin:singlevalfields improvementNoel Grandin
look for any kind of types, not just POD types, helps to find smart pointer fields that are only assigned nullptr Change-Id: I2d887e98db012f03b646e1023985bcc196285abc Reviewed-on: https://gerrit.libreoffice.org/62382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26loplugin:unusedfieldsNoel Grandin
Change-Id: I36d3e874aac2d57d4e6f24a0e89c9836704bb7a6 Reviewed-on: https://gerrit.libreoffice.org/62383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26Introduce SimpleTextFormatter and format unopkg output using itSamuel Mehrbrodt
This will write log messages as plain text (no timestamp and other stuff like PlainTextFormatter). Warnings and errors will be prefixed accordingly. Change-Id: Id82512d7dd3907a4c7cd69a963a375966189dc20 Reviewed-on: https://gerrit.libreoffice.org/62370 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-26Log unopkg errors to log file if requestedSamuel Mehrbrodt
Before only the output generated by extension add/remove/... functions were logged to file, but not the error messages of unopkg itself. Change-Id: I4451aa51e2877ae48c453ee4791e36d970832567 Reviewed-on: https://gerrit.libreoffice.org/62369 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-26oox: remove dead QuickDiagrammingImportMiklos Vajna
This would create a com.sun.star.drawing.DiagramShape, and work with that, but nobody implements such a service. Change-Id: I32a63dd258a5f168e37c5926a832dadd45c2b179 Reviewed-on: https://gerrit.libreoffice.org/62371 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26LibreLogo: add unit tests for program compilationLászló Németh
from LibreLogo to Python Change-Id: I39df100a13efe3573b33cb856701cbeb0d95954d Reviewed-on: https://gerrit.libreoffice.org/62364 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-26Fix typosAndrea Gelmini
Change-Id: I537871602282f85f2947f91f9b579b0e8cf12fe8 Reviewed-on: https://gerrit.libreoffice.org/62378 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-26tdf#120888 Use event notify resultJim Raykowski
Change-Id: Ic85f7182b66f9f5c31b612e5a93299496e874fc0 Reviewed-on: https://gerrit.libreoffice.org/62381 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-26Change kScInterpreterMaxStrLen now result string length limit to 256MBEike Rathke
This is arbitrary. Change-Id: I88875e674464984c174e27fa6038080cc7366ecf Reviewed-on: https://gerrit.libreoffice.org/62375 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Use SAL_MAX_INT32 in CheckStringPositionArgument()Eike Rathke
... as that does not affect the result string length. Change-Id: Ia4426b4444845b3966da6a8c46089d8a98a38cb0 Reviewed-on: https://gerrit.libreoffice.org/62374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Introduce kScInterpreterMaxStrLenEike Rathke
... and use that instead of SAL_MAX_UINT16 where string operations are involved. Change-Id: I41248bc1a876c19cd917269e44a6e91f51e569f5 Reviewed-on: https://gerrit.libreoffice.org/62373 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26Rework GetStringPositionArgument() to return sal_Int32Eike Rathke
... and set FormulaError::IllegalArgument for illegal values. Change-Id: Iaf4c5123a3290ee1860d16fcf270e8c2a2e0845f Reviewed-on: https://gerrit.libreoffice.org/62372 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-26tdf#120907 Arrow keys don't work in palette listMaxim Monastirsky
For a docking window which reparented to a floating window via DockingManager, Window::GetParent() won't find the floating window, because WindowImpl::mpRealParent points to the previous parent (e.g. the toolbar). What we need is to check WindowImpl::mpParent instead. Change-Id: Ibdc5e29b7b8db37f9cbea65b3d7fbe39de334319 Reviewed-on: https://gerrit.libreoffice.org/62361 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-25use "range for" to iterate through certificatesTomaž Vajngerl
Change-Id: Ife206ab29f2f8eaa2358f45e6bae2290d95fd4d6 Reviewed-on: https://gerrit.libreoffice.org/61779 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-25Support to sign a document with a specified signatureTomaž Vajngerl
Change-Id: I92e392b315c9217b63db830dea1b2e91387b56c2 Reviewed-on: https://gerrit.libreoffice.org/61778 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-25Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - tdf#120221 Add experimental note Change-Id: I591c7ef34a84059060a7eeeff15ad2f7b6cc58ae Reviewed-on: https://gerrit.libreoffice.org/62365 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-10 03:37:24 +0000