summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-01(blind) fix of 'ERROR: Source for LICENSE.html not found!' on macOSAndras Timar
Change-Id: I0f87d96691281e773b48ab11380c0dfa3a65ebba Reviewed-on: https://gerrit.libreoffice.org/70083 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-01Add XServiceInfo tests to ScSubTotalDescriptorBaseJens Carl
Change-Id: I1460f6f205bab736d4107675b05cec5654fdb673 Reviewed-on: https://gerrit.libreoffice.org/70042 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01Revert "Restore original $licensepath of the optional EULA of MSI package"Andras Timar
This reverts commit c2f121842edcfba060c46343d78d4ef4c28b6249. Change-Id: Id4c8a0311e93cb5befd61abccfe994750a67df22
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Resolves: tdf#123175 don't use NWF to draw buttons with an overridden bgCaolán McNamara
Change-Id: I434f476f62c5c754d96eeb0cb9ad7c0b8d38ccec Reviewed-on: https://gerrit.libreoffice.org/70069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Add Rows() method to ooo.vba.excel.XApplicationTor Lillqvist
Change-Id: I7e1d83539153eede300b2b24f2fa6796859d299c
2019-04-01tdf#122926 FILEOPEN ODT Slower compared to the pastNoel Grandin
on my machine, this takes the time from 12.3s to 8.9s Change-Id: Ibdc7e3c34d1acb0d1f7f784720552fa6c7977fa5 Reviewed-on: https://gerrit.libreoffice.org/70074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-01Use "Visual C++ ATL (x86/x64) with Spectre Mitigations" if availableAndrés Maldonado
Change-Id: Iab63cf16f8c12c8148a8ac7eaea68007d4c27f23 Reviewed-on: https://gerrit.libreoffice.org/69891 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-01sc lok: avoid save incorrect data, whether the pane has ...Henry Castro
horizontal / vertical splits In the tiled rendering case the horizontal / vertical splits were not implemented, so the leftmost visible column is 0. So preserve horizontal / vertical splits when saving the document Change-Id: I15b6f009910e51fdaf475de5aac1ebded16c1956 Reviewed-on: https://gerrit.libreoffice.org/69926 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-04-01tdf#115192 XLSX export: fix hyperlink inserted to shapetundet
Hyperlink inserted to shape didn't work after export, because the LO wrote TargetMode="External" code incorrectly in the xml. test_115192.xlsx: Test file from Excel 2016. Change-Id: I3a9d39c1aa5de5af6d1ca43d16c45a5401ec6f3d Reviewed-on: https://gerrit.libreoffice.org/69915 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-01weld ScSolverProgressDialogCaolán McNamara
Change-Id: I5ee081b1c9e542a2b717b4eb27ee0aba7331d57d Reviewed-on: https://gerrit.libreoffice.org/70071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSubTotalDescriptorBase. Change-Id: I7fbfd244a9777b256098a1a7b8d3b2577cb71ebe Reviewed-on: https://gerrit.libreoffice.org/70041 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01Resolves: tdf#124411 default dnd to MOVE for internal and COPY for externalCaolán McNamara
which what the macosx version appears to also do Change-Id: Icff9cada2c821544d0130e28cc3e3862154a57dc Reviewed-on: https://gerrit.libreoffice.org/70063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Avoid "Text Import" dialog if invoking Paste() from OLE AutomationTor Lillqvist
Excel does not show such a dialog in that case either. At least not in the customer use case. Possibly we could try to be clever and sniff the string to see if it seems to use defaults, like TABs as separators, and if not, then show the dialog? Change-Id: Ib12b628eee25273aa489dbbd86004167ca105c0b
2019-04-01IShellLinkA -> IShellLinkWMike Kaganski
Change-Id: If07d7e0d2a3a33f0bcc96352ea40ff83a2f483ed Reviewed-on: https://gerrit.libreoffice.org/70062 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01Resolves: tdf#124440 nospin has no subeditCaolán McNamara
Change-Id: I4e801ec234e86be935a79c9e29f0e5091904f12e Reviewed-on: https://gerrit.libreoffice.org/70052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01use drawing area font for previewCaolán McNamara
Change-Id: Ibebf128c1db3a3bfb59c47624e16e6bf2d47b652 Reviewed-on: https://gerrit.libreoffice.org/70051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#124413 Crash on undo / redo in Basic IDENoel Grandin
regression from commit 3a9d3f271c445641bebd057c4c91279f9b3cd7d5 Date: Mon Apr 23 09:38:41 2018 +0200 loplugin:useuniqueptr in TextDoc Change-Id: I51ab5de7571e4ec358442e54d590adf88fbeb12d Reviewed-on: https://gerrit.libreoffice.org/70061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-01weld SwAssignFieldsDialogCaolán McNamara
Change-Id: I1242f89b4a2809c730b9bc7c2b6b7207edabd47f Reviewed-on: https://gerrit.libreoffice.org/70015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#120865: preserve cursor shape on repositioning the cursorKatarina Behrens
i.e. don't recreate cursor with new (default) arrow shape in SalFrame::SetPointerPos, but simply move the existing one Change-Id: I3406ceff25a53de6f2afa318114370c318e6a500 Reviewed-on: https://gerrit.libreoffice.org/70049 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-01tdf#103859 EMF+ Add transparency support for linear gradientsBartosz Kosiorek
Change-Id: I2a3c21b936bc765f152be5bb8064b9d13aabaa07 Reviewed-on: https://gerrit.libreoffice.org/69927 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-04-01Sifr icon theme update lc_andreas kainz
Change-Id: I3e57c511006eca325ef6e000c18faa3ec68619de Reviewed-on: https://gerrit.libreoffice.org/70046 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-01Get rid of XclXmlUtils::ToOString(const OUString& s)Mike Kaganski
The helper function is used in export code to convert UTF-16 internal string representation to UTF-8 used in XML encoding. I suppose that all strings here should be already valid UTF-16 (an invalid input should have been validated at import/input stage). An invalid string at this stage means a programming error in another part of code that breaks this precondition, and should not be handled at export stage. This effectively changes flags used in conversion from UTF-16 to UTF-8, so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be truncated on invalid bytes instead of inserting U+FFFD, and would fail assertion in debug builds. Other changed flags don't affect UTF-16-to-UTF-8 conversion. Change-Id: I8b154249e66ee32b531b8ab503e0222b9108d829 Reviewed-on: https://gerrit.libreoffice.org/69830 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01tdf#124029 Force correct import pos&size of mso_sptArc shapeRegina Henschel
mso_sptArc uses the current pos&size of the sector as frame rectangle LO has used the underlaying ellipse. That has resulted in wrong shape position and text wrap problems in Writer. The patch sets the viewBox to the current pos&size of the sector and thus force the frame rectangle to the same values in LO as in MS Office. For details see bug report. Change-Id: I039c27f57966bad25e9f2123f50728e6a15f2f7e Reviewed-on: https://gerrit.libreoffice.org/69829 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-01sw: prefix members of SwMultiPortionMiklos Vajna
Change-Id: I00625ac33876d541117592cfb385d3bbd981a9a6 Reviewed-on: https://gerrit.libreoffice.org/70045 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-01Qt5 convert broken clippingJan-Marek Glogowski
localClipRegion was just set but never used, when KDE4 xlib blitting was replaced by Cairo / QPainter blitting. So this converts all the occurences to apply these clippings to the drawing QPainter instance. Change-Id: Ibfd60049ce604ac1415dc5c602ed5c952f972891 Reviewed-on: https://gerrit.libreoffice.org/70006 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScSubTotalDescriptorBase. Change-Id: I49a599b3670e709ee3170fd62c4c06295645b278 Reviewed-on: https://gerrit.libreoffice.org/70040 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01Fix typoAndrea Gelmini
Change-Id: I8902724d36f789c35d26a89f7288492184d23c1a Reviewed-on: https://gerrit.libreoffice.org/70023 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-01Fix typoAndrea Gelmini
Change-Id: Ic73d7ad86787defee6cfdb860a9c7d7b8926cbbc Reviewed-on: https://gerrit.libreoffice.org/70020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-01Restore original $licensepath of the optional EULA of MSI packageAndras Timar
Change-Id: If80ac5648f50deda7a16bc6661ced31357958d67 Reviewed-on: https://gerrit.libreoffice.org/70038 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-01tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScSubTotalDescriptorBase. Change-Id: I86f39c2ef5559f8b5ac4d45daeb6bcad1ab01c8c Reviewed-on: https://gerrit.libreoffice.org/70039 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01Rename ScSubTotalDescriptorBaseObj to ScSubTotalDescriptorBaseJens Carl
Correct class name to mirror the name of the object we are testing against. Change-Id: If26dc045f67df7725043f1b0ccd0d3c8ba73f4ed Reviewed-on: https://gerrit.libreoffice.org/70030 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01tdf#124150 increase size of color valueset widgetTomaž Vajngerl
Size of the color value set can be set through settings, but there was no setter. Added a setter and set it to a bigger value so it is better suited for touch. Change-Id: I8c9b17f7379c4702b0faf7847f1e6292cd89b0d0 Reviewed-on: https://gerrit.libreoffice.org/70031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-01no need to sign mysql-connector-ooo files, because they no longer exist in LOAndras Timar
Change-Id: Id9361cc6fd6d9bb150fd5a70fde7f6c91097b04a Reviewed-on: https://gerrit.libreoffice.org/70018 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-01Add XServiceInfo tests to ScViewPaneObjJens Carl
Change-Id: I3764dd54f0ddb86166028a6c9c824e58ff0a88a6 Reviewed-on: https://gerrit.libreoffice.org/70029 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01Fix typoAndrea Gelmini
Change-Id: Ic7ed36a39c09627e94f61a2b36454c4f19b24ebd Reviewed-on: https://gerrit.libreoffice.org/70021 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'strcpy' function. Change-Id: Iba2cbf1c94f1744b4e34c0f20d9dc030d52f5d9f Reviewed-on: https://gerrit.libreoffice.org/70024 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01Fix typoAndrea Gelmini
Change-Id: Ib38d3dd25f15ce403ee9ff461a94331a4a7c24ac Reviewed-on: https://gerrit.libreoffice.org/70019 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#124362 hide Addressbook button in OnlineAndras Timar
Change-Id: If066c4440c7add08836fa3ebb569ffc36969072e Reviewed-on: https://gerrit.libreoffice.org/69966 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-31tdf#120703 PVS: GetBitmapBits does not return required buffer sizeMike Kaganski
... unlike GetMetaFileBitsEx or GetEnhMetaFileBits, which are used in the other branches. The implementation is trying to pass nullptr to the function since commit 41e72962df83a410986fb48250aaaf1adc827c13 Just calculate the required buffer size using BITMAP struct filled by GetObject call. V575 The null pointer is passed into 'GetBitmapBits' function. Inspect the third argument. Change-Id: I0d164694c99d805fd59b65ea1b4df4919a89e130 Reviewed-on: https://gerrit.libreoffice.org/70012 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#73092 remove remaining shape of the repeating animation.Mark Hung
It is neccessary to set a drawshape to invisible (i.e. remove the effect ) before the drawshape rewind, otherwise it remains at the original place. The timenode container will ask its child to remove the effect after all the child finished, before it start to repeat or it deactivate. Change-Id: Iaef1a8269b61afa0c37b03655e2ea169f1d3c453 Reviewed-on: https://gerrit.libreoffice.org/69543 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-03-31tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c Reviewed-on: https://gerrit.libreoffice.org/69989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31license: fix one more internal linkAndras Timar
Change-Id: I22b33d80a65bc55765ff13f39459de6f68485caa
2019-03-30license: fix a few internal linksAndras Timar
Change-Id: I9139bb22881e7761028a7b78ac644bea4f83e35b
2019-03-30tdf#45904 Move XFormLayerAccess Java tests to C++Jens Carl
Move XFormLayerAccess Java tests to C++ for ScViewPaneObj. Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a Reviewed-on: https://gerrit.libreoffice.org/69942 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-30license: update 'Dictionaries' sectionAndras Timar
Change-Id: I18ec509ffac02bba0fd6191041a8f994034c8e74
2019-03-30Fix typoAndrea Gelmini
Change-Id: If908885fe642e0222f53d57e25ce9dab81bf27d5 Reviewed-on: https://gerrit.libreoffice.org/69973 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>