summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Convert region to use std::unique_ptrMark Page
Change-Id: I1bcc6c62e2caa16f4f3fbc0bef60934e72a3e9a3 Reviewed-on: https://gerrit.libreoffice.org/31669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07tdf#88206 replace cppu::WeakImplHelper* in ucbhelperJochen Nitschke
Change-Id: Iaa48400372ad5a927914c5c93d21f4871ebf5c78 Reviewed-on: https://gerrit.libreoffice.org/31690 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07tdf#88206 replace cppu::WeakImplHelper* in toolkitJochen Nitschke
Change-Id: I89713755023ea003559cc76fb77eb97de2135cae Reviewed-on: https://gerrit.libreoffice.org/31696 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07tdf#104420 writerfilter: no dummy para in headersJustin Luth
Change-Id: I22bf2d85e01ce5a084babdc07a11ada0790f4933 Reviewed-on: https://gerrit.libreoffice.org/31710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-12-07starmath: Add unit test for importing MathML's mathcolorTakeshi Abe
Change-Id: I1e6378834889d6808a1aa724b2cc72c59b02435e Reviewed-on: https://gerrit.libreoffice.org/31671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-07starmath: Require that they are non-0 vectorsTakeshi Abe
Otherwise, division by zero would happen. Change-Id: I77fde7da87f32ba530482e80623bb449313cf986 Reviewed-on: https://gerrit.libreoffice.org/31670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-07sw: Kill unused SwRewriterTakeshi Abe
Change-Id: Ic4b208773df1cce4e6d682c0d7b119409daf467e Reviewed-on: https://gerrit.libreoffice.org/31650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Ifa46b0eb0fb8f288acbcf19f7090a62c6a1ecef3
2016-12-06Resolves: rhbz#1401778 gtk3+wayland switching windows from the window woesCaolán McNamara
ignore 0 timestamps cause they're useless and get the current event time stamp during MenuBarReturnFocus to determine the timestamp of the menu command dispatch Change-Id: Ia4b00aafc9ef47b41dcca2c160e943200db5c524
2016-12-06SafeModeDialog: Rename widget to match labelSamuel Mehrbrodt
Change-Id: I6bb02527fa77846343e55ff73497d1b46b5e1ba8 Reviewed-on: https://gerrit.libreoffice.org/31699 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Revert "attempt to fix Linux-rpm_deb-x86_71-TDF tinderbox build for 5-2, ↵Eike Rathke
tdf#101363" This reverts commit 39aa5c2c653f36393416a6aadd6e599051bbfe7b. Turns out the cause is something completely different..
2016-12-06Revert "try a volatile"Eike Rathke
This reverts commit 8a460cfa1b1ce01c7a479ce2e7f21a92a2c50de3. Turns out the cause is something completely different..
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Simplify codeSamuel Mehrbrodt
Change-Id: Ibb154ebdacb6f445371cb55d795420f92bed0a22 Reviewed-on: https://gerrit.libreoffice.org/31691 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Could not activate checkboxes to remove extensionsSamuel Mehrbrodt
Because of missing event handler Change-Id: Id546a2b22a89321ca09ec29ba7787a1315753bcf Reviewed-on: https://gerrit.libreoffice.org/31692 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06Make the CPPUNITTRACE="lldb --" thing work again (on macOS)Tor Lillqvist
It doesn't seem to work (any longer in 10.12) to pass DYLD_LIBRARY_PATH in the environment to the process to be run under lldb. We need to make lldb execute an explicit 'settings set target.env-vars' command. Use a temporary file to pass that command. I could not figure out where to call the gb_CppunitTest_POSTGDBTRACE macro I define, to remove the temporary file, sorry. Help appreciated. Change-Id: I46bd05f14623639e6ce10112b92ef497cdbb0755
2016-12-06Remove noise SAL_INFO that even crashed when pPrefix was NULLTor Lillqvist
Not sure why it crashed only on macOS? Change-Id: I9578d7de39e22ba79950c6b47aad26944a5d0fa2
2016-12-06tdf#88206 replace cppu::WeakImplHelper* in sax and xml*Jochen Nitschke
Change-Id: I75f4000a17155fbdff96fe0733dc0225b20cd4d2 Reviewed-on: https://gerrit.libreoffice.org/31678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06Convert TextView to unique_ptrMark Page
The destructor contains reset to the unique_ptr's because it is not clear of the importance of the destruction order Change-Id: Ifbbb4fe8352cb3b50f18cebd60cf00af010c086a Reviewed-on: https://gerrit.libreoffice.org/31673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06Change Read/Write access to Scoped Read/Write accessMark Page
Change-Id: Idbe8e393b64f2a151e20c1851d7c14fa161acf97 Reviewed-on: https://gerrit.libreoffice.org/31635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06Fixes tdf#104412 - DirectoryNameoutofPath no longer worksAlex McMurchy1917
In the macro tools library the subroutine GetFileNameWithoutExtension has a missing bracket in the last line. This confuses the following subroutine DirectoryNameoutofPath causing it to fail. This only came to light after the introduction of commit "tdf#80731 Closing parenthesis is now detected (Mid statement and functions)." which tightened up on syntax validation. This commit adds in the missing bracket to subroutine GetFileNameWithoutExtension in the macro tools library. Change-Id: I015c88a29a933cd42b7a7623a9ae70d090739c54 Reviewed-on: https://gerrit.libreoffice.org/31677 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-06Remove broken SAL_INFOStephan Bergmann
Identifier apparently is not null terminated; caused CppunitTest_unoxml_domtest to fail with out-of-bounds read under -fsanitize=address. Change-Id: Id7c6ef6323d41d16b559488604e1c1feb725d608
2016-12-06Make VclPtr move assignment operator actually moveStephan Bergmann
071e23fee07b92b8f07800cda3ca7e66afe818ae "add move operators for VclPtr" added (among other things) a move assignment operator that rather copied m_rInnerRef. But if b72c6feba87bd8707f39902a3066ba476188cb1d "manage VCL widgets using rtl::Reference" had not pointlessly introduced a user-declared copy constructor in the first place, all the copy/move special member functions would be implicitly declared (as VclPtr does not have a user-declared destructor). Change-Id: I1bec05a7a1b5b48a7b7d74e64a88f118454f8cb2
2016-12-06cppcheck unreadVariable: curr_OffsetTibor Móger
Change-Id: Iffc1d36a0e1921f55f24f5e3f9fc1b063b7c0f16 Reviewed-on: https://gerrit.libreoffice.org/31672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-06loplugin:staticmethodsNoel Grandin
Change-Id: I701dfbe69380b5e4024fe55d0045c909bd4b607a
2016-12-06sw: outline longer SwLineLayout member functionsMiklos Vajna
Change-Id: I8ad38c64eea399e3b682a82f7b1a10ca8c669021
2016-12-06pretty the scheduler debug a littleNoel Grandin
Change-Id: Ia5fe9869b5730a81d4343c4fe0a6cf7ca942cca6
2016-12-06we the fuzzers headless of courseCaolán McNamara
Change-Id: Ib5d2ace4501840e554c03a6f6c1506ceb920039c
2016-12-06Comment cppcheck accessForwarded as harmlessStephan Bergmann
Change-Id: I2692ba63f010b61e7b4c1fe54368f4dac9c42d60
2016-12-06remove some ascii art and demote a SAL_WARNNoel Grandin
Change-Id: Ia4d084a598aca050cda02c17d11ed97eecef7650
2016-12-06OSL_TRACE->SAL in unotools..uuiNoel Grandin
Change-Id: I7f391604401b8a10f5d451673ed6223c031c56ab
2016-12-06OSL_TRACE -> SAL_ in vclNoel Grandin
Change-Id: Icd317671a6b1b5356f0ccc7c59d50952fe20269b Reviewed-on: https://gerrit.libreoffice.org/31667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06unwind fpicker RID_FILEPICKER_IMAGES imagelistCaolán McNamara
Change-Id: I1b55e4581c7fcbdf228c3b903269e28d37e53297
2016-12-06Use std::unique_ptr for AnimationEntryMark Page
Change-Id: Ia089be3677adadb4250003b78b7c6bc15ab8bc42 Reviewed-on: https://gerrit.libreoffice.org/31631 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06tdf#104317 RTF import: avoid setting CustomShapeGeometry on a line shapeMiklos Vajna
Even Santa Claus knows it has no such property. Change-Id: I46e27868c62fabd10c6447956e40e55962ee284b Reviewed-on: https://gerrit.libreoffice.org/31668 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-06tdf#103524 - Fix Bottom Toolbars closing operationMert Tumer
Added variables to control state of bottom toolbars, and based on their state open/close the bars Change-Id: I5f9429b336451a354b95dcee18b71fb577c28559 Reviewed-on: https://gerrit.libreoffice.org/30298 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-06Do not enable radio buttons of image flip on createMuhammet Kara
On the Image tab of the Image Properties dialog, The radio buttons under the horizontal flip option should come disabled when that option is not checked. Wrong order of "Enable" calls was causing them to be enabled on create, all the time. Change-Id: Ie361a8280e2a303d38025c5c684f5c07ba2e1ef9 Reviewed-on: https://gerrit.libreoffice.org/31619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-12-06new loplugin/rewriter comparisonwithconstantNoel Grandin
As per sberg' suggestion Limit it to == and !=, because some people like the flow of inequalities like: "0 < a && a < 42" The changes to sal/ were made using the rewriter. The rewriter still has one bug, in pipe.cxx, it managed to pick up some random piece of macro. No idea why. Change-Id: I01305f9c5396a4b6c7421d6e92f1b4b529388e82 Reviewed-on: https://gerrit.libreoffice.org/30962 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06convert IMPL_PAINT constants to typed_flagsNoel Grandin
Change-Id: I9a38a2927cc626e3a94c9eeaffb94b7fd2b6204c Reviewed-on: https://gerrit.libreoffice.org/31634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06convert PolyStyle to scoped enumNoel Grandin
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06tdf#71409: Let's not crash the function wizard dialog.Kohei Yoshida
It's a long story, but here is a short summary: When the function wizard dialog launches, it uses an edit engine instance to process text input, and that edit engine instance comes from the input window (for whatever reason). And, we are supposed to get ScTextWnd::MakeDialogEditView() called to instantiate such edit engine instance for the function wizard dialog. My previous change, however, changed this and ScTextWnd::InitEditEngine() ended up getting called to instantiate the edit engine instance. These two functions create edit engine instances with different settings intended for different use cases... The crash we saw is just one manifestation of such differences. Change-Id: I7fd84c1b1eca2351b9ecc87e325c2fd3787369eb Reviewed-on: https://gerrit.libreoffice.org/31664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-12-06try a volatileEike Rathke
Change-Id: Iadaeb1cdf8a73cac3308e82caa2e65db07ec0fc1
2016-12-06use IncCol() IncRow()Eike Rathke
Change-Id: Ibae425df118ad222db2740b51040d7a6c65b2aa6
2016-12-05Updated coreliongold
Project: help 75c62b4a8207e56c9998429a07760350badc9ded tdf#101140 Adding Help for RAWSUBTRACT function Change-Id: I8eba1c661a31766a5fd84489e4a7db46d5570f73 Reviewed-on: https://gerrit.libreoffice.org/31086 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-12-05IMG_FILEDLG_BTN_STD is unusedCaolán McNamara
Change-Id: Id41d43ec74575ba0edc59f87ffa8b6c9b1485010
2016-12-05only IMG_PRIMARY_KEY is actually usedCaolán McNamara
Change-Id: Ie888ed93f0d511e0c040af32f41e8350113b586c