summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-11-01Prepare for removal of non-const operator[] from Sequence in vclMike Kaganski
Change-Id: I65f411affcf0340c054d09426483d57c530edb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124411 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-01Prepare for removal of non-const operator[] from Sequence in unotoolsMike Kaganski
Change-Id: I720d1c1e4a8d32e8a7c7ac62ab9cf988bac31d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prevent many -Wunused-function in i18npool serviceJan-Marek Glogowski
... registration. Change-Id: Ice406aa6e8817b4281cc3905d2ba2703ce482c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124440 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31Echo cross-toolset configure optionsJan-Marek Glogowski
... just like autogen.sh does. Change-Id: I30ee6b4043c138d7c1e8de154b33fbc7528c34dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124439 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31Prepare for removal of non-const operator[] from Sequence in unoxmlMike Kaganski
Change-Id: Ie7738eb599ac2ae98618e258786b2a0d956cb9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124408 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in uuiMike Kaganski
Change-Id: I3b4ddb7c371c5a01c561e4b45f3c181b5d9e2a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124409 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in ucbhelperMike Kaganski
Change-Id: I06b04e3eed46aba8aac528b2c394d60e733533a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124405 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31crashtesting: assert on conversion of fdo67521-1.odg to pdfCaolán McNamara
#4 0x00007fffcb03c5d9 in std::__replacement_assert(char const*, int, char const*, char const*) (__file=0x7fffcb4fbb03 "/usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray", __line=586, __function=0x7fffcb4fbd8c "const _Tp &std::valarray<double>::operator[](std::size_t) const [_Tp = double]", __condition=0x7fffcb4fbb95 "__i < this->size()") at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/x86_64-redhat-linux/bits/c++config.h:2660 #5 0x00007fffcb3b4b54 in std::valarray<double>::operator[](unsigned long) const (this=0x7ffffffefea8, __i=0) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:586 #6 0x00007fffcb3b4a79 in std::begin<double>(std::valarray<double> const&) (__va=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:1225 #7 0x00007fffcb3b49ac in comphelper::containerToSequence<double, std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:192 #8 0x00007fffcb3b4963 in comphelper::containerToSequence<std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:200 #9 0x00007fffcb3aaa83 in chart::(anonymous namespace)::lcl_ValarrayToSequence<double>(std::valarray<double> const&) (rValarray=...) at chart2/source/tools/InternalData.cxx:72 where begin() is implemented with return std::__addressof(__va[0]) and that operator[] (for arg __i) then has __glibcxx_requires_subscript(__i) which asserts if there is no index __i which is the case for 0 when the valarray is empty Change-Id: Idc2c185cbfb3806764c3071ecee302dc823b4660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124529 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31Support system async file pickersJan-Marek Glogowski
Query XAsynchronousExecutableDialog and don't depend on the "com.sun.star.ui.dialogs.SystemFilePicker" service for the decision. Change-Id: I199ab55a40afaeca7870513829105e47d258420d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124511 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31tdf#145363 Qt reparent modal dialogs on showJan-Marek Glogowski
Simply said, one can't have two modal dialogs open at the same parent in Qt. All modal windows must open as a stack, each parented to the previous one. This is kind of logical. Unexpectedly Qt totally breaks, if you open two modal dialogs on the same window. This happens, because the existing paragraph style dialog and the "sub" "list style" dialog are both children of their Writer window. I'm not sure the additionally introduced QWidget-based parent handling is strictly needed. It seems Ok. So for every visibility and modality change, we reparent the Qt widget, either on top of the modal stack or restore the original LO-based parent. The LO hierachy is never changed! Change-Id: Id209c9aa67774440089dc50a6648ac293950087a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124500 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31tdf#145363 Qt popups actually are windowsJan-Marek Glogowski
An other patch in the whole Qt popup handling saga. At this point it mainly exists as a prerequisite for the real tdf#145363 fix. I just wanted to keep it separate. Maybe it also helps Qt Wayland. Change-Id: Ib76e9919398bdd5fa7d6239ddb126859f0c0edbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124525 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31Prepare for removal of non-const operator[] from Sequence in testMike Kaganski
Change-Id: I9f2c0deda676b10377b0a4572d26422cb0d8b807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31fix usage of MSVC's -debug:fastlinkLuboš Luňák
Using /link while only compiling does nothing (and MSVC apparently doesn't bother to warn). Fix gbuild to pass -debug:fastlink when linking, and limit it to dbgutil builds, since pdb files cannot be moved elsewhere if the option is used. Change-Id: I0325c55ddea1ce881b60b1373c81019d154ef672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124526 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-31backendtest: Drawing Open Polygon testhomeboy445
Change-Id: I57af3232ad5e83b649fdfac719dc2359e1bbb412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120171 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in toolkitMike Kaganski
Change-Id: I10b3f696fdb0bff1781fb22ec560e1c6dfc10b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124401 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in toolsMike Kaganski
Change-Id: Ifff56df8da9b0b9e4d4e96d6b09f490807e96f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31ScriptForge - (SF_Calc) new ShiftDown, ShiftLeft, ShiftRight, ShiftUp methodsJean-Pierre Ledure
ShiftRight()/ShiftDown() insert empty cells at the left/on the top of a given range and move all cells at the right/bottom of the range accordingly. They are similar to the Insert Cells ... menu commands ShiftLeft()/ShiftUp() delete cells at the left/top of a given range and move all cells at the right/below the range accordingly. They are similar to the Delete Cells ... menu commands The insertion/deletion may be done for a whole column/row. The number of columns/rows to insert/delete may be chosen. All methods are available in Basic and Python user scripts. Change-Id: I14555a3966c26054925dd71b0696f3dfc773fc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124530 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-10-31Fix OSL_ENSURE in ucbhelperJulien Nabet
Following: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6d200d8e739595bd4c6310bede7d66e3c05fbb85 loplugin:moveparam in ucbhelper Change-Id: I90bf228932887f66b7f9d2e61d2d17bfa91d1935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124531 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31Qt de-obfuscate the aWinFlags assignmentJan-Marek Glogowski
The aWinFlags assignement is an obfuscated case statement, so this explicitly defaults to Qt::Widget and drops the whole or'ing. Change-Id: If6ac1817d1e600a174c1308a3bad0af5f3f9c30b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124524 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-10-31crashtesting: failure on conversion of fdo74498-1.doc to pdfCaolán McNamara
noticable since... commit 894b4911ffb96ff667fdeb3aec7922316ab7230a Date: Thu Oct 28 09:27:29 2021 +0200 pass DX array around using o3tl::span instead of pointer but presumably a problem since... commit 793905906980e77a9853a8dd01fab95b65ca4f02 Date: Tue Sep 14 15:28:33 2010 +0200 filled-tab-editeng.diff: Filled tab wasn't filled in shapes n#564454 here I assume the right fix is to extend the DXArray (if non-empty) to match the new length using the value of the initial entry of the old DXArray Change-Id: I36a6040c2d05e108c7c6f9cdab9a33557036cd22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124528 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31SwNavigator: Improve tracking on showingJim Raykowski
Currently, tracking is not updated when the List Box mode is switched from Off (content tree hidden) to On (content tree shown) and is not immediatly updated for the sidebar version on showing. This patch fixes these cases by making tracking update on show. Change-Id: Ic7c4ba2ddad70e469ecfed97c656fd83b59584d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124499 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-31ofz: build failureCaolán McNamara
Change-Id: I4595bb2345db025b04073538ae680bd74696260e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124527 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31add o3tl::span ctor from std::vectorLuboš Luňák
Makes code simpler, and std::span can be constructed from std::vector too. Change-Id: Iae26b53c52148c19d9068a63126a7393d098d654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124507 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-10-31Prepare for removal of non-const operator[] from Sequence in svtoolsMike Kaganski
Change-Id: I614a97e5e2328c787ce19612a88839e234d54382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124396 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in stocMike Kaganski
Change-Id: I2aabd9a1c764ae69a933bdb4df635ebb0c91f0cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in svxMike Kaganski
Change-Id: Ib5fda9469f9a1987cf9071c0e228c582cfb3dfa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124397 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in swMike Kaganski
Change-Id: Ie9530262e4addec01091cc1147e68be5b5a782f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124398 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31pass an explicit parent to use for any warning dialogsCaolán McNamara
Change-Id: I7909775b63dfe830e5f0e5b024fa6b47a074736a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124457 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31do not mix bitmap read and write accessLuboš Luňák
Change-Id: Ic479c467f2dcb85c5c786e90a0dcaf48b7d39505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124508 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-31tools::Long->sal_Int32 in bitmap filtersNoel Grandin
Change-Id: Ic37f238824e1af11c924d3bccc4933cee364d798 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31Unused TOOLBOXBUTTON_DEFAULT_LOCATION in fpickerJulien Nabet
Change-Id: I6da38e7585a2e607e407e5f829b64fc5498d04d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124506 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31Prepare for removal of non-const operator[] from Sequence in svlMike Kaganski
Change-Id: I6b71a075de5d5ac002dc48cd2bb21ff5bf5dd072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124395 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in svgioMike Kaganski
Change-Id: I2ae44fc1016b062b574b3aa1e25f5b59b18e2fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124394 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in sotMike Kaganski
Change-Id: I5d6da6ce158fb29ff37452281d28c297795b4cb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124391 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in starmathMike Kaganski
Change-Id: I0ac241a5849a5c7d2726ceb0084612a7a1070b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124392 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31tools::Long->sal_Int32 in Bitmap::DitherNoel Grandin
Change-Id: I8cc4d6d964946e1f5fce4ae5b0bdc08b98ce8e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31Typo: TOOLBOXBUTOON->TOOLBOXBUTTON in fpickerJulien Nabet
Change-Id: I7110afbdd554b180c368894b9aa6b3b79a8fb2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124498 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31tools::Long->sal_Int32 in ImplExpandNoel Grandin
Change-Id: I9f57bf3b67b71aece6e595e83f70a3dff4ec3d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31tools::Long->sal_Int32 in StretchAndConvertNoel Grandin
Change-Id: Id8ceb7042cf28e9130986393aff52bc29920b51a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31tools::Long->sal_Int32 in OutputDevice::Blend*Noel Grandin
Change-Id: I26ad2727dbc258a49e7f370167b80e98438a50e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31tools::Long->sal_Int32 in ToolboxNoel Grandin
Change-Id: I1f337558e6fcd6ea552814611cd6fb8a4f3b2f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31Prepare for removal of non-const operator[] from Sequence in smoketestMike Kaganski
Change-Id: Ica192dfb16716b4fb38d59eee0a39c6dd411b6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124390 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in slideshowMike Kaganski
Change-Id: Ic3d4835a6153ce3451e5ddf7a74310ea2b70da2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124389 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in sdextMike Kaganski
Change-Id: I1992d1ffbbc80efe9749ebd254971a0a92a10019 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124386 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in sfx2Mike Kaganski
Change-Id: I0cdce64983901a6cc3b50dc9873a370ff08b9eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124387 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-30Prepare for removal of non-const operator[] from Sequence in shellMike Kaganski
Change-Id: Ie7792d0aa3f404d9177a1eb6f75569577fc3d6a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124388 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-30Prepare for removal of non-const operator[] from Sequence in sdMike Kaganski
Change-Id: I82dc012188f846161beeb54901c2f5d298e5c3b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124385 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-30Related: tdf#145377 call select handler if restoring previously selected scriptCaolán McNamara
Change-Id: Ibab3e920e6830c86bb6bfba070f14ca8a153c25f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>