summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-27sc: pivot table compact layoutDennis Francis
This implements compact layout for pivot tables. In ooxml each row field can have a compact layout setting. Support for any such "mixed" layout of tabular/outline/compact per field is also implemented. This also implements expand/collpse toggle buttons to field labels to make pivot tables with compact layout more usable. Such buttons are also available if other layouts are used. Conflicts: sc/qa/unit/pivottable_filters_test.cxx sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/checklistmenu.hxx Change-Id: Ieaa1f3bd282ebdec804d0b45a0af7b3d95a2027f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151057 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2023-04-27Extend tiled rendering test to account for dark modeParis Oplopoios
Made testGetViewRenderState test for change from light mode to dark mode Change-Id: Ia02e7a462e595671492405733f25c0bbb3c24080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151046 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-27CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOleImgMiklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: I5726642d932a495ff2158d3a0ed9c242a5c13278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-27tdf#136749 no need to use maMutex in SwAccessibleMapNoel Grandin
we already need to be running under the SolarMutex, so just use that. Shaves some 5% off time here. Change-Id: Ife13f44d2e52171638bebcee946f5a1f07248cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-27tdf#38194 Use a hashed string HSL color approachJim Raykowski
for style name color creation New magic for style name color creation. Change-Id: Ia6eec2dcf04fc2c3c38276bf6eaed73598505947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151079 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-27Bin the unused paintTileToCGContext special thing for iOSTor Lillqvist
It was used by "LibreOfficeLight" which died years ago. Change-Id: I71a1315448baa4f1ec7a22b20cb3dd39c88cda78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151066 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-04-27Remove wrong "toolti-text" in notebookbar.uiRafael Lima
This patch removes wrong "toolti-text" entries in Calc's notebookbar.ui file. Besides being wrong (the correct would be "tooltip-text"), these entries do not make sense since tooltips are not supported in this manner by the Tabbed UI. Moreover, "toolti-textp" is not used in any of the notebookbar files. Change-Id: I2f862cfe53a8de5fa1566fec7cc00c14d1bcc505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151022 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-27Resolves: tdf#151958 Disable binary search on sorted cache for current releasesEike Rathke
Temporary measure until the actual cause is fixed. The by string query of binary search on sorted cache is broken for mixed types like here the numeric date cells and text cells. Change-Id: Icfe0b0c30987fcefdd6ed11066ea9113f3b4dabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151074 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 6a79a8d4a5ca9e76f0811ddc8fcf8d79b21728ac - Refactor page - no content change Change-Id: I0f97c79e69234b52147c0812066f50f952705bd9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151077 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-26Simplify aCurNode.children construction in sw/WriterInspectorTextPanel.cxxJulien Nabet
Change-Id: Ide294aadc8a0c0df1fa6ba24bae044a2592677f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to bd22a155b84999d3a2e75cca0e1c735993971064 - update translations for master and force-fix errors using pocheck Change-Id: I8c546190ea25d29f985750ecb2461a126f0815ff
2023-04-26pptx export: fix export of vertical table textSarper Akdemir
The mapping (implemented in 77655fc3dca05d4bb2366e67ccea228e3886bfe2) used on export and the accompanying roundtrip test was incorrect. This patch fixes both. Rotation value of - 9000 maps to vert270 - 27000 maps to vert Change-Id: I9a9f889a2bff0241e62ee685492034eec6d0cccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150955 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
2023-04-26tdf#136749 std::map -> unordered_mapNoel Grandin
considerably faster when looking up pointers, shaves 10% of time off here Change-Id: I521f8d557a30e4f430caab6b0701ad8da65f99f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26sw floattable: DOCX import: m_bConvertedTable is now unusedMiklos Vajna
This was added in commit 659c0227a50d298780d72902314e03df8824bc06 (tdf#107889 DOCX import: consider page breaks for multi-page floattables, 2017-05-16), but is no longer used since commit c50bf5a5daaae3d40f89ea0784a75a8a571c208d (sw floattable: remove no longer needed DOCX import heuristics, 2023-04-12). Change-Id: Ieba43e1175ab59c29c0555299facb8fc0e865acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151067 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-26Typo UNO_NAME_EDIT_PARA_TAPSTOPS->UNO_NAME_EDIT_PARA_TABSTOPSJulien Nabet
Change-Id: I515557adc9363858ebda5230e8428e2b58d06d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151068 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 77b1a5a7118478c2b3a86fd43cfc68e336ac913c - tdf#153547 Fix typo + Reference to comment #2 + Refactor of whole file Change-Id: I1c167c9ca1a0cf8e6d3f10ecb9da02eac9060ba3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151071 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-26Disable WiX-based MSI generation for the momentThorsten Behrens
Right now, CI builders have no WiX toolset installed, breaking all daily builds (since commit 9aee0383c3ebc3f267c99e19764728ba09c12d3a) Change-Id: I92ba2590c5afa711d3079edc070fd904b01de6f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150823 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-04-26cid#1401342 Uncaught exceptionCaolán McNamara
Change-Id: I50a2a4b1763749ae6117e38c982808b514e876d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151037 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26upgrade to more recent fuzzing dicts and use some additional onesCaolán McNamara
that look a good fit for the formats we're already fuzzing Change-Id: Ie635d17d829858c0cb10f71ea936f8dc131db811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151052 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26add a svg fuzzerCaolán McNamara
Change-Id: I9662d91d2761b4f160858897f19f31f474dccbed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26assume IFrame script/macro support isn't neededCaolán McNamara
seems undocumented at least Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26use skia's svg seed corpusCaolán McNamara
Change-Id: Iee1e7a6bbc3e50b3e882465aafea4c9b0650dcbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26expose parsing svgs for testingCaolán McNamara
Change-Id: I4d59aa9a684bd3e05fca473d6c7567cd8258b242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#151624 Fix Insert Formula tool in the Tabbed UIRafael Lima
As reported in the ticket the Insert Formula tool was misaligned in the Tabbed UI since the removal of the Emoji tool. This patch fixes that by making the tool use all the available vertical space. Change-Id: I26d36ba4fc6f38e80d8ab46bfdf88c08fbf2fd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150701 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-26Resolves tdf#153852 - Make sort dialog resizableHeiko Tietze
Change-Id: Ie0db5c713bf16443962245900655736aeddce532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151042 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-26tdf#108757 speed up PDF generationNoel Grandin
std::list->std::vector reduces output time by 10% because we search the m_aChildren often and vector is better at that Change-Id: I4d0d5f6248a9c36aa0085cb22315ad6e2f53738e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26tdf#108757 avoid some OUString construction on a hot pathNoel Grandin
Change-Id: I468bc9fac024dd9fa33286382264e2b84617481b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 3Miklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed the crash, but a layout loop remains. The current problem is that we could have a document of 3 pages where the last page had no anchor for the fly frame, so it took the anchor from the previous page, but this lead to negative frame heights and at the end an empty 3rd page. To fix the problem: 1) Make sure SwTextFrame::FormatAdjust() doesn't break the invariant that only the last frame of a floattable anchor has text content. 2) Make sure SwTextFrame::AdjustFollow_() doesn't join a frame that still hosts non-last split flys. With this, we have exactly 3 anchor frames (in a flow frame chain) for the 3 pages and the 3rd page looks correct. The original document still needs more work to fix the layout loop, though. Change-Id: I2fc9c4728fdf191ac5b5b435a10d553a699bae75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151048 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-26Bin leftover dead codeTor Lillqvist
Change-Id: Ie0583d52b01bba92e6fc41f0fee3fd4732f1d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151054 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-04-26Fix typoAndrea Gelmini
Change-Id: I05e089a8d04d2b5527cf466510b182eeac355836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151044 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Fix typoAndrea Gelmini
Change-Id: I13e43e0cd7f3f3e31b581c5b3cec12f5c0634cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151043 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26update creditsChristian Lohmaier
Change-Id: I934d635e0d241b9884017e4a22ba99e9d1459783
2023-04-26Revert "workaround compile failures in libxml, with clang-17"Noel Grandin
This reverts commit 4a828dde104551c1c3d935ed8b43ebc546fa77c3. Reason for revert: Caolan merged a better fix with aa87fe2562e7a55a18a1c757a49babfe74377bcd Change-Id: I3ae713555fc62782675dbc48ad51a36ff41bfcf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scaleTibor Nagy
This is a follow up to commit 3f614f431475e1bf3bb3bbeac59b0681309628b7 (tdf#95295: don't add duplicate conditional formats) The above commit clearly describes how this fix works. Change-Id: I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150899 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-26jsdialog: enable themedialog.ui and themecoloreditdialog.uiTomaž Vajngerl
Change-Id: Ie6c6af3e3a98548cad8b5bfb067382a03296b278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151033 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-26Related: tdf#155017 Stop after the first pop in case the shell was not on stackMike Kaganski
After commit 271f17a6022c64cbbe9befbc66a9eaaa0567d569 (tdf#155017: make sure that the correct shell is popped from SfxDispatcher, 2023-04-26). This restores the previous logic for a hypothetical case of a pop without POP_UNTIL scheduled for a shell, which was not on the stack (so that it wasn't removed in the code added in the commit mentioned above); I haven't a reproducer, but it definitely can happen, given how things work here. So I try to avoid breaking it even further :-) Change-Id: Ied0a1406881fbefe3cf069f816c50da03a41dcd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26use our existing zipfuzzer_seed_corpusCaolán McNamara
Change-Id: Ib0ea6ad80ff24d3b405051c22b4cdcc461ae2018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#152246 Fix RTL content control field positionHossein
With this patch, the horizonal position of the content control fields are corrected. Previously, they were calculated just like the fields in the LTR paragraphs. To implement this, I've used the GetTextFrame()->SwitchLTRtoRTL method. The remaining issue is that The exported fileds in the PDF are still LTR themselves. For example, the combo box will still be LTR. It should be pointed that handling vertical text is still an issue that should be addressed later. If you rotate the paragraph with content control field, the output does not obey, which is incorrect. Change-Id: I927d14f9ca90434b4397dcf175dbb9531dda0c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150515 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#138093 DOCX import: fix broken date selector control in tableCzeber László Ádám
In tables, first character of the text value of the date selector control left outside of the control during the import, resulting broken date selector, e.g. 2[023] instead of [2023]. (Clicking on the broken control, according to the year *023*, the selector listed the lowest possible value, year 1900, and selecting that, the result became 2[1900].) Note: the fix works well with nested tables, too, so likely the condition with tables is obsolete. Perhaps regression from commit b36ef83ea59eeaca239e58b95aa0b1acdcb99efc "tdf126701: MSForms: Fix import of date field at the end of the paragraph." and commit 68e1be4ccbb90ee9a788962219a88312c4ffbea2 "MSForms: Rework text-based date form field's representation". Change-Id: Ib217a3a06522bfe7b3b0fbc884f98504f628fc59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-26tdf#155006 don't show "InsertObjectFloatingFrame" by default in menus and ↵Caolán McNamara
toolbars still exists, just isn't presented by default. help describes this as "Inserts a floating frame into the current document. Floating frames are used in HTML documents to display the contents of another file." and "Changes the properties of the selected floating frame. Floating frames work best when they contain an html document, and when they are inserted in another html document." This is basically support for html IFrames and is a fairly obscure thing for an ordinary document. Change-Id: Iec8ff591393e4ee4ed8791094e1f15a225808c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150707 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 2Miklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed a crash, but a layout loop remains. One problem there is that we move too many rows to a next page. Analyzing what Word does and how we behave, we handled the TABLE_ROW_KEEP flag even for floating tables, but Word only does this when table wrapping is "none". Fix the problem by following suit, which gives the correct 2.5 rows on the first page of a reduced bugdoc. The layout loop for the original document still needs more work, though. Change-Id: Ief79d4b4e984a9e46ee133ae3e7e7cf81e13a836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151009 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-26Renumbering comments in include/svx/xdef.hxxJulien Nabet
Change-Id: Ice9f69824a6127dd23ce9e760b06ce9f03403604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Related tdf#154769: XML forms add anyURI/hyperlink datatypeJulien Nabet
See https://www.w3.org/TR/xmlschema11-2/#anyURI Since I copied-paste string datatype + add check url, I thought about deriving from string datatype but seeing https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/datatypes.html#built-in-datatypes anyURI doesn't derive from string TODO: contrary to "string" which uses "preserve" for "whitespace" "anyURI" uses "collapse" There's WhiteSpaceTreatment notion in datatypes.cxx and m_nWST associated, WhiteSpaceTreatment::Preserve seems to be the default but when searching about it, it's seems not used. Change-Id: Ifc2dc06072e40b9be168c2f40a9506fe7d267ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150822 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26tdf#86630 sw page number wizard: set page style numbering typeJustin Luth
Giving the user the opportunity to change the number type is rather important. Well, maybe not too critical since I assume that the default page number style is relatively accurate for each locale, and at least for English we always just use numbers for the page style. However, a wizard is the perfect place to expose such a setting, otherwise it is buried in page style settings - far from where anyone would look when inserting a page number. Change-Id: I9053504fa55d16ebf5424946b480cb044b79988c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151005 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#154855 DOCX export: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>Miklos Vajna
The bugdoc has a table where shapes are anchored in cells. The wrap type is set to "none" ("in front of text" in Word UI terms) and the follow text flow ("layout in table ell" in Word UI terms) option is enabled. The import into Writer is fine, but saving back to DOCX and checking in Word is not: all shapes move to the left cells. What happens is that since commit e993638d5ecd33783f2eebdccfa87a81e5a8a2c5 (DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>, 2022-01-24), we ignore layoutInCell in case wrapNone is used with a suitable horizontal relation orient, since Word doesn't capture anchored shapes inside the cells in practice in that case. This helps for the old bugdoc, but introduces the problem that we now lose the layoutInCell setting on export, which is not wanted. Fix the problem by leaving the import and the layout unchanged, but do the opposite mapping on export: if we have the relevant wrap and horizontal relation orient case, then enable layoutInCell, even if the doc model doesn't have it. Note that Word itself behaves inconsistently here: if you change the vertical offset of one of these shapes to position the shapes outside the cell, Word does it, even if "layout in cell" is enabled. Change-Id: I980a995d76afdee4716f7669081c688065427ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151000 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#155017: make sure that the correct shell is popped from SfxDispatcherMike Kaganski
Honestly, I don't quite understand the idea of using the stack of shells in SfxDispatcher, when the order of addition of shells there does not match the order of removal. After opening the bugdoc, SfxDispatcher has these shells in xImp->aStack (from top to bottom): [8] SwWebView [7] SwWebTableShell [6] SwWebTextShell [5] SwWebListShell [4] FmFormShell [3] SwWebDocShell [2] SfxViewFrame [1] SwModule [0] SfxApplication SfxViewFrame dtor calls ReleaseObjectShell_Impl. * First of all, it calls PopShellAndSubShells_Impl for SfxViewShell; * Then it calls SfxDispatcher::Pop for SfxObjectShell; * Then it calls SfxDispatcher::RemoveShell_Impl for SfxModule; * Then SfxObjectShell is destroyed; * And finally, SfxDispatcher::SetDisableFlags is called. PopShellAndSubShells_Impl (for SfxViewShell) finds the passed SwWebView at the top of the stack (pos. 8), and removes it. SfxDispatcher::Pop for SfxObjectShell queues removal of the passed SwWebDocShell *without* SfxDispatcherPopFlags::POP_UNTIL mode. SfxDispatcher::RemoveShell_Impl first calls Flush, which actually executes the queued actions. At this point, an SwWebTableShell (pos. 7) is the top of the stack; SfxDispatcher::FlushImpl will pop it, and stop (because there was no SfxDispatcherPopFlags::POP_UNTIL at the previous step), so the intended removal of SwWebDocShell (which is at pos. 3) will not happen. Then RemoveShell_Impl will proceed searching for the specific shell (SwModule), and removing specifically that (at pos. 1). At the moment of destruction of object shell, the dispatcher's stack looks like this: [5] SwWebTextShell [4] SwWebListShell [3] FmFormShell [2] SwWebDocShell <-- The problem is here [1] SfxViewFrame [0] SfxApplication and pos.2 points to a destructed object. Finally, SetDisableFlags iterates all the shells still in the stack, setting their flags - and obviously accessing already destroyed object. In debug builds, this crashes reliably; in release builds, where dtors do not fill memory, the access of the just-destroyed objects likely often goes unnoticed. In different documents, the order and the set of shells there is different, e.g. an empty Writer document would have view shell just above object shell, resulting in correct removal of the object shell. I don't know what strategy is intended here. I decided to implement a small change, that makes sure that without POP_UNTIL, popping a shell removes exactly that shell that was requested for removal. Change-Id: I670d024056a5b32d5485f00a4799a8b0bacb6485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151003 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26tdf#155011: Fix assert/checkMike Kaganski
pFrameStartAfter may be a section frame itself, thus its FindSctFrame would not return this. Same for pSav. Change-Id: Ib592965b30eb47f37ba54fe7f39af0b8689b3175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26tdf#153789 KJ: icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I9a989e039ae726e413c0a54ab805a0ee7d09c94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151007 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-26tdf#86630 sw page number wizard: default to center of pageJustin Luth
Defaulting to one side of the page only makes sense if the footer is mirrored. [Well, mirrored isn't the best word here because it only refers to margin spacing.] The only way to get mirrored footers is to have separate left and right pages. It would be nice to add mirroring to the wizard, but that can be done separately. First, lets just get a better default value in place. Change-Id: I314c6a34414a696c6f2e27bb2b0747fdb86f3b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150998 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-04-25Resolves: tdf#41304 Add percent operator % to reference delimitersEike Rathke
Change-Id: I094fcb800a29de424db28e1b58f1239381a3b4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151001 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-28 21:22:30 +0000