summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-06Qt5 implement scaled image drawsJan-Marek Glogowski
If the source and target rects don't match, LO expect the image to be scaled. Change-Id: I337acfa56600eba92c10aed7a70749ad08c03e90
2018-07-06Qt5 implement 4bit => 32bit bitmap conversionJan-Marek Glogowski
Some of the PNG icons are 4bit palette based PNG images. This implements the conversation function for the most common 4bit case, so we don't rely on some generic handling. All other non-4bit conversions can be handled by Qt. Change-Id: I4ddd744fb7166fc3a6992b6be6c250c2adb99ca5
2018-07-06Qt5 flesh out font handlingJan-Marek Glogowski
Fills some more FontAttributes based on the QFont. Also implements initial font rotation support. Something is still strage with the vertical font in Writers vertical ruler. Text looks correct in vertical text boxes FWIW. The toRectangle bug is embarrassing; I was wondering for quite some time, which glyphs had strange size rects :-) While at it, move the Qt5Font header to vcl/inc/qt5. Change-Id: I67fa400486981035be6f98c5ab56e82d69c42065
2018-07-06Add ostream::operator<< for SalTwoRectJan-Marek Glogowski
Change-Id: I4466ebb154acd8046927db6b945b04c85095b87e
2018-07-06Some cleanup and commentsJan-Marek Glogowski
Change-Id: Ic1dda9b0e5d7896703b65d0d43be340196bcb871
2018-07-06loplugin:useuniqueptr in XclExpObjListNoel Grandin
Change-Id: Ia7f2be93d6306d72773ab611de2945c8a711a2d9 Reviewed-on: https://gerrit.libreoffice.org/57010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-06dbahsql: Look for properties only after nameTamas Bunth
Additional properties in SQL string like "DEFAULT" or "NOT NULL" should be searched only after column name, because what if a column name is "myEvilNOT NULLColumn" Change-Id: I21f0755ba14c7267243d9999f044db4d16963387 Reviewed-on: https://gerrit.libreoffice.org/56462 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06dbahsql: refactor, around parseColumnpartTamas Bunth
Change-Id: I663da1474d3f1c3bde8a3d3c041e8fd0fe4c7d43 Reviewed-on: https://gerrit.libreoffice.org/56459 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06tdf#117867 dbahsql: Migrate default valuesTamas Bunth
Default Value "NOW" is a special case, because Firebird likes it with single quotes. In contrast, HSQLDB uses the keyword without quotes. Add unit test for parsing default value "NOW" Change-Id: I34886f8ae53e98addb52bf5e85030a03721d6a45 Reviewed-on: https://gerrit.libreoffice.org/56454 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-07-06tdf#118414 sw: fix fieldmarks in GetNextAttr()Michael Stahl
Apparently this needs to stop both before and after the CH_TXT_ATR_*. (regression from 3e724847308c0d9cdd727898faaeb347c5f0643a) Change-Id: Iff3d594d2eec59436ad683b9cc7aca04f7527bd5 Reviewed-on: https://gerrit.libreoffice.org/57017 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06tdf#101856 sw: hidden bookmark portions in SwTextFormatter::NewTextPortion()Michael Stahl
All other hidden-text features already have a AUTOFMT hint or a TXTFIELD hint, so the SwAttrIter already creates new portions for them. The bookmarks aren't considered by SwTextFormatter currently, but SwScriptInfo already has all of the required info. Change-Id: I451ce331110aa58df8955e1a3ffa339e6f905b22 Reviewed-on: https://gerrit.libreoffice.org/56959 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06tdf#101856: Use bookmark attributes at loadSerge Krot
Conflicts: sw/source/core/text/porlay.cxx Change-Id: I935c50f8b3a1d7179121b9230a7f7f25fa6aea22 (cherry picked from commit f8afdb8ba99074a85b331065b4642081467557ec) Reviewed-on: https://gerrit.libreoffice.org/49578 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06tdf#101856 odt: write/read new bookmark attributes: unit testSerge Krot
Change-Id: I094f91c2af2d171067e3c37a8d52276835d36e9c (cherry picked from commit 61150f1c37744457e7a1a1c1e684612b6adf0298) Reviewed-on: https://gerrit.libreoffice.org/49424 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06tdf#101856 Backport parsing of bookmark propertiesSerge Krot
Change-Id: I7654aa93d4d86a5d36201832ac3609b9f4c30e03 Reviewed-on: https://gerrit.libreoffice.org/50565 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 88b6b1a8c149163d226eb3295930e3407bcb8b5b) Reviewed-on: https://gerrit.libreoffice.org/56958 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06tdf#101856 create bookmarks w/ new hidden/cond attrs, save as odtBernhard Widl
Committer's note: this is forward ported from 5.2+backports branch, with numerous conflicts. tdf#101856 add new checkbox/editfield for hidden/condition attrs Conflicts: sw/uiconfig/swriter/ui/insertbookmark.ui Author: Bernhard Widl <bernhard.widl@cib.de> (cherry picked from commit c347e00821791377731ab32acd103ea006f3cc1b) tdf#101856 Fix crash in Insert Bookmark dialog Author: Serge Krot <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/50616 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit bcc16920eec647f2a3753d60c4d969862f272942) Change-Id: Ib1df7a4c1477693aa2d0ec067635cdcbd393cebd Reviewed-on: https://gerrit.libreoffice.org/46820 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06solenv: adapt native-code.py to xsec_xmlsec_component_getFactory removalMiklos Vajna
Change-Id: Ic8bfac8b0d0741abeaa38c75d1bad254fe6acaeb
2018-07-06Karasa Jaga: Add missing Impress menubar icons & Common Align actionsRizal Muttaqin
Change-Id: I8a6a9774e40b0ea68fca37e0eb80e59e10241459 Reviewed-on: https://gerrit.libreoffice.org/57016 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-06xmlsecurity: convert last non-uno-consturctor based serviceMiklos Vajna
Change-Id: Ib8a16c69aa2a05118e329a6552682b7a21d4536a Reviewed-on: https://gerrit.libreoffice.org/57023 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-06Added text transformations for external dataVikas
- Uppercase, which sets all text in the selected columns to upper case. - Lowercase, which sets all text in the selected columns to lower case. - Capitalize Each Word, which makes all words in the selected column start with a capital letter and sets all subsequent letters in a word to lower case. - Trim, which removes any leading or trailing whitespace characters from text. Change-Id: I6da37bec9d820887a155da57d0b0c75f36e8ac69 Reviewed-on: https://gerrit.libreoffice.org/56780 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I72d34c875951a8b4a349d92b0d893fdaecd718e7 Reviewed-on: https://gerrit.libreoffice.org/57033 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt
Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06Simplify string concatenation.Mike Kaganski
Change-Id: Ib478a7371599309f68b6fffd4dbed0f17c9ecb01 Reviewed-on: https://gerrit.libreoffice.org/57032 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-06tdf#117903 Add signature line feature to calcSamuel Mehrbrodt
Change-Id: I4e9121803a26cba1f40f8f1c673c7809543ef2ec Reviewed-on: https://gerrit.libreoffice.org/57015 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06add a selection for the DB range to Dataprovider dlgMarkus Mohrhard
Change-Id: I02c63b46e21cd8d04e6b515e2cbbee08743d5657 Reviewed-on: https://gerrit.libreoffice.org/49459 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Added Delete Column Transformation in Data Provider DialogManuj Vashist
Change-Id: Ibebd92c426d1653642c5b9d037d6368636561fcd Reviewed-on: https://gerrit.libreoffice.org/56786 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Limit GetNextPos() loops to range also for nMoveX, tdf#68290 follow-upEike Rathke
And straighten the code a bit to use one init block and return early if nothing marked or not protected. Change-Id: I4c9247479a137cb7f9435180f3f54667d28a29ef Reviewed-on: https://gerrit.libreoffice.org/57025 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-05Colibre icons: add 32px size iconsandreas kainz
Change-Id: Ib9b16fe037d1ecaac3c52723a002d0b6c440ba31 Reviewed-on: https://gerrit.libreoffice.org/57019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-05cid#1437407: create class loader in doPrivilegedStephan Bergmann
Change-Id: Iade079e44c8d88a13830258157d9481f4b8b3358 Reviewed-on: https://gerrit.libreoffice.org/57013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-05Only access css::drawing::PointSequence when not emptyArmin Le Grand
Had to adapt EscherPropertyContainer::GetPolyPolygon due to it using conversions from UNO API drawing::PointSequence to old tools::polygon, containing unsafe memory accesses. It is not useful to fix that, use new tooling instead. Before correctly testing nCount for zero in b2dpolygontools.cxx when you look closely always a point was added - a random one due to accessing random memory. This is corrected, so in test case for "tdf104115.docx" a PolyPolygon with two polys is used, the first being empty (had one point due to the error mentioned above). When having no points, CreatePolygonProperties in escherex.cxx does badly calculate and alloc the pSegmentBuf array used to write to doc formats (in the test case - 20 bytes alloced, 22 written). This did not happen before due to having always a point due to the error before - argh! Corrected that and hopefully this will work now. To be on the safe side and to not need to redefine that whole CreatePolygonProperties I will turn back that little change and better sort-out empty polygons inside GetPolyPolygon alrteady. That should bring us back to the original state, at the same time avoiding that CreatePolygonProperties has to handle empty Polygons at all. That stuff urgently needs cleanup - I took a look and thought about using std::vector<sal_uInt8> so no wrong alloc or write too much could happen, but that nTotalBezPoints needs to be pre-calculated because it gets itself written to that buffers... Change-Id: Iefc885928f5bb29bceaf36c2a1555346bb21fd26 Reviewed-on: https://gerrit.libreoffice.org/56927 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-05sc: Prefer std::vector to std::dequeTakeshi Abe
There seems no need for choosing deque in the first place 5099046dccb69af04e2a3adafad8e06c0832bd06. Change-Id: I194e6bee37d8f6f177aee96681b3014119aa11c1 Reviewed-on: https://gerrit.libreoffice.org/56997 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-05Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9696a9ad3c0f5c3e6bb12a81dd2386e927eebed2 Reviewed-on: https://gerrit.libreoffice.org/56987 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-05FontFeatureTest set weight/italcs explicitlyTomaž Vajngerl
Font featrues can depend on the state. To make the state more stable we need to set the the font properties explicitly. This sets the weight, italics, width type to "NORMAL", which changes the number of available features. Change-Id: Ida6be4191762c3acfeb7b95182b80717e9774c62 Reviewed-on: https://gerrit.libreoffice.org/57011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-05fix HSQLDB_JAR define in scp2/InstallModule_ooo.mkRene Engelhard
for one HSQLDB_JAR is already a path and secondly, gb_Helper_make_path doesn't even exist (anymore). It's supposed to end up in URE_MORE_JAVA_CLASSPATH_URLS so use gb_Helper_make_url Change-Id: I52c6117299caeb4fac8c894fc54564befc673e67 Reviewed-on: https://gerrit.libreoffice.org/55552 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-05tdf#118546: GetNotebookBar() may return nullptrMike Kaganski
Change-Id: I411ea0abcb5fd5fac0db7fe0c4bad16a0c1b9d77 Reviewed-on: https://gerrit.libreoffice.org/57006 Reviewed-by: Kshitij Pathania <kshitijpathania@gmail.com> Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-05Adjust indentation to match surrounding codeSamuel Mehrbrodt
Change-Id: I631fe8553907c5ddc979a139c8cc77d3902d204a Reviewed-on: https://gerrit.libreoffice.org/57014 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-05Fix for commit ae412b4Andrea Gelmini
In commit ae412b486e02aa5890769bebcfc46e485a72103c I missed a '>', to close tag. Change-Id: Id60b88b5b2a38ede2a2c0680abcc8af32f900586 Reviewed-on: https://gerrit.libreoffice.org/57007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-05-Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
Change-Id: I97cbb82fc0912e9b9ccdfdf78c424c478251362b Reviewed-on: https://gerrit.libreoffice.org/56993 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-05block ocText for calc's threadingLuboš Luňák
It may end up calling XColorList::CreateStdColorList(), and XPropertyList is not thread-safe (gnome#627759-1 with disabled mnOpenCLMinimumFormulaGroupSize). Change-Id: I79c8335c6e8e3aaf39e01c68e6dbf6011820971a
2018-07-05tdf#105225 fix new background tab page in calc format cells dialogJim Raykowski
Change-Id: I56cca8d22e98364eb369f3ccf54ca1acb3eb8516 Reviewed-on: https://gerrit.libreoffice.org/56983 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-05Honor border width in a welded color picker for gtk3/x11Maxim Monastirsky
Change-Id: I1b59e85edb8e9df5be453dc0be1d7d1ffd100ceb Reviewed-on: https://gerrit.libreoffice.org/56996 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05Fix initial width of the color palette in welded pickerMaxim Monastirsky
Problem can be seen with non-gtk3, if the initial palette has no scrollbar (e.g. "standard" palette). The cause is that in non-gtk3 we don't have overlay scrollbars, so the palette area needs to be enlarged when switching from a palette with a scrollbar to a palette without a scrollbar. In practise, this was happening also on initial show, although the palette already had the correct width. To fix that, start with a never scrollbar policy by default, and add the scrollbar later if needed. Change-Id: I5286f301b3c7ef5c72b650290ace784222f7922d Reviewed-on: https://gerrit.libreoffice.org/56995 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05tdf#117745 - Split Options/Formatting Aids/"Display of"heiko tietze
Field options moved into another frame Change-Id: I42a1422617183e5059e66b4f280cbf9cc6daa79d Reviewed-on: https://gerrit.libreoffice.org/56090 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-05sw HTML import: strip query & fragment for <object data="..."> and file URLsMiklos Vajna
There are two cases: when the <object> is a child of an outer <object> (we create an embedded object) and the non-embedded <object> case (we create an image). Call the new SwHTMLParser::StripQueryFromPath() in both cases. INetURLObject considers this query/fragment part as "name" (end of "path"), so just do it manually. Change-Id: Icb7991082b6e595db5729f3c4c84073c80834f27 Reviewed-on: https://gerrit.libreoffice.org/56989 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-05use std::unique_ptr for ScTable in ScDocumentNoel Grandin
Change-Id: Ic817fbd7953afe9007f9ec6071f53c8beca6dd18 Reviewed-on: https://gerrit.libreoffice.org/56949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-05Menubar Impress: add missing icons to menubarandreas kainz
Change-Id: I5116e214ab64923c28dda4d10feab1193b5d9d31 Reviewed-on: https://gerrit.libreoffice.org/56978 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-05vcl: experiment for font related test fails on WNTMichael Stahl
Change-Id: I7471299c1f0d4c0431e9b896cd2fbf5a056f31f8 Reviewed-on: https://gerrit.libreoffice.org/56892 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-05Impress Menu -> Insert -> Slide Number fixed wrong commandandreas kainz
Impress Menubar -> Insert -> Slide Number open the Header and Fooder Dialog Change-Id: Ie6c03358254265422ef2b760aa182515a44480d4 Reviewed-on: https://gerrit.libreoffice.org/56976 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-05UBSan apparently still needs --dynamic-list-cpp-typeinfoStephan Bergmann
...(presumably due to it using -fvisibility-ms-compat, cf. solenv/gbuild/platform/com_GCC_defs.mk), or else things start to fail like <https://ci.libreoffice.org/job/lo_ubsan/962/console>'s CustomTarget_testtools/uno_test: > /cpputools/source/unoexe/unoexe.cxx:502:24: runtime error: member call on address 0x60600000c288 which does not point to an object of type 'com::sun::star::lang::XMain' > 0x60600000c260: note: object is base class subobject at offset 40 within object of type 'bridge_test::TestBridgeImpl' > #0 0x50dc0b in sal_main() /cpputools/source/unoexe/unoexe.cxx:502:24 > #1 0x507762 in main /cpputools/source/unoexe/unoexe.cxx:348:1 > #2 0x2b2ede591444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #3 0x429425 in _start (/instdir/program/uno.bin+0x429425) Change-Id: I7f2c38ef2f3cedae07d71246980ad1f21220db72
2018-07-05tdf#43438: SwContentTree: handle ModeChanged notificationMike Kaganski
Change-Id: Iebb53af7fb06ebab6d5cdd1ce514480caec1b17e Reviewed-on: https://gerrit.libreoffice.org/56985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-05find-unneeded-includes: stop proposing internal libstdc++ headersGabor Kelemen
They wouldn't really compile anyways and only cause unnecessary blacklist entries. Some '- memory' entries can already be removed from the blacklists. Change-Id: Iab53d5a57121f61abe935e712dc23a55390235bf Reviewed-on: https://gerrit.libreoffice.org/56979 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-18 05:42:02 +0000