summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-06-21Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ifd550df955cc95498949a0907e43ba41f68ba585 Reviewed-on: https://gerrit.libreoffice.org/56216 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-21Updated coreTor Lillqvist
Project: dictionaries 846e5da4b28bb40158cfb992f3a371614e25a349 tdf#104332 (and others): Fix two thinkos in my recent commit Change-Id: I6908826572153daeee1211ea3796a6e4a0e007b2 Reviewed-on: https://gerrit.libreoffice.org/56217 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-21Fix typosAndrea Gelmini
Change-Id: I6a42d683e2d4d2d8887822dc17ab2fd7f51982a5 Reviewed-on: https://gerrit.libreoffice.org/56210 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-20Prepare for Excel's dirty circular references iteration behaviourEike Rathke
In which either convergence is detected or N iterations are executed and the result is displayed no matter what. Which would "do N iteration steps" but never detect non-convergence. Enable that only with an additional option where the user specifies s/he doesn't want to be informed of non-convergence errors. Change-Id: I3caba0c200e16514e39ea46d7f899afc05a5a2cc Reviewed-on: https://gerrit.libreoffice.org/56183 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-20Avoid side effects of additional Interpret() during iterationEike Rathke
... which could alter results if this formula cell again depends on other formula cells in the circular reference(s). Change-Id: I2b56902a71c0f16f9777507402ea004ae609bfbc Reviewed-on: https://gerrit.libreoffice.org/56182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20show down arrow in GtkMenuButtonsCaolán McNamara
Change-Id: I6468474110adfc477927f6d89b44e92d29384484 Reviewed-on: https://gerrit.libreoffice.org/56164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20tdf#66089 tdf#105720: only rely on bPixelToLogicAron Budea
Left-aligned currency symbols were put in preceding cells sometimes, because fill width was calculated incorrectly. Commit 37210da00a9190f7765fa9c1e4a08629d2f4c2c4 fixed the issue for LOK, but the bug was still reproducible in Calc if setting "Use printer metrics for text formatting" was enabled. Change-Id: I6cf90493cbf98c5020acd5faf1d0f3cf2def5c25 Reviewed-on: https://gerrit.libreoffice.org/56172 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20uitest Calc/Goal seek; tdf#37341 ; tdf#43693Zdeněk Crhonek
Change-Id: Ib6416eec6245f22f49687437a466b1e5c6d60efb Reviewed-on: https://gerrit.libreoffice.org/56181 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-06-20lok: Unit test for passing table borders via jsonToPropertyValuesVector.Jan Holesovsky
Change-Id: Iadc0d76a1903d76fcd84f316d4796cc1dec13277 Reviewed-on: https://gerrit.libreoffice.org/56150 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20lok: Unit test for jsonToPropertyValuesVector.Jan Holesovsky
Change-Id: I3e0623cc68838c650edbd03cc89bf3fcb8098ff8 Reviewed-on: https://gerrit.libreoffice.org/56149 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20lokit: add jsonToUnoAnyHenry Castro
Change-Id: I79c2fe22fe7f3a8daa121ecaa529b6bca3216bf3 Reviewed-on: https://gerrit.libreoffice.org/56032 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-20Make check for ant a bit more robustStephan Bergmann
...by cd'ing to an empty dir first. As reported in the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-June/080400.html> "Ant not working ???", there appear to be Java toolchains that can be disturbed by filenames with "accented" (non-UTF8?) characters, which people may happen to put in their checked-out SRCDIR. Change-Id: I9cf3523f4816c3b0e2d6f67fc490c2514c8e1263 Reviewed-on: https://gerrit.libreoffice.org/56158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-20Updated coreTor Lillqvist
Project: dictionaries 2d8dd0af877de8494ca9c2c027eba4a42bbc09eb tdf#104332 (and others): Speed up Lightproof initialisation Delay import of the the heavy lightproof_impl_pt_BR to when actually needed. Shaves several hundred milliseconds (on my machine, about 300 ms) from the time needed to just get a list of what grammars checkers are available. It's silly to load the heavy pt-BR impl module even if no Brazilian Portuguese proof reading is being performed. Sure, the same change could be done to the other Lightproof dictionaries, too, but they are much smaller, so importing them unconditionally always does not hurt so much. Change-Id: I3c3f64e80bd9519f188905abda7c25337c81462d Reviewed-on: https://gerrit.libreoffice.org/56176 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-20tdf#117575 Add QA unit test of thousand sepLaurent BP
Change-Id: Id28e688e7f81a2f3f43f01be44d03c5f185ffd01 Reviewed-on: https://gerrit.libreoffice.org/55904 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-20NatNum12: fix and add capitalization prefixes, tdf#115007 follow-upLászló Németh
Limit NatNum12 conversion only for the selected parts of the date format (this bug – double calls of getNumberText – was hidden by the space prefix " " and empty return values at the first calls, resulting unchanged dates yet). New prefixes: "capitalize", "upper" and "title" to handle optional capitalization. (In Calc, it was not possible to format the result of NatNum formatting, but some languages often need capitalization or title case to format numbers and currencies.) Thanks code clean up using enum WhichCasing to Eike Rathke. Change-Id: I5fceb784930e6bc6d376116f5a42ad49cd248a54 Reviewed-on: https://gerrit.libreoffice.org/55681 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-20Resolves: tdf#118120 RET_ALL shares same value as RET_HELPCaolán McNamara
Change-Id: I766c379171ac25eb9c1d8036e052fb8f2b4e1459 Reviewed-on: https://gerrit.libreoffice.org/56167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-20tdf#77517 Additions to unit tests.Winfried Donkers
Change-Id: I2b4035ceeb4cb65de811628100efdda7e3c127ae Reviewed-on: https://gerrit.libreoffice.org/56056 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-20Related: tdf#117049 treat yet unknown result as initial 0.0Eike Rathke
For the first =A1+B1 in B1 with iterations the result could had been #VALUE! depending on string conversion calculation settings. Change-Id: I8d7a745d67ba7a20f7a66e8aa143642d08ea5111 Reviewed-on: https://gerrit.libreoffice.org/56173 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-20Resolves: tdf#117049 do not re-interpret a single circular self-referenceEike Rathke
... to not execute the calculation twice, which added an implicit iteration step. Change-Id: I943f770d32ebe84a8359f2f94c1f0bf5731b6f88 Reviewed-on: https://gerrit.libreoffice.org/56170 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-20Colibre icons: 32px updateandreas kainz
Change-Id: I08f53b7c2e961c249e5109641288ad6dc84af7d9 Reviewed-on: https://gerrit.libreoffice.org/56159 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-20remove printfTomaž Vajngerl
Change-Id: I82ba88a11936616f3ddfebed5a550fee79ef73f7
2018-06-20Fix UITest_solver for --enable-ext-nlpsolverStephan Bergmann
...after <https://gerrit.libreoffice.org/#/c/56121/> "uitest Calc/Solver" was merged (see comments there for details) Change-Id: I6cc0833b353d79a3be3be85078776c44588b5182 Reviewed-on: https://gerrit.libreoffice.org/56163 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-20loplugin:useuniqueptr in ScColContainerNoel Grandin
Change-Id: Icb4fffb27535a767b307c1d01e5bc96372c98352 Reviewed-on: https://gerrit.libreoffice.org/56108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SdDrawDocumentNoel Grandin
Change-Id: Id67b08d8d8a08d7e19ef8534b7bb9d689a571e06 Reviewed-on: https://gerrit.libreoffice.org/56105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxSearchFormatDialogNoel Grandin
Change-Id: Ie7da9255e27734f93f7a7758ca9ec25108c0e547 Reviewed-on: https://gerrit.libreoffice.org/56104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in HtmlExportNoel Grandin
Change-Id: Ib146bdfd04f428d922e23ec6b5054d53326ca5f3 Reviewed-on: https://gerrit.libreoffice.org/56106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SfxAcceleratorConfigPageNoel Grandin
Change-Id: I12c6ca5542729d4af77a7d4253ea1bbaae81781c Reviewed-on: https://gerrit.libreoffice.org/56096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20tdf#42949 Fix IWYU warnings in sc/inc/[ux]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management Change-Id: I53d2c5dc9e16a64a143b16316d2aeab05023d866 Reviewed-on: https://gerrit.libreoffice.org/56076 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-20fix new a11y warningCaolán McNamara
Change-Id: I637c48335bb8e532bb8bad3b05e60fb1c06f6414
2018-06-20menubar scalc: sync with swriter layoutandreas kainz
Change-Id: Iac8cd198b85f83fbd7fa71a228df13f150ef04fc Reviewed-on: https://gerrit.libreoffice.org/56071 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-20Add UI test for the Customize dialogMuhammet Kara
Change-Id: I00109ef54ec7cfc1f4976794daa92ded3cd6ce4b Reviewed-on: https://gerrit.libreoffice.org/53119 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20forcepoint: rework to explore loopCaolán McNamara
Change-Id: I14f6a3269fc3347a9976d899519e74f58d5975c8 Reviewed-on: https://gerrit.libreoffice.org/56125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxFontSubstTabPageNoel Grandin
Change-Id: I3e9e1c91f541c7e191ceb3d7ee6974fa46d26c6b Reviewed-on: https://gerrit.libreoffice.org/56101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in PropertyControlNoel Grandin
Change-Id: I6b648f26f3946da27585a70f18406e92d9de80c2 Reviewed-on: https://gerrit.libreoffice.org/56107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in AlignmentTabPageNoel Grandin
Change-Id: I78dc902ae41eb8d8423c83a4ec32a4ca932bbc5e Reviewed-on: https://gerrit.libreoffice.org/56103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20gla11y: Enable warnings for more widgets missing a labelSamuel Thibault
Namely GtkTreeView GtkTreeViewColumn GtkTextView GtkDrawingArea Change-Id: I4190fc73d0c7fd3575bef0388f44aa52b51f29d2 Reviewed-on: https://gerrit.libreoffice.org/55743 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-20filter clean-up: remove duplicate of checking EMF magic headerLászló Németh
Change-Id: I63fd380be974c1d15beef0d2cfec42350119ae2f Reviewed-on: https://gerrit.libreoffice.org/56050 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-20coverity#1437408 Uninitialized scalar fieldCaolán McNamara
Change-Id: I553198047d999be1cbaa20b1a1829ffc9e5197b5 Reviewed-on: https://gerrit.libreoffice.org/56116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20coverity#1437409 Unchecked dynamic_castCaolán McNamara
Change-Id: I00d0bfc961bd7b8b183008be1d9be93d1e717688 Reviewed-on: https://gerrit.libreoffice.org/56117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxDefaultColorOptPageNoel Grandin
Change-Id: I398ba3828bddf295e99624d7caa8d636e96c360c Reviewed-on: https://gerrit.libreoffice.org/56100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxColorOptionsTabPageNoel Grandin
Change-Id: Iefd1719a4f9c529840b4c584df8c7f2104d29fb3 Reviewed-on: https://gerrit.libreoffice.org/56102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in IconChoiceDialogNoel Grandin
Change-Id: I4a97cd8497056b48f8fb6439b2dc428887e0a0b9 Reviewed-on: https://gerrit.libreoffice.org/56098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20xmlsec: update to 1.2.26Miklos Vajna
Allows dropping the xmlsec1-ecdsa-assert.patch.1 backport. Also fix the generated test certs + generator script to avoid expired certs for a while (.db files generated with Firefox 57.0). Change-Id: I8cba9a01633a3952c845e15e23b18d44544cdb59 Reviewed-on: https://gerrit.libreoffice.org/56123 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-20menubar writer: remove designmode from editandreas kainz
designmode is for forms and available already there Change-Id: I460b49bba8dbfd1e2f3a91b1478f5414fe09db86 Reviewed-on: https://gerrit.libreoffice.org/56060 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-20loplugin:useuniqueptr in SvxCharacterMapNoel Grandin
Change-Id: I85e254fc59b4b0954bbed3876935f56e6480f525 Reviewed-on: https://gerrit.libreoffice.org/56097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in TPGalleryThemePropertiesNoel Grandin
Change-Id: I4a288f9bd1b8abd7c588c1c895c8b6a8ef399fc2 Reviewed-on: https://gerrit.libreoffice.org/56099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20personalization: disable "own theme" button if we don't have anyNoel Grandin
Change-Id: I3a5bfb757361208ce4ec193698a6e87b66285906 Reviewed-on: https://gerrit.libreoffice.org/55846 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-20Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I73d08a2fa9af0aaed7f748f43a0ffc9b53c79c5f Reviewed-on: https://gerrit.libreoffice.org/56138 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>