summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-18Drop unused HAVE_FT_FACE_GETCHARVARIANTINDEXJan-Marek Glogowski
Change-Id: Iececf24304d69b5f06903be52193bf3b222ce2aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128521 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18Remove now invalid using_vclplug infoJan-Marek Glogowski
Follow-up on commit 5da906d07bf88bb9c56325d03272006d5a0662c4 ("iOS+SVP convert remaining VCL plugins to salplug"). Change-Id: Ifa2bee03c1cc107aaf22aedcbb08815d2623d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128525 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18Resolve gtk3 crash of If1ffb50743292f3cc0c3271646d0538337977762Heiko Tietze
Change-Id: Id1080b71d1252bdcef804a4f8398a3c42073ee0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128522 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-18SwNavigator: disallow tracking update when content tree has focusJim Raykowski
When document layout has not finished and there is no content to track at the cursor position, e.g. the cursor position is at the start of a document having text before the first heading paragraph, a selection made in the Navigator content tree can automatically unselect. This is not only annoying but causes a crash when action of a choice from the Navigator context menu is dependent on entry selection, e.g. 'Delete', 'Edit', 'Rename'. This patch prevents this annoyance and crash by disallowing content tracking when the content tree or the content tree context menu has focus. Change-Id: I2b0fd1ac4f53571e30ce1efa2934a70de2aad819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128520 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-18RTF import: handle the pictureContrast and pictureBrightness shape propsMiklos Vajna
Map it to (the UNO API of) GraphicDrawMode::Watermark, similar to what the binary import does in SvxMSDffManager::ImportGraphic() and how the drawingML import does it in oox::drawingml::GraphicProperties::pushToPropMap(). Change-Id: I8023aa8fcbd086d4c7a30729e3ca615a7356da4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128515 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-17Avoid -Werror=dangling-pointer=Stephan Bergmann
> vcl/source/bitmap/Octree.cxx: In constructor ‘Octree::Octree(const BitmapReadAccess&, sal_uLong)’: > vcl/source/bitmap/Octree.cxx:69:17: error: storing the address of local variable ‘aColor’ in ‘*this.Octree::mpColor’ [-Werror=dangling-pointer=] > 69 | mpColor = &aColor; > | ~~~~~~~~^~~~~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘aColor’ declared here > 67 | BitmapColor aColor; > | ^~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘<unknown>’ declared here (new with GCC 12) Change-Id: I5b1ffa15b92f2c41dbe51dfa843eb6bab3a4b449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128517 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-17Mysql/MariaDB: copypasta from Firebird part, no pb for table renaming hereJulien Nabet
Change-Id: I58cb94376e8cf7f06cd825ee7019fb5e9726fc9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128516 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-17tdf#146731: sd_layout: Add unittestXisco Fauli
Change-Id: I50e7c1e89a217c845612d02942a22d9ef1abbea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128511 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-17tdf#145538 - Use range based for loopsVaibhavMalik4187
Change-Id: I5bf5a88d40f9633d9af9c40df2ee927130701f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128318 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-01-17sd: this is actually a layout test, move it to the right fileXisco Fauli
Partially revert fa5ab8aa5d88e7128015127af75980a65f945cbb < tdf#135843 Fix the missing border handling > Change-Id: Ib80530c9e46e029c910843beac0d55dbd393af3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128512 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-17Resolves: tdf#146757 Use correct format index keys instead of wrong hackEike Rathke
The hack worked by accident as long as the internal index constants didn't change. Which was the case with commit f7d0c6b42a0a5ec98876006cd5048589219be741 CommitDate: Thu Sep 23 20:28:42 2021 +0200 Sort ZF_STANDARD_NEWEXTENDED_DATE_... into ZF_STANDARD_DATE category convertDateString() Standard + 36 == old ZF_STANDARD_DATE + 6 => DATE_SYS_DDMMYYYY unchanged convertDateTimeString() Standard + 51 == old ZF_STANDARD_DATETIME + 1 => DATETIME_SYS_DDMMYYYY_HHMMSS became wrong nothing (no format assigned, empty DATE slot) convertTimeString() Standard + 41 == old ZF_STANDARD_TIME + 1 => TIME_HHMMSS became wrong ZF_STANDARD_DATE_SYS_DMMMMYYYY (DATE_SYS_DMMMMYYYY) So time 08:00 double 0.33333... was converted to string "30 December 1899" which then numeric was 0. Change-Id: I642e0a977d4e167f78537d20624e86721e518c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128507 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-01-17Use convertTwipToMm100 directlyMike Kaganski
Change-Id: I776f5c1babca523c476a5a094ed219219e1c89c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128445 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d7f7d5045e12127006f92247e7df56076c65f0ba - Remove inacurate statement on regex Help page Refer to discussion in patch https://gerrit.libreoffice.org/c/help/+/73408 Change-Id: I543e052609ca4330f52a2c4ebae7189a2275ba75 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128509 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-17loplugin:finalclasses in chart2Noel Grandin
Change-Id: I6cc88d50df7a6c77285f8534de43fd0c8d251bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-17tdf#144862 set default render mode to LayoutAndMatchRenderCaolán McNamara
Change-Id: I7340d7b7802a58922635fe49a4f15e085505e409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17Drop unused declarationMike Kaganski
Change-Id: I17cd0d144b64fc6bfc8ce10f1de2db3ce4565ac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128444 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-17Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to df6f47ebcb1caf2a9791661de0fa8c484efd0515 - tdf#129697 Use LIBREOFFICE instead of GLOBAL as index heading Change-Id: I8c00eb4ed888eb8b2e898144141ef1c5a659bb49 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128503 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-01-17vscode-ide-integration: use gdb from $PATH by defaultMike Kaganski
Change-Id: I6f69439465b2968c5ab3900dbb9d5591c1c1f800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127360 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-01-17Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 96608a0e847be46c1429e5711b08e7a0c2b66e68 - tdf#89805 Document "Always apply manual breaks" option This patch also refactors headings to use <h1>, <h2> and <h3>. Change-Id: If886313cd9e140246016d8c6537f4267c1d4b0a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128431 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-17tdf#145321 Crash scrolling DOCX to bottomNoel Grandin
this is a consequence of commit d4dc6b5cfdb02ad00a06ad32650948648abe010d use std::vector for fetching DX array data which made pre-existing bugs easier to see. This crash made apparent that we have bad data ending up in SwDrawTextInfo. So I added some asserts there to catch that. However, that simply made apparent that there are bug(s) at a higher level that I have no idea how to to fix. So at the primary problem site in SwTextCursor::GetModelPositionForViewPoint I clamp the values to sane ones. Change-Id: Ic74f6944932bbfc22e8cf9addf9e7511755b18be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-17SVG export: fix missing custom bulletsMiklos Vajna
It seems this was broken since b76628acb1ae4fc06f8c1b70ec2e0cf39356deef (text export support for bullets and hyperlinks, 2012-08-11), the problem is that SVGFilter::implEmbedBulletGlyphs() has a fixed list of characters that are typically used as bullets, but e.g. "-" is missing from that list. Fix this by improving SVGTextWriter::implWriteBulletChars() to continue working from those shared glyph paths when the glyph is in the fixed list, but otherwise call GetTextOutline() to look up the path for the custom bullet. Change-Id: I3de8fab8dc6c78e273629d13566d1f9f289eb752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128495 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-17tdf#135843 tdf#146731 Fix the missing border handlingGülşah Köse
Reverts fa5ab8aa5d88e7128015127af75980a65f945cbb inside. And fix the missing border problem with better way. Reason of the problem is using ORIGCELL cell style for bottom and right of merged ranges is wrong. Eg: We have Row X Col 3X3 table. (0,1) and (0,2) merged. The right side of right border style should be same with (0,2). But ORIGCELL points (0,1) instead. In case we should use LASTCELL. Same reason is valid for bottom case. Change-Id: I5282083541f0bd02f3765943da4f34cabe05ef13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-17tdf#136362 Remove unnecessary blank area and option in some image toolbarJeff Huang
Only in Calc, Draw and Impress. Change-Id: I944aad875fedd1dd19657c49b059e33fd6e9d3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127984 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I77847175d5ad0b2757eb24fcff08a4caf5d77519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17iOS+SVP convert remaining VCL plugins to salplugJan-Marek Glogowski
While this makes the preprocessor usage even larger, the code in salplug.cxx is now hopefully easier to follow. I added a comment about the main code structure at the beginning. It also includes changes to the generic plugin list to include gtk3_kde5 before gen, qt5 and qt6 after gen, but still skips the headless / svp plugin. And I explicitly excluded salplug.cxx from the externandnotdefined compiler plugin. I could have added a dummy, but that seemed not worth the effort. My try on a non-dummy with correct includes and defines made the code in salplug.cxx much harder to follow. FWIW, the iOS VCL plugin actually seems to use the osx SalData, so I think these changes to iosinst.cxx are more correct then commit 7d990aafdc363b2a12b5db78637d7f3bef7780bd ("VCL drop m_pInstance from *nix SalData"). But hard to tell without a compiler. Change-Id: I0e2944d4221ca5910fb2120cc8b24def5c5b3f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128477 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-17Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 21f7faaea2017e085b030d4c40c24067e37a1ee5 - Related tdf#123318 Fix harder and update Base URL path Base Help used to be generated into the path shared/explorer/database Change-Id: I977dea766c621c0387c78238b65e45b5d4017929 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128450 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-01-17Add <module>.*all aliases to .all* and update helpJan-Marek Glogowski
And just echo a rename info for the 'all' target and exit with an error, so people will actually adapt. 'all' had been modified to run 'allbuild' in the original commit anyway. And since there is no toplevel 'all' target, this just seems consequent. And .PHONY the new targets. Also advertise "make help" a bit more at the end of configure. Follow-up on commit d6496fce2e51a3e44753e6b5c462824f182b48d5 ("split gbuild's <module>.all to <module>.allbuild or .allcheck"). Change-Id: Ia74020375f0a024dc67ea37ae4b18655af9df084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128490 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-17ensure glyph fallback would use the correct dxarray variantCaolán McNamara
Change-Id: I4f7183f2f038bcc780e9438b04ee4d15b945d065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17sw: prefix members of SwTableFUNC, sw::sidebar::PageFooterPanel, ...Miklos Vajna
... sw::sidebar::PageFormatPanel and sw::sidebar::PageHeaderPanel See tdf#94879 for motivation. Change-Id: I68ac0ba7d36ae9217a98d90245cac104c636fe1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128492 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-17Resolves tdf#143733 - Make selection border widerHeiko Tietze
Border width and handle size follow the zoom factor now Border is drawn evenly inside and outside the rectangle Change-Id: I83cfb8a8156e2f0346ded3e2abed4386d4006d00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128222 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-17tdf#142450 add code to store showing whitespaceDhiraj Holden
I have put in code to store the option to show whitespace. This option is stored at the document level like the other layout options. Change-Id: I26989da2714f884a5a4d5ced3329ff669771fe7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126497 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-17Recheck modules [e-f]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-16Mysql/MariaDB: implement edit VIEW with GUI or SQLJulien Nabet
Delete View works (and the list is updated) Modifying View works But, there are at least 2 things to fix: - adding a view still works but the list isn't updated without manual refresh) - renaming view doesn't work (a popup error message appear) Change-Id: I48ffb322910ca64d51a161424f265de387bdd7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128483 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-16tdf#146421 Calc Sidebar Alignment Section follow arrangement guidelineandreas kainz
Change-Id: If1ffb50743292f3cc0c3271646d0538337977762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126688 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2022-01-16SwNavigator: use one loop instead of two to fill fields member listJim Raykowski
Change-Id: I02f20e48606a34b2f9f4739f1777dd8aea8637ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127798 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-01-16dump AltNaturalDXArray if presentCaolán McNamara
Change-Id: I3410a7c4c999e660b2df69dcea8f7c5bd7fa3196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16add missing placeholder labelsCaolán McNamara
Change-Id: Iae743fd6d7e13f91501e386e609e5965ef742db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16tdf#146453 retain precise vertical base pos with ResolutionIndependentLayoutCaolán McNamara
Change-Id: Ied157d8d4bc9b57cfa17716453189ddf48cba641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Related: tdf#146453 retain accurate positioning in rotated text renderingCaolán McNamara
Change-Id: I477c5a72dd9618a2b0f3e91a96209ae3f6b3d1aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Firebird: missing space in DROP commandJulien Nabet
It's more to have something clean. Indeed there wasn't impact on Firebird since the table name is surrounded by quotes, eg: DROP TABLE"TableTest" Change-Id: Iad525ccb912347798c6780fd1a5bac12ee85333f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128488 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-16restore the explicit translatable="no" for some labelsCaolán McNamara
Change-Id: Ifbb05dc12a02afd11470e868b88d72fa18c1a388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz#43689 Null-dereferenceCaolán McNamara
Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16Qt notify LO of many QScreen related eventsJan-Marek Glogowski
LO just has a single display event, SalEvent::DisplayChanged, Qt has a multitude. So this will generate multiple LO notifications. I don't see any reasonable way to prevent that. Doesn't seem a problem here. Change-Id: I2f11e53765869a4ca292a1d337347e4e7470e3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128474 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-16use more concrete types in chart2, ChartViewNoel Grandin
Change-Id: I51d503cd71ef2adc0e590ef836dabf9906495bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-16use more concrete types in chart2, DiagramNoel Grandin
Change-Id: Iae84e16b3406f4c08139764a1838e38b13cebee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-16tdf#146439 retain precise base start pos when using ResolutionIndependentLayoutCaolán McNamara
Change-Id: I16a585abf4805d87a2eeb4e3e9d9bd9f2697b838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15include memory for std::unique_ptrCaolán McNamara
Change-Id: I63aa82b45f3dfcfd89d5d655eae3b347c1092af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15use more concrete types in chart2, ChartModelNoel Grandin
Change-Id: Iecbc92aa096ede1845936faa708d1a9e8747b658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-16 06:17:10 +0000