summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-22better name for a function overloadLuboš Luňák
It's better to add to the name what the overload does rather than just have a "mysterious" extra int. Change-Id: Iff89679c4a978a4596ac662ef74e934cdefefc9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124001 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-22revert unittests to use plain text-based LibreOfficeKitCallbackLuboš Luňák
At least for now it seems that the more complex SfxLokCallbackInterface is just an unnecessary complication for unit tests. The performance doesn't matter, and handling all the specialized callbacks makes things more complicated. In the future it'd be also useful to make the tests (optionally?) use also CallbackFlushHandler as the provider of the messages, in order to test CallbackFlushHandler more thoroughly, so perhaps in the end it makes more sense to keep unit tests using the plain text interface. This reverts unittest-related parts of 3b729db05553c1a6d461fb41c89 and adds a smaller wrapper callback class that converts messages from SfxLokCallbackInterface to LibreOfficeKitCallback format. Change-Id: I6c14f0be4ed7b777444b131140be54188d309cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124000 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-22no need to allocate RangeIndexMapPtr separatelyNoel Grandin
Change-Id: I0e2aae923530667877bfb111b006b214ca51a730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22tdf#145274 FILEOPEN: Text properties are lostNoel Grandin
Revert "tdf#135683 speedup SwAttrHandler" This reverts commit b62153753a9f21afb2a49110ef0459e427b0b01a SwAttrHandler::RemoveFromStack breaks the assumption I made in creating the above commit Change-Id: I20ab532e1eae98c94f7c579755285262d46f2f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124012 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22vcl: move variable declar's closer to 1st use in DrawComplexGradientToMetaFileChris Sherlock
Change-Id: Id626799d1b077e649f67a8abf335a63efd15d433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123000 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-22lok: invalidate sheet-geometry sizes on clip pasteDennis Francis
Change-Id: Ie2b308f970673381dfa354620e3394acb44f971f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123869 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit a547f8a1db3c39ad2c84a6bc11cec075ad52c268) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124011 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-10-22LOK: introduce way to restrict uno commandsPranam Lashkari
With this new API we can define which uno commands to restrict their functionality Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx include/LibreOfficeKit/LibreOfficeKit.h include/LibreOfficeKit/LibreOfficeKit.hxx include/sfx2/viewsh.hxx Change-Id: I9f3fd659d373e56542c5323922a53564f1cfb27b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124046 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 69519a798132d28edb7f1cee5ef7f801b853dcba - Fix variable name Change-Id: I508ae24bb0a38be10eae3b88dbef060b555ef2a4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124043 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-22return weld::Builder by unique_ptrNoel Grandin
Change-Id: Ifa4f5951d200eaad6c8aebd3f29eed053c927ff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22Make external/breakpad/ubsan.patch apply againStephan Bergmann
(It apparently silently broke with something like ff673ce838a5538b1432daf9007c047f6455a5ba "update breakpad to the current chrome_m90 snapshot" and nobody doing ASan/UBSan builds with --enable-breakpad in the meantime.) Change-Id: Ic955e1725d2493d849b460a09dfa0238815e2c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124033 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-22Improve emfio module documentationHossein
* Describe how it works * Fix the example * Better formatting * Fix typos Change-Id: Ia568ca522453a6c3da1502bd2e7c3a8ce3a29fc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123987 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-22freetype: Build '--without-brotli'Michael Weghorn
After commit c99b73c16b725ec2bf2f5417f28d1688c3322d7d Date: Wed Oct 20 12:08:02 2021 +0100 upgrade freetype to 2.11.0 my local Android x86 build (using NDK 20.0.5594570) started failing with In file included from .../workdir/UnpackedTarball/freetype/src/sfnt/sfnt.c:25: .../workdir/UnpackedTarball/freetype/src/sfnt/sfwoff2.c:27:10: fatal error: 'brotli/decode.h' file not found #include <brotli/decode.h> ^~~~~~~~~~~~~~~~~ 1 error generated. Disable the optional Brotli dependency added upstream with commit 9443a1bc3e6cfa315db976ff80f6c5e91b12b387 Author: Nikhil Ramakrishnan (निखिल रामकृष्णन) <ramakrishnan.nikhil@gmail.com> Date: Fri Jun 28 01:01:17 2019 +0530 Add Brotli dependency and required checks. Brotli is required for decompressing WOFF2 font directory streams. The library is thus being added as an optional dependency for FreeType. * builds/unix/configure.raw: Add checks for `libbrotlidec'. (REQUIRES_PRIVATE, LIBS_PRIVATE, LIBSSTATIC_CONFIG): Updated. * devel/ftoption.h, include/freetype/config/ftoption.h (FT_CONFIG_OPTION_USE_BROTLI): New macro. Change-Id: Iea8d3e333cb60182026fb9fde5a0171ae197ee57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124031 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-22sw: remove useless debug code in SwTextShellMiklos Vajna
A debugger can be used to examine that temporary instead. Change-Id: I8c04144f5174564e232c5d5effe466ccf5e52468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124037 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-22Optimize assignment from OUStringLiteral to OUStringStephan Bergmann
...by making the OUString's pData point to the OUStringLiteral, instead of copying the contained characters. This is one of the improvements that had not been done as part of e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString": "To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc." (Simply dropping the OUStringLiteral overload was not possible in this case, though, as that would have lead to ambiguities among the various OUString and std::u16string_view overloads.) The now-deleted OUStringLiteral rvalue reference overload means that some existing assignments from ternary-operator OUStringLiteral<N> to OUString no longer compile and had to be replaced with uses of std::u16string_view. Those had not already been replaced in e6dfaf9f44f9939abc338c83b3024108431d0f69 because they happened to use OUStringLiteral instances of identical length N in both arms of the ternary operator, so did not already start to fail to compile back then. Change-Id: I328e25b8324d045774e811d20a639f40d6a9a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124040 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-22Removed duplicated includeAndrea Gelmini
Change-Id: Ie5f8e53334f060dd99bb55ea034cc0370ea7a6ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124034 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-22re-arrange BlockInfo a littleNoel Grandin
so that it is more likely that the interesting data is next to each other and thus in CPU cache (i.e. the control fields and the first few elements of the array) Change-Id: I50e46df3f639899e39f1b7733cf8e754d2435b4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22Use size_t instead of sal_uLong in filter/source/svgJulien Nabet
Change-Id: I741307bdecbb6e5104a8fcdf892ea609671ae6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124032 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-22Remove sax dependency from emfioHossein
Module 'sax' was one of the dependencies of 'emfio'. This is also mentioned in: https://wiki.documentfoundation.org/Development/Build_System Previously, module 'emfio' was directly depending on 'drawinglayer' and 'sax'. But the build is fine when 'sax' is removed from 'emfio/Library_emfio.mk'. Also there is no mention of sax when invoking 'git grep sax' inside emfio folder. With this patch, the 'emfio' dependency on 'sax' is removed. Change-Id: Ib6f9dc3df33865b6fc912d02b27b01232a6a3fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123988 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-22Converted VCL documentation to MarkdownHossein
Converted VCL documentation to Markdown format: * README.md Main README file (Added link to other md files) * README.vars Environment Variables in VCL * README.GDIMetaFile GDIMetaFile class * README.lifecycle Understanding Transitional VCL Lifecycle * README.scheduler VCL Scheduler Change-Id: I15d973b14005a4944f7b5104c5c80184e1083203 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123867 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-22tdf#144999 SwNavigator: Add way to collapse all categoriesJim Raykowski
This patch adds a context menu item that can be used to collapse the content tree to the root categories all at once. Change-Id: I15274e6db838e9e8503a79384bed4ffcf983041c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123811 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-22Resolves: tdf#92015 Handle malused *:rfc-language-tag ODF violationEike Rathke
... and don't let it overwrite existing fo:* tags with less information. Change-Id: I63c223f6bccd682e4173449ddc76c36e8fac6c35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124042 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-21tdf#145245 correct relative position of extrusionRegina Henschel
ODF specifies for draw:extrusion-depth, 'The draw:extrusion-depth attribute specifies the depth of an extrusion. It takes two white space separated values. The first value specifies the depth of the extrusion in units, the second value specifies the fraction of the extrusion that lies before a shape. The second value shall be in the range [0,1].' The default for the second value is 0. Because LibreOffice has no UI to change the value, the error becomes only visible, if you create own custom shapes. On import the ODF values are put in CustomShapeGeometry>Extrusion> Depth. Method GetExtrusionDepth() calculates from that the length values rBackwardDepth and rForwardDepth so that its sum is the depth. CreateCustomShapeProperties() in escherex.cxx#2699 and ApplyCustomShapeGeometryAttributes() in msdffimp.cxx#1684 use them in the same sence. But methods Create3DObject() and CalculateNewSnapRect() in EnhancedCustomShape3d.cxx have used these values as if they were coordinates. I have keept the calculation in GetExtrusionDepth(), because it reflects the meaning in ODF. I have corrected the signs in Create3DObject() and CalculateNewSnapRect(). Change-Id: If275bb263b6f3d790f5893a69f38f8433acfbe7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123997 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-10-21tdf#141634 Special end of para split for folded outline nodeJim Raykowski
After split place the cursor on a new blank line after the folded content and at the same level as the split outline node. Change-Id: I4073a1c0047ab8479993d8e605cc038896cd4630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123747 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-21Fix typosAndrea Gelmini
Change-Id: I7e249b2fd01dac96afb03dc0ddca6a1080f190f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124035 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-21ofz#40166 fix build failureCaolán McNamara
Change-Id: Ie71b63cbd7e10aff6a9374dcaad24c3153db3bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124039 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 08d7c8f595a3d4b4736e2bc993867cbcb4fa71d2 - tdf#144463 Fix Slide Show help pages Change-Id: I464f7c4c09bb04f484c94ff29ec1ad63c201eb3a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123515 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 2aae6a437951d1029eaeb13fdeaa70ce48ef5e72 - Fix <embedvar> tags for better l10n (Part 2) This is Part 2 of the fixes requested by translators concerning the use of the <embedvar>. Change-Id: I4c846632ded9a7260f86818d7a0eb6257b414b19 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124008 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to c37c5f2131d0fe893d7de8995e7deb73262988aa - Related tdf#143846 Improve Arabic/Roman help pages Change-Id: I4be244dba35f137c1b7d356aab658c5e08604e51 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123523 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to f025640e2603ee252a21e935c2790627a2e95224 - Fix <embedvar> tags for better l10n (Part 1) This is Part 1 of the fixes requested by translators concerning the use of the <embedvar>. Change-Id: Iee5ea4289034449c33156d4e20483943eb872ae0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123782 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-21Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 993399c7c55d58bf084234713b07ac6ef8442b03 - Fixing L10N issues Change-Id: I45c83f083b861fbe594cb83a82b419aa51b29526 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123786 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-10-21use sal_Int32 in BigPtrArrayNoel Grandin
now that it's only use-case is also using sal_Int32 Change-Id: I9c51bb8fd6b8f5713b84b1a1f0a216e676a73299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21sd: fix inteaction between multi-col shape text and automatic heightMiklos Vajna
Multi-column shape text works by assuming a fixed height, then flowing content to a next column once the current one is full. Automatic height works by first laying out the text and then resizing the shape to have a matching height. When both are enabled, then we used to first calculate the automatic height and then lay out the multi-col text using that height. PowerPoint takes the height from the file format and lays out the multi-col text using that fixed height, and only editing modifies the automatic height. Fix the problem by not updating the automatic height when we have multiple columns, this is meant to improve the stability of the layout anyway. Manual testing shows that editing the text on the UI still updates the automatic height, as probably expected. Based on Mike Kaganski's research - thanks! :-) Change-Id: Iaf46c6008018b4bf26310322f25788a49c1d27f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123999 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-10-21Typo: pragraph->paragraphJulien Nabet
Change-Id: I8363b3f9f4f11e3f7447e8bc0853fa4928f8550c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124030 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to b8e91b3ca199444badbbcca1bb135f30f6e434eb - Refactor XHP help files prior to patch This patch only refactors indentation and headings. No changes are made to help contents. Change-Id: I7cf71ab26381859d92791d95246e0bb88d8b88a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124007 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-10-21introduce SwNodeOffset strong typedefNoel Grandin
for indexing into node children. Replaces various usage of sal_uLong, tools::Long, sal_uInt32 with an underlying type of sal_Int32. Also add a NODE_OFFSET_MAX constant to replace usage of ULONG_MAX Change-Id: I2f466922e1ebc19029bb2883d2b29aa4c0614170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21Restrict macOS ARM64 to Java >= 17Stephan Bergmann
The commit message of e529461bcb126e0975ffa3f86e1fd5a630551de2 "Enable JVM also on macOS ARM64" had identified <https://cdn.azul.com/zulu/bin/zulu17.0.63-ea-jdk17.0.0-ea.27-macosx_aarch64.zip> "to work reliably now" while other (older Zulu) JVMs "have always crashed with SIGBUS that smelled like our uses of pthread_jit_write_protect_np in bridges/source/cpp_uno/shared/vtablefactory.cxx colided with corresponding calls in the in-process JVM". Those observations would be in line with <http://openjdk.java.net/jeps/391> "JEP 391: macOS/AArch64 Port" only implemented for Java 17 now (see <https://github.com/openjdk/jdk/commit/dbc9e4b50cdda35f5712deaf440c49f50b9edc96> "8253795: Implementation of JEP 391: macOS/AArch64 Port"). So for macOS ARM64 assume that all OpenJDK variants (i.e., providing an empty jvmfwk/distributions/OpenOfficeorg/javavendors_macosx_aarch64.xml) of at least Java 17 (i.e., building on recent 3460c16d7f749d8d2a59d8b927df5ec31f64a083 "Make getVersionInformation always return a VersionInfo" and "change the hardcoded '1.8.0' to '17' for just that one platform") work. Change-Id: I11e8ba232cee066a25a49edebd0cc50e24e84124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-21loplugin:flattenNoel Grandin
Change-Id: I3b4226a9d089ec9aedab95d96e50a068f57a76c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21tdf#144222 fix pdf export with vertical layoutMark Hung
Remove the offset adjustment that is no longer necessary. That was done in every backend before, and has been removed now. We can trust what layout text provides us. Regression from: commit dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481 Author: Mark Hung <marklh9@gmail.com> Date: Sun May 2 15:12:46 2021 +0800 vcl: adjust LayoutText() for vertical writing. Change-Id: I077f5a5f0711444086e56e4469dbcb3010ffe661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123682 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-10-21tdf#144650 crash after opening of read-only fileNoel Grandin
Change-Id: Ia888ae79940cbc618b2e693d0e658c152346e926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123948 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2021-10-21Use NSModalResponseOK instead of deprecated NSFileHandlingPanelOKButtonTor Lillqvist
NSFileHandlingPanelOKButton is defined as NSModalResponseOK in NSSavePanel.h: NSFileHandlingPanelOKButton API_DEPRECATED_WITH_REPLACEMENT("NSModalResponseOK", macos(10.0,10.13)) = NSModalResponseOK, For some reason, when as a test I just removed the SAL_WNODEPRECATED_DECLARATIONS_PUSH and _POP lines, I still did not get any depreation warning about NSFileHandlingPanelOKButton. I wonder if there is some problem in latest Xcode or in our build system that means we don't get any deprecation warnings at all any more on macOS. Change-Id: Ia61dd9f800eb7d251508dbd491a9c48c8e6118f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123964 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Mark external/cppunit/order.patch.0 as upstreamedStephan Bergmann
Change-Id: Ic0bfacd74e007c979d574e65767cbfb0d40c9ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123965 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-21Make getVersionInformation always return a VersionInfoStephan Bergmann
...even for JREs not listed in javavendors.xml, making it default to a VersionInfo with sMinVersion = "1.8.0". 3d27b2fa9c5a03f78e5145377402f8a88e3da1be "tdf#124503: Support JRE installations with unknown java.vendor property", which had changed getVersionInformation to return an optional<VersionInfo>, said in the commit message: "For simplicity, assume that any versions of such JREs are supported. Our baseline is Java 6, and there are unlikely any older versions of JREs from unknown vendors out there." Our baseline is Java 8 by now, and there are still unlikely any older JREs out there, but for macOS ARM64 we may want to restrict to at least Java 17 implementing <http://openjdk.java.net/jeps/391> "JEP 391: macOS/AArch64 Port", and this commit is a prerequisite for such a change (where we would then e.g. change the hardcoded "1.8.0" to "17" for just that one platform). (OtherInfo::compareVersions in jvmfwk/plugins/sunmajor/pluginlib/otherjre.cxx unconditionally returns 0, meaning "versions compare equal", so introducing a default version of "1.8.0" should have no negative effect on any JREs that use OtherInfo.) Change-Id: I34dc5f2b755c2254a91d42c262786ceec70c746e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123958 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-21ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7e8a0824ec5dba8d2c97b0963704f228f1956e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-21Bin dead codeTor Lillqvist
Change-Id: I2098172d065a195a15b7fd81a34dab25b1f38e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123956 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Add source files from fpicker/source/aquaTor Lillqvist
Change-Id: I10e84beb550c9e0410c35fe85db407fa1dceb5b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123955 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-21ofz#40166 fix build failureCaolán McNamara
Change-Id: I18d7993e508763edeb428b583783584afc295efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123953 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-21Update git submodulesMartin Srebotnjak
* Update translations from branch 'master' to ef9ad5558c68bdcb52ac8891dc5794ee0a1f7e31 - Update Slovenian translation Change-Id: I9063f14a9f9aed24e305f5fb1fc499bfcada5d2e
2021-10-21Fix commentTor Lillqvist
Change-Id: Ifd1068066c8711a1fa96ff4ede1fa0017a221617
2021-10-21Add documentation for the 'emfio' moduleHossein
The module 'emfio' is used to read and write WMF/EMF/EMF+. This is the list of topics discussed in the 'emfio' documentation: * Introduction * EMF+ Specifics * Limitations * Known Bugs * Dependencies * Tools * Related Software * References Change-Id: Iccd1269f62b8099b823d755c84e0ea51a545fae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123846 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-21sw: avoid 'else' after 'break' in textboxhelperMiklos Vajna
Avoids a not necessary indentation. Change-Id: Idc8fb511b835f93532ae732254ee7815d38c48eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123907 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>