summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-26vcl-svp: Store 24-bit images in 3-byte pixelsAshod Nakashian
This adds support in headless rendering for more compact 24-bit RGB image storage in 3-byte pixels instead of 4 bytes. There is a conversion necessary to accomodate Cairo, which requires 4-byte pixels, but that is relatively. Early tests show no loss of performance at runtime. Unit tests updated since the bitmap memory bytes are crc-ed, which obviously are different in size if not in content. (cherry picked from commit 354ad875092fd0c3b12f232950375206ec5d66a6) Reviewed-on: https://gerrit.libreoffice.org/46679 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 11adb51f2553dc4a838c8668d94909771d70e1ab) Change-Id: I3919f7c56d14d09e67f163f035b4c7683b49087c Reviewed-on: https://gerrit.libreoffice.org/47009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-26remove redundant space in question about modified imageStanislav Horacek
Change-Id: I293d535ef2bf8c9fd458944d9da3dcc2066326e3 Reviewed-on: https://gerrit.libreoffice.org/47056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-26loplugin:passstuffbyref improved return in basic,frameworkNoel Grandin
Change-Id: Ib19836febb59f4e2bb07dc874cfc6baabc653237 Reviewed-on: https://gerrit.libreoffice.org/47065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-26mark angle value in picturepage.ui as untranslatableStanislav Horacek
Change-Id: I20c2c13770d8bef2d4f8e117101fb92e8182e26e Reviewed-on: https://gerrit.libreoffice.org/47059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-26Remove redundant call to OutputDevice::ImplRefreshAllFontDataMike Kaganski
Since commit 40809ce46999e9cedb2fe5db8e9d53ebb6c182bf, OutputDevice::AddTempDevFont called OutputDevice::ImplRefreshAllFontData twice: first time explicitly before return, second time in UpdateFontsGuard destructor. Change-Id: Ie67bdcbd98de5f6053379af700239246412b88db Reviewed-on: https://gerrit.libreoffice.org/47066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-26svtools: Use std::unique_ptr for LineListBoxTakeshi Abe
This also inlines LineListBox::ImplInit(). Note that m_vLineList never contains nullptr. Change-Id: Ia4798943fbb53e1720d51faff7643e46d2cd2585 Reviewed-on: https://gerrit.libreoffice.org/47046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-26loplugin:passstuffbyref improved return in canvas and svtoolsNoel Grandin
and for now, ignore methods with params so we don't fall into the trap of thinking that calls to methods like: Bar& foo(Bar &p) { return p; } can be converted from Bar f() { return foo(Bar()); } to Bar const & f() { return foo(Bar()); } Change-Id: Ia3795eb2baf353cb6bec4ebf40451f2789d66ad7 Reviewed-on: https://gerrit.libreoffice.org/47034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-25Updated coreOlivier Hallot
Project: help be3381c27d46e71df2d513e42c1d68f3e0a14bfb Fix <filename> root path The missing slash corrects the caculation of the <base> tag. Change-Id: I1d1affcaef8b69049452f67d5ec122f6722874c6 Reviewed-on: https://gerrit.libreoffice.org/47061 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-25Updated coreOlivier Hallot
Project: help cd0fc90695b27b736b2c5e00389aa1052bfc6e30 Fix typos in help page Add switchinline Change-Id: I0bb07ddf67f8e83ab91a4de6c0d6d3c5c43a0e57 Reviewed-on: https://gerrit.libreoffice.org/47048 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-25coverity#1426946 Unchecked return valueCaolán McNamara
Change-Id: I42d94649df7e64dce0af7ae242523106b1a04679
2017-12-25ofz#4783: Integer-overflowCaolán McNamara
Change-Id: I44f5c71db2a2da00da510673ee6a596582c8e3b9
2017-12-25ofz#4777: Direct-leakCaolán McNamara
Change-Id: Iefb1304540b59a1d0fae79d9d5c1ad4a6474d925
2017-12-25coverity#1426945 Unchecked dynamic_castCaolán McNamara
Change-Id: I6c3d84a0fb1b4332f78a1c0ca04c9a7700b53c90
2017-12-25ofz#4732 Null-dereferenceCaolán McNamara
Change-Id: I5ed632702f3a2304902b32aa6ac770586cc4ef34 Reviewed-on: https://gerrit.libreoffice.org/47044 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25coverity#1426922 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6b45631448a447eb128f5e30a272f54651db77df Reviewed-on: https://gerrit.libreoffice.org/47039 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25coverity#1426923 Pointer to local outside scopeCaolán McNamara
Change-Id: I200b09dc514b64fbd88050a1f5a8668ec640305f Reviewed-on: https://gerrit.libreoffice.org/47040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4734 Null-derefCaolán McNamara
Change-Id: I9b0a5c1e14e95a686986975921f3adb769caad29 Reviewed-on: https://gerrit.libreoffice.org/47020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4738 Integer-overflowCaolán McNamara
Change-Id: Id15409ecde9e001d3be7ee60b34d43cbcc654a2e Reviewed-on: https://gerrit.libreoffice.org/47045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25coverity#1426921 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic264c74c2fc4cc5677895b50394a933b3e3fa9d2 Reviewed-on: https://gerrit.libreoffice.org/47038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4735 Null-dereferenceCaolán McNamara
Change-Id: I930c6ace947c4516facc36782451303e12dba336 Reviewed-on: https://gerrit.libreoffice.org/47043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25ofz#4760 Floating-point-exceptionCaolán McNamara
Change-Id: I4f379e045d12e8eae3dd140cfd6eb958a3003d09 Reviewed-on: https://gerrit.libreoffice.org/47042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25Adjust includesAron Budea
Change-Id: I11385fc987e6951570454919c110de7167f41f5a Reviewed-on: https://gerrit.libreoffice.org/47036 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-12-25tdf#114684: don't print pages for ranges completely outside ...Mike Kaganski
... of possible pages range. Change-Id: Ibe50f116aecdad8c7cba7f9844bc04c15716d127 Reviewed-on: https://gerrit.libreoffice.org/47052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-25tdf#114663: consider left/right page numbers when not printing blanksMike Kaganski
Commit 3c1a343f6936f1dcefdf79a677f8c26ce29676e6 made it possible to use document pages' sequential number (unaffected by automatically inserted blank pages) in Pages input box when not printing blank pages. But the implementation didn't take into account the case when only left/right pages were printed. In this case, it treated the unprinted right/left pages same way as automatic blanks, i.e., excluded they from page numbering, so that e.g. when user entered 10-20 (when selected even pages), actually printed 11 pages from tenth even page (#20 in original document) till twenteeth even page (#40). Expected result (familiar from other applications, and worked before the commit) is to print 6 pages with even numbers, that are in the pages range 10-20 of original document (10,12,14,16,18,20). Now we consistently use StringRangeEnumerator::getRangesFromString after converting user input with page numbers conditionally referring either physical pages, or pages without blanks, to equivalent range string referring physical pages. This preprocessing of range string also ensures correct enumerating later (when StringRangeEnumerator is created based on this string, e.g., for processing of PostIts). Change-Id: I2381699bc4c37841bf9ce789cdad03141dd72255 Reviewed-on: https://gerrit.libreoffice.org/47030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-24sc: compact ScColumnAshod Nakashian
Remove ScDocument* member from ScColumn and re-use the one in ScAttrArray. This saves 8 bytes and makes the code more homogenious by using GetDoc() member everywhere. (cherry picked from commit 1168a11278ed3c2a00058e1f802f6e44cb925318) Reviewed-on: https://gerrit.libreoffice.org/46680 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit dc3f0bde0bdef2a1e94055be146b433cb9fc54ba) Change-Id: I16a94b7ef7c45ef3af14e812b45f255f39939a6e Reviewed-on: https://gerrit.libreoffice.org/46990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-24pdf: use bimap for GraphicsContext-id mapAshod Nakashian
In some large PDFs the two maps for mapping GraphicsContext to ID and finding GraphicsContext given and ID are huge (over 160 MB in one case). By using a bimap the footprint went down to 110 MB. Reviewed-on: https://gerrit.libreoffice.org/45380 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 551543bf359f644f727fd1aa86e2c5ae499f88ce) (cherry picked from commit ac328157460e9e6a9ca6834e8233a28e845c2806) Change-Id: I59a444b5efa09fcabc26fa492de723ca063e14a4 Reviewed-on: https://gerrit.libreoffice.org/46988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-24Improve Natvis display of SwNodeMike Kaganski
Change-Id: Ib1d4b8ed69ab60e9d7fccc6627051500d62c4a49 Reviewed-on: https://gerrit.libreoffice.org/47049 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-24coverity#1426873 Unintended sign extensionCaolán McNamara
and a bunch of others Change-Id: I110545b74bfc71b17e2e10edc95bc4bb5aa5651c Reviewed-on: https://gerrit.libreoffice.org/46957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-24convert RES_FRM constants to TypedWhichIdNoel Grandin
Change-Id: I0c71a6fd2e094cebdb720e6c0661cd8a7bb8482c Reviewed-on: https://gerrit.libreoffice.org/46812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-24loplugin:passstuffbyref even more return improvementsNoel Grandin
Change-Id: I2a752025cd429e4d271626402dce5d8a8b0c76d2 Reviewed-on: https://gerrit.libreoffice.org/47021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-24.gitignore vscode ide filesAshod Nakashian
Change-Id: I0857885e459430e7b64f2a697943cb97d2e57cbf Reviewed-on: https://gerrit.libreoffice.org/46674 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit c6f01eb87f5e4c1c13b78fed26c70a91aa5bcbe2) Reviewed-on: https://gerrit.libreoffice.org/46676 (cherry picked from commit b3589dd6b4b4ed78b934187f21c96cbca51382f1) Reviewed-on: https://gerrit.libreoffice.org/46989 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-24Fix compilerplugins/clang/test/passstuffbyref.cxxStephan Bergmann
...after 2a1fb4401da16f6a18c0bd05fe4b460a3048f9b5 "loplugin:passstuffbyref improved returns", where compiling as C++17 causes a false positive for S2::set1, whose return statement consists of > `-ReturnStmt 0x9ef8d78 <col:23, col:44> > `-ExprWithCleanups 0x9ef8d60 <col:30, col:44> 'class rtl::OUString' > `-CXXFunctionalCastExpr 0x9ef8d38 <col:30, col:44> 'class rtl::OUString' functional cast to class rtl::OUString <ConstructorConversion> > `-CXXBindTemporaryExpr 0x9ef8d18 <col:30, col:44> 'class rtl::OUString' (CXXTemporary 0x9ef8d10) > `-CXXConstructExpr 0x9ef8cd0 <col:30, col:44> 'class rtl::OUString' 'void (char const &[4], typename libreoffice_internal::ConstCharArrayDetector<char const[4], libreoffice_internal::Dummy>::Type)' > |-StringLiteral 0x9ef7160 <col:39> 'const char [4]' lvalue "xxx" > `-CXXDefaultArgExpr 0x9ef8cb0 <<invalid sloc>> 'libreoffice_internal::Dummy':'struct rtl::libreoffice_internal::Dummy' Change-Id: I7b9de7ce6b5604c7d686c8a4a7034019cd1d75c4 Reviewed-on: https://gerrit.libreoffice.org/47029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-24tdf#114670 Make sure to dispose the menuMaxim Monastirsky
Change-Id: I30612a0b3cfef7d19ff6a5180db76a8002186bd5 Reviewed-on: https://gerrit.libreoffice.org/47025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-23Blind fixStephan Bergmann
...after a692cdf779dc998f58ebf9e9f84f22edf7dbe421 "LOK: tilebench improvements" Change-Id: Ic19c97ab381dc339270b8d7072458b57755b5e0d
2017-12-23NB Writer: tabbed toolbar get updatedandreas kainz
Change-Id: I71469d410e27ebe719e861cb0964ed6e4ba21805 Reviewed-on: https://gerrit.libreoffice.org/46852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-23pixman: drop cached glyphs above size watermarkAshod Nakashian
The glyphs cache only tracked the number of glyphs in the cache, which isn't very useful when the glyphs vary in size from a few bytes to dozens of megabytes. In terms of memory footprint, we are interested not just in the number of cached glyphs, but also in the total memory usage. We now track the pixel-size of each glyph and drop as many as necessary to fall below the set threshold which is currently 4 MBs. There was no performance loss observed after this patch on a diverse set of documents of all types (if anything, a very modest performance win was hinted in some cases), with significant memory reduction in some cases where dozens of megabytes were previously left stale in the cache. Change-Id: I377a4c1e59611fca6bf253dd9fa90f75b5295d4b Reviewed-on: https://gerrit.libreoffice.org/45378 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 407660a08c8df27d7cd44435eefa31bd92364a3c) (cherry picked from commit ded39dc17a34127a872b11abddc32bbbb5aae047) Reviewed-on: https://gerrit.libreoffice.org/46987 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-23LOK: support password-protected PDF docsAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/45547 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit dc773e81bd360316a96b1b61c552d263e1d87e89) Reviewed-on: https://gerrit.libreoffice.org/45563 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 82fb0abc37320fb1157b21efbf31954190353d41) Change-Id: I48d959dba2c38b72d1d6fc0fa9171b96dbed0e7c Reviewed-on: https://gerrit.libreoffice.org/46986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-23LOK: support tile-dumping in tilebenchAshod Nakashian
And other improvements. (cherry picked from commit b7d893d8a1ecb24290c4470e12d71caba2b85216) Reviewed-on: https://gerrit.libreoffice.org/46678 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 0e7ccbdd559df3a446e73c367b12824c6c143579) Change-Id: I5a27d6d2df5f946a708dd3b0b4fef8159da86e5c Reviewed-on: https://gerrit.libreoffice.org/46985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-23Use proper quotation marks in this translatable stringAdolfo Jayme Barrientos
Change-Id: I1e082e7f19af2895cfb595f1734e69808594bd04
2017-12-23Replace Start Center imageAdolfo Jayme Barrientos
Change-Id: Id0eadcbbaec9d189e92710f6bd4ed21d7da2870c Reviewed-on: https://gerrit.libreoffice.org/47023 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-23TestImportHTML: survive std::out_of_rangeCaolán McNamara
Change-Id: I084fd72e472bd2e647da3a80c7573280cd22bd93 Reviewed-on: https://gerrit.libreoffice.org/46998 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23ofz#4728 Null-derefCaolán McNamara
Change-Id: Ide91a63424f864e2913b8268c4eca7961ba54572 Reviewed-on: https://gerrit.libreoffice.org/47000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23ofz#4723 use vector::atCaolán McNamara
Change-Id: I07ca0d9c0dc6d15f089d5c4832bb30e1ef62ef04 Reviewed-on: https://gerrit.libreoffice.org/46999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23ofz#4722 Integer-overflowCaolán McNamara
Change-Id: I772ff6e6758610e7fa746f5e9b308accdea8159e Reviewed-on: https://gerrit.libreoffice.org/46997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23svtools: Use std::unique_ptr for SvImpLBoxTakeshi Abe
Change-Id: I4c5917eaa478e76411e9d8bbc5bd59c655693383 Reviewed-on: https://gerrit.libreoffice.org/47012 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-23VBA tests (4) - don't pass when all tests failZdeněk Crhonek
Change-Id: Ib4f9b5df1cffe104ba27be95183d075f24f28bb3 Reviewed-on: https://gerrit.libreoffice.org/45774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-12-23loplugin:passstuffbyref improved returns in vclNoel Grandin
Change-Id: I0b103df2e7ce59093869f547225c95865d33da27 Reviewed-on: https://gerrit.libreoffice.org/46916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-23tdf#108031 Area chart labels not rotatedJochen Nitschke
This fixes recognition of x-axis or y-axis when the coordinate system is rotated (3D-view). So the labels are rotated correctly. Change-Id: Iaacfec943f3885c58e99a55585714a79f1d0d9d5 Reviewed-on: https://gerrit.libreoffice.org/38355 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-12-23tdf#114605 Allow line split buttons to work in the menusYousuf Philips
Change-Id: Ie6cb2b19c56cb5b38f1dca89dba775970f405748 Reviewed-on: https://gerrit.libreoffice.org/46905 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-15 06:36:56 +0000