summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-30Resolves: tdf#127859 fix header/footer dialog crashCaolán McNamara
Change-Id: I643afbac841bbd1bc7857e25d8e1d98b4d48e881 Reviewed-on: https://gerrit.libreoffice.org/79842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30loplugin:duplicate-defines in filterNoel Grandin
same constant on two different nearby lines Change-Id: I3656ab58c26beae0f8f4e329a508dbe651db24db Reviewed-on: https://gerrit.libreoffice.org/79832 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30pNew could be nullptrMike Kaganski
Both if branches dereference pNew, so just check for that instead of useless check for ( pOld || pNew ) which is granted if pOld != pNew Change-Id: I5654c0a4e12e614d4d2068ddae582c1b86f2d61f Reviewed-on: https://gerrit.libreoffice.org/79837 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-30ofz#17817 avoid OOMCaolán McNamara
Change-Id: I354edf5b169e797c76ec79719cdce01e63329df4 Reviewed-on: https://gerrit.libreoffice.org/79833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30Simplify iterating in SwRegHistory::MakeSetWhichIds a littleMike Kaganski
The IsAtEnd check is redundant here. Change-Id: Ie576d039ea3db5f98d9c8c3dfd7e77519fcc1e1d Reviewed-on: https://gerrit.libreoffice.org/79836 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-30loplugin:duplicate-defines in UnoControlsNoel Grandin
these are only used by internal code, so move inside the relevant .cxx file Change-Id: If7cdf17a49ff3089ad2100961092dd2747523a8d Reviewed-on: https://gerrit.libreoffice.org/79830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30tdf#127735 DOCX export: fix internal hyperlinks to table targetTünde Tóth
Hyperlinks with internal table targets didn't work in Microsoft Word. Change-Id: I93b2b38d3d0196939f7aa5021811d2a9d5e482f5 Reviewed-on: https://gerrit.libreoffice.org/79524 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-30tdf#127734 DOCX export: fix internal hyperlinks to section targetTünde Tóth
Hyperlinks with internal section targets didn't work after export. Change-Id: I355091193f9b7f92d3fec77ee7d8a27bfd981724 Reviewed-on: https://gerrit.libreoffice.org/79522 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-30tdf#127733 DOCX export: fix internal hyperlinks to chart targetTünde Tóth
Hyperlinks to internal chart targets didn't work after export. Change-Id: I724c6af8fd7f1961260b82331b9f62d8cbd88f25 Reviewed-on: https://gerrit.libreoffice.org/79456 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-30tdf#127732 DOCX export: fix internal hyperlinks to frame targetTünde Tóth
Hyperlinks to internal frame targets didn't work in Word. Change-Id: Ia402bbdd2e77d8d3bb68ed2ed3a6bde1a913617c Reviewed-on: https://gerrit.libreoffice.org/79448 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-30null derefCaolán McNamara
since... commit a5081700bacb90d8560959a4d65d94a2d4e8dadd Date: Fri Sep 20 10:31:40 2019 +0200 Change-Id: I4876b0ddeede794d8c638cccb7c825d1db122fdd Reviewed-on: https://gerrit.libreoffice.org/79652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30jsdialogs: add callback LOK_CALLBACK_JSDIALOGSzymon Kłos
Change-Id: Ie79e24ae3a376e0de3d82daff4a1263c7ce3b33a Reviewed-on: https://gerrit.libreoffice.org/79825 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-09-30new loplugin:duplicate-definesNoel Grandin
Change-Id: I98e17e0a92ae5d51778b9a72c679ed262a6f5cb0 Reviewed-on: https://gerrit.libreoffice.org/79826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30Slightly DRY the O(U)StringNumber codeMike Kaganski
At least don't repeat the "O(U)StringNumber" in template argument of base class, and the number type in ctor argument Change-Id: I65cbe49a8fbbf5d9839cae9efc218130756a6710 Reviewed-on: https://gerrit.libreoffice.org/79822 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-30tdf#42949 Fix IWYU warnings in xmloff/source/[c-m]*/*cxxGabor Kelemen
Also checked xmloff/qa Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I843917d255f841066ace8d944aa1d00f1b718108 Reviewed-on: https://gerrit.libreoffice.org/79773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-30sw: prefix members of SwGammaGrfMiklos Vajna
See tdf#94879 for motivation. Change-Id: I53e8dd6a24da0a35d36f415237525b8cb87854c4 Reviewed-on: https://gerrit.libreoffice.org/79824 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-30align show-expander default with gtk defaultsCaolán McNamara
Change-Id: Ie2d03c1b98c78e58afc07a07a21ff934a62fd280 Reviewed-on: https://gerrit.libreoffice.org/79818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30QR Code Dialog Test Writer and Calcshubham goyal
Change-Id: I72613afe607063663a2ae1d395c2cdf320b9c463 Reviewed-on: https://gerrit.libreoffice.org/78877 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-09-30Make resolved comments appear resolved when printedScott Clarke
Added an indication to resolved comments when printing them or exporting them as a PDF. Change-Id: I9a84b76d6f12cca3c4541d19a0890cbd1cf430a7 Reviewed-on: https://gerrit.libreoffice.org/78712 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-09-29tdf#127857: fix assertion when enabling/disabling design in formsJulien Nabet
See bt: https://bugs.documentfoundation.org/attachment.cgi?id=154634 When replacing first remove the AccessibleShape (if exists) then create the new one to replace it Change-Id: Ia7b0818ab153d710617c0cc60fc06bc07922cebf Reviewed-on: https://gerrit.libreoffice.org/79813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-29tdf#127863: fix crash when trying to edit assigned macro to a buttonJulien Nabet
see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154638 Let's avoid iterator use here to avoid invalid iterator in debug mode + slight formatting Change-Id: I40b42201ad299aee33275b2c961e1e0233f86ad4 Reviewed-on: https://gerrit.libreoffice.org/79812 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-29Move Rectangle,Point,Size serialization to GenericTypeSerializerTomaž Vajngerl
Change-Id: Iae489fc31b13b836e1df5327ba2fa07e0325907a Reviewed-on: https://gerrit.libreoffice.org/79793 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-29drop some unnecessary includesCaolán McNamara
Change-Id: I2ea014aab7463d7127df73a6efba0e06270bd756 Reviewed-on: https://gerrit.libreoffice.org/79755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-29weld DbaIndexDialogCaolán McNamara
Change-Id: I5fe97c0bea6d386c4b39d8bf9341c844ccb792ae Reviewed-on: https://gerrit.libreoffice.org/79745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-29vcl: refactor SVM test to check also from filesTomaž Vajngerl
It's important that we also check from the files as we can change both - the import and export code, and we could actually break the SVM file compatibility. Change-Id: Iedb245f84e49f931e46ae20beadf612758076603 Reviewed-on: https://gerrit.libreoffice.org/79792 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-29constmethod for accessor-type methodsNoel Grandin
Apply the constmethod plugin, but only to accessor-type methods, e.g. IsFoo(), GetBar(), etc, where we can be sure of that constifying is a reasonable thing to do. Change-Id: Ibc97f5f359a0992dd1ce2d66f0189f8a0a43d98a Reviewed-on: https://gerrit.libreoffice.org/74269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-29Fix typoAndrea Gelmini
Change-Id: I3a322ce0d16daa179dd674b975327180f8b10561 Reviewed-on: https://gerrit.libreoffice.org/79809 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-29loplugin:constmethod in sdNoel Grandin
Change-Id: I063194abe47d8c1d3d9202bbe4b01d79c36ceda3 Reviewed-on: https://gerrit.libreoffice.org/79790 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-29tdf#127422 draw text with correct pKernArray values.Mark Hung
Prior to 5f62b97ae7891b8c601f6093a1ec5358feb20790, Starting position was specified and DrawText was used to render the text without referring to pKernArray. After the patch, DrawTextArray was used but pKernArray was not update correctly. Instead of draw each substring seprated by space, this patch increases the values pKernArray when a space is encountered and call DrawTextArray only once. Change-Id: I9e61b2d0608400f26136490248740c5f00b56cc3 Reviewed-on: https://gerrit.libreoffice.org/79544 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-09-29Fix typosAndrea Gelmini
Change-Id: I8a93a6ed49661ddfae390a0302fca1fab5c95f14 Reviewed-on: https://gerrit.libreoffice.org/79795 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-28tdf#127785 correct calculation of text rectangle in flipped shapeRegina Henschel
The calculation had used a wrong corner. That resulted in negative width or height. Thus the entire shape frame was used as fallback instead of the smaller text rectangle. Change-Id: Ia18d9630dc83c0556115609575f26dcfa71bdb13 Reviewed-on: https://gerrit.libreoffice.org/79774 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-09-28loplugin:constmethod in xmlsecurityNoel Grandin
Change-Id: I7892b4819fd7491882e6ca995bf2ce5c65230609 Reviewed-on: https://gerrit.libreoffice.org/79791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in basegfxNoel Grandin
Change-Id: I8b3f7810eb08b5217df30b7be27aafadeeed247a Reviewed-on: https://gerrit.libreoffice.org/79647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in chart2Noel Grandin
Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2 Reviewed-on: https://gerrit.libreoffice.org/79645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute l10n of standard attributes Change-Id: Iccd6d1b1ee11d702ccdc61226011b80973370287 Reviewed-on: https://gerrit.libreoffice.org/79794 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Improve readability of events Help page. Change-Id: Ic205109612715e3bbae9d3af990f8c3867def050 Reviewed-on: https://gerrit.libreoffice.org/79789 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-28Use G_ADD_PRIVATE and *_get_instance_privateArkadiy Illarionov
G_TYPE_INSTANCE_GET_PRIVATE and g_type_class_add_private are deprecated Change-Id: Id2a03e1ddc523d088682fd29f6b9d4e25f0cd4a2 Reviewed-on: https://gerrit.libreoffice.org/79663 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-28loplugin:constmethod in writerfilterNoel Grandin
Change-Id: I1e1c4e574e910ef9683520ae950b14eb4ebbc63f Reviewed-on: https://gerrit.libreoffice.org/79784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in vclNoel Grandin
Change-Id: I6a456979a6cfcd7920dc468baf9b23013cb701a4 Reviewed-on: https://gerrit.libreoffice.org/79783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in sdext..starmathNoel Grandin
Change-Id: Ib1b60382c9ec62f35f0f232c3f2c2d5664ea669e Reviewed-on: https://gerrit.libreoffice.org/79779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in dbaccessNoel Grandin
Change-Id: I030283816185f42f9012c8dfb2d745164abd7234 Reviewed-on: https://gerrit.libreoffice.org/79644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in basctlNoel Grandin
Change-Id: I6a3f74a3c52f3fb97b26de69b20ffd7502968d5e Reviewed-on: https://gerrit.libreoffice.org/79646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28"KWINDOWSYSTEM_DEPRECATED static void setMainWindow" (take 2)Julien Nabet
/home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx: In member function ‘virtual bool KDE5FilePicker::eventFilter(QObject*, QEvent*)’: /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:271:51: error: ‘static void KWindowSystem::setMainWindow(QWidget*, WId)’ is deprecated [-Werror=deprecated-declarations] 271 | KWindowSystem::setMainWindow(w, _winId); | ^ In file included from /usr/include/KF5/KWindowSystem/KWindowSystem:1, from /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:24: /usr/include/KF5/KWindowSystem/kwindowsystem.h:255:42: note: declared here 255 | KWINDOWSYSTEM_DEPRECATED static void setMainWindow(QWidget *subwindow, WId mainwindow); | ^~~~~~~~~~~~~ There's a new method we could use but it's only possible when baseline will include kwindowsystem >= 5.62 Change-Id: Idd3dca98e15585077c20848613fce72c5daae0e2 Reviewed-on: https://gerrit.libreoffice.org/79781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-28loplugin:constmethod in ucb..uuiNoel Grandin
Change-Id: I53db381de8e063b6a3aa07051351e655c6f040fa Reviewed-on: https://gerrit.libreoffice.org/79782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in swNoel Grandin
Change-Id: I73c3c6d2165287d2d581a04b23b1d3b48166a488 Reviewed-on: https://gerrit.libreoffice.org/79780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28Hold reference on parent dialog while emitting EndDialog.Michael Meeks
Also cleanup the code. Change-Id: I5f9d562319dc244ee22feb2e3fd64023bc229c4e Reviewed-on: https://gerrit.libreoffice.org/79771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79777 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-28tdf#126321: avoid flickering in page size popupXisco Fauli
In a Tabbed notebookbar, Layout - Page Size Change-Id: I74ab54e96486de960d1ccc7bcb3c2679e25a6e9e Reviewed-on: https://gerrit.libreoffice.org/79752 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-28Avoid lambda being destroyed while it is being called.Michael Meeks
Also armor against mpDialogImpl going down during EndDialog. This can happen during an insert chart wizard cancel, as out of place embedded dialog cleanup occurs. Change-Id: I1b666f07d4ec72e07fdf6888cea44a5a13976073 Reviewed-on: https://gerrit.libreoffice.org/79772 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79778 Tested-by: Jenkins
2019-09-28Revert "KWINDOWSYSTEM_DEPRECATED static void setMainWindow"Julien Nabet
the function is only available from kwindowsystem 5.62, so more recent that our baseline. This reverts commit 94e22f5a2fcc9f193ce0370805156ad5320d4141. Change-Id: I6957a7d4438cd57c4a0eab29a9c615d45eaa2235 Reviewed-on: https://gerrit.libreoffice.org/79776 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-28loplugin:virtualdead in editengNoel Grandin
Change-Id: I72f9cf62f9daeaed5108ede41dd41544204a9745 Reviewed-on: https://gerrit.libreoffice.org/79643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-25 16:08:40 +0000