summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-04additions dialog ui updateandreas kainz
Change-Id: I045f80d0c7df9c31979b0c74848557d77ebb80af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102045 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-04Avoid warnings about use of uninitialized valueMike Kaganski
Use of uninitialized value $microversion in int at C:/lo/src/core/solenv/bin/modules/installer/windows/file.pm line 568. Use of uninitialized value $vervariant in int at C:/lo/src/core/solenv/bin/modules/installer/windows/file.pm line 568. Change-Id: I916861a34d39a796d2941f9a8d972e7a082e3b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102058 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04Avoid warnings about use of uninitialized valueMike Kaganski
Like these: Use of uninitialized value in exists at C:/lo/src/core/solenv/bin/modules/installer/scriptitems.pm line 402. Debugging the failing values, these are: element 113 Dir => gid_Dir_Autotext_Language HostName => LibreOfficeDev 7/share/autotext/qtz modules => gid_Module_Langpack_Basis_qtz specificlanguage => qtz Styles => (CREATE) element 512 Dir => gid_Brand_Dir_Share_Uno_Packages HostName => LibreOfficeDev 7/share/uno_packages modules => gid_Module_Root,gid_Module_Root_Brand specificlanguage => Styles => (CREATE) element 513 Dir => gid_Brand_Dir_Share_Uno_Packages_Cache HostName => LibreOfficeDev 7/share/uno_packages/cache modules => gid_Module_Root,gid_Module_Root_Brand specificlanguage => Styles => (CREATE) element 514 Dir => gid_Brand_Dir_Share_Uno_Packages_Cache_Uno_Packages HostName => LibreOfficeDev 7/share/uno_packages/cache/uno_packages modules => gid_Module_Root specificlanguage => Styles => (CREATE) Change-Id: I9c91e2fa9bbaab4c15e96dbbdc710141e500c482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102053 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04revert the macos part of..Noel Grandin
commit 217122387f6e0ef657b8ba85eae082b448901cec Date: Tue Aug 25 12:23:13 2020 +0200 dont turn on malloc debugging for gdb itself because it doesn't work Change-Id: If6f1ac2ddc1683dab9d57df742c647083304af07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-04xmlsecurity: pdf incremental updates that are non-commenting are invalidMiklos Vajna
I.e. it's OK to add incremental updates for annotation/commenting purposes and that doesn't invalite existing signatures. Everything else does. Change-Id: I4607c242b3c6f6b01517b02407e9e7a095e2e069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102057 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-04tdf#136062: sc: Add UItestXisco Fauli
Change-Id: Ic154f80a0b4c9bcade64e7c5ba9180db5c199de0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102054 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-04sw: default to UI locale when language is missingMiklos Vajna
This means that when extras/source/shellnew/soffice.odt is opened, it'll always match the user's language. The same was already working in Calc and Impress. Change-Id: Ic1afc82d7b59f1bd32815586f756e7e8408e5c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102051 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-04Fix typo in codeAndrea Gelmini
Change-Id: If214d98b729d84d98e8b748978035e723ed043a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102036 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#135672 doc import: fix left table positionJustin Luth
On round-tripping, the table was creeping left on each save. A follow-up commit handles growth creep. Why this specially added code is now wrong is unknown to me. I'm guessing that for docx, Writer was changed and doc format never picked up on that change. It looks like this probably happened already in OOo based on bibisect seeing this creep and table growth as far back as I can test. I really don't like just ripping out code like this, but the proof is in the pudding. Now several documents round-trip at the same position and size. Who can complain? See the bug report, which questions why this was added: commit 53d67a4e9f26689dbcce07f045ef6222bfadc27e Author: Caolán McNamara on Tue Oct 16 11:42:32 2001 +0000 #93253# Fix borders and positioning Change-Id: I3914bc84143a62f518542c10d19461e1edfadd17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101187 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-04uitest: this is a calc fileXisco Fauli
Change-Id: I8d5b4d08818711b37d6624ec6e45b793d3553afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102055 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-04tdf#117703: sw: Add UItestXisco Fauli
Change-Id: I4f5e5daf95171036489a5c67256e153154309b6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102049 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-04ignore fully opaque alpha bitmap for SkiaLuboš Luňák
This avoids some more expensive operations (if using CPU) like SkBlendMode::kDstOut for hacks like 9ff0cd1f6b2200940ac51e580809e2a17c4b9550 that just set a fully opaque bitmap as the alpha. Change-Id: I446efc482d7bb13e899bf8b352e13fce6b5f9176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101896 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-04fix erasing virtual device with alphaLuboš Luňák
The background cannot be simply set as background also for the internal alpha virtual device, since this hackish alpha uses black = opaque and white = transparent. So e.g. setting to background to COL_WHITE actually resulted in the content being transparent. Try to map to what the alpha virtual device actually needs. Change-Id: Ie5179769d9bce989eddfc96f5cbd2b94d1d88d53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101927 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-04tdf#118148 Extended tips for HC2/swriterOlivier Hallot
Change-Id: I523bd35ae359d8c5d18e9a553ef101dda0a1e2dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101894 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-04Drop duplicating is_empty_dirMike Kaganski
This version was introduced in b173b425a1c1478ab3c4b43e58e09b751e3e3387, then in cabadfc288e5e7324723c62f36b918a80db90323, another copy was added so that now install.phony.log had this line: Subroutine is_empty_dir redefined at C:/lo/src/core/solenv/bin/modules/installer/systemactions.pm line 475. Let's keep the newer version, that is at line 280. Change-Id: I50f3668e47d4ea8f9c309abde8abe233cff12af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102046 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04svx: Introduce GalleryBinaryEngine::getModificationDate()Aditya
Also make GalleryBinaryEngine's functions GetSdgURL(), GetThmURL(), GetStrURL(), GetSdvURL() private to the class. Introduce getModificationDate() to GalleryBinaryEngine because that it where it belongs - it deals with URL Change-Id: Idd3c42e779652df030ae104e40581d9de1a07863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101505 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04svx: Refactor Gallery::RemoveTheme()Aditya
Introduce GalleryTheme::removeTheme() and GalleryBinaryEngine::removeTheme() Change-Id: Ic9c1b4fdb3e173d922635e5fd78d463e1f2c220a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101496 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04tdf#136404 DOCX import: ignore NaN cells in table formulaLászló Németh
Ignore empty cells or cells with text content in data range of AVERAGE, COUNT and PRODUCT (the new interoperability functions in Writer), like MSO does, instead of using NaN data as zeroes here. Add AVERAGE, as a new function instead of alias of MEAN to return error message instead of zero for NaN-only arguments, like Calc does (Note: also MSO gives empty result instead of zero). Change-Id: I5e18f3e2b16cb0621dad2bba141ae63fb5edd241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102012 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-04Avoid loplugin:external and loplugin:simplifypointertobool warningsTor Lillqvist
Note that this file isn't actually compiled at the moment unless you edit the Module_libreofficekit.mk. And then the unit test will fail. But that is another problem. Change-Id: I431ce889ca4059e98662cddcaee3aa570102c515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102042 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-04Remove an odd CPPUNIT_ASSERT(0)Tor Lillqvist
The unit test that code is in isn't even run currently (commented out in Module_libreofficekit.mk), so no harm in not making it fail intentionally. (The commit message of the commit that added the test with the intentionally always failing assertion does not tell what the idea was.) Change-Id: I93407723ce10c77366e6f7f96df93d86f214f497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102030 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-04svx: Refactor GalleryBrowser1::ImplFillExchangeDataAditya
Introduce GalleryTheme::getModificationDate() Change-Id: I1ca34482ee5f0007a1d698e345e399ac3de31a51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101495 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04svx: Rename GalleryThemeEntry::mpGalleryBinaryEngineEntryAditya
Rename mpGalleryBinaryEngineEntry to mpGalleryStorageEngineEntry because GalleryThemeEntry will have 2 engines: GalleryBinaryEngineEntry and GalleryXMLEngineEntry. Change-Id: I348d8df111f33cceacdbfe746bc484802fc18d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101431 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04svx: Rename GalleryTheme::mpGalleryBinaryEngineAditya
Rename mpGalleryBinaryEngine to mpGalleryStorageEngine because GalleryTheme will have 2 engines: GalleryBinaryEngine and GalleryXMLEngine. Change-Id: I990a3655121b4e4e5735c6a8d5e5afe13c674b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101427 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04svx: Introduce GalleryFileStorageEntryAditya
Abstract class for GalleryBinaryEngineEntry and upcoming GalleryXMLEngineEntry. This interface will be used by GalleryThemeEntry class. Change-Id: Ifa81fe7f17479a9583fd526e5173658aa33efd30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101420 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-04tdf#124176 Use #pragma once in codemakerGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I421f0594d5f4389f7800a5bd0e339edde5627bb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100182 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in compilerpluginsGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Id60579406a5aa16c3dc05a1bb5f1c1c828d39c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100251 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04don't warn about perfectly ok small-button styleCaolán McNamara
Change-Id: I60bd07d9ff9100a6a20b3c0cb65c9b9d33767029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-04tdf#136354 DOCX import: fix vertical mirrored alignment on bottom marginTibor Nagy
The relative mirrored vertical alignment (INSIDE and OUTSIDE) of bottom page margin wasn't handled. Note: this fix doesn't check mirroring (if it's possible to mirror vertically either, for example, by mixing portrait and landscape mode in a document), only support INSIDE as OUTSIDE as alternative names of TOP and BOTTOM in case of alignment to bottom margins. Follow-up of commit d54264e34c1ccc0eaf4178ab165a843028500223 (tdf#133071 DOCX import: fix vertical alignment to bottom page margin) Co-authored-by: Attila Szűcs (NISZ) Change-Id: I6d844f57505bcda1faa7dd6112d1cda666c3ac07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101934 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-04xmloff: remove dead com.sun.star.comp.Draw.XMLStylesExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I04eb38aad193dfbfde5df42f3e367aa47dfd12ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102019 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-04tdf#124176 Use #pragma once in chart2George Bateman
This commit was carried out mostly by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Ifee23b494264f895e5612952d0875cac064e4132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100181 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Replace 3 include guards with #pragma onceGeorge Bateman
These are the include guards mentioned in tdf#124176 as not being compatible with an automated fix. Change-Id: Ia74453b7b96405ad36440dcd8e24759352bd15da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100092 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in configmgrGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Ide38653f1828752b90d7e312471c9facb99646a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100252 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in bridgesGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Icadf43a74e4ba99e587a1e6287adf8d65f819ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100144 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in binaryurpGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I7141f07eca2b8338be6bd6b24580256cda6ba092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100129 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in basctlGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I812869f1a7cb2ac3e9c97240abc456cd12afd0b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100121 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in basicGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Ief7f29d8efaa3d6ac417080f3147a087844621a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100128 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in canvasGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Icd712adf20fa2dbaaea2fc33a0fd870c8595b7e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in cppcanvasGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I984bb1056da13d163f7fe654d780502a6d34231f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100253 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#124176 Use #pragma once in avmediaGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Iec8964e460e26778bbe9fe33e6130d7f179fae51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100142 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04tdf#123353 XLSX export: fix lost AutoFilter on empty cellsTibor Nagy
The AutoFilter button was lost during export when only the rows with empty cells were visible and everything else was hidden. The filter itself was still active, but the button itself was gone. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ia0b16bf4f15303d1320081cb62090368a0ce3908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101847 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-04tdf#124176 Use #pragma once in comphelperGeorge Bateman
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I72229dc1ef743f0394f778aec7c49c11fe7e5176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100183 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-04Make many OUString functions take std::u16string_view parametersStephan Bergmann
...instead of having individual overloads for OUString, OUStringLiteral, and literal char16_t const[N]. (The variants taking OUString are still needed for !LIBO_INTERNAL_ONLY, though. The variants taking ASCII-only literal char const[N] are also left in place.) This nicely reduces the number of needed overloads. std::u16string_view allows to pass as arguments: * OUString * OUStringLiteral * OUStringChar (with the necessary conversion added now) * OUStringNumber * u"..." char16_t string literals * u"..."sv std::u16string_view literals * std::u16string, plain char16_t*, and more A notable exceptions is OUStringConcat, which now needs to be wrapped in OUString(...), see the handful of places that needed to be adapted. One caveat is the treatment of embedded NUL characters, as std::u16string_view(u"x\0y") constructs a view of size 1, while only u"x\0y"sv constructs a view of size 3 (which matches the old behavior of overloads for literal char16_t const[N] via the ConstCharArrayDetector<>::TypeUtf16 machinery). See the new checkEmbeddedNul in sal/qa/rtl/strings/test_oustring_stringliterals.cxx. The functions that have been changed are generally those that: * already take a string of determined length, so that using std::u16string_view, which is always constructed with a determined length, is no pessimization (e.g., there are operator == overloads taking plain pointers, which do not need to determine the string length upfront); * could not benefit from the fact that the passed-in argument is an OUString (e.g., the corresponding operator = overload can reuse the passed-in OUString's rtl_uString pData member); * do not run into overload resolution ambiguity issues, like the comparison operators would do. One inconsistency that showed up is that while the original replaceAll(OUString const &, OUString const &, sal_Int32 fromIndex = 0) overload takes an optional third fromIndex argument, the existing replaceAll overloads taking OUStringLiteral and literal char16_t const[N] arguments did not. Fixing that required a new (LIBO_INTERNAL_ONLY) rtl_uString_newReplaceAllFromIndexUtf16LUtf16L (with test code in sal/qa/rtl/strings/test_strings_replace.cxx). Another issue was posed by test code in sal/qa/rtl/strings/test_oustring_stringliterals.cxx that used the RTL_STRING_UNITTEST-only OUString(Except*CharArrayDetector) ctors to verify that certain function calls should not compile (and would compile under RTL_STRING_UNITTEST by taking those Except*CharArrayDetector converted to OUString as arguments). Those problematic "should fail to compile" tests have been converted into a new CompilerTest_sal_rtl_oustring. Change-Id: Id72e8c4cc338258cadad00ddc6ea5b9da2e1f780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-04tdf#136377: Replace yum by dnf for Fedora in readme.xrmJulien Nabet
Change-Id: I62ec93d7051bbb795f01f6779f65d7fbf77a672a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101904 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-04uilogger : Add support in the Logger and DSL for MenuBtnAhmed ElShreif
For example the DSL syntax will be: >>Open List From menugearbtn >>Select item no 6 From List of menugearbtn >>Close List From menugearbtn Change-Id: I767948d9bc124a119632825d437746ea38c40ad3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101514 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-09-03tdf#136099 Sidebar position and size alignment updateandreas kainz
Change-Id: I36dfcea69395295fb480422126bbe31497773de8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102017 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-03initialize possible CPU intrinsics use also for normal Skia (tdf#136326)Luboš Luňák
7a38f1817b0568cfbcda9a91dc86eafaba336871 added initialization only for SAL_FORCESKIA=1, but not for the normal SAL_ENABLESKIA=1. Change-Id: I1442811c757d74d31fa35d908f0292a2691e8038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102008 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-03fix offsets in our SSSE3 Skia functions (tdf#136326)Luboš Luňák
'src' is uint32_t, so that extra '*4' was wrong. Change-Id: Ie0628a72bd4f7eb3122e4b1d67b6bb759f74bc46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102007 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-03Drop unnecessary, wrong downcastStephan Bergmann
...during UITest_writer_tests UITEST_TEST_NAME=trackedChanges.trackedchanges.test_tdf135018, see <https://ci.libreoffice.org/job/lo_ubsan/1747/>: [...] > /sw/source/core/undo/undel.cxx:829:19: runtime error: downcast of address 0x61300019f180 which does not point to an object of type 'SwFlyFrameFormat' > 0x61300019f180: note: object is of type 'SwDrawFrameFormat' > 62 03 00 10 50 14 62 26 8e 2b 00 00 c0 01 5d 00 20 61 00 00 40 3a 23 00 20 61 00 00 c0 73 54 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwDrawFrameFormat' > #0 0x2b8e1ef42aaa in lcl_ReAnchorAtContentFlyFrames(SwFrameFormats const&, SwPosition&, unsigned long) /sw/source/core/undo/undel.cxx:829:19 > #1 0x2b8e1ef38d83 in SwUndoDelete::UndoImpl(sw::UndoRedoContext&) /sw/source/core/undo/undel.cxx:913:21 > #2 0x2b8e1ef66b01 in SwUndo::UndoWithContext(SfxUndoContext&) /sw/source/core/undo/undobj.cxx:235:5 > #3 0x2b8d9da12092 in SfxListUndoAction::UndoWithContext(SfxUndoContext&) /svl/source/undo/undo.cxx:1321:37 > #4 0x2b8d9da12092 in SfxListUndoAction::UndoWithContext(SfxUndoContext&) /svl/source/undo/undo.cxx:1321:37 > #5 0x2b8d9d9f95cd in SfxUndoManager::ImplUndo(SfxUndoContext*) /svl/source/undo/undo.cxx:698:22 > #6 0x2b8d9d9fa566 in SfxUndoManager::UndoWithContext(SfxUndoContext&) /svl/source/undo/undo.cxx:666:12 > #7 0x2b8e1ee6275b in sw::UndoManager::impl_DoUndoRedo(sw::UndoManager::UndoOrRedoType) /sw/source/core/undo/docundo.cxx:607:32 > #8 0x2b8e1ee639bb in sw::UndoManager::Undo() /sw/source/core/undo/docundo.cxx:640:16 > #9 0x2b8e1ce8891a in SwEditShell::Undo(unsigned short) /sw/source/core/edit/edundo.cxx:131:57 > #10 0x2b8e228bf8a8 in SwWrtShell::Do(SwWrtShell::DoType, unsigned short) /sw/source/uibase/wrtsh/wrtundo.cxx:44:26 > #11 0x2b8e21a7b828 in SwBaseShell::ExecUndo(SfxRequest&) /sw/source/uibase/shells/basesh.cxx:557:27 > #12 0x2b8e21a799cf in SfxStubSwBaseShellExecUndo(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:2193:1 > #13 0x2b8d97b4d845 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) /include/sfx2/shell.hxx:197:35 > #14 0x2b8d97ae4c54 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:252:16 [...] Change-Id: Ie6c6fff1a68e4c37ffadd242fca8346f5311ff89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102015 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-03set small button provider at screen instead of at each widgetCaolán McNamara
and make the small close button in the menubar use that same provider add a small-button pattern to match buttons in toolbars Change-Id: I13623519d6fa51d9bd474589fa00e2fcc0c1e599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-03tdf#129423 sw: export-only tests, part 10Daniel Arato (NISZ)
Convert some unit tests from "export" tests to "export only". Remove nullptr checks on parseExport's return value to make the tests fail if parsing fails for any reason. Change-Id: I0edb7988431b9e8cf5959dcb5753301fa4a0c210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101721 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-02 19:31:46 +0000