summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02Resolves: tdf#99467 pasting text from java apps to gtk3 gives bad resultsCaolán McNamara
Change-Id: Ib2625c900def20baa470f0a15e4f72a3f763099e
2017-05-02loplugin:checkunusedparams in ooxNoel Grandin
Change-Id: I95bce82654bd0da7ed76ebd22b107b870ed15a1f Reviewed-on: https://gerrit.libreoffice.org/37144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in hwpfilter..lotuswordproNoel Grandin
Change-Id: I4925a95cc74571c2e0ffd413d7ac8bc162c247d7 Reviewed-on: https://gerrit.libreoffice.org/37143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02sw: prefix members of SwLayHelperMiklos Vajna
Change-Id: I6beec3d0083f6b2f4055b7cffe9c59a630a89261 Reviewed-on: https://gerrit.libreoffice.org/37135 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-02loplugin:checkunusedparams in basctl and basicNoel Grandin
Change-Id: I077ce96aed3c79045d5e8438109a8b1690ff1218 Reviewed-on: https://gerrit.libreoffice.org/37062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in forms..formulaNoel Grandin
Change-Id: Iacd973b97fccda217c691cca0a8f440640ff7a0b Reviewed-on: https://gerrit.libreoffice.org/37140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02tdf#77816 Duplicate dlg: enable fractionnal angleLaurent Balland-Poirier
In Duplicate dialog of Draw: Count angle in 100th of degree Change-Id: If1af9a42e7c35d39edbdc3fa624489d7e38b42e1 Reviewed-on: https://gerrit.libreoffice.org/36816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02unused wizards basic file and dialogCaolán McNamara
Change-Id: I56e82ab480b33d3205516e371302b1a091678e22
2017-05-02revert 'tweak for pdfiumless build'Caolán McNamara
commit 8d747b8cf849b7d705048544ac20eceba7eb5a45 Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Apr 29 20:01:40 2017 +0100 tweak for pdfiumless build and lets see if commit 6f53cf281eb3c13fc516ff79decb70b2a87a96d0 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Sat Apr 29 05:11:40 2017 +0200 apparently the executable does not need pdfium directly anymore is sufficient here Change-Id: I2bf381e1d51d851aa829730b3d13edb1c03ea873
2017-05-02Updated coreOlivier R
Project: dictionaries c82ad83da55f7c0d4667edea003b8038e473dcd1 tdf#107558 French spelling dictionary (6.0.3) and thesaurus Change-Id: Ia3da9c3b2e4a0ca1032edad131838b3a705e0597
2017-05-02Fix typos in color namesGabor Kelemen
Change-Id: I6d26b17a3fa51f6ff16fa1968b5ce445e949f43d Reviewed-on: https://gerrit.libreoffice.org/37128 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02loplugin:checkunusedparams in extensionsNoel Grandin
Change-Id: I1ea1a43da45039fc5d62f21e83c216461abf99de Reviewed-on: https://gerrit.libreoffice.org/37134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02Don’t mark any field without strong LTR text CTLKhaled Hosny
Regression from e3b7ef45d4364fda15691b5748a9a88bc908afc6 which removed the condition this block was implying, so putting it back here. This should fix Jenkins_Callgrind tinderbox, we probably should have some unit tests based on the file from [1] and [2], but I don’t know how… 1. https://bz.apache.org/ooo/show_bug.cgi?id=89825 2. sw/qa/extras/ww8export/data/tdf91083.odt Change-Id: I88ad2564908b3a269e95d1969366c8506801818b Reviewed-on: https://gerrit.libreoffice.org/37050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-02tdf#107204: Make sure we always do Unicode Bidi, take twoKhaled Hosny
[ Now that the side-effect will be fixed by <https://gerrit.libreoffice.org/#/c/37050/>.] Writer seems to have an “optimization” that only applies bidi algorithm if the text direction is nor LTR and there is some characters that we classify as complex script. This is a very simplistic optimization as evidenced by the bug above. We certainly don't want to skip bidi the text differently based on the default direction (whatever that means), and not all RTL scripts are complex ones, even if they are we might be behind Unicode in our script classification. Just trust that bidi algorithm does the right thing and don’t do premature optimization. If this turns out to be a real performance issue, we will need to find a better optimization. Change-Id: I276e2ae0ac92fb51d2e37ef2ad0b11efc6b441ef
2017-05-02AutoText: read names of entriesSzymon Kłos
+ extended model to parse <docPartPr> and <name> marks + names are inserted to the document before content of each entry + SwDOCXReader interprets first paragraph of each section as a name Change-Id: Ib7de152ba1c6bea4f4665f98d321019c3f68863e Reviewed-on: https://gerrit.libreoffice.org/37124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-02Revert "tdf#107204: Make sure we always do Unicode Bidi"Miklos Vajna
This reverts commit e3b7ef45d4364fda15691b5748a9a88bc908afc6, as it breaks the testTableKeep part of CppunitTest_sw_ww8export on the Jenkins_Callgrind tinderbox (and also for me locally) and there is no fix in progress to address that. See the bug for a comparision of the old/new layout for the problematic testcase. Khaled says it's OK to push this revert till it's clear how to fix the bug without side-effects. Change-Id: I669de98ffa8b519024e332ae468808d7e7243df2
2017-05-02loplugin:checkunusedparams in cppcanvas and dbaccessNoel Grandin
Change-Id: Ia66e6326f3d1750b4e46a3f9f7127e7ed4aa99ca Reviewed-on: https://gerrit.libreoffice.org/37068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in drawinglayerNoel Grandin
Change-Id: Ib497b284a80fae69930f226d2e70368cb9e962ef Reviewed-on: https://gerrit.libreoffice.org/37072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02create SfxGroupId based on o3tl::strong_intNoel Grandin
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71 Reviewed-on: https://gerrit.libreoffice.org/37108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02SwFieldTypes can just be a std::vector typedefNoel Grandin
Change-Id: I10b43a71c8cedc6efbb30056d3da7fd431f04791 Reviewed-on: https://gerrit.libreoffice.org/37121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#107145 display applied filters for page field in pivot chartTomaž Vajngerl
Add field output description which shows the description of the filtered output, which can be either "- all -" when nothing is filtered, "- multiple -" when multiple values are outputted or the specific value - the only value remaining. Change-Id: I8fca6050dabba9878e9f3a31e4be7a03e3b87467 Reviewed-on: https://gerrit.libreoffice.org/37125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-01tdf#107526: fix icon managementJulien Nabet
by following http://opengrok.libreoffice.org/xref/core/vcl/inc/svdata.hxx#91 Change-Id: I57d13e33c31f25580c93ef2abfec78e9386a8c04 Reviewed-on: https://gerrit.libreoffice.org/37126 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-01Updated coreAdolfo Jayme Barrientos
Project: help bbdcec4b66f4d87a7974927e9abd2d19a4b9557b tdf#79766 “Western characters” → “Western text” also in Help Change-Id: Ibe58a6242f5ffaa1fec4ddb6a327135b61780b9c
2017-05-01tdf#107074 uncommenting createLabels for the axis fixes the issueTomaž Vajngerl
Quick fix for this bug seems to be to call createLabels again after creating shapes. The code to position axis label seems to be quite messy it would be better to greatly refactor the code if we want to do any enhancement to this code in the future. Change-Id: I2bc2c3d503944002c538d2d2a5119102c927f3b7 Reviewed-on: https://gerrit.libreoffice.org/37122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-01AutoText: Reading multiple entriesSzymon Kłos
+ each entry is placed in a separate section + extended model and dmapper to react on docPart mark Change-Id: I7e5213a09ae7352d1d09369bd0a209b6d4e18e82 Reviewed-on: https://gerrit.libreoffice.org/37107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-01SwTOXTypes can just be a std::vector typedefNoel Grandin
Change-Id: I0b20f4dfdbc692e9122f64a11b65bd4234e00ee7 Reviewed-on: https://gerrit.libreoffice.org/37120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#107102: fix crash in ScCheckListMenuWindow::CreateAccessibleJulien Nabet
by checking maEdSearch in addition of !mxAccessible.is() See http://bugs.documentfoundation.org/attachment.cgi?id=132608 for bt Change-Id: I2cf7f28daaa6d371d3be0d21bb7f140ff6bb8c8c Reviewed-on: https://gerrit.libreoffice.org/37110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-01AutoText: handle Delete key in the dialogSzymon Kłos
Change-Id: Ifbd0026b097ff9fbf077dda57f874cfc59da3e45 Reviewed-on: https://gerrit.libreoffice.org/37119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-05-01filter: get svg JS code warning-freeThorsten Behrens
Subsequent submissions need to pass 'eslint filter/source/svg/presentation_engine.js' w/o error. Change-Id: If79c43844d48602d19cde8d4dd12d7e7eef674fe
2017-05-01unnecessary PairedList macroNoel Grandin
Change-Id: I54a6478522f03706b5d2d10b58857a3de2876ca8 Reviewed-on: https://gerrit.libreoffice.org/37118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#51358 Add Support for BoxSnakesWipePath transition in SVG ExportRohan Kumar
Ported the class BoxSnakesWipe Change-Id: I024f982998571d5a90252b10f873c0fc344af2ff Reviewed-on: https://gerrit.libreoffice.org/36902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-01Fixed my mistake: Fix Rotation issue in ParallelSnakesWipeRohan Kumar
seems like SVGMatrix.translate() and its counterparts doesn't modify the matrix inplace. Change-Id: I3ccfbe99f58cd455e291d4d41657a104ec197e83 Reviewed-on: https://gerrit.libreoffice.org/36903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-01tdf#107362 don't insert kern if snap to char is not checked.Mark Hung
SwKernPortion is inserted between different scripts to snap the later text portion to the charcter grid if type of text grid is lines and chars, even if snap-to-char isn't checked, and create unexpected space there. It is not necessary because when snap-to-char is not checked, there would be pitch between characters. Format all three scripts in the same way and do not insert kern portion anymore if snap-to-char isn't checked. Change-Id: I6078b425aa735beb50cc6a6b4eafbba9f91f7132 Reviewed-on: https://gerrit.libreoffice.org/37037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-05-01tdf#79766 Use consistent wording in Asian Layout Kerning optionTakeshi Abe
Change-Id: I4ed78efc82a9dad490930351175dc5d501fdc499 Reviewed-on: https://gerrit.libreoffice.org/37114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-05-01sd: Use unique Page ids for better multi-view support + unit testPranav Kant
... instead of using simple IDs which are assumed to be one greater than the slide position everywhere in the codebase. Use a 16 bit static counter and uniquely assign page ids to SdPage objects. This helps in identifying which slide was already selected in second view before any slide is deleted in the first view. Otherwise, using simple positions to keep track of it leads the second view to end up selecting the wrong slide after any slide is added or removed in the first view. Change-Id: I465cf7ea86899f0e52549062a9e5fa5cd459f978 Reviewed-on: https://gerrit.libreoffice.org/36863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-05-01loplugin:stringconstantMaxim Monastirsky
Change-Id: I8f7a0d5b4b0534c71a32457d58006af0d6ddf133
2017-05-01svidl: Adapt to SlotType removalMaxim Monastirsky
No diff in workdir/SdiTarget. BEWARE: If you're going to revert this for whatever reason, you should also revert the previous commit that removed the SlotType property from sdi files! Change-Id: I78cc391a6b47f4672157926eba1b55e786f48f2d
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01svidl: Remove nested method supportMaxim Monastirsky
No diff in workdir/SdiTarget. Change-Id: I53e974c8ccafbbc3675f67b87a0e1b8ff19b6790
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-05-01FN_TOOL_ANCHOR cleanupMaxim Monastirsky
Drop unused execute method, and fix state method to match actual use. Change-Id: I93b86bbe10b48bf7fca7d9068446a698d7dd9036
2017-04-30cppcheck: duplicateBreakJulien Nabet
Change-Id: Ia33dddfba35da3b495aae4edabe80b1a560674cd Reviewed-on: https://gerrit.libreoffice.org/37111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-30coverity#1405737 (golden) Logically dead codeCaolán McNamara
regression since commit 46a153cbcac1a3e2881b83b5537037321c34797c Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Sun Apr 23 18:53:58 2017 +1000 vcl: update error codes to defined constants for code clarity Change-Id: I6e86c45b71fc15d6645501128e7d86f8e179e652 Reviewed-on: https://gerrit.libreoffice.org/36851 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com> Change-Id: Id1a3f26a84c7641b0b6af71dc842a683d0c1dd0c
2017-04-30coverity#1405740 Resource leakCaolán McNamara
Change-Id: I6537e818a783ef908e2ae4d068752669529fb75e
2017-04-30coverity#1405739 Explicit null dereferencedCaolán McNamara
Change-Id: If12d46d49936af3a91b2d50ca8fca43596eb4ae5
2017-04-30coverity#1405738 Unchecked dynamic_castCaolán McNamara
Change-Id: I15533651b1eff5c00d69f7a1e050997f25addabe
2017-04-30untranslated strings are just stringsCaolán McNamara
Change-Id: Ic7247a6d0e702572ca304bb048bfabfafcbf7505
2017-04-30stop torturing std::string in SfxSlotPoolNoel Grandin
when what you really want is std::vector. Also drop unnecassary use of std::unique_ptr and constify a couple of methods. Change-Id: I676ee3460a015b0c7656167c06a569c30c861f98 Reviewed-on: https://gerrit.libreoffice.org/37106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>