summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-12Fix typoAndrea Gelmini
Change-Id: Ib728bcd332400df7e6c5466387fcdbda97792382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98489 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12Fix typoAndrea Gelmini
Change-Id: Ifad92aedd6f72f837d1839638d9f76b92d0c29d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98585 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12weld CheckBoxControlCaolán McNamara
Change-Id: Iea057189ab17c1fdaf6663f1c328b9d288d97a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12check if the "realhandler" is the tracking windowCaolán McNamara
if the tracking window wasn't already found Change-Id: Iadb42abcba615c1b55165450da6946a6129283ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12center check/radio buttonsCaolán McNamara
Change-Id: Icae25573c09861e44a42c54daaeeebfec706bd37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12filter/storagefd: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7329893b62a9fb511535f6caadcdb6e007aadfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12filter/t602: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Icf7829977f4225ec40a63f5f2b8cf23ab360e883 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12missing trailing commasCaolán McNamara
Change-Id: I6a541d5c34f933a08f3ed48b23e85a18d7e36afe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98594 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12filter/xmlfilteradaptor: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I44392add5b0ed6d3184e4ecdd2e8da729a78169c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-12tdf#118148 Extended tips in editmodulesdialog.uiOlivier Hallot
Change-Id: I1dacc63149dbbf16668ed15635e466d3558f39d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98565 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465260 Unchecked return valueCaolán McNamara
Change-Id: I0f4a71e4735bd5038b45a259bd5136ebcc4c66a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98572 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465256 silence Uncaught exceptionCaolán McNamara
Change-Id: I1356f311b8eb71549ab9570ae7e568f52c301070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98581 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465252 Dereference null return valueCaolán McNamara
Change-Id: I8884218bb93a5684fb8f0754013fa00215bbc002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465253 Unchecked return valueCaolán McNamara
Change-Id: I796fa775f6447801fa9e5f0eef023cf3b2ce8908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465254 Uninitialized pointer fieldCaolán McNamara
Change-Id: I256b55e55a9c1bf04f165a4b2de667881d714c59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98576 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12add test for editing of annotations (using .uno:EditAnnotation)Tomaž Vajngerl
Change-Id: Ic798ab94bb63a3ae80882e77cf1582d875e27d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98583 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-12allow .uno:EditAnnotation also for Draw not just ImpressTomaž Vajngerl
Change-Id: I0a0e7e3db3830e7f8a21b600249daffd28a253e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98582 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d949d2a2013b810295294067aa8d45b95398c7e4 - Housekeeping on XML Change-Id: I2459b37ae6f5ca20a377c3882d72cb08dc36abed
2020-07-11cid#1465255 Unchecked dynamic_castCaolán McNamara
Change-Id: I564bcde3ee6a96307ae133e550888f41b610e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11cid#1465258 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie2646cecfcbf85cc2b24d06786ed9773fcbb7c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11cid#1465259 silence Arguments in wrong orderCaolán McNamara
Change-Id: I67e82a3ec9128a486ef882f803c900b7c94a4529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98573 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11filter/xmlfilterdetect: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ie16b3a2a11c4b5fee579c05d041d287d753ab2a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11filter/xslt: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7aae8e370a31a69f84dcbb4372077e5b8e0781fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11use accessible description before querying helpCaolán McNamara
Change-Id: I1b5814566fd0750b92797cbf8581da0bee003630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11unoxml_component_getFactory doesn't exist anymoreCaolán McNamara
Change-Id: Iaf1ba4753c481f92096afd062ef0dd6210f0628e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98579 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11use an aux modify handler instead of listening for VclEventId::EditModifyCaolán McNamara
Change-Id: Ie35ad08a24b8b0c989806c4739bfe925fd9ab746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11connectivity: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id678e4c51459429dd3953c0e54558d2c36e85eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11desktop/deployment: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I11fe446e07e9a807c1267c4037922877d987003c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11dtrans/mcnttype: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Also drop mutex, no need to lock when we're just constructing something. Change-Id: I5e845ae2fbb03fc4f38d0ee85b2061891fa0993f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11vbahelper: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I190d58fe45aa0b724b7239f5417bd0293d6dca80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 21609114dcc627949bca327ffe29b6df6e3b097f - Add title to Help page Change-Id: Ie43d7c4b68110bb31c7c21aa4ffbedc73b8c7ab9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98556 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-11desktop/deployment: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I1559c29286c8877f5fc75cdb293403f5e5e5a538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11tdf#134647 crash going to next slide on slideshowNoel Grandin
regression from commit 1cd0e02cdf7fc5b5903320ffd24865d11465d14b cairo/canvas: create instances with uno constructors Change-Id: I4d09f8d68a24b0efa47d12df1c542f2953efed3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98530 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-11NFC writerfilter: cleanup gridAfter dead codeJustin Luth
Since commit 1d1748d14 in 2016, DomainMapper has never processed property LN_CT_TrPrBase_gridAfter, and so it has always been its initialized value of zero. However, gridAfter still DOES create fake cells in ooxml. With recent changes, those fake cells are now included in nGrids (i.e. they have a gridspan of 1) and so the nGrids + m_nGridAfter would no longer be appropriate in case gridAfter is ever processed again with + <ref name="CT_DecimalNumber"/> - <ref name="CT_TrPrBaseGridAfter"/> The row SHOULD know about gridAfter, so I'm not removing the foundational bits, even though they are currently still unused. Change-Id: I9b8b1006d528590c4621ce86564e007399b07d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98533 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-07-11paintTile: Try to find a view that matches the tile-zoom requested...Dennis Francis
by iterating over first few shells to avoid switching of zooms in ScGridWindow::PaintTile and hence avoid grid-offset recomputation on all shapes which is not cheap. Change-Id: Ib086112ebd504087d80c6d6f2879a69dca8ce44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98168 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit f54d3aa9bee7bc794b18b968835c6d6393f350ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98163 Tested-by: Jenkins
2020-07-11reset all draw gridOffsets when zoom needs to change...Dennis Francis
so that these are recalculated on render, else the shape positions in the tiles will be wrong. It is not enough to reset for just the objects in the tile because the render code iterates over all objects and then decide whether to render them based on the position/size. An obvious optimization is to choose a view/window with its zoom matching the tile-request using some useful heuristic and avoid a linear scan of views. Change-Id: Iffa96d261bc3362af3a528fbf7d4d3bcafc6d497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98167 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 22d458164ae903f502e82f471c22ff8e1ebbb839) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98162 Tested-by: Jenkins
2020-07-11scPrintTwipsMsgs: Use print logical coordinates for draw objectsDennis Francis
as a result LOK_CALLBACK_GRAPHIC(_VIEW)_SELECTION messages will now be in print-twips. For tile-rendering, it needs the pixel-aligned coordinates of each object. The translation of print coordinates to pixel-aligned coordinates can be done behind the scenes by the ViewContact/ObjectContact/ViewObjectContact objects associated with the draw object which uses the cached "grid-offset" for each object (introduced in the patch "Refactor calc non-linear ViewToDevice transform"). For doing this, a subclass of FmFormView with a specialized "createViewSpecificObjectContact" method is used for tile-rendering. The createViewSpecificObjectContact creates a "proxy" object-contact object that delegates the grid-offsets queries to the actual ScDrawView generated ObjectContact. This is needed because currently there is no way to share the ObjectContact/ViewObjectContact instances between different SdrPaintWindow's without making changes ~everywhere. Change-Id: Ifdfb623c8d6dd81700ec4a5dfeeb6b2391a96154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98166 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 345f9480618d0867f6b42a83a7ae1d62c8ef9c0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98161 Tested-by: Jenkins
2020-07-11tdf118148 Extended tips for optsavepage.uiOlivier Hallot
Added extended tips in AtkObject::accessible-description in ui file Added pango markup in extended tips Change-Id: Id8e2465d2e6ecae306921395f7e84534a8295069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98293 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-11Add missing dependencyMike Kaganski
... see commit 5b66a038701241e0b9fa3a339acbd74f9ca4cf92 for details Change-Id: I8380842d180d3517b76a4084f33246f80f17e323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-10Change $[officename] to %PRODUCTNAME in ui fileOlivier Hallot
Change-Id: I8c5b5baa272f7ea2902ad0e61a6e4412b06953e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98461 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-10Fixup pre-commit hook to work with worktreesThorsten Behrens
For git worktree setups, the hooks sit with the original repo (usually the initial clone). Worktrees with older version checkouts then miss the blacklist->excludelist rename, and consequently fail. Change-Id: I5f60fabc7d5856c74d93c4ada54f57574e0fd1a9
2020-07-10tdf#134548: sw: revert of changes to tab at zero posVasily Melenchuk
It looks like solution for provided in 5ed96c for tdf#83309 is enough to resolve original bugdoc, so these changes for emission of tab at zero position are not required and produce just regressions. Corresponding unittest for tdf#83309 is adjusted: it is using now original bugdoc. Change-Id: I2e7683f071f78c720436b4c9ccb903133a985e7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98476 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10disable animations during widget render to surfaceCaolán McNamara
Change-Id: I6b3073092e8eaf83bff89b35c50b3476039af410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10Add Extended Tips in optpathspage.uiOlivier Hallot
Change-Id: I7b1cdb981f29b773bc4f0db61d180d0f1fdc4642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98539 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-10tdf#134576: proper handling of For/For Each with On Error Resume NextMike Kaganski
1. In SbiRuntime::PushForEach, always initialize SbiForStack::eForType to avoid handling the loop as simple For loop in SbiRuntime::StepNEXT. 2. In SbiRuntime::PushForEach, just like in SbiRuntime::PushFor, don't set error, but imitialize the loop properly. This allows to proceed to SbiRuntime::StepTESTFOR, where the error will be handled gracefully. 3. In SbiRuntime::StepTESTFOR, check for the proper initialization of the iteration, and set the error. 4. In SbiRuntime::StepTESTFOR, on error, modify the type of iteration into Error - to make sure that loop ends on next iteration (so only a single iteration happens inside the Resume Next). Change-Id: Idd0bab79fb0099fa3ad295b7fc6ab2eb6173f7b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98537 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 79e8a3820948824f875051058e4ed33cf822a529 - Fix mistake in Help page for VDB() Change-Id: Ib3780415a1ca5385dd27391f2b33fd1904e5e24b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98523 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-10tdf#134582 sfx2: when storing, set Version on embedded object storageMichael Stahl
This previously wasn't needed because there was only one version for which it was checked (1.2) but since commit a541cd91951eca15e40764244b34c72b347f9f26 there's a second version so when loading an existing embedded object in one version and storing it in another, the Version must be updated so the attribute in META-INF/manifest.xml matches the one in content.xml. Change-Id: Ic2fc303c6f6bc254050d531d578029377976ecb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98521 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-10tdf#107902: sc_macros_test: Add unittestXisco Fauli
Change-Id: I6fb494944c51a06ffec955e900f146e748f8f2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98522 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-10tdf#134692: copy deep when there are multiple references to the old arrayMike Kaganski
E.g., when we redim a copy of an array, the other copy would still have its old dimensions, so shallow copy would share some array elements between the now different arrays. The other possible approach would be to try to modify the original array to have the ByRef semantics. Change-Id: Iab272ecbf4ade67048d6a126f17322441c5aa808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98481 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 11:23:06 +0000