summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-31Revert "Prevent nonsensical comparations between OUString and nullptr_t"Stephan Bergmann
This reverts commit 2e3f5c8dd3b21efe83269f603e26ac20f3adde64, some GCC have trouble with deleted friend functions; need to fix that properly.
2016-10-31Prevent nonsensical comparations between OUString and nullptr_tStephan Bergmann
...now that 1b98f38 css.xml.sax.XAttributeList is broken by design 074defe Strange OUString null check a24105a Nonsensical OUString null check 9799fe3 Nonsensical OUString null check d6b9fea Nonsensical OUString null check f2de7d0 This apparently always wanted to check that _rChars.trim() is non-empty a8cfc97 SvxBrushItem::GetGraphicLink no longer returns a pointer are fixed. (OString didn't have this problem with overloaded operator ==/!=, but had a similar issue with nullptr_t that OUString in turn didn't have, f20162304d73bc01955e9ef6506c3bd1c7016c48 "Rule out OString(std::nullptr_t)".) Change-Id: I4ca0e1f5a911448e7bc9b8c5dddff5993d61ef18
2016-10-31css.xml.sax.XAttributeList is broken by designStephan Bergmann
In the Java interface it was reportedly copied from, getValue can return null to indicate a missing attribute, but in UNOIDL that's not possible. The workaround that implementations of the UNOIDL interface resorted to is apparently to return an empty string (another option would have been to throw an exception). But the code in xmlsecurity appears to be written under the ill assumption that getValueByName would return null for a missing attribute. What the code as written actually did check was whether the return value is an empty string (because it picks the operator ==(OUString const &, sal_Unicode const *) overload, which happens to treat a null second argument like an empty string). Ideally, the code in xmlsecurity would have some way to tell a missing attribute from an empty one (via some extended XAttributeList2, or by iterating over all getNameByIndex, or ...). But for none of the affected attributes it seems expected that the attribute's value could be an empty string, so checking for an empty string seems to work reasonably well in practice. So keep it simple and just check for an empty string properly. Thanks to Tor for spotting that odd xmlsecurity code. Change-Id: Ib068ee98ef818683a43309ab4d7c3a4731e8deff
2016-10-31Strange OUString null checkStephan Bergmann
...ever since 035d20bd248b4f958c185001752688ef88318af6 "INTEGRATION: CWS aquafilepicker01". Unclear whether this was written under the assumption that m_aCurrentFilter is a pointer (which would explain the OSL_TRACE message talking about "null"), or whether it really wanted to check for an empty string (which the code acutally happened to do). So lets keep the empty-string check in, given it was in there ever since the code's introduction in 2007. Change-Id: I9e48b6ceccaf069c6a6a88d3918ba88379a72497
2016-10-31Nonsensical OUString null checkStephan Bergmann
...ever since 523e10ac08b35b6b63e9ac0ffefac7c013e4ee89 "INTEGRATION: CWS scriptingf4: #i28384# - implement Macro Selector specification". (That happened to redundantly check for non-empty aScriptURL, too.) Change-Id: I3fae859af4b0cc5d2b5f8a609c74b00b120694f3
2016-10-31Nonsensical OUString null checkStephan Bergmann
...ever since acd2c90978052723475a41144dd5d92090fbf6b4 "fdo#80897: Preservation of text warp properties." (That happened to redundantly check for non-empty presetWarp, too.) Change-Id: I6162f7cb5c82b7950eb3742c61bc3297e9c6fa1b
2016-10-31Nonsensical OUString null checkStephan Bergmann
...ever since at least d32b3a714fe55892bdead03502c5a9b0e77fa61d "#i106421#: move svx/source/cui to cui". (That happened to redundantly check for non-empty url, too; maybe in the distant past GetScriptURL returned a pointer.) Change-Id: I6139db1d4b1fdcf5325895569de293dd89e36d9f
2016-10-31This apparently always wanted to check that _rChars.trim() is non-emptyStephan Bergmann
...and d3e89269304c623e3b52a097e9e270f1bf1f09b8 "initial checkin - implementations for formlayer import/export - still under construction" just forgot the '.getLength()' in OSL_ENSURE(0 == _rChars.trim(), ... that is present in other, similar code. (And the current code happend to use the operator ==(sal_Unicode const *, OUString const &) overload that happens to treat a null first argument like an empty string.) Change-Id: I9d74b6ae29ca5f5f80391de50e4898add6bf6fe2
2016-10-31sfx2: Metadata has no need for cryptographic randomnessMichael Stahl
Change-Id: I911c15c0ea7a3cae0269c67d8bd6fd79e9b6d8c6
2016-10-31Updated coreStanislav Horacek
Project: help afded9511ec67e7181ffcc2614bf4c676539efcd update description of Find and Replace dialog Change-Id: I40af15d57e568eebdb5fe145e6a8bc9c8d6845b0 Reviewed-on: https://gerrit.libreoffice.org/30396 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-10-31populate library path to gbuildtojson in testsBjoern Michaelsen
the test environment clears LD_LIBRARY_PATH as it seems to cause trouble for make in ASAN. "make gbuildtoide" only runs the gbuildtojson exe, so make sure it gets the LD_LIBRARY_PATH that was filtered out from the make that starts it. Change-Id: I69ee0024232092aebcd1e8e11b002d6f7eb55c84 Reviewed-on: https://gerrit.libreoffice.org/30433 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-31Updated coreGabor Kelemen
Project: help 129393b348cf785721113200e54fe7d243dbd403 tdf#103527 Remove references to the Colors settings page The Tools->Options->$officename->Colors page was removed in 28da3aed71a4850f47156d717b6a18fce98154e9 Change-Id: Ife056262aba89c79d2e98f1a0f97630ed5c498ef Reviewed-on: https://gerrit.libreoffice.org/30402 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-10-31fix MSVC 2015 build Error C2397lbenes
Change-Id: I4810aa8b0b7d28bcd41b4aa19d40f41757d540cd Reviewed-on: https://gerrit.libreoffice.org/30411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-31No good reason for dbaccess::OCacheSet::updateRow to be pure?Stephan Bergmann
Most of its virtual member functions are (though insertRow is already a curious exception), even though they are defined, so smells like a copy/paste error rather than deliberate design. And appears to have been the only reason why loplugin:unnecessaryoverride filtered out such overriding of pure base functions. Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
2016-10-31SvxBrushItem::GetGraphicLink no longer returns a pointerStephan Bergmann
...since cfb4463d2afd36ca6d0fbb9e374bf5387fee84df "convert include/editeng/brushitem.hxx from String to OUString", which boldly changed it from returning a pointer to returning a reference, probably not even taking into account that that broke the value set (from string+null to just string). However, that change appears to have worked OK in practice, and there maybe wasn't a need after all to distinguish a null value from an empty string. These two places here were missed in the change, and happened to keep working, as they picked the operator ==(sal_Unicode const *, OUString const &) overload, that happens to treat a null first argument like an empty string. Change-Id: If2d76951fa4bf6c7821321327ad653bd0a95a788
2016-10-31loplugin:oncevar in xmloff..xmlsecurityNoel Grandin
Change-Id: I2353d3c73130ed9420e8d803a9a96a06549bb6bd Reviewed-on: https://gerrit.libreoffice.org/30429 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31loplugin:oncevar in unoxml..toolkitNoel Grandin
Change-Id: I3b97665908be0a44d24192433bdc9c2bd9008736 Reviewed-on: https://gerrit.libreoffice.org/30431 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Clean up #include lineStephan Bergmann
Change-Id: I8fe49533c3aa2830cf068d9cad091f3c2ab0fbfd
2016-10-31Adapt SalFrameStyleFlags maskStephan Bergmann
...after 016730421e5e58415170b464bf9d9ca47d6c3b4e "remove newly unused WB_NEEDSFOCUS and fragile FLOAT_FOCUSABLE" Change-Id: I9c780c8ec755d624e0eb1891876bd264bd47955c
2016-10-31MS formats allow padding without borders, regardless of display.Justin Luth
AllowPaddingWithoutBorders is about display / UI settings. Whether LO displays them or not, the border distance should be saved for proper round-tripping, so no need to test for compat setting (and which is always true anyway in this code segment). related to tdf#41542 and commit 52b29c60801cf75364fd8275a22e812797cb184d Change-Id: I3822d9ea50376b50b89dff37b7394286cab76fff Reviewed-on: https://gerrit.libreoffice.org/30426 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-10-31loplugin:countusersofdefaultparams in sc(part1)Noel Grandin
Change-Id: Ia2b0174654fad536ee23f6174a0b38b1843a4aa5 Reviewed-on: https://gerrit.libreoffice.org/30427 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31loplugin:oncevar in vbahelper..writerfilterNoel Grandin
Change-Id: Ifd7e91753d9652d6b1c535cde3cddf74757a2483 Reviewed-on: https://gerrit.libreoffice.org/30430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31fix unnecessaryoverride clang plugin on clang < 3.8Noel Grandin
Change-Id: Id78d694cf7271a6abf94234958ab623cf1cd93a5
2016-10-31fix use of is_sorted_untilNoel Grandin
fix for "comparison doesn't meet irreflexive requirements, assert(!(a < a))" as a consequence of author Jochen Nitschke <j.nitschke+logerrit@ok.de> commit e75561bd19faa332c077ec249a397d056fae63f2 bin SfxUShortRanges, inline and rewrite only usage seems that std::is_sorted_until has stronger requirements than we actually want here, so open-code a similar algorithm Change-Id: I126584d9146137b9ac699dad85fd9691490dc30d Reviewed-on: https://gerrit.libreoffice.org/30435 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-10-31update vclwidgets plugin to check local variablesNoel Grandin
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31sw: bookmark names don't need cryptographic randomnessMichael Stahl
Change-Id: I6cecbf9b5a8b66de2e0e2d90fdecf6b389caad25
2016-10-31sw: RSID have no need for cryptographic randomnessMichael Stahl
Change-Id: I4a3c4e390a6d05059e27ca33f02c38cfb6bb2e47
2016-10-31sw: DocumentListsManager: no need for cryptographic randomness hereMichael Stahl
... or in SwDoc::GetUniqueNumRuleName() Change-Id: Ifd6df902f7feae9db77f38654d7eb246dfb3510a
2016-10-31return dialog pointers using VclPtr<>Noel Grandin
or their ref-count could drop to zero before they actually get used Change-Id: I5af7a0cc8650e3d779c870144c23b6de19c8cc45
2016-10-31This needs to be VclPtr tooJulien Nabet
Avoid this segfault: Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 38 assert(mnRefCnt>0); (gdb) bt 0 0x00002aaad2a20e4e in VclReferenceBase::acquire (this=0x9999eeeef579c129) at /home/julien/lo/libreoffice/include/vcl/vclreferencebase.hxx:38 1 0x00002aaad37325ae in rtl::Reference<AbstractScImportAsciiDlg>::Reference (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/rtl/ref.hxx:63 2 0x00002aaad37321b5 in VclPtr<AbstractScImportAsciiDlg>::VclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:89 3 0x00002aaad3731e25 in ScopedVclPtr<AbstractScImportAsciiDlg>::ScopedVclPtr (this=0x7ffffffef7c0, pBody=0x55555be02790) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:305 4 0x00002aaad373055e in ScFilterOptionsObj::execute (this=0x555558d8d450) at /home/julien/lo/libreoffice/sc/source/ui/unoobj/filtuno.cxx:179 5 0x00002aaad1c03f50 in (anonymous namespace)::handleFilterOptionsRequest_ (xContext=uno::Reference to (cppu::ComponentContext *) 0x5555559ec960, rRequest=..., rContinuations=uno::Sequence of length 2 = {...}) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:259 6 0x00002aaad1c044f4 in UUIInteractionHelper::handleFilterOptionsRequest (this=0x555558c1b400, rRequest=uno::Reference to (RequestFilterOptions *) 0x555558d5edf8) at /home/julien/lo/libreoffice/uui/source/iahndl-filter.cxx:315 Change-Id: I50f9f5c4c63328a0aaa3ecb2d83a902de6a38add Reviewed-on: https://gerrit.libreoffice.org/30410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31tdf#103334 - EDITING: Undo on bullet point styleNoel Grandin
I have checked the normal model and the editing model after UNDO, and all seems to be well, this is purely a rendering/lack-of-invalidation issue. The extra invalidation I add here is restricted to the UNDO case to prevent tripping up a LOK unit test (SdTiledRenderingTest::testCursorViews). I confess to not having followed the invalidation logic all the way to see why exactly it makes the bug go away. Change-Id: I34f7d84526462665b1ec09aba966c98cd4e8795f Reviewed-on: https://gerrit.libreoffice.org/30225 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31fix logic error - still set zero padding if no border setJustin Luth
caused by commit 52b29c60801cf75364fd8275a22e812797cb184d originally, if there were no visible lines (bFirstLine), then any line distance was reset to zero, but with AllowPaddingWithoutBorders that should not be done. However, the case were there is no boxItem at all was missed - padding should still be initialized to zero in that case. Change-Id: I0a95ee1de6781089196a1ba40d2c0365d15926e2 Reviewed-on: https://gerrit.libreoffice.org/30412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-31tdf#103403: Wrong glyph advances with GraphiteKhaled Hosny
Patch sent upstream: https://github.com/behdad/harfbuzz/pull/357 Change-Id: I245509d386e83970e4b08bd2a4b20a590303025a
2016-10-31Avoid excessive text clipping on WindowsKhaled Hosny
Use a better rounding strategy so that when the bounding box involves part of a pixel we include the full pixel, so floor for -ve values and ceil for +ve ones. Without this I see lots of cut text on Windows. Change-Id: I258f63eb37911574cd3f6f08da22349756c0775c
2016-10-31Reduce number of argumentsKhaled Hosny
The font is already a member of the class, and the EM height is unused. Change-Id: Ice2eb2bb3e4b491bcb93123e1c3a08170cdaa50b
2016-10-30cppcheck unreadVariable: diffJochen Nitschke
since initial commit 27a1e85b656bad222f113f650b03397aa3bc59d3 Change-Id: I46a973fdd6b565117030a3ae218928807e9bac41 Reviewed-on: https://gerrit.libreoffice.org/30406 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30cppcheck unreadVariable: nRemoveSelectJochen Nitschke
since introduction in commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366 Change-Id: I9e735ec9f39502b90cec40af4397abac0165df83 Reviewed-on: https://gerrit.libreoffice.org/30407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30cppcheck unreadVariable: nCountJochen Nitschke
unused since commit debafc2c17b957ff2edc8821bf0f615816645e94 Change-Id: Ida1da503739454a1fb67b4d0df3067060c2738e5 Reviewed-on: https://gerrit.libreoffice.org/30409 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30cppcheck unreadVariable: nJochen Nitschke
since initial commit d02f75a8c36705924ddd6a5921fe3012fafce812 Change-Id: I51d56485f4b6224a1b7ce16b0788e7e884d57b37 Reviewed-on: https://gerrit.libreoffice.org/30408 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30toolbox: don't need "ItemImageOriginal" anymoreTomaž Vajngerl
Change-Id: I7037b7a8c70150f9946cca0c48607bd887779c82 Reviewed-on: https://gerrit.libreoffice.org/30405 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30tdf#103588: Draw with the right font on WindowsKhaled Hosny
Apparently without implementing InitFont(), we might end up drawing with the wrong font, thanks to the arcane ways GDI API. Change-Id: I224de138446d4a536e13992efa98b0f04609576a
2016-10-30-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I695b3709c2b53f62773dc390b89966061c7b0ae9
2016-10-30Updated coreMaxim Monastirsky
Project: help 4f39d66542067430093d3887a83bde67d838e20b Update after recent dbaccess HID removal Change-Id: Ifbbfaf592aca44eb2a2a83e9afef3427aef364b8
2016-10-30bin SfxUShortRanges, inline and rewrite only usageJochen Nitschke
only use was to merge 2 range tables in SfxItemSet::MergeRange of which one table always contained a single range. rewrite the merge algorithm (SfxUShortRanges += operator). sort new range into the table of ranges and merge overlapping ranges afterwards. Not as optimal as the original code but it's short, maintainable and works without 'goto' inline the DBG_CHECK_RANGES macro Change-Id: I991c050f069d44fe72b3ea374863f5f26e7099e9 Reviewed-on: https://gerrit.libreoffice.org/30299 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30vcl: use links to "large" (26px) icons also for 32px iconsTomaž Vajngerl
This adds links to "large" icons (prefixed with "lc_") also for 32px icons automatically so that we don't need to duplicate the links.txt files. Change-Id: I5fc3a769aa795060b6ae2d554cadd81938e4d4ec Reviewed-on: https://gerrit.libreoffice.org/30399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30Allow using xml menus in DBTreeListBoxMaxim Monastirsky
Change-Id: I8dfab0ae5d64b416123ab5690b43cf2db77d92dc
2016-10-30Add resource name method to IContextMenuProviderMaxim Monastirsky
Change-Id: I218fd18101f8f7039052fe8a065096e4c9809adb
2016-10-30Convert RID_MENU_APP_EDIT to xmlMaxim Monastirsky
Change-Id: I6868624b1726b1044e741a1fc0cdabe703f84c31
generated by cgit (git 2.34.1) at 2025-01-29 22:59:10 +0000