summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27tdf#79546: Make sure temp copy of inserted media file keeps the same extensionTor Lillqvist
Inserting videos into Impress presentations with 'Insert>Audio or Video' did not work at all for me. This helps. It seems that the AVFoundation APIs are sadly rather picky about file name extensions. Why we need to make a temporary copy of the media file (which after all can be rather large) at all, when inserting it in a slide, I don't understand. But I am not going to dig into that now. Change-Id: I43fcfb5bb3ef0a2c0f8979ac3e7c458a84f180a1 Reviewed-on: https://gerrit.libreoffice.org/50390 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-02-27Fix assert(mpDialogImpl->get_response(pButton) == RET_HELP)Stephan Bergmann
...in Dialog::add_button (vcl/source/window/dialog.cxx:1348) during CppunitTest_cui_dialogs_test (part of `make screenshot`) Change-Id: Ie5b8e301b99350a19f6de7de6496a9b315b633ee Reviewed-on: https://gerrit.libreoffice.org/50415 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27uitest for bug tdf#77479Zdeněk Crhonek
repair test case - original file contain smb:// URL. New test file created from scratch. Change-Id: I64f32f87cb620be9988b91f8c96548e219057316 Reviewed-on: https://gerrit.libreoffice.org/50386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-27tdf#116043 fix customize dialog icons going awayJim Raykowski
Change-Id: Id4022092765c085efcd71627a1dd8290f7441e74 Reviewed-on: https://gerrit.libreoffice.org/50407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-27Update orcus to 0.13.4.Kohei Yoshida
Change-Id: I261fa22fa8557409c13370761de584fe64083fba Reviewed-on: https://gerrit.libreoffice.org/50403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-27Replace the 2 occurences of Navigation by NavigatorJulien Nabet
and get rid of: warn:legacy.osl:10410:10410:sfx2/source/control/msgpool.cxx:211: GroupId-Name not defined in SFX! Indeed "Navigation" isn't taken into account in getGidResId from msgpool.cxx (sfx2) Change-Id: Ie5d54175106c1ca835a487ccfe2a38f3f21dc93d Reviewed-on: https://gerrit.libreoffice.org/50400 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-27Fix exporting bitmap table + testTomaž Vajngerl
Change-Id: I0577de02000c6aeb45bf1e950b9212beadacb05b Reviewed-on: https://gerrit.libreoffice.org/50334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-27Switch AgileEngine::calculateHashFinal() to GetOoxHashAsVector()Eike Rathke
... to de-duplicate implementation and cut some overhead. Also, it seems UTF-16BE password was never handled. Change-Id: I46cae8516c6f2d1568aabc8d993c883f424c7d12 Reviewed-on: https://gerrit.libreoffice.org/50401 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27Updated coreCaolán McNamara
Project: help 87195b21bae39f7bc4fe4c35f305241d1f5d0b3f update help ids for accept/reject dialog Change-Id: Iea81698d82be9ecced7b45c0a465459abec88860
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27tdf#111789: TextBox shadow propeties are not saved to PPTXTamás Zolnai
Change-Id: I0c858676e1fc02a72b4b6bfd10f512d8e9166061 Reviewed-on: https://gerrit.libreoffice.org/50402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-27tdf#1155015: Make sure checkbox text really wrapsKatarina Behrens
for :wrap property to be effective, a reasonable height request is needed so the text is not forced into single line again Change-Id: I3bfe459b4894cad1682d03a8ef77f0c54690bf4d Reviewed-on: https://gerrit.libreoffice.org/50394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27Resolves: tdf#115951 wrong entry selected for numbering posCaolán McNamara
Change-Id: I4e317abb3cfceee2de4826f967a27d14fb3878ef Reviewed-on: https://gerrit.libreoffice.org/50354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27loplugin:useuniqueptr in TriangulatorNoel Grandin
Change-Id: If963704ec8af82ed2af1418621ef7fc5e475567f Reviewed-on: https://gerrit.libreoffice.org/50364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27drop old tools/gen.hxx methods in swNoel Grandin
Change-Id: I1db8954b86e9b2ec27ecc1f65e8ff7715612d756 Reviewed-on: https://gerrit.libreoffice.org/50363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27drop old tools/gen.hxx methods in sdNoel Grandin
Change-Id: I8af9c5c0085f5e6f8e498c48bae69f8247ef88ed Reviewed-on: https://gerrit.libreoffice.org/50362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27drop old tools/gen.hxx methods in scNoel Grandin
Change-Id: I3652c0a35a6873e80ee22d908a8969d09410776b Reviewed-on: https://gerrit.libreoffice.org/50361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27Performance is still sluggish, so use non-broadcasting functionKatarina Behrens
avoid O(n^2) due to broadcasting in the initial round of spellcheck. Also always delete OPO Change-Id: I70f2165686dee6a22ab7803e21ed886ff1679d07 Reviewed-on: https://gerrit.libreoffice.org/50360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-27Use for-range loops in comphelper and configmgrJulien Nabet
Change-Id: I91033395cb30a4ba9e65adb89712b3c70a39a508 Reviewed-on: https://gerrit.libreoffice.org/50396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-27tdf#115715 RTF import: ignore zero para indents in styles without parentsMiklos Vajna
The only reason the DOCX equivalent of the bugdoc was imported correctly is that these default zero margins are simply missing from the DOCX markup, suggesting Word ignores them. We now do the same, this way the stripped down document's 3 paragraphs all have different margins as expected. (Also rework the testTdf112211_2 testcase to test the original problem better: I verified that the layout is unchanged before/after this patch.) Change-Id: I88d56c27c19e070e983c3392f99bca96597cd56e Reviewed-on: https://gerrit.libreoffice.org/50391 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27sw HTML import: allow custom XHTML namespace aliasMiklos Vajna
This helps in case the HTML filter is given an XHTML that has an explicit namespace alias for <http://www.w3.org/1999/xhtml>. Change-Id: I437fa85ba19ce907c9c4b10c8d10aaf2217dc0ea Reviewed-on: https://gerrit.libreoffice.org/50380 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27sw: prefix members of SwScriptField, SwTemplNameField and SwWrongListMiklos Vajna
Change-Id: Ia82df7c6c8260c90f76d77355b70b8589978b9c2 Reviewed-on: https://gerrit.libreoffice.org/50341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-27tdf#97228 Moved struct FltCallDialogParameterShubham Verma
Moved struct FltCallDialogParameter to svtools/inc as this struct is used only in the files located there . A separate header file is made named FltCallDialogParameter.hxx which has this struct and appropriate modification are done to the inclusion of header files in each file. Change-Id: I60326b58fcbbb9c34abdb7c3de48667268b5d5e5 Reviewed-on: https://gerrit.libreoffice.org/50265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-27Styles dialog no longer gives any statusSamuel Mehrbrodt
So always enable the button to activate the styles sidebar. Found by UBSAN: test_asian_phonetic_guide (asianPhoneticGuide.asianPhoneticGuide) ... /svx/source/dialog/rubydialog.cxx:322:68: runtime error: downcast of address 0x602000635e30 which does not point to an object of type 'SfxBoolItem' 0x602000635e30: note: object is of type 'SfxVoidItem' Change-Id: I6ff20c76b4a45189d78707cd258ed2aff80c50a5 Reviewed-on: https://gerrit.libreoffice.org/50367 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-27vcl: test BitmapPalette greysChris Sherlock
Change-Id: Ief511d75e5a9b1e9230036c453edcb8b0a039221 Reviewed-on: https://gerrit.libreoffice.org/50328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-27Remove duplicated includesAndrea Gelmini
Change-Id: I8caee48fa9a08d6ee8c5c084468634dcd2a5fbf6 Reviewed-on: https://gerrit.libreoffice.org/50383 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-27Use for-range loops (canvas)Julien Nabet
Change-Id: I6a3b0b7bd6d4d3f432877e9fab0aadc041a4e8e9 Reviewed-on: https://gerrit.libreoffice.org/50389 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-26Updated coreAndrea Gelmini
Project: help e99b572b78c43358f910219ee89a13a87d8e7bba Fix typo Change-Id: Ia48c3586354cf4144a42810fcf0ca678ae28085c Reviewed-on: https://gerrit.libreoffice.org/50374 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-26Updated coreAndrea Gelmini
Project: help acc847de97f5bbaefe27500d630ae8180215f09e Fix typo Change-Id: I474984c776c141f18c789a9e16b026cd4588bca7 Reviewed-on: https://gerrit.libreoffice.org/50376 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-26tdf#114076: Expand ClipRange to next PixelBoundArmin Le Grand
Do this by going to basegfx::B2DRange, adding a single pixel size and using floor/ceil to go to full integer (as needed for pixels). Also need to go back to basegfx::B2DPolyPolygon for the creation of the needed MaskPrimitive2D. The general problem is that Writer is scrolling using blitting the unchanged parts, this forces this part of the scroll to pixel coordinate steps, while the ViewTransformation for paint nowadays has a sub-pixel precision. This results in an offset up to one pixel in radius. To solve this for now, we need to expand to the next outer pixel bound. Hopefully in the future we will someday be able to stay on the full available precision, but this will need a change in the repaint/scroll paradigm. Change-Id: Idb4a596bc298d1b80aab6f36ad4204afe94d54f7 Reviewed-on: https://gerrit.libreoffice.org/50369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-02-26split out GetStandardWarningBoxImageCaolán McNamara
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e Reviewed-on: https://gerrit.libreoffice.org/50377 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26convert corner case warningboxes with checkboxesCaolán McNamara
Change-Id: Ic8b58b792236a733b6687148eac5c06bbf734acf Reviewed-on: https://gerrit.libreoffice.org/50325 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Introduce DocPasswordHelper::GetOoxHashAsVector() with salt value vectorEike Rathke
In preparation to use this in AgileEngine. Change-Id: I45fb6ba24b759a72af0c7afa22eae75f1ae728ce
2018-02-26ofz#6571 Integer-overflowCaolán McNamara
Change-Id: If4a0b9532c69a1b3746fab8c727f245cd2e8a131 Reviewed-on: https://gerrit.libreoffice.org/50375 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26vcl: Bitmap::MakeMono() -> Bitmap::MakeMonochrome()Chris Sherlock
Change-Id: I6b5259d56e8fe5855f8a1125bb87a3dea8e5f425 Reviewed-on: https://gerrit.libreoffice.org/50301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26tdf#115742: allow ignoring stale lockfile on saveMike Kaganski
This change reuses TryLaterQueryBox, but only uses the new option to ignore the lock and save. Other options ("Try Again" and "Save As") are not used, because this functionality is not implemented currently (TODO/LATER). Change-Id: Idf825be23cf97d2b338c0cf5d532f8460843bf48 Reviewed-on: https://gerrit.libreoffice.org/50371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26Introduce enum comphelper::Hash::IterCount instead of boolEike Rathke
Clarifies intention, and with IterCount::NONE prepared to handle something like old PBKDF1, if anything actually used that. See https://tools.ietf.org/html/rfc8018#section-5.1 where iteration count is not part of the re-hash. Change-Id: I5f97ca7a91f611eced8ced0a0c64961c04535d36
2018-02-26vcl, solve iOS compile failure.jan Iversen
"voided" new formal parameter Change-Id: I7d8849765eb6a2642f48159bae34c3b8bec3a8cd
2018-02-26Fixing initialization code for Bluetooth and IP Server for Impress.Rostislav Kondratenko
Change-Id: Icc385fb760b8a5ff337f58dc95ba3c3f86805eaa Reviewed-on: https://gerrit.libreoffice.org/50108 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-26Revert "tdf#97361 Tests in sw should be more pythonic"Saurav Chirania
This reverts unnecessary changes in commit 4469c1d4061e8cb463469e60e5d87af5f9bf9636 as suggested in comments at- https://gerrit.libreoffice.org/#/c/49163/ Change-Id: Iad5da22624d7c543177a2271abb58bc4f6f31ecd Reviewed-on: https://gerrit.libreoffice.org/49660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26sw: add props. BackGraphic as replacement for BackGraphicURLTomaž Vajngerl
This adds BackGraphic, HeaderBackGraphic, FooterBackGraphic properties, which are a repalcement for BackGraphicURL and similar properties that will be removed in the future commits. Change-Id: Iff20f2a97342d7c586c933d51614b5e0b54d2da0 Reviewed-on: https://gerrit.libreoffice.org/50338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-26Removed duplicated includesAndrea Gelmini
Change-Id: Ib93cb76a3b667ca96e228d0b59da9f9849850081 Reviewed-on: https://gerrit.libreoffice.org/50330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-26forcepoint #10 pop empty stackCaolán McNamara
Change-Id: I96452a86187a6b03251614625445d1b18a5ee218 Reviewed-on: https://gerrit.libreoffice.org/50357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26ofz#6561 sanitize palette indexCaolán McNamara
Change-Id: I78cc6a7eab114fdbcc438385706d56cd48a4f1fc Reviewed-on: https://gerrit.libreoffice.org/50351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26ofz#6563 nBytesPerScan of 0Caolán McNamara
Change-Id: I00263d06fc06e1b4efb9938ea57d09fa5381adf8 Reviewed-on: https://gerrit.libreoffice.org/50350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Use unsigned char, it is..Eike Rathke
Change-Id: I691f138faf53846cb55db589dcf2f87d70d35b8d
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
generated by cgit (git 2.34.1) at 2024-08-11 01:18:58 +0000