summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-01remove unnecessary SAL_WARNNoel Grandin
none of other backends warn about this Change-Id: I9b7ceba413d15698a28806cbb35bd02ccc6e9585 Reviewed-on: https://gerrit.libreoffice.org/67229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-01fix incorrect OSL_ENSURENoel Grandin
broken in commit 5e0b52c1893ffe04a68333026afa7a557c48d534 Date: Thu May 17 14:51:04 2012 +0100 some more ConstAsciiString behind OSL_ENSURE Also convert to SAL_WARN_IF, and make the error message more useful. Change-Id: I7f1d0c577751e7309d5a0d544f38c5050b903a58 Reviewed-on: https://gerrit.libreoffice.org/67230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-01remove redundant typedefhimajin100000
Change-Id: I00cb289de0e75cb663f0a4fba0a9a5dc820e368b Reviewed-on: https://gerrit.libreoffice.org/67246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-01Fix conversion of non-BMP charsStephan Bergmann
...which are apparently encoded as two consecutive \uXXXX\uXXXX escape sequences representing a UTF-16 surrogate pair Change-Id: Ic47a678dee5e28ab4dc43e115ae5c4efefb1db96 Reviewed-on: https://gerrit.libreoffice.org/67245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-01Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Add Help page for Python session Change-Id: I01f1448176f5c95a5151bb3040e9c2ef53fcb7f1 Reviewed-on: https://gerrit.libreoffice.org/67214 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-01One more "Don't add snap point < MINZOOM"Stephan Bergmann
...similar to a89f535d85bb7d32ccb5196813ba6233f45c0c83 "Don't add snap point < MINZOOM", this time triggered during CppunitTest_smoketest Change-Id: Ibee45c7b1ac9b29c7c4757bbdafd909076bcb058 Reviewed-on: https://gerrit.libreoffice.org/67243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-01Avoid -Werror,-Wimplicit-fallthrough with clang-clStephan Bergmann
...where CPPUNIT_FAIL is marked as noreturn only for __GNUC__ Change-Id: Id820b00d8dfe1218a10cd586d32cc20eb6a003de Reviewed-on: https://gerrit.libreoffice.org/67244 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-01tdf#107792 vcl/win: use ScopedGDI in WinSalVirtualDeviceDmitriy Shilin
Change-Id: Ia804f4ab527870ded8d57aa0d49aae1d357b7ac9 Reviewed-on: https://gerrit.libreoffice.org/66649 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - fix commit 622324ec76e54ea1de99d6cea3debc2389049f5 * SVG images cannot have undefined width and height * pick'd a mistake in setting generic images width and height Change-Id: I9f3e62e535c82d624c5c209b0e000784b2765604 Reviewed-on: https://gerrit.libreoffice.org/67234 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-01Introduce O3TL_UNREACHABLE as a better alternative to assert(false)Stephan Bergmann
The code in sw/source/core/fields/reffld.cxx had turned into whack-a-mole: MSVC needed the unreachable default:assert(false); to fall through to init some vars to avoid C4701 ("potentially uninitialized local variable"). But Clang (with !NDEBUG, and an implementation of assert marked as noreturn) reported that as "fallthrough annotation in unreachable code", requiring the #ifdef NDEBUG guards to be added. And now clang-cl (also with !NDEBUG, but with the MSVC implementation of assert apparently not marked as noreturn) complained about "unannotated fall-through between switch labels", which wold require the #ifdef NDEBUG guards to be removed again. O3TL_UNREACHABLE (inspired by LLVM's llvm_unreachable and underyling LLVM_BUILTIN_UNREACHABLE) hopefully improves on that for all compilers involved. For non-MSVC (i.e., Clang or GCC) it assumes that __builtin_unreachable is supported (which it is at least for GCC 7, which is our current baseline per README.md). Change-Id: I4474f95664d97c3d0e506bab90f80d5ab252ec6e Reviewed-on: https://gerrit.libreoffice.org/67232 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-01Sifr icons: add svg icons and update png oneandreas kainz
Change-Id: I53f61fc5eb75a5310d96b98649c44eaf8b0687ba Reviewed-on: https://gerrit.libreoffice.org/67241 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-01tdf#122820 vcl/win: do not use un-named C++ objectsDmitriy Shilin
Change-Id: Ifbaf53ff002f8f61f9f49ab9bb14e7598e006402 Reviewed-on: https://gerrit.libreoffice.org/67187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-01xmloff: create XMLImpressImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I10cac20b8180c0fc4d7cade2ab3d5de0f9380a88 Reviewed-on: https://gerrit.libreoffice.org/67240 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-01tdf#84431 set default format for chart image exportMartin van Zijl
Change-Id: I0b07bfe6e2dd8227c6a291252cd2fa8c48412866 Reviewed-on: https://gerrit.libreoffice.org/64581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-01tdf#41202 allow decrease selection with shift-click in writerMartin van Zijl
Change-Id: Ic9522af1d3f41188f6feb31e68737fba83b3c6d4 Reviewed-on: https://gerrit.libreoffice.org/64995 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-01tdf#38101 remove highlight after using format painterMartin van Zijl
Change-Id: I631fd1357c7b066eaad98f5b2f0950f59330330e Reviewed-on: https://gerrit.libreoffice.org/64904 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-01tdf#44837 fix bug where replace all clears selectionMartin van Zijl
Change-Id: I3b1c95439434fab55ffd159dce0aacded4551a07 Reviewed-on: https://gerrit.libreoffice.org/65291 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-01Fix typosAndrea Gelmini
Change-Id: Ib748f39705cb4cee9f331e1d048a3f531116c616 Reviewed-on: https://gerrit.libreoffice.org/67242 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-31Support bitmap PDF export for RedactionMuhammet Kara
* Add a new parameter IsRedactMode (SID_IS_REDACT_MODE) to .uno:ExportDirectToPDF * Make sure the new param makes it into PDFExport as part of FilterData * Hijack the metafile before being sent to ImplExportPage(), convert to bitmap, and replace the original * Add a new entry to GenericCommands.xcu to make our button with param visible * Nitpick: For things to be included in the bitmap conversion, they need to be added to the metafile before the conversion in PDFExport::ExportSelection(). Things added after that point (inside ImplExportPage() for example) will not be bitmapped/pixelized Change-Id: Iec7020917da920a968ea969b98e53f17eadaa275 Reviewed-on: https://gerrit.libreoffice.org/67108 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-31Sifr icons: add 32px cmd svg iconsandreas kainz
Change-Id: I619dbbf059f335f685789ad6afb679a8c55a25e5 Reviewed-on: https://gerrit.libreoffice.org/67212 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-31Allow CXX_X86_BINARY to be passed into autogen.shStephan Bergmann
This is necessary for building with clang-cl, where $CXX_X86_BINARY needs to match $CXX (i.e., both invoke clang-cl) so that the compiler switches (which have been determined based on the nature of $CXX, i.e., are Clang-specific when $CXX is clang-cl) passed to $CXX_X86_BINARY are actually understood by it. (Building extensions/source/scanner/twain32shim.cxx failed with "cl : Command line error D8021 : invalid numeric argument '/Wendif-labels'".) For now, my local clang-cl build will just pass a suitable CXX_X86_BINARY similar to the passed CXX (but with --target=i686-pc-windows-msvc -arch:SSE instead of --target=x86_64-pc-windows-msvc) into autogen.sh. Change-Id: Id958525f97e1d16f17af49e0b0288c1018885749 Reviewed-on: https://gerrit.libreoffice.org/67228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31Fix compilerplugins/clang/test/useuniqueptr.cxx for clang-clStephan Bergmann
...where it failed with > error: 'error' diagnostics expected but not seen: > File C:/lo-clang/core/compilerplugins/clang/test/useuniqueptr.cxx Line 266: rather manage this var with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr] > File C:/lo-clang/core/compilerplugins/clang/test/useuniqueptr.cxx Line 275: rather manage this member with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr] apparently due to differences in how some std types are implemented. Change-Id: Ib81ed1a1da867359e7f22bb6fb6ceb3e610e2b41 Reviewed-on: https://gerrit.libreoffice.org/67226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31tdf#121780: com.sun.star.comp.sfx2.BackingComp needs to be registered alwaysStephan Bergmann
...instead of never (as there is no handling of org/openoffice/Office/ProtocolHandler-start.xcu in officecfg/Configuration_officecfg.mk). That install:module="start" included in d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1 "Startcenter: Refresh RecentDocsView when select 'Clear list' menu option" was probably misguided cargo-cult-copying from (meaningful) install:module="impress" that were already present in officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu. Change-Id: I03ed0cf84b576597a7b88ee6627a12cedbca4960 Reviewed-on: https://gerrit.libreoffice.org/67224 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31Related: tdf#116371 RTF export: handle rotation of SwGrfNodeMiklos Vajna
This is similar to commit b226383a83e41bbced9fc2a02dc09a449401ec97 (tdf#116371: export rotation of SwGrfNode, 2019-01-26), just this is for RTF, not DOCX. Make sure we don't test the ODT import result as it's done already in CppunitTest_sw_ooxmlexport13. Change-Id: Iaf2d3011c45f3459e920f679683b1a45de42efe7 Reviewed-on: https://gerrit.libreoffice.org/67218 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-31tdf#79197 enable comment of a selected changeLászló Németh
with cursor position at the end of the change, ie. now using "Next Track Change" not only select the next track change, but it enables the icon "Insert Track Change Comment" and the menu item "Edit->Track Changes->Comment...", and it's possible to add comments as expected. Change-Id: I21318e70614d1285dd6fd90d8a7cc707fc0b5757 Reviewed-on: https://gerrit.libreoffice.org/67216 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-31tdf#123089: expand menulist horizontallyXisco Fauli
Change-Id: I578883c9eaf02b919fe2a7128d4255ab2a1cd2b8 Reviewed-on: https://gerrit.libreoffice.org/67222 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-31flatten desktopdetector codeNoel Grandin
Change-Id: I9a7ee90fc0b8427ba237ebd8feb2c2467f6847d5 Reviewed-on: https://gerrit.libreoffice.org/67169 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2019-01-31tdf#123050: catch object does not have a key labeled 'theme_data'Xisco Fauli
json::document_error: node::child: this object does not have a key labeled 'theme_data' Change-Id: Ic4daf53cff4e3e25b83393cb92957bf60cd5a92c Reviewed-on: https://gerrit.libreoffice.org/67161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31uitest add test for Impress / find and replace dialogZdeněk Crhonek
Change-Id: Id3479e790c9a1faf7ce3e0b542900c8875aac653 Reviewed-on: https://gerrit.libreoffice.org/67213 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-31uitest for bug tdf#96432Zdeněk Crhonek
Change-Id: I9afe5656f3a5b14527ca70633fb5ec5a99615e82 Reviewed-on: https://gerrit.libreoffice.org/67207 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-31NB: add print to grouped_compact file drop down menuandreas kainz
Change-Id: I8e6eab164ee864eb56d2ba7184a5587a18d5353a Reviewed-on: https://gerrit.libreoffice.org/67130 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-31tdf#115549 Enable handling background object.Gülşah Köse
Change-Id: Ibb9c01d83572259b812981aa6229e9aa9b7c60f3 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/67215 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-01-31tdf#122198 don't remove db after closeSzymon Kłos
Change-Id: Ib652174148e6997c1aabe0251a62612f28243d6e Reviewed-on: https://gerrit.libreoffice.org/67200 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-31libnumbertext: try to remove some odd stuff from ExternalProject.mkMichael Stahl
Why do we need this? Change-Id: I662402731de9b5c56d05730d31ae59606484ec97 Reviewed-on: https://gerrit.libreoffice.org/67210 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-01-31uitest for bug tdf#123013Zdeněk Crhonek
Change-Id: I1a2248b167718293af0c8a7aa8be27dc0d3a99cd Reviewed-on: https://gerrit.libreoffice.org/67211 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-31CppunitTest_sw_ooxmlexport4: testTdf81345_045Original depends on fontsMiklos Vajna
I'm not sure about the exact details, but this started to fail on one machine for me, and not on an other one. Simply mass-copying all .ttf fonts from the good machine's ~/.fonts directory to the bad machine made the test succeed. So annotate the test as poor by explicitly not running this when bundled fonts are not available. Change-Id: I42358aee08b3decd942fe93de6ff4f198f7bf63a Reviewed-on: https://gerrit.libreoffice.org/67206 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-31tdf#121069, tdf#121469 migrate special charactersTamas Bunth
dbahsql: Decode UTF8 characters stored as unicode code point values in schema file. Change-Id: I90db2345a6de9bee7aae8ae6a7c046a03eebc0a7 Reviewed-on: https://gerrit.libreoffice.org/67197 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-01-31uitest for bug tdf#107494Zdeněk Crhonek
Change-Id: I78857cc47222a1ac81eff134b3cb570bd113ffb1 Reviewed-on: https://gerrit.libreoffice.org/67202 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-31loplugin:unusedfileds is no-op on Windows, so don't run its test thereStephan Bergmann
But nevertheless, make sure that the variables m_bar9/10 used in combination with css::uno::Any have UNO-compatible type. Change-Id: I241d8b5d37de60b00b5bfdc69e642872b28e8ee2 Reviewed-on: https://gerrit.libreoffice.org/67201 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31be more lenient wrt patched epmCaolán McNamara
commit c3ab3df902b9e2ad363d1eca14da8f9f7f1567bb Date: Thu Oct 14 09:53:40 2010 +0200 changed the configure.ac to require "Patched by Libreoffice", which was possibly an error Change-Id: I6f8e302baeed054f36b54f8bfb6f5cad826ee788 Reviewed-on: https://gerrit.libreoffice.org/67199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Fix confusing message... if EPM is patched, be sure to log thatJim Jagielski
(cherry picked from commit e774041ec07d7f168c41a42b6ffa6aacc816d442) Change-Id: Ie21b6a4a20199e4c7b7ef891719916db4ffba545 Reviewed-on: https://gerrit.libreoffice.org/67198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Removed whitespace, fixed typosMatthias Seidel
(cherry picked from commit fef416499d3559230d78288661d73fe59838273e) Change-Id: I0a8f766fb5255628ea58679acca5c6b5fcefe2b1 Reviewed-on: https://gerrit.libreoffice.org/67196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Removed whitespaceMatthias Seidel
(cherry picked from commit e50d4c88a194dccc2b3de451503a10903e3ab006) Change-Id: Ib5fbbd250fbfa9db5f3df36277f81ffa999632d7 Reviewed-on: https://gerrit.libreoffice.org/67195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31weld::TreeView::get_selected_index returns intStephan Bergmann
With Clang -fsanitize=implicit-signed-integer-truncation during UITest_calc_tests3: > cui/source/tabpages/numfmt.cxx:1714:31: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 > #0 in SvxNumberFormatTabPage::SetCategory(unsigned short) at cui/source/tabpages/numfmt.cxx:1714:31 > #1 in SvxNumberFormatTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/numfmt.cxx:531:9 > #2 in SfxTabDialogController::CreatePages() at sfx2/source/dialog/tabdlg.cxx:1964:32 > #3 in SfxTabDialogController::Start_Impl() at sfx2/source/dialog/tabdlg.cxx:2038:5 > #4 in SfxTabDialogController::runAsync(std::shared_ptr<SfxTabDialogController> const&, std::function<void (int)> const&) at sfx2/source/dialog/tabdlg.cxx:2077:18 > #5 in ScAbstractTabController_Impl::StartExecuteAsync(VclAbstractDialog::AsyncContext&) at sc/source/ui/attrdlg/scdlgfact.cxx:699:12 > #6 in VclAbstractDialog::StartExecuteAsync(std::function<void (int)> const&) at include/vcl/abstdlg.hxx:73:16 > #7 in ScTabViewShell::ExecuteCellFormatDlg(SfxRequest&, rtl::OString const&) at sc/source/ui/view/tabvwsha.cxx:550:11 > #8 in ScCellShell::Execute(SfxRequest&) at sc/source/ui/view/cellsh3.cxx:359:36 > #9 in SfxStubScCellShellExecute(SfxShell*, SfxRequest&) at workdir/SdiTarget/sc/sdi/scslots.hxx:7275:1 > #10 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) at include/sfx2/shell.hxx:207:35 > #11 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at sfx2/source/control/dispatch.cxx:355:20 > #12 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) at sfx2/source/control/dispatch.cxx:1092:17 > #13 in void std::__invoke_impl<void, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(std::__invoke_memfun_deref, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/invoke.h:73:14 > #14 in std::__invoke_result<void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >::type std::__invoke<void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/invoke.h:95:14 > #15 in void std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::__call<void, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&, 0ul, 1ul>(std::tuple<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&>&&, std::_Index_tuple<0ul, 1ul>) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/functional:400:11 > #16 in void std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >, void>(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/functional:482:17 > #17 in std::_Function_handler<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)> >::_M_invoke(std::_Any_data const&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/std_function.h:300:2 > #18 in std::function<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) const at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/std_function.h:690:14 > #19 in SfxHintPoster::DoEvent_Impl(void*) at sfx2/source/notify/hintpost.cxx:46:9 > #20 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) at sfx2/source/notify/hintpost.cxx:43:1 > #21 in Link<void*, void>::Call(void*) const at include/tools/link.hxx:84:45 > #22 in ImplHandleUserEvent(ImplSVEvent*) at vcl/source/window/winproc.cxx:1932:30 > #23 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2485:13 > #24 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:285:29 > #25 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx:284:22 > #26 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx > #27 in SalUserEventList::DispatchUserEvents(bool) at vcl/source/app/salusereventlist.cxx:110:17 > #28 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:423:19 > #29 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:441:48 > #30 in Application::Yield() at vcl/source/app/svapp.cxx:505:5 > #31 in Application::Execute() at vcl/source/app/svapp.cxx:422:9 > #32 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1621:17 Change-Id: I5b6aba4c4b832cea4209e3adc1c079e3fdd34924 Reviewed-on: https://gerrit.libreoffice.org/67194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-31const_cast is not needed hereMike Kaganski
Change-Id: Ifdc1b9006fb325f14ce7623d9a28acc41a067167 Reviewed-on: https://gerrit.libreoffice.org/67193 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-31tdf#123077 gtk3_kde5: Set KFileWidget's custom widget only onceMichael Weghorn
Since the event filter is only used to set the custom widget in the KFileWidget, it can and needs to be removed again once this has been done; which also avoids crashes. (s. https://gerrit.libreoffice.org/#/c/67185/ for more infos, where the same thing is done for kde5) Change-Id: I5c719fb17510916b4730ed5c00bb638df2f183e3 Reviewed-on: https://gerrit.libreoffice.org/67184 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-31CppunitTest_writerfilter_rtftok: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I16e0c1adf854c3a2fa8d945724270d2d87461b39 Reviewed-on: https://gerrit.libreoffice.org/67192 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-31tdf#123077 kde5: Set KFileWidget's custom widget only onceMichael Weghorn
Since the event filter is only used to set the custom widget in the KFileWidget, it can be removed again once this has been done. Previously, events could cause 'fileWidget->setCustomWidget()' to be called multiple times, which resulted in a crash. (The fact that calling 'KfileWidget::setCustomWidget()' multiple times causes a crash could also be easily be reproduced by just duplicating the call.) Basically the same will be done for the gtk3_kde5 case, but in a separate commit to simplify backporting. Change-Id: Ic463c44d8a95f44ce09924893d682f402ad7ed3d Reviewed-on: https://gerrit.libreoffice.org/67185 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-31misleading and unnecessary fall through commentsCaolán McNamara
Change-Id: I6309a484c3411bc1151ff2ccd276d70600854021 Reviewed-on: https://gerrit.libreoffice.org/67191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31loplugin:unnecessaryparen (clang-cl)Stephan Bergmann
Change-Id: I0cd14e0ace9c9d2fcd880477b0485295e3010b71 Reviewed-on: https://gerrit.libreoffice.org/67138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-01 04:50:07 +0000