summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-02tdf106792 Get rid of SvxShapePolyPolygonBezierArmin Le Grand
SvxShapePolyPolygonBezier was an implementation for the UNO Shape group of polygons with bezier parts (filled/unfilled/ closed/open), e.g. com.sun.star.drawing.OpenBezierShape. It was differing from SvxShapePolyPolygon just by supporting drawing::PolyPolygonBezierCoords instead of the simple drawing::PointSequenceSequence and some details. This leads to problems - the ShapeType *does change* e.g. when you edit a non-bezier Shape in Draw/Impress and change parts to curve (also when closing, see ShapeTypes above). This is why SvxShape::getShapeType() already detects this identifier by using thze internal ShapePolyType (e.g. OBJ_PATHLINE). So there is no reason to have two separate UNO API imple- mentations for sthe same type of SvxShape at all. Get rid of the extra one and unify this implementation detail. Also cleaned up double basegfx tooling for conversions of UNO API Poly/bezier data and B2DPolygon. Adapted test for "tdf113946.docx", see comment there. Adapted test for "tdf90097.rtf", see comment there. Also needed to use the Linux values, also check comment there. Adapted test for "tdf105127.docx", see comment there. Adapted test for "tdf85232.docx", see comment there. Had to fic a problem with test for "tdf96674.docx"- the adaption of the RotateAngle for line objects goes havoc together with the UNO API when scaling is involved. That old aGeo rotate stuff just kills the existing rotation due to numerical inprecise stuff. The UNP API - in trying not just to apply a rptation, but manipulate the existing one then goes wrong in not re-getting the current rotation value anymore. ARGH! This is the original reason for the ols tdf#96674 task - i doubt that the additional code to make a line not exactly hor/ver is needed. Checked and it is not needed, thus removed the change from tdf#96674 in shape.cxx. Change-Id: I2bb8d4cfe33fee3671f3dad60e5c18609a394f9d Reviewed-on: https://gerrit.libreoffice.org/56614 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-02tdf#117923: handle direct formatting for numbering in .docMike Kaganski
Since commit df07d6cb9f62c0a2c4b29bd850d4efb4fcd4790b, we do for DOCX. DOC also has this problem, so set the relevant compatibility flag on import for this format, too. Change-Id: I3aef593341edffa878a06566da815cb72aa38004 Reviewed-on: https://gerrit.libreoffice.org/56812 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-02Resolves: tdf#56910 detect a Space (blank) separator if not selectedEike Rathke
On populating the CSV import dialog for the first time attempt to detect a possible space (blank) separator if field separators don't include it already. This can be necessary because of the "accept broken misquoted CSV fields" feature that tries to ignore trailing blanks after a quoted field and if no separator follows continues to add content to the field assuming the single double quote was in error. If this blank separator is detected it is added to field separators and the line and subsequent lines are reread with the new separators. Change-Id: I3c6d74ce8883f1d279a810e800e54b349d85ac71 Reviewed-on: https://gerrit.libreoffice.org/56810 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-02libnumbertext: update to 1.0-1László Németh
New languages: Albanian, Galician (by Adrián Chaves), Norwegian Bokmål and Nynorsk, Ukrainian (based on Russian). Change-Id: I6b40dfdafe3023edc661b0a9e9f2dedbc94364f8 Reviewed-on: https://gerrit.libreoffice.org/56785 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-07-02tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJacek Fraczek
Change-Id: Ib06c8ed707bdfd87b294b2597614249fac2c1f18 Reviewed-on: https://gerrit.libreoffice.org/56342 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-02sw: prefix members of SwAccSingleTableSelHander_ImplMiklos Vajna
Also use the 's_' prefix in sw::ClientIteratorBase, like it's done almost everywhere else. Change-Id: Id2c28037eb4f69ce1f27e0365e2b078ffc300935 Reviewed-on: https://gerrit.libreoffice.org/56798 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-02Karasa Jaga: Update many iconsRizal Muttaqin
Change-Id: Iead405770be4ba3bc9c957f8cef656b0b462d6b0 Reviewed-on: https://gerrit.libreoffice.org/56744 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-02Colibre icons: add icons for Common Align actionsandreas kainz
Change-Id: Ia234b76039759d6f71ec6578e7ffa4ff4236dae2 Reviewed-on: https://gerrit.libreoffice.org/56797 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-02loplugin:constantparamNoel Grandin
Change-Id: I9fbfa6163c1d4650c52b00dc911972f07fe7c0e5 Reviewed-on: https://gerrit.libreoffice.org/56778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I1c32a6e7e517acc2e8bb3e7898329cb38ed4accb
2018-07-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I27512b518bada81c607c5dd73c6e5155ec1b19d8
2018-07-02tdf#109190 sd: only MakeVisible on mouseclick-upJustin Luth
Since MakeVisible is called on both mousebuttom-down and mousebuttom-up, this also eliminates useless double-processing. In the problematic use case, the user pressed Ctrl-A to select a tall table. When clicking to de-select the cells, the contents moved around in unexpected ways because the rectangle is at the end of the selection during down-click, not at the cursor location. The re-arrangment of the screen invalidates the mouse-up, so the intended cursor position shifted. In the bug's calendar example, position the screen so that items 20-31 are hidden, select the whole month, and then click on 5. Before, it would move the screen down to show 31, and the cursor would be placed at the screen position where 5 had originally been. Solved by only repositioning on mouse-click up. However, mouseButtonDown must still be honoured while selecting, otherwise you can't select off-screen content with the mouse. Change-Id: I41c90a7b113dc59a3c8c385139a5bb41993646fa Reviewed-on: https://gerrit.libreoffice.org/56262 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-02tdf#51223 can now undo auto-capitalise with enterNickson Thanda
Change-Id: I1ff1bd0137415349d1eb89bef0947453f72a8ef5 Reviewed-on: https://gerrit.libreoffice.org/56267 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-02loplugin:unusedmethodsNoel Grandin
Change-Id: I92665f577bfe39497905063da517a05b8008c3cc Reviewed-on: https://gerrit.libreoffice.org/56743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02Colibre icons: update mediaplayer iconsandreas kainz
Change-Id: I97cf021a65e6daedc742cf76089622a7ba6b309e Reviewed-on: https://gerrit.libreoffice.org/56794 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-07-02Colibre icons: update avmedia iconsandreas kainz
Change-Id: I6212e22935676bc2d5107c91f2af29e0b9e9e076 Reviewed-on: https://gerrit.libreoffice.org/56793 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-07-02Colibre icons: fix sc_*columns* iconsandreas kainz
Change-Id: Ie98683c6631b05bd831620a60ebac55b940211e1 Reviewed-on: https://gerrit.libreoffice.org/56792 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-07-02scaddins: Drop unused stuffTakeshi Abe
Change-Id: Icdbb297df55ed5984b4008e304a41df89a996334 Reviewed-on: https://gerrit.libreoffice.org/56523 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-07-02uitest interpreter: add support for starting appsSaurav Chirania
Change-Id: Iaab98515d2046aaff1e3da4f80de192ebc01a9eb Reviewed-on: https://gerrit.libreoffice.org/56789 Tested-by: Jenkins Reviewed-by: Saurav Chirania <saurav.chir@gmail.com>
2018-07-02Small cleanup and simplificationMike Kaganski
Change-Id: I1e8a750832f365f080f6f60c81560dc942003049 Reviewed-on: https://gerrit.libreoffice.org/56788 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-02tdf#108000 sw layout: ignore emulated keep on large tablesJustin Luth
There is no point in a very large (multipage) table keeping with the following content and it just makes the layout more complex. This is especially true when we are emulating this using MSWord's convention, and not LO's native table-keep option. This patch only affects my earlier code for emulated tables. Otherwise, something about the general logic could loop forever in certain huge tables. This seemed like a very reasonable compromise. Change-Id: Ic1bde12b266e71fc9f608ec4d1223277108750fa Reviewed-on: https://gerrit.libreoffice.org/56314 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-02uitest interpreter: let's use argparse to parse argumentsSaurav Chirania
Reasons to do this- 1) We will add more arguments in future, handling them manually will be time consuming. 2) Argparse generates a useful help message automatically. Change-Id: I7ce8cc2746f7774c4fa7cd5b173da637e10a770b Reviewed-on: https://gerrit.libreoffice.org/56777 Tested-by: Jenkins Reviewed-by: Saurav Chirania <saurav.chir@gmail.com>
2018-07-02sc: Replace DblMin() with std::min()Takeshi Abe
Change-Id: Ic9ca0e9c1a63519026152f9aa1a038f183de1e4d Reviewed-on: https://gerrit.libreoffice.org/56581 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-02Move writesort() method from WriteDatabaseRange to free functionVikas
Change-Id: I732a0693aae92c5e654d1f8f414b7d6bd38b0562 Reviewed-on: https://gerrit.libreoffice.org/56662 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-01uitest interpreter: add more featuresSaurav Chirania
1) Support UNO commands 2) Support closing dialog using buttons 3) Correct keyword for modless dialog 4) Introduce "Redundant Couple" for couples from which only 1 statement can generate the log. Change-Id: I3541fea6a0b72de2c03626476b8abb43a7324dab Reviewed-on: https://gerrit.libreoffice.org/56776 Tested-by: Jenkins Reviewed-by: Saurav Chirania <saurav.chir@gmail.com>
2018-07-01cppcheck: variableScopeJochen Nitschke
Change-Id: Ic175a141cc6b6e98e66da7bc34ee77090236c9b6 Reviewed-on: https://gerrit.libreoffice.org/56767 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-01cppcheck: variableScopeJochen Nitschke
Change-Id: Ic6491da10fe4fdf46a7f6fac8e2ca6f32701a25f Reviewed-on: https://gerrit.libreoffice.org/56770 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-01cppcheck: variableScopeJochen Nitschke
Change-Id: I7c90978dba2e751303244785a38fe251bd955224 Reviewed-on: https://gerrit.libreoffice.org/56766 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-01cppcheck: variableScopeJochen Nitschke
Change-Id: I06fc0e6cba1e5754f9b801e55e27fcde4457eb72 Reviewed-on: https://gerrit.libreoffice.org/56768 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-30cppcheck: variableScopeJochen Nitschke
and use unique_ptr for vector elements Change-Id: I5421a53e96928699fd451d4ff3e2eef0bf847f42 Reviewed-on: https://gerrit.libreoffice.org/56772 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-30cppcheck: variableScopeJochen Nitschke
Change-Id: Icd99a9e6791840f7701745b93a0f414bf61e2955 Reviewed-on: https://gerrit.libreoffice.org/56773 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-30Reduce number of operations on OUStringMatteo Casalin
Change-Id: I5d65dd36981e6d75f0e3c0e3f00e1964d1249887
2018-06-30Use indexed getToken() and avoid getTokenCount()Matteo Casalin
Change-Id: I8807f8e7fd0fb76723bc4d46fa35cc346777051e
2018-06-30Avoid using getTokenCount() to get last token in a stringMatteo Casalin
Change-Id: I8e26d07c67fe10a55717a238563dd036b94fd381
2018-06-30Constify, fix whitespacesMatteo Casalin
Change-Id: Ief4c2e01fb855ce294ecf000dfb9b9e12982e441
2018-06-30Avoid using getTokenCount() to get last token in a stringMatteo Casalin
Change-Id: I6c36394f391850baf641268912e71ebaa3504b5d
2018-06-30Avoid using getTokenCount() to get last token in a stringMatteo Casalin
Change-Id: I1a2d181fdf03926452cb00f49490c9c4151dd8f9
2018-06-30Initialize local variableMatteo Casalin
Change-Id: I07583fe1fb70ffb7ec5cbeaacfdba207dac7eb0d
2018-06-30Avoid getTokenCount() + not empty OUString has at least 1 tokenMatteo Casalin
Change-Id: Ib8771f9621e050c100f2a319e354106bf316b24c
2018-06-30Copy INetURLObject object instead of constructing it twiceMatteo Casalin
Change-Id: Ib20f96fe63218aed4055bd0175ddc9e9c71e3fb3
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: Ia3c7657a89187ff21fca6d07c27ba260a0be36d8
2018-06-30Bail out early and reduce temporariesMatteo Casalin
Change-Id: I78e3d50f0bcbbb482ce79bbb1f14885e1e412569
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: If884a9eb09b55836995d04cd82832d3f79d6531c
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: Ia56f125151aa96d014e348b6d022b45138f732c9
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: Ia878affbdcb9674675619f34a423ac6c9a90b16d
2018-06-30Avoid getTokenCount()Matteo Casalin
Change-Id: I2a1b034ba6b587664ce94560e88af5acb860788d
2018-06-30Not empty OUString has at least one tokenMatteo Casalin
Change-Id: I02dd1c045af1367ae56eeb60dad23912111dcd6f
2018-06-30Avoid getTokenCountMatteo Casalin
Change-Id: I9bbfa1280857e3aaaac78402432001d4b48cd73a
generated by cgit (git 2.34.1) at 2025-02-07 23:57:38 +0000