summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-03sd menubar move xml to submenu like in writerandreas kainz
Change-Id: I867cfdf2b9927b749d866fc83327b6094f92164f Reviewed-on: https://gerrit.libreoffice.org/70204 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-03In LibreOffice core commit d4d3766, several variables were changedGreg Veldman
to be declared as const. However, on platforms not excluded by NO_PTHREAD_PRIORITY, osl_thread_priority_init_Impl() then tries later to assign values to these. This leads to compiler errors on platforms so affected, including FreeBSD. Revert as necessary on affected platforms, also using NO_PTHREAD_PRIORITY to match the code in osl_thread_priority_init_Impl(). Change-Id: I0e968231e7c1be9771844222a7bab1f0fcb51a0e Reviewed-on: https://gerrit.libreoffice.org/69603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03Fix in convertToOOXMLHoriOrient: values of VertOrient were takenPatrick Jaap
Change-Id: I47093292aeed5c0579dd4b365561ee86935632e4 Reviewed-on: https://gerrit.libreoffice.org/70197 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03various cleanups - no behavior changeTomaž Vajngerl
Change-Id: I28749d31ba272f26df9b79201cb106911692f6f7 Reviewed-on: https://gerrit.libreoffice.org/70199 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124155 fix slider for border and angle in gradient tab pageTomaž Vajngerl
This is the consequence of the previous change, where the sliders didn't respond to input when welded. Change-Id: Ifec7fd913435a6ec51b93872c7a40d6815807397 Reviewed-on: https://gerrit.libreoffice.org/70198 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03WinAPI: Fix some leftovers having UNICODE-define-dependencyMike Kaganski
Change-Id: I21b4df5b595c3814a5a3fb85d9da531729447b7e Reviewed-on: https://gerrit.libreoffice.org/70193 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-03tdf#114316 vcl opengl windows: fix missing context menu in full-screen modeMiklos Vajna
Full-screen mode on Windows used to work by measuring the space needed by window caption (title) and borders, then positioning and sizing the window in a way, so that the caption and borders are not visible. This approach breaks at least in the OpenGL case where a large enough negative position results in rendering errors. Fix the problem by explicitly requesting the window to have no caption, so we render less outside the screen (30 pixels -> 8 pixels in my case), which makes the "exit fullscreen" toolbar appear, also the context menu is visible. Change-Id: I6cf2b9774b505d3887b958a6a018b5ae84bbe4bc Reviewed-on: https://gerrit.libreoffice.org/70191 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-03Revert "add more append methods to *StringBuffer"Noel Grandin
This reverts commit 8cfa7f4dc00f3dd37e57917ef25c806b0e9e6e73. comment from sberg: we already have 70519a43e0d89a6b5d89859a6851f8c757c6b0c7 "Replace OUStringBuffer::appendCopy with append(std::u16string_view)" (which can be extended to OStringBuffer if needed) Change-Id: Ifcc550a8cf26ef38ad49fde8b067f53c999c9276 Reviewed-on: https://gerrit.libreoffice.org/70178 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03python3: upgrade to release 3.5.7Michael Stahl
Fixes CVE-2019-9636 CVE-2019-5010 CVE-2018-14647 Change-Id: If0a115960aed1ee90b63e6716c844669f0ec91e5 Reviewed-on: https://gerrit.libreoffice.org/70182 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-03Filter out problematic file URLsStephan Bergmann
Change-Id: I87fd37e56326bef4888354b923407530c6f70760 Reviewed-on: https://gerrit.libreoffice.org/70177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-03sc menubar change spacing from 3 to 2 as everywhere elseandreas kainz
Change-Id: Id395159b8b4a0f324cb188878fcbc76f73c0db36 Reviewed-on: https://gerrit.libreoffice.org/70180 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-03Support for native 32bit Bitmap in VCL and SVP (cairo) backendTomaž Vajngerl
This adds basic support for 32bit bitmaps for the SVP backend. For other backends the support is disabled for now as we need to add it for each backend separately and enable support. When this patch is applied it is possible to a Bitmap with bit count 32, but currently no input filter uses this with the exception of the new PngImageReader(libpng based), which is used only for the icons. For a general support more things need to be implemented and tested: - conversion back and fourth between 32-bit and 24-bit + 8bit alpha (or other supported pairs) - 'raw' export of the bitmap needs to be handeled properly (like in SVM import/export) so it creates the correct image. - input filters need to be checked and converted if this is necessary - look for possible bugs when drawing transparent bitmaps - check of UNO API Change-Id: I7a7be0e6134dfdd9a7aeaef897131bb6e710ae7e Reviewed-on: https://gerrit.libreoffice.org/69289 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124155 change "gradient tab page" - increment & angle sliderTomaž Vajngerl
Remove slider for increments as the increments should better be left to "auto" and rarely modified (setting a value means it will use a limitied amount of increments, but auto effectively means as much as it is needed and can use the native backend for drawing). OTOH use a slider for setting the "angle" as it is already present in hatch tab page. Angle needs a slider as it is usually one of the main properties of a gradient (especially linear). Increase the tab pages a bit (10px on every side) to have a bit of breating space for all the widgets. Change-Id: I66167fe2c97b53bc3627237279332bdd59fb03d7 Reviewed-on: https://gerrit.libreoffice.org/70175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124500: convert short path names from drag-n-drop to long namesMike Kaganski
... otherwise link URLs with short names like 2E23~1.PNG would be inaccessible from the network, or after copy to a different directory or system, where the autogenerated short name might be different. Change-Id: Ice0b2fa205a25aba232e960cad2615a527cba05a Reviewed-on: https://gerrit.libreoffice.org/70145 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-03Related: tdf#124148 null-deref on clicking inside empty listboxCaolán McNamara
since... commit ce9dab8c161e29769131cec741a6a9cceec8552d Date: Thu Mar 28 17:43:29 2019 +0900 tdf#124148 add configurable margin for the listbox pop-up list Change-Id: Id0bedb86f4fb74aff230d65f1e4371959814fd0f Reviewed-on: https://gerrit.libreoffice.org/70151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-03tdf#120270 : ScUndoDragDrop - Notifying listeners of the area...Dennis Francis
is not enough. This needs to be done recursively, ie notify the listeners, notify the listeners of the listeners and so on. ScDocument::BroadcastCells() seems to do exactly that, so lets use it here intead of collect+notify. Change-Id: Ifa273fea5f08af661958cd9b4c3d01d9044b8727 Reviewed-on: https://gerrit.libreoffice.org/70044 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-03add more append methods to *StringBufferNoel Grandin
which performs the append without needing the creation of a temporary *String Change-Id: If9ad3222275f26659db2e7df8d34f068977c4d17 Reviewed-on: https://gerrit.libreoffice.org/69826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-03find-unneeded-includes: filter out boost/variant.hppGabor Kelemen
As seen in include/sfx2/sidebar/Paint.hxx this replacement is not needed Change-Id: Idba8014a7effaec69c06891657cbd62546b7ac09 Reviewed-on: https://gerrit.libreoffice.org/70026 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-03pdfium: avoid problems with SetForm using WIN32_LEAN_AND_MEANMiklos Vajna
So that it does not get defined to SetFormA() or SetFormW() and still requires no patching. Change-Id: I4364b02306633733d8536ebd8d7d42273dfeef74 Reviewed-on: https://gerrit.libreoffice.org/70150 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-03Fix typosJens Carl
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I42090a462b15fbc537b0fdb5eaf66f60a213e5ff Reviewed-on: https://gerrit.libreoffice.org/70103 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: Ib4895ce8c0d56b89260ea71734687734298d7c92 Reviewed-on: https://gerrit.libreoffice.org/70168 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I7831896b8898f0cb20589fbd241b97fcc21db366 Reviewed-on: https://gerrit.libreoffice.org/70108 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I546735f427a47d9ada1589e1861d0cf696788b05 Reviewed-on: https://gerrit.libreoffice.org/70107 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I0e8f761768c7faf3da1d11d6fe02ee24e1180cf2 Reviewed-on: https://gerrit.libreoffice.org/70104 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I907b28c98133162a31835ebaeae6244dc8735752 Reviewed-on: https://gerrit.libreoffice.org/70106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Removed executable permission on data fileAndrea Gelmini
Change-Id: I1468140656a6a1d78d7753b69043c28660747a7e Reviewed-on: https://gerrit.libreoffice.org/70167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I794be89bed433e813feaecffce9464d087ddde61 Reviewed-on: https://gerrit.libreoffice.org/70105 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I8f5828e0e9887aaee928e4ff794bd21399fa5abc Reviewed-on: https://gerrit.libreoffice.org/70171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03Fix typoAndrea Gelmini
Change-Id: I54ab0fd193e0a133a49462f456fb2fe120494bee Reviewed-on: https://gerrit.libreoffice.org/70170 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Fix typoAndrea Gelmini
Change-Id: Id1a9ca4952e52df2ca48b81d80c24f62d451a811 Reviewed-on: https://gerrit.libreoffice.org/70169 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Remove now obsolete _TableRow interface testsJens Carl
Remove obsolete _TableRow.java file, missed it with commit cc9a8c13dad6f3d82a2386554bd6113b486a1752. Change-Id: I900ae9368d145dbe95b144323459ba05e38f6766 Reviewed-on: https://gerrit.libreoffice.org/70165 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03Add XServiceInfo tests to ScTableRowObjJens Carl
Change-Id: Ia3ad25e5e401abd3b27687a951a8c00fe710e57f Reviewed-on: https://gerrit.libreoffice.org/70164 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03tdf#45904 Move TableRow Java tests to C++Jens Carl
Move TableRow Java tests to C++ for ScTableRowObj. Change-Id: I72cd8006b8ad932bab56681de9aac66fb40542fe Reviewed-on: https://gerrit.libreoffice.org/70159 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableRowObj. Change-Id: Ib448d6440cd6a285cd55297669bb19bd8aec6b07 Reviewed-on: https://gerrit.libreoffice.org/70156 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02Introduce next Japanese gengou era 'Reiwa'Takeshi Abe
starting from 2019-05-01, which has been announced officially. This fills the provisional slot acknowledged at cacbb0faef77ae8462de9ff5c7307a6a2e28b2bb. Change-Id: Ifb12e6afaad4c66d455f664b46ec946e80324e87 Reviewed-on: https://gerrit.libreoffice.org/70028 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-02tdf#121103 ANOVA sum of squares formula correctionJaromir Wysoglad
The ANOVA sum of squares is now hardcoded to use '$Sheet?' in the source cell addless every time. Change-Id: I215b719be11ecfc2ae20c5df8e86876bc22d50f0 Reviewed-on: https://gerrit.libreoffice.org/69899 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-04-02obsolete .ui suppressionsCaolán McNamara
Change-Id: Icb873895cadb7cfd039e6cf0f9b23f52555c7941 Reviewed-on: https://gerrit.libreoffice.org/70147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#124272 use ClipRegion's geometry if not a rectangleArmin Le Grand
By error the ClipRegion's geometry was replaced by it's BoundRect expanded to PixelBounds. If the ClipRegion is not a rectangle, this will create wrong results. To do both - extend to PixelBounds and have the original geometry included - use the PolyPolygon topology as needed (see comment in code for details) Change-Id: If3f75223144eba8eb23909a7c701ad544346099b Reviewed-on: https://gerrit.libreoffice.org/70146 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-02Add a few SAL_INFOsTor Lillqvist
Change-Id: Ibdb013f4eeee8a2b2e29e3adb56943b5fccf9772
2019-04-02Implement the FullName property correctly in the Automation caseTor Lillqvist
Return a complete pathname. For or internal Basic, keep the existing semantics, that for some reason returns just the filename. Change-Id: I897cc797ca2158ca7c798f3e8adcdfa57a41ee3b
2019-04-02Sifr icon theme update last missing lc_ iconsandreas kainz
Change-Id: I004883067cc8ac747db2263654203dd777bcab7d Reviewed-on: https://gerrit.libreoffice.org/70148 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-02Warn when getFileURLFromSystemPath() fails, not when it succeedsTor Lillqvist
Also, display the name that the call failed for in the warning message. Change-Id: I0b6b7baca1d534b5bada5286b2b0e5b8e94f1832
2019-04-02Resolves: tdf#124485 [none] is at index 0Caolán McNamara
rather than the meaning of nothing-selected which is -1 Change-Id: I3be01fa8d6b57f61aa660be5912f479e79cff2b2 Reviewed-on: https://gerrit.libreoffice.org/70142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02limit URLBox growthCaolán McNamara
Change-Id: Icea856be18aeaf07379be25eaeab240fe263bb52 Reviewed-on: https://gerrit.libreoffice.org/70140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02find-unneeded-includes: use a better data structureGabor Kelemen
Turns out plain dictionary requires keys to be unique. So we need to store values as lists. This way there are no more false positives for <set> as in include/sfx2/linkmgr.hxx and include/sfx2/objsh.hxx Thanks Miklos for the advice! Change-Id: Ie2cfb63644d6cbd51171eb95e3bcdd9246343efa Reviewed-on: https://gerrit.libreoffice.org/69953 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-02State the name of the log file that contains an errorStephan Bergmann
...to make it easier to debug a failing build Change-Id: Ic936a6e6026db4208f58e19fb27e2c2d6e4adfec Reviewed-on: https://gerrit.libreoffice.org/70138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#124266 : Paint cell if formula-cell has changed even if...Dennis Francis
not dirty. Change-Id: Id54811009079438945bb162dd3eb8705ce174781 Reviewed-on: https://gerrit.libreoffice.org/70043 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>