summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-22Fix typoAndrea Gelmini
Change-Id: I996d18f76a04f822712687755b0ad51aa287d354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144713 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-22Fix typoAndrea Gelmini
Change-Id: I50fc85e0ae8d75275fd1746c5e4aebe7e186cac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144035 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-22loplugin:unocast (xmlsecurity::Certificate)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I3d9bd77093d2e6376717d27f105e72ff5a919fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22tdf#152535 Provide better localization for "Grand" subtotal stringsRafael Lima
As discussed in the bug report, having the word "Grand" hardcoded first in subtotals is not great for translation, since for some languages the translation of "grand" would come second. This patch creates separate strings for each case of Grand, f.i. "Grand Count", "Grand Sum" and so on. Now each of them will have their own translation. Change-Id: Ib875bc1a7b2fcc8934ad85bfe09374f8d9d9a179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144666 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-22loplugin:unocast (sd::Annotation)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: Id600e83ae94409914b20a2a2620031ce340a9390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22loplugin:unocast (sd::TextApiObject)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) The odd implementation of TextApiObject::getImplementation had been effectively like that ever since the code's introduction in 5d431414afa79d392fe6a885940c559236c25aa2 "CWS-TOOLING: integrate CWS impressnotes01", for no obvious reason. And as it can be reduced to a single comphelper::getFromUnoTunnel call, drop the function and directly call that at the (single) call site. Change-Id: If50a81cf8bee0dddbdfb5e6b5516c24a03e858e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22loplugin:unocast (SignatureVerifierImpl)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I3c2f1eae3d9b2b5ecb6a05c9e7149946b63bb11f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22loplugin:unocast (pcr::PropertyEventTranslation)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I0800465df08a8caa4d48e205f181d3eb35611dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-22check for null pointerAndras Timar
Change-Id: I106b3de160ea70520aa98ad48d5f1005de6c6be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144700 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-12-22Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 08d0004b7aa823bedc51c521919faf0d82fe24f2 - update translations for 7.5.0 rc1 and force-fix errors using pocheck Change-Id: If01e073a30643a65862a5a7ec1b304448654566f
2022-12-21cid#1517814 Calling risky functionCaolán McNamara
Change-Id: I0451ac0375ad5a29a5bf65ebcc028ae44c43d934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21cid#1517812 Dereference null return valueCaolán McNamara
Change-Id: Ia9cf34f03a18e499f83e495c0f3714b7476c3973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144687 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21tdf#152029 Headings can also use BringTypesWithFlowFramesToAttentionJim Raykowski
Change-Id: If4c094471bda4e01151680dc1f356eefa48aa4f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144689 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-12-21ofz#54461 Null-dereferenceCaolán McNamara
seen since: commit 96a856f87f16cca2e039c973c18d57c8b9dca362 Date: Fri Dec 16 13:20:25 2022 +0100 tdf#152206 DOCX import: fix mixed first footnote Note: tdf#152506 is the correct issue identifier. Change-Id: I6e66db1a6a87cfce444346f193a418880750e03c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144692 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21sync with latest additions to d2dpixelprocessor2dCaolán McNamara
commit 7d948d5c7edbbfd29a77b97a5101aa43917e5ec2 Date: Tue Dec 20 18:42:42 2022 +0100 SDPR: Add handling/direct rendering of some simple Primitives Change-Id: If5432ac02f51f4b9194ec5df347f93e11f58959b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21tdf#152617 Fix color of controls in the Dialog EditorRafael Lima
While editing dialogs in the Basic IDE the background of controls as labels, radio buttons and checkboxes is wrong. They're black in dark themes and white in light themes. The correct color should be FaceColor to make it have the same backround as the window. Change-Id: If436b0034dd7a665fc779e0df793703562adb5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144363 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-21initial Experimental System-Dependent PrimitiveRenderer for CairoCaolán McNamara
just some partial pieces export TEST_SYSTEM_PRIMITIVE_RENDERER=1 and the simple drawing shapes work Change-Id: I3e01501a1cb21ec86d6fe8f5637a23e7358ffc86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21qa: hint about tolerance in namesXisco Fauli
As suggested by Mike in https://gerrit.libreoffice.org/c/core/+/144171 Change-Id: I653118985b781ebb1eed71587ae19efe45e1c800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144691 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21sw, field insert: handle the Content param for refmarks and accept HTML thereMiklos Vajna
Creating a bookmark just to refer to it is a bit hacky, refmarks are the proper solution to that. But while .uno:InsertBookmark allows specifying custom HTML for the content of the created bookmark, there is no matching UNO command that would do the same for refmarks. Fix the problem by extending .uno:InsertField: - add a TypeName parameter, so TypeName=SetRef can be used in macros, which is more readable than Type=12 - handle the previously ignored Content parameter when creating a refmark and accept HTML there to allow rich formatting Note that unlike bookmarks, refmarks are text attributes in a text node, so in case multi-paragraph HTML would be provided, the created refmark will only cover the content till the end of the first paragraph. Also not that unlike fieldmarks and bookmarks, a refmark can only represent a reference, not a bibliography, we'll need sections for that. Change-Id: I4d95f0a6e5618f1b611f7431e9189a63ee75d349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144646 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-21tdf#152606: sd_export_tests: Add unittestXisco Fauli
Change-Id: Ib34a5d312228570b05a84884189f7bd0b45af522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144650 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to bd369936bec0c2cc1934026a09e4ceb361b7de7f - update Slovenian files for change in ulf structure see https://gerrit.libreoffice.org/c/core/+/144672 for details Change-Id: Ic59e538acd2736b7c7ea81a4936ff9cd27e2d882 - update translations for 7.5.0 rc1 / master and force-fix errors using pocheck Change-Id: I374cdb4f45e7f52d049acd45bbcd728dbf9b6d9a
2022-12-21tdf#140215 Simplify the handling of .ulf filesIlmari Lauhakangas
Now the headings in the ulf files for .desktop files are in the form [filename_Key] Gallery names are also adjusted to fit the new scheme, where there is no longer a need to pass a --key argument to desktop-translate.py Sync comments with .desktop files and the remaining .ulf and remove obsolete Mandriva Linux meta data while at it. Script to mass-replace relevant names in translations will be provided to infra. Change-Id: I87e8028aa5b66f5f5560efa62ddd9b1e5b61c49c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138455 Tested-by: Jenkins Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-21cid#1517813 Uninitialized scalar fieldCaolán McNamara
Change-Id: I119e6af448d80cf47dfe3f5bd7983ebf57221790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21oox: fix crash in oox::drawingml::Transform2DContext::onCreateContextXisco Fauli
Similar to 68a259f5af8757923be8a226631f38366fe8e37b "tdf#152606: fix crash when opening specific pptx" See https://crashreport.libreoffice.org/stats/signature/oox::drawingml::Transform2DContext::onCreateContext(long,oox::AttributeList%20const%20&) Change-Id: Iac769edadb72590d8aef1ea3fc3845fce7a0bd86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144648 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-21sc: fix null deref in ScInputHandler::InputChangedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/EditView::ShowCursor(bool,bool,bool) and https://crashreport.libreoffice.org/stats/signature/EditEngine::GetText(LineEnd) Change-Id: Ib1486161c722c213ccc64809010f54e9ab4dc52e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144684 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21Use ScCellRangesBase's existing XUnoTunnelStephan Bergmann
Change-Id: I1323a0aad06118397f39eec0f42494491df93f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Use ScModelObj's existing XUnoTunnelStephan Bergmann
Change-Id: I2f0a6bbc5fe382a64d0a32ba955a28f44dad388c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144681 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Use ScNameRangeObj's existing XUnoTunnelStephan Bergmann
Change-Id: I968484d9c140dd9407732c07b2bbc042f0342725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Resolves: tdf#152593 reuse Line Style preview code for Line Width previewCaolán McNamara
Change-Id: I842b3bfaeb63978377ebb3edaef4dfd94ec296a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21tdf#152598 Add more assets into .ico filesgaljit
Added 24x24 and 48x48 images into the .ico files Change-Id: I1a35428805643dc8d08ab36d3430769f143c75fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144677 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2022-12-21tdf#152378 a11y: Don't trigger check for empty highlighted textofftkp
Do not trigger accessibility check test for empty highlighted text Also added an empty line in the test document to check that it's no longer detected after this patch Change-Id: I173a61fc25c0ea4cf81642a7ea37a762b3b583f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143673 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-12-21loplugin:unocast (RangePageBreaks)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I16297c96e60d76a15b59aedc4e88164bb782c61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144652 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21iloplugin:unocast (pcr::OFormattedNumericControl)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) (Making the base class pcr::CommonBehaviourControl TControlInterface template parameter variadic required swapping it with the other TControlWindow template parameter.) Change-Id: Iadc9dc7eb8fbe882b63b5db49d8a39ae5c4c05c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21tdf#152612 Add Duplicate page item to Pagepane context menuRoman Kuznetsov
Change-Id: I49a889202c5a291b0da9eb970b838b657af2313a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144596 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-21tdf#90641 - Insert bibliography dialog: sort entries by identifierAndreas Heinisch
Change-Id: I77210c1dff237deeb93df0102cd96685cb36d4f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144645 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-12-21tdf#146875 sw: move also at-frame flys off SwPageFrameMichael Stahl
The bugdoc contains an at-frame anchored fly on page 77, which is anchored to an at-page anchored fly. While layouting page 74, the fly is moved to page 77, and the content on page 74 invalidated. Unexpectedly, calling RegisterAtPage on a SwFlyLayFrame does absolutely nothing, as it calls the base class SwFlyFrame, so the fly stays on page 74. Thus, page 74 never actually becomes valid, and later pages are never layouted. (regression from commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf) Change-Id: I4fcbed4daf83f9e554de5a877a40b2c2419c0f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144631 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-21tdf#152029 follow up: Handle content that extends to following pagesJim Raykowski
Brings section and table content to attention in the document view that extend to following pages. Previously only the frame area on the page these content types begin is brought to attention. Change-Id: Ia023e85cc7c14e0c50a0a0f9765a17fb207a95da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-21tdf#151548 sw ContentControls: use ResetAttrs with undo.Justin Luth
My initial commit adding SwTextContentControls::Delete didn't put it into the undo stack. But this slightly obscure ResetAttrs function can take this one argument and do the same thing, but with undo. make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testModernVBADelete Change-Id: Ibfcb278186b17aa3c3d9f1970e55ceb0ec00ddc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144238 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-21vcl: /Filter [/FlatDecode] not properly readDennis Francis
Change-Id: I156e153ae1a123cf9cf54eb23e6d3abe8962f677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit f5ad4f9dfac27d5675fa5c397f66b8cc45cc31a1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144435 Tested-by: Jenkins
2022-12-21vcl: read references to /Kids array...Dennis Francis
if the argument of /Kids is not an array. Conflicts: vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: Ib73962d3a27aa7e1ce5ddbe6845a1dd73bd7a343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143559 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 10185a6aec5d3b74a51e4b9474645e12bf794df8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144434 Tested-by: Jenkins
2022-12-21tdf#152606: fix crash when opening specific pptxJulien Nabet
bt here: https://bugs.documentfoundation.org/attachment.cgi?id=184264 Related with 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 tdf#149551 separate TextRotateAngle from TextPreRotateAngle Change-Id: Idab19bee37c7a6fe1dc3818b6ff111389d290e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144588 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-21CppunitTest_sw_uiwriter2: simplify testRTLparaStyle_LocaleArabicMiklos Vajna
Use comphelper::ScopeGuard the avoid the need for a separate preTest(). Change-Id: I89cb89f86baf5da1671b05ddb368335d0b3d2ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144628 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-21No need for bool return value hereNoel Grandin
all of the implementations of this method return true. Change-Id: I6dc02499af1809110edd482a48d9f6d5d42ead19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-21loplugin:unocast (frm::OInterfaceContainer)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: Ie8f6fbe25dfffc082033a4bc967d738143746506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144635 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Use rtl::Reference to avoid some dynamic_castsStephan Bergmann
(And some of those dynamic_casts could apparently never evaluate to null, and the corresponding checks have thus been dropped as being redundant.) Change-Id: I351d1c9f2894c5a88429ce3c7495f12145664743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144636 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21loplugin:unocast (ScVbaShapes)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I913565ccd93472f2a8893c4251e80d0309827c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144633 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21loplugin:unocast (ScVbaShapeRange)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I4a66df07f2e768ee3203b730b50be4b9ec6a01a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144634 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21tdf#151548: second cleanup "Add basic word::XFormField support" etc.Justin Luth
Change-Id: I0647f29aa23959cbf9809cd745473e7b048901eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143079 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-20SDPR: Add handling/direct rendering of some simple PrimitivesArmin Le Grand (allotropia)
(SDPR == SystemDependentPrimitiveRenderer) Make D2DPixelProcessor2D directly render the added simple Primitives LineRectanglePrimitive2D FilledRectanglePrimitive2D SingleLinePrimitive2D to use less ressources & get faster since no conversion to Polygons is done. These are Primitives that *may* be handled directly, but do not have to - I checked that the decomposes do work before adding direct handling. Change-Id: Ifa97c595c262d84a9889f92571b2c9909bcef0e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144626 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-12-20sw: ODF import: fix assert in SwTable::ConvertSubtableBox()Michael Stahl
Assert in swnewtable.cxx:2179 fires: For ooo98643-1.odt the conversion is not possible, the default for row height is "variable" which wasn't handled. For ooo27428-1.sxw the conversion is possible so remove the assert; the sum of the inner row fixed height is just smaller than the outer row's but unsurprisingly the subtables is layouted such that the last row gets the extra space, same as the conversion does. (regression from commit 4757dfc2a520f63fba0b27cc161fe732231dbd0e) Change-Id: I2635179f350c8b5b84016dc82625b73364df92a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144622 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>