summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-10Enable QR and barcode dialog for onlineDarshan-upadhyay1110
- enable QR and barcode genration dialog for online - Change Qr code genration dialog to async Change-Id: Ia46b8e27a3002adcc893e5ef4c2545d7edcc3e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156642 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 6ed38adb5578d0b52d11d8f2077e345f9a8c7ade) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10lok: set help root URLAndras Timar
Change-Id: Id4089027f095daebb69942eb3315d516cfb14779 (cherry picked from commit 2239e4c1b2dcf06650316a106e5bd883ceefb6c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10jsdialog: hide help and close buttons for searchreplace dialogPedro Pinto Silva
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I0f3bc2cd6839c74dff40431f8659d7f90b285d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149293 (cherry picked from commit c65142fd9fd9a43e1f27cb11f5b4048600b5a4c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10gtk3 a11y: Drop unnecessary check before loopingMichael Weghorn
If `nTextMarkupCount` is <= 0 here, the loop condition isn't met, so the body is never entered anyway, so no need to check this explicitly. Drop the extra nesting level. (Use `git show -w` to ignore whitespace change.) Change-Id: Ib472da039d7b0a02ae3206b350c3feb6d42b914b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157759 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-10tdf#157182 vcl,filter: PDF/A export: fix crash due to SE ID mismatchMichael Stahl
The SE IDs in PDFExtOutDevData and PDFWriterImpl are supposed to match. If PDF/A-1 is exported then RemoveTransparenciesFromMetaFile() is called and that does unspeakable things to the Metafile and then we just throw away the PDF related data for the page in PDFExtOutDevData::ResetSyncData(). This means that then EnsureStructureElement are called on PDFExtOutDevData but not on PDFWriterImpl, so on the next page the IDs will no longer match, which is noticed if there is no transparency to be removed on that page. pdfextoutdevdata.cxx:347: bool vcl::PageSyncData::PlaySyncPageAct(): Assertion `id == -1 || id == mParaInts.front()' failed. Guess the easiest way to deal with this is to have the premature ResetSyncData() replay only the EnsureStructureElement actions, which is only possible because they don't really require any extra data stored in the ridiculous vectors in PageSyncData; PDFWriterImpl will eventually remove the elements as they are never initialised. (regression from commit 07d790ca473cd6e71f0343419b819fa6b485dc01) Change-Id: I8eb295504067edff00608e28fd86b0c86d547083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157748 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-10Remove exec bits on .doc fileAndrea Gelmini
Change-Id: Ia5cf772cab86869a46c5a8f610fe43d170545516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157760 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 415f52ad94adf6df48604304e4e038c1e58bcb79 - Fix grammar Change-Id: I07a30b1b3df454fce1144587176b3612d9bde474 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157724 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-10tdf#107786: sw_ww8: Add test for null pointer dereferenceOmkarAcharekar
Change-Id: I54bd01ce3b0007abe9adb58c0b17195e38e8ceaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157742 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-10Make some methods const, and avoid some const_castsMike Kaganski
Change-Id: I4964abd34836438e3d24ee7c3c3b324f356477b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157746 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-10Drop repeated codeMike Kaganski
Change-Id: I0bbbaaf7c24851beca78d4ed024ffc44609e0093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157719 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-10sw: SwTbxAutoTextCtrl should sort groups by titleMichael Stahl
Change-Id: I2134492fd681393da6f4fc29aec95117145e8e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157735 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-10lok: fix getting SID_DOC_READONLY slot propertyHenry Castro
Unfortunately, the property is not always set when import XLSX documents. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If501734704174b92b3589b61a019ba973592c331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157736 Tested-by: Jenkins
2023-10-10tdf#157571 sw floattable: fix incorrect blank space after table-in-shapeMiklos Vajna
Regression from a4af5432753408c4eea8a8d56c2f48202160c5fe (tdf#120262 sw floattable, legacy: fix text wrap around fly when no content fits, 2023-07-17), the bugdoc has a shape which contains a table, and lots of empty paragraphs next to it wrap around the shape. Writer didn't wrap these empty paragraphs, so some of the page 1 content was shifted to page 2. What happened here is that in case there is a really small space for the wrapping text around a floating object, then Word has some minimal limit. If the available horizontal space is smaller than the limit, we don't even try to wrap, even if the content (an empty paragraph) would fit. It was assumed that this limit is the shape for normal anchored objects and floating tables, but the two bugdocs show that there are two different limits here. Fix the problem by going back to MINLAY as the default limit where we start wrapping, and only increase that to TEXT_MIN_SMALL when wrapping around floating tables. That fixes the bugdoc and keeps the older floating table use-case working as well. This also allows reverting changes to testParaUpperMarginFlyIntersect, to assert the non-floating-table case again. Change-Id: I8f8a776c6ad5bdfa0ee4f197b600463fef6431f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157743 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-10Silence a new -Werror,-Wdeprecated-declarations for nowStephan Bergmann
Change-Id: I5b457a4e1b9804b53a72d53a49ca9695424fc0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157708 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-10CppunitTest_sw_ooxmlexport4: rework to avoid preTest()Miklos Vajna
ImportComboBoxAsDropDown is on by default, so all we need is to turn it off at a single place + restore it at the test case end. Change-Id: I399aa60e5bf89817baa226de090625fd89fbbac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157734 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-10tdf#156980 SwNavigator: Make headings delete even if they haveJim Raykowski
folded outline content Change-Id: If952d8d845c2eeec86231014b924f1632d2f5efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157667 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 97c4b5ce17d662c498faa38c23074a645e21649b - tdf#155875 UI cmds Writer/Help in Help(52) + refactoring + Grid menu - final Change-Id: I0a237e1e8a6019a9b1cc65db2eebcb8f33ff1072 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157739 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3644717d42d7fa24a61af95a6b51643665d879d1 - tdf#155875 UI cmds Writer/Help in Help(51) + refactoring + Edit menu - final Change-Id: Ibf65e70f1edfa2733800eaa9e69ca9789abb0b2c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157738 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-09Add -rpath when building analyzer executable on macOSStephan Bergmann
...as at least with LLVM 18 trunk, the generated executable references @rpath/libclang-cpp.dylib but didn't actually contain an LC_RPATH Change-Id: Ida643903aa4566853ea9541553f0dfc9c3243d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09Avoid a false loplugin:casttovoid on macOSStephan Bergmann
...involving conditional preprocessed code at > vcl/skia/SkiaHelper.cxx:265:13: error: unnecessary cast to void [loplugin:casttovoid] > 265 | (void)blockDisable; > | ^~~~~~~~~~~~~~~~~~ > vcl/skia/SkiaHelper.cxx:286:22: note: first consumption is here [loplugin:casttovoid] > 286 | if (!blockDisable && !DefaultMTLDeviceIsSupported()) > | ^~~~~~~~~~~~ Change-Id: I222d72d240852be2d64fe08d345f00d137cd5a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157707 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09loplugin:casttovoidStephan Bergmann
Change-Id: Ifa6c18651b2e3faa4500f19217bf11dba10f02fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157709 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09bump odt2pdffuzzer max_len againCaolán McNamara
Change-Id: I2fcd448d4efef924d088bfc9470ae800dbd78504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157737 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-09tdf#157650 Unhelpful error when XML in content.xml is malformedNoel Grandin
regression from commit d9e322d60f65ff20631dab87baa5a2c7c71daaa2 replace ErrorInfo with simpler mechanism we need to tunnel the necessary information through the uui stuff, so add a new Exception class to do that. Change-Id: Ie1fde486e8637b802340795348a5e5aad6a54e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-09lok: add getter function to read "ReadOnly" flagHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id9d2bc638d0f48cb33764b07fb8976b97117a621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156621 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157733 Tested-by: Jenkins
2023-10-09tdf#157502 and tdf#157652 invert alpha maskPatrick Luby
Due to the switch from transparency to alpha in commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, invert the alpha mask. Change-Id: Ib6df3523be36ba5d5aaf3887557d4a6a8fa6098c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-09sfx2: invoke handler "LoadReadOnlyRequest"Henry Castro
It will ask the user if open the Excel documents "read only" Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I909fb39709198e02496f8c522f477c077fb875e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156624 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157730 Tested-by: Jenkins
2023-10-09vcl: render scaled fonts for LOKPranam Lashkari
problem: In online calc when fonts are not scaled, text box disappears when not active Change-Id: I9c8fdb3c0d14a3e7ed502ddb2b46c0769a855280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153624 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 6460c685c3bc3f4929263c7681080056b59948fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153654 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2023-10-09tdf#142524 Search Commands: use ▸ to indicate sequenceIlmari Lauhakangas
Change-Id: I2a3a7c4db03dbfe53f2b71de7ee9b3df42a22866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157689 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-09lok: implement "handleLoadReadOnlyRequest"Henry Castro
Is used for interaction handle to query user decision regarding to open the document read only. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ia945eae7b1627d57d6211ae92a784d50313c2627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156623 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157703 Tested-by: Jenkins
2023-10-09Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a99fef353cedd72e5b96e2115d4d621d3d513d09 - Fix error in index Change-Id: I703300156a250cb1c7f940c0ad0101d305e74d9d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157628 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-09tdf#100034 tdf#157318 XLSX export: fix lost named ranges associated to sheetsRafael Lima
The original fix for tdf#100034 (see commit [1]) consisted of explicitly not exporting to XLSX named ranges that are not built-in. This has a side-effect that user-defined named ranges associated with sheets are also not exported to XLSX. Hence, if the user creates a named range linked to a sheet and saves the file to XLSX, the named range is not exported (which is the issue reported in tdf#157318). This patch implements a new fix for tdf#100034, reverting the previous fix. When the Print Ranges are cleared by the user, the associated named ranges are also cleared, thus fixing the original problem. This new fix has the advantage that user-defined named ranges linked to sheets are again exported to XLSX files. Regression from commit 639519dc2bad058197b6ff73c9e3df622f979f97 "tdf#100034: Fix to persistently remove print-range". References: [1] 639519dc2bad058197b6ff73c9e3df622f979f97 Change-Id: Ic3b84365a6086e96f60b222cd6337991ac90f483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157455 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-10-09Hyperlink dialog: hide some buttons in LOKSzymon Kłos
Change-Id: I55a4ca5921b44a7c091a3742a85f2c9da5a188a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156760 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Attila Szűcs <attila.szucs@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157672 Tested-by: Jenkins
2023-10-09tdf#49253, tdf#157635, tdf#157576: sd_png_export: Add unittestXisco Fauli
Change-Id: I59b869c84381e2904edbc399b3d1598896e1dd29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157699 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-09uui: implement "handleLoadReadOnlyRequest"Henry Castro
Is used for interaction handle to query user decision regarding to open the document read only. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ia6792ca540b5c62f4c9de8a5793ef45de3740484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156622 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157660 Tested-by: Jenkins
2023-10-09cid#1545413 drop PerMessageDeflateExtensionCaolán McNamara
Change-Id: Iac5133ebddf026037af22e0f22fead658348b108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-09cid#1547102 Uninitialized pointer fieldCaolán McNamara
Change-Id: Id713220c13df8b557b637d305da158abc5d5421f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-09tdf#157575 Clarify labels content in Security Options dialogGabor Kelemen
Change-Id: Iba2fdf3a74bc50ddd9e7a6727a446acfb40a4bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157564 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-10-09tdf#157588 Clarify meaning of High macro security levelGabor Kelemen
Change-Id: I4647ebdba45e2598b993d7aeb06111f069a0eba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157556 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-10-09crashtesting: fix PDF export of fdo45193-1.docxMiklos Vajna
This started with commit 1d3d2a995239c3c71432006cb795324c56a0412a (tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxes, 2022-06-20), the trouble is that once anchored objects are inserted to the anchored object list of a layout frame, the list has to be re-sorted if something that influences the sort key changes. Normally the way to do this is similar to commit 0a6a151c4b7c78a363fb64598fbda39db4f42d07 (Related: tdf#70062 keep drawing anchor objects sorted, 2015-02-11), but here the problematic call is SetFormatAttr(SwFormatAnchor(...)) in SwTextBoxHelper::changeAnchor(), and we don't have a layout by the time that happens, so using UpdateObjInSortedList() is not something we can do. In any case looks like no proper fix is coming for this soon, so at least fix it up so we don't try to do binary search on a vector that's not yet sorted. This also seems to help 3 other documents from crashtesting, and also the tdf#157571 bugdoc (related to sw floattable), which is why I started looking at this in the first place. Change-Id: I9b532a39f6c28604304fa9bbecf9faf9842739a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157691 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-09svx: prefix members of SdrHdlLineMiklos Vajna
See tdf#94879 for motivation. Change-Id: I08a0368a6e262982419b3866defd6a181675af0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157690 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-09tdf#157633 a11y: Drop a11y description in Word Count dialogMichael Weghorn
Drop the accessible description for the Word Count dialog since, as pointed out on the a11 mailing list [1], having that whole text read out each time by the screen reader isn't really the desired behavior. For dialogs, NVDA on Windows only reads the a11y description and not the dialog content if the a11y description is set (s. [2]). In case of this dialog, there's also no way to have the text read out by moving focus (there are only 2 buttons at the bottom of the dialog), but only by having the whole dialog read out by pressing a screenreader-specific keyboard shortcut, in which case NVDA would announce the description of the dialog again first of all, before announcing the actual content. There's a help button right in the dialog that can be used to get the same information easily, so drop the a11y description. This also implies that this text is no longer shown as tooltip on mouse hover when extended tips are enabled in the settings, since that feature makes use of the a11y description. [1] https://listarchives.libreoffice.org/global/accessibility/msg01055.html [2] https://github.com/nvaccess/nvda/blob/a380b6a76a0a29df32e57c1bd974b11a895ac0c8/source/NVDAObjects/behaviors.py#L151-L156 Change-Id: I9d4ceb20534fd87a8c1a3fa3ad5848bf0f4a0f29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157638 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-08make testCondFormatFormulaListenerXLSX reliableCaolán McNamara
Change-Id: Ibd8c9b7831af73967229c578b9dcf7217d800610 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157686 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-08ofz#62236 avoid TimeoutCaolán McNamara
Change-Id: Ic7207ece03a30d8ffefadbf072d4da5fa66dfc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-08Drop temporary aliases from Tuple2D and Tuple3DMike Kaganski
Change-Id: I091b68bbeee74452a3d6a03711cfc482b7a78e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157685 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-08Fix buildMike Kaganski
See e.g. https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/148996/consoleFull#699387013baec2b5c-2b20-4190-a3fa-ceac4be9cf93 > error: use a _ustr user-defined string literal instead of constructing an instance > of 'rtl::OUString' from a UTF-16 string literal [loplugin:ostr] Change-Id: Ia813425bc75e4351add73b8665355d02222ccf78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157629 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-08Simplify a bitMike Kaganski
Change-Id: Icfa6d5bdc3c1a9e13f7e29d36a4a873a5c6bb05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157684 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-08tdf#156040 pick a better "LightColor" for windows dark themeCaolán McNamara
in the absence of a better idea, do like StyleSettings::Set3DColors does Change-Id: I9868d4eb94fb221fcbf5e3a4e4761fb2bd8888fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-08SfxRequest doesn't need to inherit from SfxHintCaolán McNamara
or anything Change-Id: Ibfedb7dce6503b5593111380c53fc0ef6c7e93af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-08cid#1547086 Logically dead codeCaolán McNamara
since: commit 757a73379dba01fde853443a09583d862c404531 Date: Fri Oct 6 09:31:28 2023 +0100 Related: cool#7373 add an SfxHintId::ThisIsAnSfxEventHint luckily this is the only use of SfxHintId::NONE so easy to audit Change-Id: Id593eb3b2c2d26c9552aa7bf6033afd4f3112120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-07loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literalsStephan Bergmann
This is a first cut at rewriting uses of OUString constructed from u"..." as u"..."_ustr. It covers the same changes as <https://gerrit.libreoffice.org/c/core/+/155412/6/> "WIP: Delete OUString UTF-16 string literal ctor/assignment op", but does so with automatic rewriting (see e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 "loplugin:ostr: automatic rewrite", plus a handful of 002b0a9d5793e07609f953b9961b04bcab7a7e3f "loplugin:ostr: manual modifications" where automatic rewriting wasn't set up to handle macro bodies). The compilation-time impact of all those changes appears to be negligible: For some Windows build of mine, just touching the files that would be affected by 002b0a9d5793e07609f953b9961b04bcab7a7e3f and e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 (but without actually applying those changes yet) and doing `time /opt/lo/bin/make -O check screenshot PKGFORMAT= gb_SUPPRESS_TESTS=x`, three times in a row reported sample real times of 21m15.438s 23m17.840s 23m41.529s and repeating all that with the two changes actually applied reported sample real times of 22m43.547s 21m42.687s 23m1.813s The plugin itself is already prepared to do further rewrites (see the TODOs), which will be done in follow-up commits. Change-Id: I408ecf056dce1b9da683d7c377b8d9058df1558d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157676 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-08 16:19:10 +0000