summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-09cache these tarballs for oss-fuzz build tooCaolán McNamara
Change-Id: I97b4c6996886037f1b042d77ba9dc61c2ebc765a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139712 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09writerfilter: avoid divide by zeroXisco Fauli
in DomainMapperTableManager::endOfRowAction() See https://crashreport.libreoffice.org/stats/signature/writerfilter::dmapper::DomainMapperTableManager::endOfRowAction() Probably since 116cadb5d2582532c69677a2f8499e8e9b7b9b80 "tdf#59274 DOCX import: fix tables with incomplete grid" Change-Id: I12f2842107885fbbc62be2186511102f642e3efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139717 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09ofz: Undefined-shiftCaolán McNamara
Change-Id: Ida81135280ff61c3a8e96e8f5ed977959e169f61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09ofz#51149 avoid TimeoutCaolán McNamara
Change-Id: I7709e69154d231e597d364210bc876afca3df4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09rearrange to have a single ConvertTable callCaolán McNamara
Change-Id: Ic48ebac04d6e95df8748f38b1f23a8295fba77b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139718 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09Allow to pass LIBCPP_DEBUG into configureStephan Bergmann
...(e.g., by setting it in autogen.input). I need that with some of my Clang builds until the issue discussed in the mail thread <https://discourse.llvm.org/t/pack-expansion-bug/64910> "Pack expansion bug?" is sorted out. (Make sure to even allow passing in an empty > LIBCPP_DEBUG= even though it turned out I needed a non-empty > LIBCPP_DEBUG=-D_LIBCPP_ENABLE_ASSERTIONS=0 in my case.) Change-Id: I353ab535568ebd5add93485c219fe2a06fde0565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-09Update git submodulesMiklos Vajna
* Update helpcontent2 from branch 'master' to 18621b8577dda9415f471809c53db623059f8b51 - Add initial help for the sw contentcontroldlg This dialog always has a single checkbox, but the 3 other frames are only visible for certain content control types, document what they are. Change-Id: Id54ac041b0e038c1205036eac40562616777c22f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-09tdf#150876 sw: track new rows inserted after a tracked row insertionLászló Németh
New row insertions after an already tracked row insertion weren't tracked. Regression from commit b251228d2e5e2832e0a617213173e8841f5b7428 "tdf#150666 sw: allow to delete tracked table row insertions" Follow-up to commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9 "tdf#143358 sw: track insertion of empty table rows". Change-Id: Ic365e70aa7808237a1bd69d0101a098ae70e8813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139594 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-09-09tdf#148214 RTF import: avoid fake paragraph for \page when possibleMiklos Vajna
The bugdoc has 2 pages, an explicit page break between them and the first page has enough content that an additional fake paragraph at the end would lead to a 3rd, unwanted page. The fake paragraph was introduced in commit 7b58fc3dafc789aa55fff5ffef6ab83c3aa8b6e0 (fdo#48104 fix RTF import of \page in inner groups, 2012-04-02), because dmapper ignores more than 1 page breaks in a paragraph. Fix the problem by only inserting the fake paragraph in case the "page break before" paragraph property would have no effect (very first paragraph in the document) or we already sent characters (para props are lazy-sent on the first character). This keeps existing cases working, but avoids the unwanted fake paragraph in the bugdoc. I suspect the root cause is that dmapper doesn't handle multiple page breaks in a paragraph -- once that's fixed, this parBreak() call can be completely removed. Adjusted tests: - testImportHeaderFooter: this asserted the presence of fake paragraphs, which are now gone in the easy case, so this change is an improvement - testTdf133437: no visual difference before/after, probably the test intent was just "make sure this page has several shapes", the exact number isn't that interesting Change-Id: Idd2b8a70b4122eb08d9d305018d384dc0bbb276a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139704 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-09Simplify by using replaceAll in a loop (winaccessibility/AccTextBase)Julien Nabet
Change-Id: I68c895033d26c81c76e680d2042aac941d56d213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139707 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-09tdf#150604 related: Label Navigator context menu delete entryJim Raykowski
specific to the content entry type Change-Id: I44ff745d8e61bcf24fee351cfa4148ae3ad31dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139628 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-08vcl: Drop CmapResult indirectionKhaled Hosny
Change-Id: I3b1beb5e976a255ef8ecdf8670b1e59547ec5ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139700 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08Fix location of ScDocShell in commentJulien Nabet
Change-Id: I316d967427b6b86d3a2dbea46f535405f2966a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139705 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08tdf#150845 fix crash in writer Form->TextObjectNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject Change-Id: I66370566562a1275c21c24523a505704508d3d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139703 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08Fix CppunitTest_sw_core_layout on non-default DPIMike Kaganski
Change-Id: I84f21b165628577ad680c98b0f28ac6956328833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139699 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08tdf#150846: vcl_pdfexport: Add unittestXisco Fauli
Change-Id: I16a7326a0164e319cf97b1a34849a3134232364d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139646 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-08Fix CppunitTest_sw_ooxmlexport15 on non-default DPIMike Kaganski
Change-Id: Iba28b332e3f9b5c03a94f563bee9c5ecdf96a61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139692 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Simplify by using replace instead of replaceAt in loop in connectivity (3)Julien Nabet
Change-Id: If7517356959d4720bbe07acea822ec835a681a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139456 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08Simplify by using replace instead of replaceAt in loop in connectivity (4)Julien Nabet
Change-Id: Iab92f1ee2be1e5b9ab3fa005890acfe9acbf3732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139460 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08Simplify by using replace instead of replaceAt in loop in connectivity (2)Julien Nabet
Change-Id: I9bbe005f0bd1399b9c43cebe0e4c58d3ec88087c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139455 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08Fix CppunitTest_vcl_pdfexport on non-default DPIMike Kaganski
Change-Id: I6cfeed3059246d01e56b1b55c8c85f89256c7340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139698 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08DOCX import: avoid duplicated bookmarks in copied header/footer textMiklos Vajna
In case a DOCX document has 2 sections and the 2nd section has a linked header, writerfilter/ copies the header text from the 1st page style to the 2nd page style. This leads to duplicated bookmarks in the doc model, which causes an unexpected increase in bookmark count on export. This went wrong with 8885bdf2f564bb7b56181c50baf39ff99d551ec9 (tdf#128106 sw: copy bookmarks at start if whole node is copied, 2021-08-27), previously at least bookmarks at the start of the header were not duplicated, though that was also inconsistent, since other bookmarks were still duplicated. Interestingly the DOC import doesn't have this problem, because it first copies header text and only later imports the bookmarks. Fix the problem by introducing a new SwCopyFlags::SkipBookmarks flag, add UNO API to set this from writerfilter/ code and skip copying bookmarks (but not other marks) in sw::CopyBookmarks() accordingly. Copying other marks is still needed, because e.g. fieldmarks have a mark and a field, and it would be inconsistent to copy the field, but not the mark. Note that the text is still duplicated in header/footer, linked header/footer is a missing feature on the Writer side. Change-Id: I40e18f231ef2c0d91ae9582621684ef5b6284904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139697 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-08tdf#150808: vcl_graphic_test: Add unittestXisco Fauli
Change-Id: Icc0f323606d5702abe03e1537e42fbd78dc6b297 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139651 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-08Fix CppunitTest_sd_export_tests-ooxml3 on non-default DPIMike Kaganski
Change-Id: Iaf9a36c63f2bca9b065b2370e88c5e86c5f06888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139677 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Fix CppunitTest_sd_png_export_tests on non-default DPIMike Kaganski
Change-Id: Id969646a82b9a408fff111c794a6096d8e857db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139678 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08vcl: Drop now unused ParseCMAP()Khaled Hosny
Change-Id: I2140b7b48ee4cc46a4a6e8e4719f3ce78a600829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139624 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Get FontCharMap from HarfBuzzKhaled Hosny
Implement PhysicalFontFace::GetFontCharMap() on top hb_face_collect_unicodes() so that it is the same charmap as what shaping code will actually use. Change-Id: I486e9d296cec5bd897e4f628d14a2f19e63b70b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139623 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Pass FontCharMap to OpenTTFont*() when possibleKhaled Hosny
Avoids parsing “cmap” table again to get it. Change-Id: I19eb882efd8c8aaaeb2fa770405ef2d69d985104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139622 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08vcl: Sort fonts in workben/listfontsKhaled Hosny
I only need a stable font order, so I can compare the output across invocations. Change-Id: I8141fd0425cdb638b0bf4bb4faa1889200bf8578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139621 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-08Fix CppunitTest_sc_subsequent_filters_test2 on non-default DPIMike Kaganski
Change-Id: I940c3213dda02a73924a9f8dc6500d7ecc38ba6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139674 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Fix CppunitTest_sc_jumbosheets_test on non-default DPIMike Kaganski
Change-Id: I067622274cfa7518462ad74015dc3942f35b6b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Clean up some #includesStephan Bergmann
...after 9e7e95a57b7c16941d9fdc59f806c1f9e4263379 "tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro" (and somewhat pedantically use the canonical <iterator> for std::size, even though the existing <vector> defines it, too) Change-Id: Iacf0a0619b496bfe7c6abb0a812b6a1b3eed40c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-08loplugin:unusedmethodsNoel Grandin
Change-Id: I94861f9fa8d8a5d22a89c902984ad2afed43dc14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08loplugin:unusedfieldsNoel Grandin
Change-Id: I104015dd9339fca3b274532ba475a66c7b01481d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I4461ca826960b194cf45ae4917093f3273b3b0a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08loplugin:virtualdeadNoel Grandin
Change-Id: Iceb6916bcc8c211a72fccfa4bbcbb22c96a72050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08fix comments in xcuNoel Grandin
that I introduced with commit d156e891db34e88991a6c18fd3cff6feddfc61c8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Sep 6 10:30:42 2022 +0200 tdf#150682 - bad shortcut in french langage Change-Id: Ibfb2613222456d6446cb81db948d6eb9c7be190f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08replace egrep/fgrep calls with grep -E/grep -FRene Engelhard
as egrep/fgrep is deprecated since long amd grep 3.8+ now actually warns (e.g. "egrep: warning: egrep is obsolescent; using grep -E") Change-Id: I5b10f05dffdd09081deb05cef974e3cdb2907315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139614 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-09-08Fix CppunitTest_chart2_import on non-default DPIMike Kaganski
It is really unfortunate that so much of our code depends on the DPI, that should not. Change-Id: Id1916677add508171490591a234f07a82a8e3f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139648 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Rework of SoftEdgePrimitive2DArmin Le Grand (allotropia)
This is pretty much the same for SoftEdgePrimitive2D as the change for GlowPrimitive2D, so for more comments please refer to commit c2d1458723c66c2fd717a112f89f773226adc841 Added suggested change of DoSaveForVisualControl mechanism Change-Id: I28901e7a0b6e1823000d2aa6a335ce2fd80e6ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139585 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-08Turn a macro into a functionMike Kaganski
Change-Id: I7c98ae858f345389b63c4b429367612f7fb3691a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Related: tdf#150786 workaround unit test failureMike Kaganski
The test detects a different problem, so this issue is unrelated to the detection. Indeed, after this issue is fixed, the test could be restored to test it all, complementing the test coverage. Change-Id: Ie3c8621d76bf1ccb58ffbdde875a7adb7bceb76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139639 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-08Fix typoAndrea Gelmini
Change-Id: I0dc42449baa4bed54aa1fdd60c1b62d4a9cb358e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139647 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-08CppunitTest_sw_uiwriter8: use more SwParaPortion::dumpAsXml()Miklos Vajna
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1 (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing, 2022-04-07) for motivation. Change-Id: Ib1fb52e1677f343999878bc288ef0cb346d665a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-08tdf#150770: sd_import_tests2: Add unittestXisco Fauli
Change-Id: I4bd5f934abb62a161a2002697d68e1bda72e697e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139634 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-08tdf#150756 Assertion when opening report for editingNoel Grandin
regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject Change-Id: Icfdf74035658a6d8222059bb6db36c852a51c4de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139632 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08sw: add an initial uitest for SwContentControlDlgMiklos Vajna
And also test the inner SwContentControlListItemDlg. Change-Id: Ida92223f49871900f8f6692f21d5052cdb04dd2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139633 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-08tdf#150832: Revert "tdf#150034 very slow opening pathological chart"Xisco Fauli
This reverts commit 613f6e75fbfcc024fc9c3732261cbf2cda6f4ad8. Reason for revert: it seems all charts in XLS files are affected. At least I could reproduce it with all the XLS files I tested it with. Change-Id: I68d13d6f609521ce6af759cf25249656176b66cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-08Revert "tdf#150569 Modify hardcoded dates to extend the range of accepted dates"Juan C. Sanz
This reverts commit b20594f2fc8f6f9fdbf0b257b4e74d95a8d90139. Reason for revert: Further testing has shown some errors in other ways of displaying the data Change-Id: Ic4909f8571c8730ab3ba622c7fad99f2646616ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-08sw: fix crash in SwViewShellImp::AddPendingLOKInvalidation()Miklos Vajna
Fatal signal received: SIGSEGV code: 1 for address: 0x0 program/libswlo.so SwViewShellImp::AddPendingLOKInvalidation(SwRect const&) sw/source/core/view/viewimp.cxx:167 program/libswlo.so Notify(SwFlyFrame*, SwPageFrame*, SwRect const&, SwRect const*) sw/source/core/layout/frmtool.cxx:3299 program/libswlo.so SwFlyNotify::~SwFlyNotify() sw/inc/anchoredobject.hxx:204 program/libswlo.so SwFlyFreeFrame::MakeAll(OutputDevice*) sw/source/core/layout/flylay.cxx:141 (discriminator 3) Change-Id: I01a64c6e0c2ad4c72cf1a9edeca2aa22e08441b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139629 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins