summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-15only need an OutputDevice not a full vcl:WindowCaolán McNamara
Change-Id: I79e0a5877a531cd1b0badf3adcc721254ad441d9 Reviewed-on: https://gerrit.libreoffice.org/80820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Bin a fairly pointless unconditional NSLog() callTor Lillqvist
Change-Id: I7c1910c3e1bf345966ec289aaf5f9c9b6cbabc22
2019-10-15Can use pointer to const hereStephan Bergmann
Change-Id: I1960e0a460ec4eae4f8d4da526aad8db863087af Reviewed-on: https://gerrit.libreoffice.org/80813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15tdf#128096: only use CharBackColor for highlight if exporting to pptxXisco Fauli
Just in case, making sure highlight in docx export works as before Change-Id: Ied42da1c5f286b80fc754a06357960e8334a765f Reviewed-on: https://gerrit.libreoffice.org/80780 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-10-15Resolves: tdf#128137 cursor jumping during edit, etc.Caolán McNamara
The mbNeedUpdate hackery to block changes caused by the user was subverted by the async handling of the treeview selection. a) add a call to wait and process outstanding async events within the protected block b) move the needupdate down to the range manager to block updates during this block in CheckForFormulaString too c) when updating the visible rows, also update the selected rows even if they are not visible. Change-Id: I4c67d6cd2780f55d5eab5f856f6fda21703b4977 Reviewed-on: https://gerrit.libreoffice.org/80794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Resolves: tdf#128140 stabilize formula dialog widthCaolán McNamara
Change-Id: Ifdb80adfd4b399035ed793f8636f31b90cf50094 Reviewed-on: https://gerrit.libreoffice.org/80800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15move HAVE_FEATURE_DESKTOP/OPENCL to their dedicated headersLuboš Luňák
HAVE_FEATURE_OPENCL is included by a common Calc header and HAVE_FEATURE_DESKTOP is included by a common Writer header, causing pretty much their full rebuilds if any feature changes. Change-Id: If29bf78bd4fd70b37981e0826a577777fd255c89 Reviewed-on: https://gerrit.libreoffice.org/80776 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-15tdf#127964 PPTX import: fix shape fill handling: style vs slide backgroundMiklos Vajna
Regression from commit 943a534ac7cb3df513583e226c986dafd8ba246b (tdf#123684 PPTX import: fix wrong background color for <p:sp useBgFill="1">, 2019-04-23), the problem was that we didn't handle the case when a shape had an XML fragment like this: <p:sp useBgFill="1"> <p:style> <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> </p:style> </p:sp> i.e. the shape both wants to use background fill and it has a style declaring how to fill it as well. We gave the style a priority, while PowerPoint gives the background fill a priority. Fix the problem by not setting the fill from the style in case the background fill is already set. Change-Id: Ie1b56e5615219138a5b7ddd7a2b25295b991bc05 Reviewed-on: https://gerrit.libreoffice.org/80804 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-15Replace getDefaultValue by getColExprForDefaultSettingVal (postgresql)Julien Nabet
Change-Id: I8e0eea84a711ce45d991c07d7811094e33bcce38 Reviewed-on: https://gerrit.libreoffice.org/80787 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-15Add option to prevent graphic swap outSamuel Mehrbrodt
Change-Id: Icbfc21b219cd4ba582e798e5deda6ef7c81a2009 Reviewed-on: https://gerrit.libreoffice.org/80773 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-14Fix method name origin in SAL_WARN_IF(vcl/quartz/salgdi)Julien Nabet
Change-Id: I7fff6af5e521318324df63b32d4be7b0e0f12771 Reviewed-on: https://gerrit.libreoffice.org/80803 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-14lok: impress: show only supported transitions in the side paneMarco Cecchetti
Change-Id: I631ee8b101bacc4dec075100aa25158b71fbae40 Reviewed-on: https://gerrit.libreoffice.org/80681 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-14use common PCH for more librariesLuboš Luňák
Change-Id: I53164be413426691025a63cfba731cf5f9d1b7f8 Reviewed-on: https://gerrit.libreoffice.org/80790 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14fix incorrect gb_DISABLE_PCH_REUSE testLuboš Luňák
Change-Id: Ife41ea7ad19c03b8dca6afe8b15d0f3b752b533b Reviewed-on: https://gerrit.libreoffice.org/80789 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14remove -bigobj usage from sw rtf unittestsLuboš Luňák
They all have been split since the time the flag was added, and they seem to be small enough again. And this prevents a PCH CXXFLAGS mismatch when using the common PCH. Change-Id: If51d3969e11bb37777d49fe877671c1313721588 Reviewed-on: https://gerrit.libreoffice.org/80793 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14filter out cl.exe printing source file name also when not using depsLuboš Luňák
This is what filter-showIncludes.awk does as a side-effect, so this is for the --disable-dependency-tracking case. Change-Id: I0fd58ff4e343c6322e9cba641acd5fa2bf3816f4 Reviewed-on: https://gerrit.libreoffice.org/80731 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - More work on Xapian result page Added module dropdown fix TODO: Language Change-Id: I47012d6280694d87fb5d19e25c6052b8a7ed89c7 Reviewed-on: https://gerrit.libreoffice.org/80771 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-14tdf#128139: add missing nullptr checkMike Kaganski
Regression after ef2ec07b4113fdadf863352c832af657b5ae205c Change-Id: I5eed95e8136a812813145283e6b533a808324380 Reviewed-on: https://gerrit.libreoffice.org/80782 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14Resolves: tdf#128134 page creation order affecting travelCaolán McNamara
the page is created before the page is moved to, so CanTravel gets locked. Only lock when the page is the current page Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1 Reviewed-on: https://gerrit.libreoffice.org/80779 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl()Michael Stahl
The code looked wrong previously, always assigning the end of the text node regardless of direction, but it turns out the improvement caused an infinite loop... let's just swap things after the loop, seems simpler than adding another if at the assignments. (regression from 4caef398af256be5f0c2a159129b528ee3702e5c) Change-Id: I098f5265fa86d6a2511a80a02230899a7a303a88 Reviewed-on: https://gerrit.libreoffice.org/80774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for master and force-fix errors using pocheck Change-Id: I69677c891cfbd2e5d91880a7020dbe4165cb8ac4
2019-10-14jsdialogs: send units for numeric fieldsSzymon Kłos
Change-Id: I63b984856926a613e38319d6d769cab64601c504 Reviewed-on: https://gerrit.libreoffice.org/80692 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-14Fix misuse of OStringLiteralStephan Bergmann
...(which got introduced with 9b5dad13b56bdde7c40970351af3da3a2c3c9350 "loplugin:stringadd look for unnecessary temporaries", and had reportedly broken CppunitTest_sc_ucalc on tml's Windows build by hitting the "strlen( str ) == N - 1" assert at include/rtl/string.hxx:1867), by introducing rtl::OStringView (and rtl::OUStringView, for consistency). Change-Id: I766b600274302ded66a6bffc91be189b20ed1ac3 Reviewed-on: https://gerrit.libreoffice.org/80778 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-14SvxLanguageComboBox is unusedCaolán McNamara
Change-Id: I8f5fc0a80e84dc4aa79f7488591fb4904e5f5338 Reviewed-on: https://gerrit.libreoffice.org/80763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14New loplugin:getstrStephan Bergmann
...to find matches of ... << s.getStr() (for the rtl string classes) that can be written as just ... << s Some notes: * The OUStringToOString(..., RTL_TEXTENCODING_UTF8) is left explicit in desktop/source/app/crashreport.cxx (even though that would also be done internally by the "<< OUString" operator) to clarify that these values are written out as UTF-8 (and not as what that operator << happens to use, which just also happens to be UTF-8). * OUSTRING_TO_CSTR (include/oox/helper/helper.hxx) is no longer used now. * Just don't bother to use osl_getThreadTextEncoding() in the SAL_WARN in lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx. * The toUtf8() in the SAL_DEBUG in pyuno/source/module/pyuno_module.cxx can just go, too. Change-Id: I4602f0379ef816bff310f1e51b57c56b7e3f0136 Reviewed-on: https://gerrit.libreoffice.org/80762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-14assert fires after help hides find & replace dialogCaolán McNamara
Change-Id: I72db53711322de9420fdb097ac60dda35f1ec5d8 Reviewed-on: https://gerrit.libreoffice.org/80769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Use default initialization instead of memset hereMike Kaganski
Change-Id: I6f4164e9c7a28e1f9d18fd6fc69dad8c48b53d9a Reviewed-on: https://gerrit.libreoffice.org/80754 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14tdf#94117: try gswin64c if gswin32c failedMike Kaganski
Change-Id: I3c29ef72525aa25ee8606122f01b7b611ecb2091 Reviewed-on: https://gerrit.libreoffice.org/80748 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14Resolves: tdf#128132 language page not openedCaolán McNamara
Change-Id: I1936840b89963ddc74fa8d7509855fb566e62404 Reviewed-on: https://gerrit.libreoffice.org/80761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Related: tdf#124729 check for GL_EXT_texture_filter_anisotropic supportCaolán McNamara
Change-Id: I7cc7225c02e1c6688df22b237af59425fb64b79c Reviewed-on: https://gerrit.libreoffice.org/80760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14gtk3atk: Make sure returned values are initializedSamuel Thibault
This is the same as 8a086a97299c ("atk: Make sure returned values are initialized"), but for gtk3atk. -1 is the now-document value to be used in this case, see https://gitlab.gnome.org/GNOME/atk/merge_requests/22 Change-Id: I3cf5f78cc1db603445edfeec1bebcb2e1e48e9ed Reviewed-on: https://gerrit.libreoffice.org/80737 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14tdf#128076: throw exception only if it's not alive and it's not a descriptionXisco Fauli
According to a comment from https://gerrit.libreoffice.org/#/c/74533/ okay... then i guess there are different kinds of callers: those who actually want to check if its a descriptor, and those who want to check that it isn't "live" so check if it's a description even if it's not alive Change-Id: I1526fdbcb006506cc67d29cbe3f65138f90843dc Reviewed-on: https://gerrit.libreoffice.org/80677 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14fix names of enumsCaolán McNamara
as per... https://docs.microsoft.com/en-us/typography/opentype/spec/cmap encoding id 3 is PRC and 4 is Big5. We are already using RTL_TEXTENCODING_GB_2312 for 3 and RTL_TEXTENCODING_BIG5 for 4 so this just changes the names of the enum but no logic change Change-Id: Ie375cdc9c704641af21a3313128f4e97a5166ca5 Reviewed-on: https://gerrit.libreoffice.org/80755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Comment out a lambda capture that isn't used, to avoid compiler warningTor Lillqvist
(The use of it is also commented out.) Change-Id: Ie015a8cbd0f7a982721a389487c2134a1aba8ed1
2019-10-14add PCHs for more external libsLuboš Luňák
I think this is all external libs where it makes sense for them to have their own PCH and be worth it. Maybe some smaller externals can also use the common system PCH, but unfortunately many externals use all kinds of defines that affect system headers, which is a problem for the common system PCH. Change-Id: I2c589ac55d93728daf3b158df110722e5f055d45 Reviewed-on: https://gerrit.libreoffice.org/80728 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14sw: deleteFieldmarkAt() should just call getFieldmarkAt()Michael Stahl
dynamic_cast isn't a performance problem here. Change-Id: I7d90025051a428588479bb1431dd8bac292f5c49 Reviewed-on: https://gerrit.libreoffice.org/80672 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14configure: remove sanitizer flags from default COMPILER_PLUGINS_CXXMichael Stahl
When COMPILER_PLUGINS_CXX is default initialised from $CXX, filter out sanitizer flags, because: a) linking fails with unresolved symbols currently b) typically the slowdown is unhelpful in a build c) if anybody wants a sanitized plugin they can set COMPILER_PLUGINS_CXX manually (init from CXX was added in ad5cbcf6ba0afdc1d8d7405c2641cce8de4a360b) Change-Id: I64dc48fae5f7a23f87b0eee0545add9a1ebd5672 Reviewed-on: https://gerrit.libreoffice.org/80655 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14sw: prefix members of SwUndoInsertLabelMiklos Vajna
See tdf#94879 for motivation. Change-Id: I9d0b4ee6fc6794dc4b2e94e23c6dd83465c1191b Reviewed-on: https://gerrit.libreoffice.org/80751 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-14Related: tdf#124729 avoid GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENTCaolán McNamara
for 0 width or height Change-Id: I1452d0e6c5470d855cae96308e689e87e1d582d5 Reviewed-on: https://gerrit.libreoffice.org/80746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Related: tdf#124729 check error status before continuingCaolán McNamara
Change-Id: Ic39e569121b2646995b8dec50c3941db65fdd500 Reviewed-on: https://gerrit.libreoffice.org/80745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14Fix numbering of font tables in sft.hxx (vcl)Julien Nabet
Following kern table removal done with e3caecb5a33288dd46a80b2ffcc47a2288305052 Change-Id: Ifb42f5dc85e25faf9f1a94db7179b981abb150df Reviewed-on: https://gerrit.libreoffice.org/80742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14Add document-level option to lock down content extractionSamuel Mehrbrodt
Setting this option will prevent copying/dragging any content from LO to another program or even another LO window. Change-Id: Ifbc032a4fa69ac1a17d4b500f5a30f5399d84ed7 Reviewed-on: https://gerrit.libreoffice.org/80586 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-14tdf#125191: Disable Undo during pptx saveMike Kaganski
Change-Id: I07fe6895cc2ba43dfa1716e67bdbb4e697e3420c Reviewed-on: https://gerrit.libreoffice.org/80727 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-13Replace "static const" by "constexpr" in sft.hxx (vcl)Julien Nabet
Change-Id: I7ee86442cf822a2e866f379a98dae901f5291b8f Reviewed-on: https://gerrit.libreoffice.org/80741 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-13tdf#128096: pptx: export highlightXisco Fauli
Change-Id: If3084f7ffaceb774dba1b1f195229313a8f1d04a Reviewed-on: https://gerrit.libreoffice.org/80670 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-13Refactor + fix TrueTypeTableNew_post + some reading types for sft/ttcr (vcl)Julien Nabet
Move const in sft.hxx and replace define by static const Also, fix some errors with data formats + TrueTypeTableNew_post definition Following https://docs.microsoft.com/en-us/typography/opentype/spec/otff: Fixed = 32-bit signed fixed-point number (16.16) FWORD = int16 UFWORD = uint16 Change-Id: I8c460e517b9f25077f5ad81a6da656695c8e6fa1 Reviewed-on: https://gerrit.libreoffice.org/80733 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-13tdf#128111: "adsrc" doesn't exist from Postgresql 12Julien Nabet
Before Postgresql 8.0, there was only "adsrc" then it's been deprecated "The adsrc field is historical, and is best not used, because it does not track outside changes that might affect the representation of the default value. Reverse-compiling the adbin field (with pg_get_expr for example) is a better way to display the default value " and finally it's been removed with version 12 See evolution with: - https://www.postgresql.org/docs/8/catalog-pg-attrdef.html - https://www.postgresql.org/docs/11/catalog-pg-attrdef.html - https://www.postgresql.org/docs/12/catalog-pg-attrdef.html Change-Id: I57e9da423a23b5a96bbb64b0e026b160e9643ab9 Reviewed-on: https://gerrit.libreoffice.org/80722 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-10-13move ToolBoxButtonSize into vclenumCaolán McNamara
Change-Id: I684d192296642bc507a6f75dd52a5ce72b028157 Reviewed-on: https://gerrit.libreoffice.org/80721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13drop some unnecessary includesCaolán McNamara
Change-Id: I07693dd5199a1fcc08c7ba25bd986d9da76958b3 Reviewed-on: https://gerrit.libreoffice.org/80720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-15 09:16:30 +0000