Age | Commit message (Collapse) | Author |
|
Just because some sections are unprotected doesn't mean that
the document should not open in forms mode. MSWord 2016
opens it in "forms view" mode which also doesn't allow
editing those unrestricted settings. Only when choosing
the "Edit Document" view are the unprotected sections
editable - similar to LO turning off the Compatibility:
Protect Forms flag.
Unfortunately, the "I want to address this" comment
was from 2011, so obviously his temporarly solution
became more permanent that expected.
If this patch now blocks someone from being able to edit a
document (because now only the forms components of the
document are editable) they can remove the forms protection
by going to tools - options - LibreOffice Writer -
compatability - and disable Protect Form.
patch developed to support tdf#120499 and depends on the
patch for tdf#37778.
Change-Id: I86e26095ade6b2cf0ab8ea8fc941a92fa672a2f7
Reviewed-on: https://gerrit.libreoffice.org/61901
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
This reverts commit 3f9c477929c261a8862411c00153e4c7d0d0ae7c.
Breaks the JunitTest_sc_unoapi tests with clang
|
|
Change-Id: Iee8cbf1d3be4f205c975d5100a8b3f2506653e26
Reviewed-on: https://gerrit.libreoffice.org/61954
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e7
Reviewed-on: https://gerrit.libreoffice.org/61937
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I96f56cee0cab3fa18992281e3745164377adade3
Reviewed-on: https://gerrit.libreoffice.org/61939
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
|
|
...to avoid -Werror,-Wshadow from Clang trunk with
<https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators",
warning about shadowing of userSpaceOnUse in enum SvgUnits in
svgio/inc/svgtools.hxx
Change-Id: Ie1438e6ad0f73c73ad643157e5f8366a6e3f6851
Reviewed-on: https://gerrit.libreoffice.org/61933
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
NB: sync MenuImage in tabbed toolbar
context menu: sync graphic.xml context menu
in writer, calc, impress and draw
Change-Id: Idab90ae9af7ac68815fe689811d6c11f948063ca
Reviewed-on: https://gerrit.libreoffice.org/61938
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Iee6c83ae03ead7ae0b2c33f6cf364c1c3c59528f
Reviewed-on: https://gerrit.libreoffice.org/61892
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I67b8cecdc85ad77d7ab48d229459a79bc168072d
Reviewed-on: https://gerrit.libreoffice.org/61721
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I18ef6cb58632898ddfcb28098b99447565bcfb99
Reviewed-on: https://gerrit.libreoffice.org/61720
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
put (so far) no-op UNO ifaces in place
Change-Id: I95394cfe05b8e3db21ddce6dfed1c1bb1d0e6381
Reviewed-on: https://gerrit.libreoffice.org/61385
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
SendFeedbackURL, QA_URL, DocumentationURL, GetInvolvedURL,
DonationURL added to global variables under Menus
Change-Id: Ie95ef2795d4079edd204edb1fcd86fde4376cedf
Reviewed-on: https://gerrit.libreoffice.org/61874
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: I666805e38c40826328d8c4226c394d4c3072b2a7
|
|
This way at least something shows up in the import result. Far from
perfect, though.
Change-Id: Iae5a073d458598e7b5059ebdf435d50ce7c7df80
Reviewed-on: https://gerrit.libreoffice.org/61925
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
It passed "make check" on Linux
Change-Id: I20e2ecce45ead161a3f95b511416044af4e04290
Reviewed-on: https://gerrit.libreoffice.org/61917
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1e3b000b1fa5c439768eef135433fbf810309bbd
Reviewed-on: https://gerrit.libreoffice.org/61930
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ifa4c540b83fd9c6841b6b57890fb5db5266d82ad
Reviewed-on: https://gerrit.libreoffice.org/61908
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ice5bb1db9f4bec803121c160a1f74c0d24551b40
Reviewed-on: https://gerrit.libreoffice.org/61929
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3aae53844f839ff54fab85ab4649c0bf0691e6de
Reviewed-on: https://gerrit.libreoffice.org/61927
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ifc4c9a4631e92eee4b7f9b215c41d2bcc12a17d1
Reviewed-on: https://gerrit.libreoffice.org/61926
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib12455751074bbd818cc2da0c813fe984d887571
Reviewed-on: https://gerrit.libreoffice.org/61920
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9885881bfc6baffe1184d52c207d8f5d81a4a3b4
Reviewed-on: https://gerrit.libreoffice.org/61919
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4177bfd48b6af1cfc526e5ff43f00f1405ea647f
Reviewed-on: https://gerrit.libreoffice.org/61911
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Only video files were handled before. .wav files had
wrong mime type in [Content Types].xml, used videoFile
tag in slide1.xml, and incorrect type in rel file.
Change-Id: I92bded52eb9f366103a10334c6a92fda9648076e
Reviewed-on: https://gerrit.libreoffice.org/61885
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Based on implementation, explain the definition of logical
advancements for RTL and LTR case and remove incorrect part.
Logical advancements are distances to the edge instead of
widths of characters, so summing all do not yield the
total.
Change-Id: I437f490e5025c2124238e8cad506a966d7bc792c
Reviewed-on: https://gerrit.libreoffice.org/61461
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
since it is being used as a bool. Also rename it to something more
readable
Change-Id: I89acc47251770c94fa321b742b0fb9327024055f
Reviewed-on: https://gerrit.libreoffice.org/61909
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Tested-by: Jenkins
|
|
Change-Id: I0a319624656eb1305522ebd4ae3ff63d5106db3b
Reviewed-on: https://gerrit.libreoffice.org/61910
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...to avoid -Werror,-Wshadow from Clang trunk with
<https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators",
warning about shadowing of BORDER_TOP/LEFT/BOTTOM/RIGHT in enum BorderPosition
in writerfilter/source/dmapper/PropertyMap.hxx.
Also, BorderPosition can apparently be made a private member of BorderHandler,
which gives extra confidence that any other uses of BORDER_TOP/LEFT/BOTTOM/RIGHT
across writerfilter/source/dmapper/ indeed meant to reference the other enum
BorderPosition.
And change BorderHandler::lcl_sprm to return early in default case, to avoid
having to come up with some new BorderPosition sentinel value to represent
"invalid pos".
Change-Id: I31e535326627cec25a17b99485bf7cf56f4c66d3
Reviewed-on: https://gerrit.libreoffice.org/61896
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I41e3548c98e0fbe86a9a736c66b4cf6d746d84c7
Reviewed-on: https://gerrit.libreoffice.org/61757
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
|
|
Change-Id: I0b2f1ca5386510e3a8217cf3bb3e08a940f438f7
Signed-off-by: Mert Tumer <merttumer@outlook.com>
Reviewed-on: https://gerrit.libreoffice.org/61788
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I05a189dcee9cf4415ce59771da03c08cf0fef6c4
Signed-off-by: Mert Tumer <merttumer@outlook.com>
Reviewed-on: https://gerrit.libreoffice.org/60727
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
None of the other QueryValue throw; in case of a problem they return
false without initialising the Any.
On the one hand, it would be useful to throw an exception for this
special property that has now become Write-Only, so that API users
get a better hint what is going wrong; on the other hand, it breaks
various other things like the various multi-property interfaces that
call QueryValue for multiple items (there are 3 such loops in
SwAccessibleParagraph alone).
(throw was introduced in 7a8ed362eb163ac15a000ba1cfc74b58315800a1)
It turns out there is even a test for the exception on ToX.
Change-Id: Id60ff43544f7399ce869227bfd6fb933dbaea3be
Reviewed-on: https://gerrit.libreoffice.org/61719
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I2a0b7e70db0d244627a462a5da5de7eeba8db940
Reviewed-on: https://gerrit.libreoffice.org/61907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id49f4d039f0eb7c4efccecda91bd656c1c31d497
Reviewed-on: https://gerrit.libreoffice.org/60784
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
* Update helpcontent2 from branch 'master'
- update help ids
Change-Id: I475516915714d6d05e3ccb65b2309241da9ff4ea
|
|
Change-Id: I9f1d66e9af454a27a341e56bbe50a558898b65a1
Reviewed-on: https://gerrit.libreoffice.org/61900
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0344e3c408f07f97caa34a87ce9e1559b6a76892
Reviewed-on: https://gerrit.libreoffice.org/61889
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7ac171654ec0a5095c05d1b54bec423b8eb9247b
Reviewed-on: https://gerrit.libreoffice.org/61888
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64
Reviewed-on: https://gerrit.libreoffice.org/61902
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id62a894b08e6221c858304d7cb198a5a3f0cbd43
Reviewed-on: https://gerrit.libreoffice.org/61893
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Protection is not related to fReadOnlyRecommended
In Word, documentProtection enforcement is a document level
setting which is required for the section protection setting
to be enforced. formprot: "The enforcement of this property
is determined by the documentProtection element (§17.15.1.29),
as it is possible to specify protection without turning it on."
In LO, section protection is honored if it is simply enabled,
so only enable a section's protection if the enforcement
variable is set. Round-tripping will lose the fact that
sections are marked as protected if the enforcement is off.
patch initially developed to support tdf#120499 where
the focus is on sections, not on read-only and the
fake section that was being created.
Change-Id: I08c37ea6a9cc8fd1bdf7f36771b2d719bf9c93d6
Reviewed-on: https://gerrit.libreoffice.org/61899
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I8852b37b2c82f88b5feb5aa42775fbfeb3c9b187
Reviewed-on: https://gerrit.libreoffice.org/61886
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I8bf3509637cb295847e0dd667c1862269a192bbe
Reviewed-on: https://gerrit.libreoffice.org/61881
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic93b0171c9862f70311e93d64d1b93baf35a5182
Reviewed-on: https://gerrit.libreoffice.org/61457
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I3d3c31f785ae2969660c95425419ef9fe5b893c3
|
|
...to avoid -Werror,-Wshadow from Clang trunk with
<https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators",
warning about shadowing of UNKNOWN in anonymous enum in
sd/source/ui/remotecontrol/BluetoothServer.hxx
Change-Id: Ie0e6794da82c79ae2f8fd848c3c015c873fd60aa
Reviewed-on: https://gerrit.libreoffice.org/61878
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
regression from...
commit 9b77f8142bf665a47c3a179e3fe3f82623a99f8a
Author: Caolán McNamara <caolanm@redhat.com>
Date: Thu Apr 6 15:08:45 2017 +0100
ditch ReadRawUniString
three argument lclGetString32 variant mistaken for two argument lclGetString32
variant
Change-Id: I163aad0de7873487d9f9c8b6c28d162159fe7ad4
Reviewed-on: https://gerrit.libreoffice.org/61884
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Also:
* Prepare the ui file for up to 9 default personas
* And make the click handlers future-proof for different numbers
Change-Id: Iddf3b1c07feff12dc1fbba3e8a881ddf04923ced
Reviewed-on: https://gerrit.libreoffice.org/61891
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
|
|
That dialog is counter-productive if you develop that feature itself.
Change-Id: Ia635a2ff0ecc29a0d11be5c621a7c2a76469f9ba
Reviewed-on: https://gerrit.libreoffice.org/61880
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I47c52fbda3692178ad6c02fea7615463eeb4dcc8
Reviewed-on: https://gerrit.libreoffice.org/61876
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|