summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-12Prevent BroadcastRecalcOnRefMoveHandler copiesStephan Bergmann
...which would contain copies of AutoCalcSwitch and ScBulkBroadcast that both do things in their dtors. std::sort (into which BroadcastRecalcOnRefMoveHandler is passed as function object argument) returns its function object argument, which caused the BroadcastRecalcOnRefMoveHandler copies. Better split the RAII part that holds AutoCalcSwitch and ScBulkBroadcast and does things in their dtors into a BroadcastRecalcOnRefMoveGuard class of its own. (And while at it, explicitly delete the copy/move functions of AutoCalcSwitch and ScBulkBroadcast to avoid such issues in the future.) (The RAII part of BroadcastRecalcOnRefMoveHandler had been added with 60d0b992ea3a910be79ae4a8e8b0bb32a358b18a "sc-perf: tdf#87101 add bulk scope for BroadcastRecalcOnRefMove() calls". The issue was found with Clang 10 trunk -Wdeprecated-copy-dtor.) Change-Id: I45d6b81e7c8b34aed57b6f66c5e1e966a43a565d Reviewed-on: https://gerrit.libreoffice.org/85063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12sc: rowcol: tdf#50916 pass ScDocument to the token classesNoel Grandin
needed to create a fake ScDocument for the external ref manager, since it has no ScDocument at all Change-Id: Ia786ac291133e3c438694e81ecfb2590729a853d Reviewed-on: https://gerrit.libreoffice.org/85050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12This shall presumably be ScVerticalStackCellStephan Bergmann
(changed from SfxBoolItem(ATTR_STACKED,...) in 2579895f2c18fd7d606715f91b1463900f6d6937 "Related: tdf#129300 add ScVerticalStackCell to provide a description") Change-Id: I665f5c0a7f5059721e38330e06ce52bd18eae362 Reviewed-on: https://gerrit.libreoffice.org/85062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - tdf#127919 link Assign Component dialog to 'Creating A Dialog Handler' Change-Id: Ie0f7b0e45ebf0e39d67abc36640cdffd22e08e29 Reviewed-on: https://gerrit.libreoffice.org/85064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12tdf#105225 New UNO and Writer Web background tab pagesJim Raykowski
Change-Id: Id3e7d1c24d086624f053085e3134792b95188c23 Reviewed-on: https://gerrit.libreoffice.org/64991 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-12Remove redundant member clear() from dtorStephan Bergmann
...and then remove newly-redundant user-provided dtor completely, similar to <https://gerrit.libreoffice.org/#/c/85032/> "Remove some redundant user-provided dtors" Change-Id: I185d3aa7c16b5d4e6e64345c7fa221b9ed0cde6e Reviewed-on: https://gerrit.libreoffice.org/85038 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12tdf#123076 Get paper size for print previewGabor Kelemen
Initialize from current paper size which can be different from A4 Change-Id: Iae5e33d79c0783a32dad8635a66cc3fbe83dc568 Reviewed-on: https://gerrit.libreoffice.org/84920 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-12Remove some redundant user-provided dtorsStephan Bergmann
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk about copy functions being implicitly defined as non-deleted even though the class has a user-declared dtor Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc Reviewed-on: https://gerrit.libreoffice.org/85032 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12tdf#115698 android: Don't modify doc on color palette initializationMichael Weghorn
Previously, the call to 'ColorPaletteAdapter::setColorPalette' from the 'ColorPickerAdapter' constructur (via 'initializeColorPalette') would not just set the color palette, but also apply the color at index (0, 0) to the current selection, since 'ColorPaleteAdapter::setPosition' calls 'colorPaletteListener.applyColor' after setting the position. This is an undesirable side effect, and led to the situation described in tdf#115698 that cell A1 would always get black background when opening a spreadsheet in the Android viewer, since black is the color at 'color_palette[0][0]' by default and cell A1 is explicitly selected when Calc first opens, s. the 'CalcHeadersController' constructor. For Writer, something similar could be reproduced by selecting a word in a document using long-tap. If experimental editing mode was enabled, that word got black background (other words selected later didn't). To avoid this, make 'ColorPaletteAdapter::setColorPalette' just set the color palette and set back the values that indicate what is selected but don't apply any color. (And make 'setColorPalette' just take the palette as parameter, and set 0 for both start values, as the only caller was doing as well). Change-Id: I0fa720ac6550102701a2c82905c9720aab6daab2 Reviewed-on: https://gerrit.libreoffice.org/85044 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2019-12-12Silence some Clang 10 trunk -Wdeprecated-copy-dtorStephan Bergmann
...by making the user-declared dtor not user-provided. Non-deleted copy functions are still deprecated with any user-declared dtor, not just a user- provided one, but Clang and GCC happen to not emit a warning then (see the discussion at <https://reviews.llvm.org/rG9e260c12bce7> "[Diagnostics] Make behaviour of Clang's -Wdeprecated-copy same as in GCC"), so keep the code simple. Change-Id: Ic3936d12b3335d3aa55e1e8e92cc5152053a1720 Reviewed-on: https://gerrit.libreoffice.org/85042 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12external/skia: Further -Werror=deprecated-copy-dtor for Clang 10 trunkStephan Bergmann
...where the warning finds more occurrences than with GCC Change-Id: I12303de8f3b2d3299e847480e556ad03663d5401 Reviewed-on: https://gerrit.libreoffice.org/85040 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Silence some Clang 10 trunk -Wdeprecated-copy-dtorStephan Bergmann
...by explicitly defaulting the copy/move functions in cases where the user- provided dtor is trivial (so could theoretically be replaced with an implicit one, cf. <https://gerrit.libreoffice.org/#/c/85032/> "Remove some redundant user-provided dtors") but is probably defined out-of-class because the class is DLLPUBLIC Change-Id: Iff5e86654b10c7a03333c06312dc5dfce925d947 Reviewed-on: https://gerrit.libreoffice.org/85041 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12SvFileStream::Lock/UnlockRange are only called from within SvFileStream itselfStephan Bergmann
...and only for whole-file locking, so simplify the implementations in strmunx.cx and strmwnt.cxx accordingly Change-Id: I973e0ea41f246ad614232b107c8bf152073867be Reviewed-on: https://gerrit.libreoffice.org/85039 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12android: add abstraction to allow us to DetachThread sensibly.Michael Meeks
If we fail to do this after runLoop - some Android VMs can get really upset if we quit a thread without doing this, also ensure that we AttachThread to new polling loop threads as we come in for good measure - duplicate Attach's are NOPs. Change-Id: I32454773af4e02c97df0b6c02f61b1dc74df80b0 Reviewed-on: https://gerrit.libreoffice.org/84956 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7241382ccc0a028c5f08304090a6344e582db068) Reviewed-on: https://gerrit.libreoffice.org/84969 Tested-by: Jenkins
2019-12-12loplugin:finalclassesNoel Grandin
Change-Id: Ia9865271cf0a75ebf4b885ff376f7d0a152b2555 Reviewed-on: https://gerrit.libreoffice.org/84925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12ATTR_SHRINKTOFIT is ScShrinkToFitCellCaolán McNamara
Change-Id: Ia5d50e8be174869439400e0cd7d02d54429c7433 Reviewed-on: https://gerrit.libreoffice.org/85021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12Unit test clean-up for testAxisTitlePositionDOCXBalazs Varga
Related commit: 9ff954d5f780cae5df6942e97b713cfc19449145 (tdf#127908 tdf#128193 Chart OOXML: Fix Custom Y axis title position) Change-Id: I5b239e8cc5d2e497e7ecd6443b9e2f3001c3c231 Reviewed-on: https://gerrit.libreoffice.org/84991 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12make Skia Windows widget drawing use correct alpha (tdf#129074)Luboš Luňák
The OpenGL code made the widget drawing use two variants drawn on black and on white, for reasons not explained in 3149cc341b1866d215110f0783227549a99b5920 (probably the Windows API doesn't handle alpha completely correctly or whatever). This means that getting the actual alpha requires a custom algorithm that needs to be implemented manually for Skia use. Change-Id: I1438f3829a1bdeda9e55700c4a397c60d5663446 Reviewed-on: https://gerrit.libreoffice.org/84948 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-12update Skia to chrome/m80Luboš Luňák
Change-Id: I26782c8bd3d8ce34cbf7ce5a00b884436d37cb85 Reviewed-on: https://gerrit.libreoffice.org/84617 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-12Use INVALID_POOL_ITEM instead of magic numberSzymon Kłos
Change-Id: I44fdc602563164944bee40848b13de0c0c62e4f7 Reviewed-on: https://gerrit.libreoffice.org/85019 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-12tdf#34517 Bring forward/backward in chart series switchedKelemen Gábor
Turns out bringing a data series forward means its index is increased while bringing backwards means decreasing it. Since the bool MOVE_SERIES_FORWARD is defined as true in ControllerCommandDispatch.cxx the condition here meant that bringing forward decreased the index and MOVE_SERIES_BACKWARD as false meant that bringing backward increased the index. Now the commands do the expected series order change. Change-Id: Ib49b301eacc227439b8fb3b0dc3513e59cbdc484 Reviewed-on: https://gerrit.libreoffice.org/84608 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-12tdf#121991 Chart OOXML import: fix deleted legend entriesTünde Tóth
The legend showed deleted legend entries too. Change-Id: I1e205cdfc4262c73d2bb189237d6bc316781931d Reviewed-on: https://gerrit.libreoffice.org/84516 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-12-12Use std::transform instead of for loopMike Kaganski
This simplifies the functions, and avoids repeated non-const operator[] on sequences, which has significant overhead. Change-Id: I670c25da6f5422822c931d1f4105b07102d7a3d6 Reviewed-on: https://gerrit.libreoffice.org/85014 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-12Use structured bindingMike Kaganski
Change-Id: I1afea430de43f44f0155078327870b8dc0c937e3 Reviewed-on: https://gerrit.libreoffice.org/85012 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-12Fix typoAndrea Gelmini
Change-Id: I288dadc5c488a1f0ec5c541c12bf2ff2bd8176d2 Reviewed-on: https://gerrit.libreoffice.org/85013 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-12tdf#127493 store ExportFormFields checkbox valueJan-Marek Glogowski
... and also correctly set the initial frames sensitivity. The commit removed the no longer needed UserSelection variant of mbExportFormFields but forgit to actually set it now. Regression from my commit 76fcd878da1624e73f1eb9d9405485d4faf66edf. Change-Id: Ia5fcc1c37e2e4b4a330b59a492f817d2db8d7347 Reviewed-on: https://gerrit.libreoffice.org/84975 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-12Fix UBSan dynamic-type-mismatchStephan Bergmann
...as seen after 331cafb1484597544bd94fa3f0e0a45b3328a4d8 "Related: tdf#129300 add ScLineBreakCell to provide a description" during CppunitTest_sc_ucalc: > sc/inc/patattr.hxx:76:14: runtime error: downcast of address 0x60200056aaf0 which does not point to an object of type 'const ScShrinkToFitCell' > 0x60200056aaf0: note: object is of type 'ScVerticalStackCell' > 6f 00 00 60 70 7b f7 16 b0 7f 00 00 ff ff ff ff 86 00 02 00 02 00 00 00 ff ff ff 04 10 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'ScVerticalStackCell' > #0 in ScShrinkToFitCell const& ScPatternAttr::GetItem<ScShrinkToFitCell>(TypedWhichId<ScShrinkToFitCell>, SfxItemSet const&, SfxItemSet const*) at sc/inc/patattr.hxx:76:14 > #1 in ScPatternAttr::GetCellOrientation(SfxItemSet const&, SfxItemSet const*) at sc/source/core/data/patattr.cxx:152:9 > #2 in ScPatternAttr::GetCellOrientation(SfxItemSet const*) const at sc/source/core/data/patattr.cxx:170:12 > #3 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) at sc/source/core/data/column2.cxx:809:43 > #4 in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:92:17 > #5 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:466:5 > #6 in ScDocument::SetOptimalHeight(sc::RowHeightContext&, int, int, short) at sc/source/core/data/document.cxx:4274:18 > #7 in ScDocFunc::AdjustRowHeight(ScRange const&, bool) at sc/source/ui/docshell/docfunc.cxx:156:26 > #8 in ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, InsCellCmd, bool, bool, bool) at sc/source/ui/docshell/docfunc.cxx:2146:25 > #9 in Test::testFormulaRefUpdateInsertRows() at sc/qa/unit/ucalc_formula.cxx:2247:11 Change-Id: I12b95a8229bac8d67d85f2a5a90a5e2e286a6981 Reviewed-on: https://gerrit.libreoffice.org/84996 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Fix typoAndrea Gelmini
Change-Id: Ie1a06014d989f51141a15c724ab026f5423335de Reviewed-on: https://gerrit.libreoffice.org/84995 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-11tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRectRegina Henschel
and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize(). Error was, that it was assumed, that SdObjCustomShape::SetSnapRect() changes the shape so, that it fits into the passed rectangle. That is true for other type of shapes, but not for custom shapes. Change-Id: Ib00d52087509f459165000abf43c7f244980a01b Reviewed-on: https://gerrit.libreoffice.org/84216 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-12-11Fix typoAndrea Gelmini
Change-Id: Iffb9bcf5bfb18591dedfea62875bae76c772b7e2 Reviewed-on: https://gerrit.libreoffice.org/84994 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Avoid crash when no uno name availableSzymon Kłos
Change-Id: I81895e68d6fda46bec0cc3bca2da63901d3fed4c Reviewed-on: https://gerrit.libreoffice.org/84950 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-11jsdialog: send items on status changeSzymon Kłos
Use existing mechanism, delete sending in getter code which caused unnecessary work. Change-Id: Ibc191c16b95fd58e7065e019f48f3837cfed5bbd Reviewed-on: https://gerrit.libreoffice.org/84914 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-11pickBestDevice return is ignoredCaolán McNamara
so might as well return the BestDeviceIndex instead of passing it by ref Change-Id: Ic92fa3b5bfe3d319ff9fcb61b7f5404b5a624be5 Reviewed-on: https://gerrit.libreoffice.org/84971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11ensure cache dir is createdCaolán McNamara
Change-Id: I708efa3dc4d9d145b1000d24cea4a4ff02628178 Reviewed-on: https://gerrit.libreoffice.org/84970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Fix typosAndrea Gelmini
Change-Id: Idc42061d8832f9d7ca5402e756c81305a309eefc Reviewed-on: https://gerrit.libreoffice.org/84968 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11Recursively include unnamed inner classes in "layout heuristic"Stephan Bergmann
This covers both cases where the inner class is defined in the declaration of a non-static data member, as needed by clang-cl for > bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx(799,19): error: unused class member [loplugin:unusedmember] > PVOID pExceptionObject; > ~~~~~~^~~~~~~~~~~~~~~~ > bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx(801,19): error: unused class member [loplugin:unusedmember] > PVOID pThrowImageBase; > ~~~~~~^~~~~~~~~~~~~~~ as well as anonymous structs (even if there appears to be no need for that across the LO code base; they are part of C11 and a widely supported C++ extension). The newly added TODO will eventually need fixing, but I didn't find a way in Clang to tell whether a RecordDecl is defined as part of a FieldDecl, and the issue appears to be of no practical relevance for the current LO code base. Change-Id: I08cecddb9b4a70c3ca480d2d2ab1ea4f198011b2 Reviewed-on: https://gerrit.libreoffice.org/84967 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-11convert PrepareHint to scoped enumNoel Grandin
Change-Id: Ia7c987dc59f335d76ee874c1bb51707cb55ff41e Reviewed-on: https://gerrit.libreoffice.org/84922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11tdf#128683 Add more tools to Table section in Writer's SidebarRoman Kuznetsov
Change-Id: I505cbf0a7324cc82d0fcb1ac76a7f2a23b8a0b0c Reviewed-on: https://gerrit.libreoffice.org/84783 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-12-11Related: tdf#129300 clear properties that are set back to their original stateCaolán McNamara
Change-Id: Ic957afbdcf6decef07d15fa10a560e560de5795a Reviewed-on: https://gerrit.libreoffice.org/84951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScIndentItem to provide a descriptionCaolán McNamara
Change-Id: Ieb1a12f35cf8974c557c6e52eac0cd9fb7f80914 Reviewed-on: https://gerrit.libreoffice.org/84945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScHyphenateCell to provide a descriptionCaolán McNamara
Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4 Reviewed-on: https://gerrit.libreoffice.org/84892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScLineBreakCell to provide a descriptionCaolán McNamara
Change-Id: Ief739616163c68e0e30d6287fdac90c1bcc9d13f Reviewed-on: https://gerrit.libreoffice.org/84879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Resolves: tdf#128867 support LocalizedDecimalSep for native gtk dialogsCaolán McNamara
Change-Id: Idb883707fb89d1f76b24ea592c51e28fffd2322f Reviewed-on: https://gerrit.libreoffice.org/84952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add dimensions to svg icons + refactor some headings Change-Id: Ic194be7d99685d3272393088973367bbbcd3246c Reviewed-on: https://gerrit.libreoffice.org/84960 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-11Extend loplugin:unusedmember "layout heuristic" to base classesStephan Bergmann
With clang-cl on Windows, where CPPU_GCC3_ALIGN expands to nothing, there were warnings about unsued Char1::c1 and Char2::c2 in cppu/source/uno/check.cxx (which were suppressed on Linux thanks to CPPU_GCC3_ALIGN(T) making the plugin's "layout heuristic" kick in for T). But Char1 and Char2 are also (indirect) bases of Char3, for which the heuristic kicks in thanks to a sizeof(Char3) expression. Extending the heuristic to base classes seems like a good improvement anyway, and happens to make the unwanted warnings on Windows go away. Change-Id: I1fac3104aa7a1745ccf2f23972953eaacbd45104 Reviewed-on: https://gerrit.libreoffice.org/84927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-11tdf#128991 Make clear in the help installer Roman Kuznetsov
that it must be installed into the same directory as LibreOffice and some visual fix in layout Change-Id: I8048c332bf381137689bfa1695862cf7d118f0a8 Reviewed-on: https://gerrit.libreoffice.org/84582 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-11tdf#127294 one new tip of the day; clarification of three existing tipsSeth Chaiklin
1. It seems that inserting images in shapes only works in Writer, so added correction to make this tip Writer-specific. 2. Added a tip about how to insert images and photos to shapes in Draw and Impress. 3. Small wording adjustment in two other tips Change-Id: Ife6d7164af294803ca0ec50487b1e2d7b6a9d75a Reviewed-on: https://gerrit.libreoffice.org/84830 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-11num->number and bul->bullet in sw/Noel Grandin
make some symbols easier to read Change-Id: Icb5ea48dce1bcf4ae17e57e8f4c7bec3acd33f82 Reviewed-on: https://gerrit.libreoffice.org/84924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11convert FrameControlType to scoped enumNoel Grandin
Change-Id: Ic74fcf0c8f7c671de5187bdee284bb43c7299d1f Reviewed-on: https://gerrit.libreoffice.org/84923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-11sc: rowcol: tdf#50916 initial conversion of Valid* methodsNoel Grandin
just default the params for now Change-Id: I13ee78aeaa1133a167d57520b334d5e644e28ece Reviewed-on: https://gerrit.libreoffice.org/84926 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-14 20:11:20 +0000