summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-05menubar: reverte recentfilelist change to have it after openremoteandreas kainz
Change-Id: I775e9d6d6bedbfe00a4e5349cf0a664ccbd0ecc4 Reviewed-on: https://gerrit.libreoffice.org/70288 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05tdf#118269 Replace InsertAnnotation commands accel for Hungarian onlyGabor Kelemen
So that Insert - Comment command would not insert an & on Windows with Hungarian keyboard layout Change-Id: I83f43cdc0b3f32e284cd747648de5bcb07505314 Reviewed-on: https://gerrit.libreoffice.org/70279 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05Remove stale accelerator for uno:AnimationModeGabor Kelemen
Corresponding command was removed in b94abbc8fd83e2ac5c7d95a8a4f03da6bc15facd (2004!) This and 15bdac207302fb54155310b0cc7fdb7283e612ed is why this accelerator showed up as uno:AnimationMode in the list instead of a human readable name Change-Id: I7b2f2cf76c75d815b85b1ceb6e8468588e3d15f1 Reviewed-on: https://gerrit.libreoffice.org/70268 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05Remove stale accelerators for uno:StyleCatalogGabor Kelemen
The uno:StyleCatalog command was removed in b4c18dc0ea32af9f070d43278e547ee0b2e540a4 Change-Id: I31118e97c5445b1021ea60b2629f12d2f60595cd Reviewed-on: https://gerrit.libreoffice.org/70267 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05sc menubar: rearrange subgroup items to have > items last sortedandreas kainz
Change-Id: Ie46fcc58039ce9686b779d27699e4988e93e8bd7 Reviewed-on: https://gerrit.libreoffice.org/70195 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05tdf#112318 sd opengl: fix lack of initial animationMiklos Vajna
Commit 881043d1f01fad663c0a17f11cbe2dab79e31217 (#i98792# Allow frequent calls to slide show update()., 2009-04-27) added a comment in sd::SlideshowImpl::updateSlideShow() talking about an "above" case, when the slideshow update suggests to not wait till the next update, but later commit 12dcf5e6e770b1933252a1f919663ba45ded4cdf (slideshow: cleanup main-loop usage, post-yield listeners, etc., 2015-11-13) removed that handling. That was fine till opengl rendering was introduced, which swaps its backbuffer in an idle handler. Given that OpenGLFlushIdle's priority is TaskPriority::POST_PAINT and SlideshowImpl::maUpdateTimer's priority is TaskPriority::REPAINT, the GL backbuffer is not always painted while an animation is ongoing. This is more visible when tweaking the bugdoc to have an e.g. 5 sec animation, then starting the slideshow results in waiting for 5 seconds and only then the slide shows up, without an animation. Fix the problem by re-introducing the handling of the fUpdate == 0, and processing idle events there, which means the GL backbuffer will be always painted, regardless if fUpdate is a small number or 0. Change-Id: I25b2dc0aa41af62d9bd89617178eb2e9997f5b17 Reviewed-on: https://gerrit.libreoffice.org/70287 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-05tdf#42949 Fix IWYU warnings in include/sfx2/sidebar/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic2bd25bcbcc7f5fb6e29ced70fddb74385b5fb2f Reviewed-on: https://gerrit.libreoffice.org/70077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05Fix typoAndrea Gelmini
Change-Id: I49ffb2fff63a8818c4e84a26923fca1484bf1e36 Reviewed-on: https://gerrit.libreoffice.org/70284 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-05Related: tdf#116098 avoid ctrl-shift-e shortcut in more placesGabor Kelemen
These were originally added in commit 4105862b03b78ff5d80d5e1f5a48f15015f79d3c Avoid the reported problem for the other two instances (Calc and Master document) too Change-Id: Ief3adafec1f05f9fb881da76c844fe8525143029 Reviewed-on: https://gerrit.libreoffice.org/70272 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-05Remove unused using declarations in directories [e-l]*Gabor Kelemen
Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05sw btlr writing mode: implement RTF exportMiklos Vajna
Note that we can't work with the table box (and frame format) of pTableTextNodeInfoInner in RtfAttributeOutput::TableVerticalCell(). This is because cell definitions are written in RtfAttributeOutput::TableDefinition(), and the loop only calls setCell(), i.e. the cell index is updated in the node info, but the table box is not. Import was already working as-is. Change-Id: Ia089c42b3a49f1a8f012a8cadaa8bcad16128c3e Reviewed-on: https://gerrit.libreoffice.org/70269 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-05tdf#120703: partially revert commit 85456fae54029edd26df2277a9eec5e2fe3d9739Mike Kaganski
... to take into account possible differences of results of dynamic_cast vs static_cast; the change casts dynamically, as before the commit, and only adds asserts on the result of the cast. Thanks to sberg for pointing my mistake out! Change-Id: Ib77d443e5a858e744f369f58542de603f948fd1c Reviewed-on: https://gerrit.libreoffice.org/70274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-05respect read-only config item: AutoFunction/Text/ShowToolTipAndras Timar
Change-Id: Ib808e35d3cc3c2895993193ac6ed05d556c1857d Reviewed-on: https://gerrit.libreoffice.org/70275 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05respect read-only config item: CreateMSOLockFilesAndras Timar
Change-Id: I6b264a2f2e2995e880169f6224c60f023584469d Reviewed-on: https://gerrit.libreoffice.org/70270 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-05Fix typoAndrea Gelmini
Change-Id: I7b329b4da49464e2bb34c29b8db0aa8e21c94c0e Reviewed-on: https://gerrit.libreoffice.org/70283 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-05Sifr icon theme update links.txtandreas kainz
Change-Id: Ia6e48da3abe6d142135f0e916f02e27b63bbcb57 Reviewed-on: https://gerrit.libreoffice.org/70280 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-05Fix typoAndrea Gelmini
Change-Id: Ie5b9e2a603146dd6bd0e22c80f7cee23ccfd39b2 Reviewed-on: https://gerrit.libreoffice.org/70282 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-05Fix typoAndrea Gelmini
Change-Id: I15ab841fb9398a52d4df48b4bc4022b0f469f771 Reviewed-on: https://gerrit.libreoffice.org/70281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-04Get rid of b2u/u2b helpers; use OUString's toUtf8/fromUtf8 insteadMike Kaganski
These helpers are used in code generator code; so any invalid UTF-8 or UTF-16 in the conversion is programmer's error which needs fixing. Thus, the behavior of toUtf8/fromUtf8 which asserts the validity is fine here. Change-Id: I3004e233c9de59f8e348455f1f04d23e8c51ed3d Reviewed-on: https://gerrit.libreoffice.org/70249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04Revert "raise cairo baseline to 1.12.0"Caolán McNamara
This reverts commit 50580f452cc7c88a231831619a3f05958ce56460. Revert "raise cairo baseline to 1.10.0" This reverts commit 58a0e60dee0d27a699f856827c20b792417d3478. 32bit baseline is currently at cairo 1.8.8 Change-Id: I5156df6aee03dbbb2e209dbd5717a98580256170 Reviewed-on: https://gerrit.libreoffice.org/70260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04Resolves: tdf#120754 on undoing an obj insert use its current ordinalCaolán McNamara
there may have been changes not caught by undo to the object's ordinal, so on use of RemoveObject (or ReplaceObject) call GetOrdNum on the object to get its current position within its parent. We can keep nOrdNum for the desired dest position within the parent for InsertObject Change-Id: I3bdabf387dd630fc1fadaaa1f3d8c05e93865e4f Reviewed-on: https://gerrit.libreoffice.org/70251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04ios widget defs: update combobox, checkbox, spinbox SVGsTomaž Vajngerl
In addition remove spinbox pressed state (it wasn't useful) and draw white filled empty rect for spinbox as we don't draw the background automatically. Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944 Reviewed-on: https://gerrit.libreoffice.org/70258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04Resolves: tdf#122780 limit massive template names in ui to a sane lengthCaolán McNamara
Change-Id: I053b30b00dbda67819af68020e2f6fa4a5b5134e Reviewed-on: https://gerrit.libreoffice.org/70255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04Get rid of USS macroMike Kaganski
The helper marco is used in export code to convert UTF-16 internal string representation to UTF-8 used in XML encoding. I suppose that all strings here should be already valid UTF-16 (an invalid input should have been validated at import/input stage). An invalid string at this stage means a programming error in another part of code that breaks this precondition, and should not be handled at export stage. (See also commit 0267a2326b5282023e8b08a147eca178c5db1980.) This effectively changes flags used in conversion from UTF-16 to UTF-8, so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be truncated on invalid bytes instead of inserting U+FFFD, and would fail assertion in debug builds. Other changed flags don't affect UTF-16-to-UTF-8 conversion. Change-Id: I12b2cc5378208904c3266924187d6402700ed6f3 Reviewed-on: https://gerrit.libreoffice.org/69801 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04CreateUndoRemoveObject default arg is always usedCaolán McNamara
Change-Id: I5676281be56ff454962900fe7500d078b1f9e7e9 Reviewed-on: https://gerrit.libreoffice.org/70252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04change GetColorCount to use sal_Int64Tomaž Vajngerl
Hopefully fixes problems on 32-bit linux. Change-Id: I1fc22f1bb37c8297bd3bd6828206d1ffa9ae722d Reviewed-on: https://gerrit.libreoffice.org/70241 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04Qt5 / KDE5 refactor create_SalInstanceJan-Marek Glogowski
Move most common code into Qt5Instance (static) functions. Not much saved with regard to LOC, but since the code was 95% C'n'P, I hope it'll be less error prone this way. Also handle all QApplication argument pointers via std::unique_ptr from the beginning. Change-Id: I87b2f571d398db7ccce3e740f16205b251be4ced Reviewed-on: https://gerrit.libreoffice.org/69578 Tested-by: Jenkins Reviewed-by: Aleksei Nikiforov <darktemplar@basealt.ru>
2019-04-04KDE5 merge KDE5SalData into Qt5DataJan-Marek Glogowski
Currently there is no point for a seperate KDE5 SalData class. The additional NWF settings fix the wrong popup menu for qt5, so this just moves all the NWF data and gets rid of KDE5SalData. Change-Id: I1c02d1f660df288a0d2e1c6607b34fc1ce593727 Reviewed-on: https://gerrit.libreoffice.org/70005 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-04Drop UNICODE/_UNICODE definesMike Kaganski
The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04raise cairo baseline to 1.12.0Caolán McNamara
Change-Id: I1816f23fea88e6b840539a88504956b00a546522 Reviewed-on: https://gerrit.libreoffice.org/70243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04raise cairo baseline to 1.10.0Caolán McNamara
Change-Id: I721b80d7ce28d36babbd2bd1957fcbd6a2d27a27 Reviewed-on: https://gerrit.libreoffice.org/70242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04typo: openning -> openingAndras Timar
Change-Id: I7da07503badec82ffb227424819a0f19eabfbbe5
2019-04-04tdf#124471 Change bullet styles names in Style section of SidebarRoman Kuznetsov
Change-Id: I1a6acd3b9496cf83cd0e1ef6d808443cd40ae2c3 Reviewed-on: https://gerrit.libreoffice.org/70121 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04Resolves: tdf#124219 check at runtime for availability of cairo functionsCaolán McNamara
Change-Id: I0ab3055760d8be690bdfff560212db368a0fa261 Reviewed-on: https://gerrit.libreoffice.org/70240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04rhbz#1696037 null-derefCaolán McNamara
Change-Id: I1a9eb5b1b38e2ec651f2d0286337106ab565a9dc Reviewed-on: https://gerrit.libreoffice.org/70239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04odk: Add hint to test this in instdir/sdkSamuel Mehrbrodt
Change-Id: I8881f33a024cb5b9e36d4a6a668d8a32aea2ed1a Reviewed-on: https://gerrit.libreoffice.org/70189 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-04tdf#124323: show restart dialog when toggling multi-threaded...Xisco Fauli
calculation Change-Id: I853ae21d4c085488232a375ef42480453c01880b Reviewed-on: https://gerrit.libreoffice.org/70210 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-04expand async to allow it to resize to optimal sizeCaolán McNamara
Change-Id: I87c413108a41f994c0e8d86f469fc361d4cd42e5 Reviewed-on: https://gerrit.libreoffice.org/70220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04weld ClassificationDialogCaolán McNamara
with the extra problem of hosting an EditView/EditEngine within a weld::DrawingArea Change-Id: Id48a57ed0dfd2d92217209c43f752edd9cf8e1bd Reviewed-on: https://gerrit.libreoffice.org/70219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04split cursor drawing into Window/OutputDevice partsCaolán McNamara
Change-Id: I6027abd3c385f838dc02cc85fda0eef212d2541f Reviewed-on: https://gerrit.libreoffice.org/70218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04allow SelMouseButton[Down|Up] without pWinCaolán McNamara
Change-Id: If5031390ac4a0cdd3dad3b43b23f4319c2dfc53a Reviewed-on: https://gerrit.libreoffice.org/70217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04add nullchecking SelectionEngine::CaptureMouseCaolán McNamara
Change-Id: Ie8594c8fe2a9e2d84121f3a6a1ee8afab265b14f Reviewed-on: https://gerrit.libreoffice.org/70216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04SelectionEngine::ReleaseMouse checks for null pWinCaolán McNamara
Change-Id: I80e6a304d07fcc290e73e6251f520926398a7ecb Reviewed-on: https://gerrit.libreoffice.org/70215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04aRect is always in pixelsCaolán McNamara
Change-Id: Ib122a2f970a7852e2979a5301f635f9f1a4ce87b Reviewed-on: https://gerrit.libreoffice.org/70214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04LOK logic is good for non-lok hereCaolán McNamara
Change-Id: I7ad351800a55798e822596733f7fcb057e2e9aff Reviewed-on: https://gerrit.libreoffice.org/70213 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04this line is equivalent to InvalidateAtWindowCaolán McNamara
Change-Id: I4f718710c778e25f92f97ed2e7e7d9d01ed99e6b Reviewed-on: https://gerrit.libreoffice.org/70212 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04uitest: disambiguate UITest_findReplaceMiklos Vajna
There was an sw and an sd one as well. Change-Id: I3d031674f6866a779d44ce642339ec59bf2c82cb Reviewed-on: https://gerrit.libreoffice.org/70236 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-04chart icon theme update sifr and colibreandreas kainz
Change-Id: Ib72500f24cbca406d258794d4e8ab2cee7ef5ed6 Reviewed-on: https://gerrit.libreoffice.org/70223 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-04ios theme definition: add slider disabled stateTomaž Vajngerl
Change-Id: Ie4388f00c4a0c11df77782691fe9ea7f706d2b5c Reviewed-on: https://gerrit.libreoffice.org/70231 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04[pt-PT] Added 12 autocorrect wordsMarco A.G.Pinto
Change-Id: I2c01a4cd0c63128c449912c1fdade3bed46d652b Reviewed-on: https://gerrit.libreoffice.org/70232 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>