summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-11-02WaE janitorial: unused variableLionel Elie Mamane
Change-Id: Id2846bd6db9bace6cffacf3a9fc4116ae727facf
2012-11-02Columns should know their tableLionel Elie Mamane
For example dbaccess::OSingleSelectQueryComposer::appendOrderByColumn expects it (via impl_getColumnName_throw via getTableAlias) There is some vagueness: Should the TableName property contain just the table name, or the *composed* table name (that is with catalog and/or schema if used by this DB)? In the case of a query, should it contain the table name (alias) *in* *the* *query* or of the original table? In the former case, what meaning do SchemaName and CatalogName have? They should be empty? For now, commit as such and deal with the fallout, if any, when it hits the fan. If we really need to store these *different* values, (that is, some code validly needs them) it would be easier / cleaner / ... to define *different* properties for these *different* notions. Change-Id: I032e619a60e7563cd51478db16cb5e0e5452bfde
2012-11-02Retrieve CatalogName only once, tooLionel Elie Mamane
2012-11-02janitorial: alignmentLionel Elie Mamane
Change-Id: I5ff8335d9c7324a101d055ff9666fce867bac8ff
2012-11-02janitorial: space between argumentsLionel Elie Mamane
Change-Id: I430929a19d7f5c9c6859c12a0952f9d335de4520
2012-11-02janitorial: use adress-of-value instead of manually repeating typeLionel Elie Mamane
Change-Id: If2422a618f98685d029289a5357fa7d7860567e7
2012-11-02janitorial: alignmentLionel Elie Mamane
Change-Id: Ia5e4729c2c85dfacc4505c3674a113a6a4415ab0
2012-11-02Don't abort when column has no (Catalog|Schema|Table)NameLionel Elie Mamane
Especially since the rest of the function is prepared to handle no/empty (Catalog|Schema|Table)Name. Change-Id: Ic0bb59ead5789e671c90887ef850588f4924f5e7
2012-11-02optimisation: take ref to OUString instead of constructing temp objectLionel Elie Mamane
Change-Id: I9dcb821cd71f89fa5b3d8274fd93facc1f43863f
2012-11-02detect even more memory mismanagement on glibcLionel Elie Mamane
Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
2012-11-02loplugin: unused UniStringsCaolán McNamara
Change-Id: Ia6a10bf30685f25a13c091f04566c62888524c94
2012-11-01New unit test for shifting cells.Kohei Yoshida
Change-Id: Ic004490ffaf1da5cdb43f0a1336437eb312813bf
2012-11-02WaE: extra clang warningsCaolán McNamara
Change-Id: I69b105c39f67372331910b6957214d62e1f3818c
2012-11-01Add comments to make it easier to follow this non-obvious code.Kohei Yoshida
Change-Id: Ib3d3e5b57799c22916845899839ddcc9a81e9b98
2012-11-01Remove the correct range, or else maItems would end up with invalid pointer.Kohei Yoshida
nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ia3ef4469b50695038836ff7b9b48172256032786
2012-11-01Now this bConsecutive flag makes no sense.Kohei Yoshida
Treat as if this flag is always false. Change-Id: Ie1364ac54f95263aa316bf81f631e607843934d5
2012-11-01This if statement is never true.Kohei Yoshida
SCROW nRow = maItems[i].nRow; and nRow will never be modified afterwards. So if (nRow != maItems[i].nRow) is never true. Change-Id: I4f867a704d50138aee8c5e7f37464880470098c2
2012-11-01Prefer early bailout to avoid big fat if block.Kohei Yoshida
Change-Id: I028606c41b1486349f96b62e0ddb071ad46e9e55
2012-11-01WaE: MacOSX, clipboard id just has to be non-zeroCaolán McNamara
Change-Id: If4edbe6fdb56e4b8fd8545404267dea7009a8c7a
2012-11-01Explicitly call these methods to init / update note positions.Kohei Yoshida
Since we don't use inc / dec recalc level, we need to do this. Change-Id: Ia99b4dbfceefd1ed951a61374250c5c61e39a62a
2012-11-01No more "increase / decrease of recalc level" for drawing objects.Kohei Yoshida
That scheme made it extremely hard to determine when the object's positions get recalculated. It's better to figure out when to recalc drawing objects' positions, and call SetDrawPageSize() manually at that point (and only once!) Change-Id: I05d9b693cfc9310f5472ed8287c7a2e36646f4d7
2012-11-01Double allocation switch no longer used since we switched to std::vector...Kohei Yoshida
for cell storage in column. And std::vector internally does double allocation. Change-Id: I4363e7593def3feb71100487c7f88c05797596e7
2012-11-01configure: don't accept -enable-headless where it won't workRiccardo Magliocchetti
Don't even try to build --enable-headless where GUIBASE would not be unx. Change-Id: I6e5a6d3071317171f42c0b1336502cec50ba72fa
2012-11-01SwNode: reorder that to avoid -Werror=reorderMichael Stahl
Change-Id: Ic58a5503dc6b7991c8804feef05b814d1055bfb9
2012-11-01Better way to initialize SwNodeArnaud Versini
Change-Id: I6bc397d9ecd44975ebfa58014c6fe7cd470e4ada Reviewed-on: https://gerrit.libreoffice.org/960 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2012-11-01Translate German comments and improve some GermishPhilipp Weissenbacher
Change-Id: If733d06e2213af824884e49bd3414df1c23cb157 Reviewed-on: https://gerrit.libreoffice.org/955 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2012-11-01add some new ado constants bnc#787452Noel Power
Change-Id: I1079cf87d223fc03e8cef53f69fa76ea4386c9b8
2012-11-01tweak comment translationMichael Stahl
Change-Id: I729612b2ffeea9c3c64f8f0c0c2313f48b965270
2012-11-01Translate German commentsPhilipp Weissenbacher
Change-Id: I8cf27a705332c6e7ea62474c78d59911406d378e Reviewed-on: https://gerrit.libreoffice.org/954 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2012-11-01vcl/headless: [HACK] workaround solarMutexx splat with headless modeRiccardo Magliocchetti
Apply mmeeks temporary solution until a proper fix is found. With the patch applied unoconv testsuite runs fine. mmeeks analysis of the problem: It looks really interesting :-) it's hard to tell (from valgrind) where the threads were pre-empted [ actually logging that might be quite a nice feature to add to for valgrind ;-], but there is already the SolarMutex guard to try to stop this from happening. I append the odd trace with some thoughts. It is -possible- that we never get around to taking the solar mutex in the first instance in 'main' - such that by the time we come to release and re-take it in vcl/headless/svpinst.cxx: void SvpSalInstance::Yield( bool bWait, bool bHandleAllCurrentEvents ) the count is zero - could you add some fprintf debugging to check that - just dump nAcquireCount ==28574== Thread 1: ==28574== Invalid read of size 8 ==28574== at 0x739C702: SfxStateCache::SetState_Impl(unsigned short, SfxPoolItem const*, unsigned char) (statcach.cxx:454) ==28574== by 0x738042E: SfxBindings::UpdateControllers_Impl(SfxInterface const*, SfxFoundCache_Impl const*, SfxPoolItem const*, unsigned short) (bindings.cxx:1500) ==28574== by 0x7383C5B: SfxBindings::Update_Impl(SfxStateCache*) (bindings.cxx:437) ==28574== by 0x7383FD7: SfxBindings::NextJob_Impl(Timer*) (bindings.cxx:1646) ==28574== by 0x92BF4AD: Timer::ImplTimerCallbackProc() (timer.cxx:142) The YieldMutex -should- be held at this point excluding this other thread (?). ==28574== by 0x95D152D: SvpSalInstance::CheckTimeout(bool) (saltimer.hxx:57) ==28574== by 0x95D17D7: SvpSalInstance::Yield(bool, bool) (svpinst.cxx:288) ==28574== by 0x92B4530: Application::Yield(bool) (svapp.cxx:434) ==28574== by 0x92B45E6: Application::Execute() (svapp.cxx:413) ==28574== by 0x50AED58: desktop::Desktop::Main() (app.cxx:1711) ==28574== by 0x92BDFB8: ImplSVMain() (svmain.cxx:173) ==28574== by 0x92BE8E4: SVMain() (svmain.cxx:210) ==28574== by 0x50E1CF4: soffice_main (sofficemain.cxx:83) ==28574== by 0x40069A: main (main.c:25) ==28574== Address 0x1466bdc8 is 56 bytes inside a block of size 72 free'd ==28574== at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387) ==28574== by 0x737F479: SfxBindings::DeleteControllers_Impl() (bindings.cxx:325) ==28574== by 0x7380572: SfxBindings::~SfxBindings() (bindings.cxx:264) ==28574== by 0x7380718: SfxBindings::~SfxBindings() (bindings.cxx:275) ==28574== by 0x758B91E: SfxFrame::DoClose_Impl() (frame.cxx:178) ==28574== by 0x75AAFC1: SfxBaseController::dispose() (sfxbasecontroller.cxx:1041) sfx2/source/view/sfxbasecontroller.cxx: This method has a live: SolarMutexGuard aGuard; ==28574== by 0x16B8E785: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (frame.cxx:1380) ==28574== by 0x16B8E1CF: framework::Frame::close(unsigned char) (frame.cxx:1633) ==28574== by 0x758BE87: SfxFrame::DoClose() (frame.cxx:140) ==28574== by 0x797F51C: SfxBroadcaster::Broadcast(SfxHint const&) (brdcst.cxx:49) ==28574== by 0x7511211: SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (objxtor.cxx:173) ==28574== by 0x7534972: SfxBaseModel::close(unsigned char) (sfxbasemodel.cxx:1491) ==28574== by 0x1E776909: SwXTextDocument::close(unsigned char) (unotxdoc.cxx:578) ==28574== by 0x7537FB0: SfxBaseModel::dispose() (sfxbasemodel.cxx:788) ==28574== by 0x1211D6E7: gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, unsigned int, double*, unsigned int) (callvirtualmethod.cxx:128) ==28574== by 0x12120FEE: cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (uno2cpp.cxx:246) ==28574== by 0x12121ACD: bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (uno2cpp.cxx:440) ==28574== by 0x15D5CE5E: binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const (incomingrequest.cxx:251) ==28574== by 0x15D5D8AB: binaryurp::IncomingRequest::execute() const (incomingrequest.cxx:80) ==28574== by 0x15D61B4C: request (reader.cxx:89) ==28574== by 0x663A506: cppu_threadpool::JobQueue::enter(long, unsigned char) (jobqueue.cxx:115) ==28574== by 0x663B00D: cppu_threadpool::ORequestThread::run() (thread.cxx:179) ==28574== by 0x663B4E9: threadFunc (thread.hxx:196) ==28574== by 0x4E467AE: osl_thread_start_Impl (thread.c:261) ==28574== by 0x5E53EFB: start_thread (pthread_create.c:304) ==28574== by 0x5B8E89C: clone (clone.S:112) Change-Id: I84aea49aff1dbc6c0d34e522d57d5af90eebfc62
2012-11-01Resolves: fdo#54466 right-aligned label text slightly clipped on rightCaolán McNamara
aae8a0c8ea27a1a6451c28d66de1ee7f0f0323ef with rather unhelpful "#99188# enlarge textrect to get rid of rounding problems" comment appears to be the root. Lets assume that commit is necessary and just adjust alternatively for right align Change-Id: I0b60c12199226ca757596c034599b81c1a4db433
2012-11-01Unit test for cache filtering, to secure the recent bug fix I did.Kohei Yoshida
Change-Id: Ie5068b45520b6c82af41062d97ec65d006b4b3ba
2012-11-01Revert cf0453d94b1af305ee385e9e2522bcc5e589530eJulien Nabet
After having talked about on IRC with Michael Meeks, it seems UX team prefers that way. In brief, it was on purpose. Thank you Michael for your time Change-Id: Ib99425a212ac5463b0465e1e755e2537bb4d51b8
2012-11-01Remove unused method in formula moduleMarcos Paulo de Souza
Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921 Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2012-11-01another some more regression testsCaolán McNamara
Change-Id: Ic13269fcf55b4e51a8124da6d2de75fb5bec23e0
2012-11-01add .odg regression load testCaolán McNamara
Change-Id: I5f7dc2a389c020a90b8087aefc90c054a809ef25
2012-11-01rework filters test to squeeze through extra flagsCaolán McNamara
that are needed to load .odt, .sxw etc files, and add a regression test for CVE-2012-4233 Change-Id: Ie178725ded3d76942030d12f23074de519cf62de
2012-11-01XubString->OUStringCaolán McNamara
Change-Id: Iea7d8681cdcd45d545826af63fc689640dfe29f0
2012-11-01valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: I7b59ddc4f9170c33e948f30194a662f27b871fcc
2012-11-01Don't let NSS use the MSVC debugging runtime in an --enable-debug buildTor Lillqvist
In an MSVC build, not exporting BUILD_OPT to the Mozilla build machinery causes the produced DLLs to use the debug CRT. The exact mechanism is a bit of a mystery, and I didn't feel like spending too much time trying to understand it. Using the debug CRT is confusing and wrong. Nothing in LO otherwise uses it. It also makes testing a build much harder for me at least, as I do that in a fairly pristine virtual machine with no MSVC debugging runtime available. (The normal CRT is bundled in the LO installer.) Change-Id: I27f774d92a3986d40162c870202bcdddd94aa7c6
2012-11-01add test for EBD-22330Caolán McNamara
Change-Id: Ifd59198a2d09e26377267c8b509c5340d83240e3
2012-10-31Rename the files to reflect the class name change.Kohei Yoshida
Change-Id: I6223cd12ab539cd19555c0b23f2bce73f519a31f
2012-10-31Rename ScDPCacheTable to ScDPFilteredCache.Kohei Yoshida
I always wanted to do this. The new name reflects what it really does better than the old one. Change-Id: I3c90cce06d482f1453936ff3916eef9663bb417b
2012-10-31Since the cache there is never NULL, let's take a reference instead.Kohei Yoshida
Change-Id: Idd3ca250ea51c9e17b4566febf13d9c8ca9c6a8f
2012-10-31The cache inside ScDPCacheTable (I should rename this) is never NULL.Kohei Yoshida
There is no point of having hasCache() method which always returns true. Change-Id: I309d3c33899cdab2049af5199ae8d41f7cbd5f99
2012-10-31These comments are no longer correct.Kohei Yoshida
They were correct up until IBM re-worked a whole bunch of stuff during the OOo 3.2 (?) development cycle. Change-Id: Ia9a9e30287f6c8451a6cfa98f3515d703e3c67cc
2012-11-01sal_Bool to boolTakeshi Abe
Change-Id: I10f8d534d664c5f27a32214c00aeee890d993d18
2012-10-31fdo#56627: Handle empty cell values separately in filters test.Kohei Yoshida
Perhaps this will make valgrind happy? Change-Id: I11f965d13f8d71b2ab9f9624367fd70713644f10
2012-10-31Use 'e' prefix for enum values.Kohei Yoshida
Change-Id: Iae3eceb38a6f9bc53805445799534ec8ee44a9a9
2012-10-31valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: I20bbd2d5ed7ba3c84ee33544f4a1a39c02729c23
generated by cgit (git 2.34.1) at 2025-01-01 18:32:19 +0000