summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-11-13-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I6bc93f212c687c908e68b2fbbced03f19f40844e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-13--disable-curl builds: split WebDAV-related JunitTests to fix checksMike Kaganski
Change-Id: I0a46dc226e141eb585817fff4871f8d1681a3f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-12tdf#158171: fix crash when double-clicking DeepL translation dialog OK buttonJulien Nabet
Change-Id: I4954357c59c7134d882fb19e9949ecbd5d60345a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12ScriptForge (SFDatabases) fix dates processing in GetRowsJean-Pierre Ledure
The database.GetRows() dataset.GetRows() methods return an array of data collected in a database table or query. When a column has the type DATE, the transmission of their values through the Basic-Python bridge require them to be converted upfront to UNO DateTime structures. The later conversion from UNO DateTime to the python datetime.datetime structure has been added with this patch. No impact on Basic scripts. The documentation does not need to be changed. Change-Id: I7a6533aff70d2d1402bfc3f057b65a4940148cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159348 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-11-12Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 5cb2f51e2711b1ec587694021376f3169246631b - Typo Change-Id: I4c44f68af3e8c15b715fd103a42f1f77fdcd1dcd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158815 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-11-12Fix some leading space inconsistenciesMike Kaganski
Change-Id: I548ec63d96a4d5e39fd29511c079b667915abb5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159345 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-12Gtk-WARNING gtktreestore.c:1047: Invalid column number 6 added to iterCaolán McNamara
since: commit 985b404f208559b4a91f31eb31dafa9d0384fdaf Date: Wed Nov 8 21:34:41 2023 +0100 tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog for Language - Writing Aids Page. Change-Id: Iff9ab545a5d212d004b55f5ceab11d4c9f6dee5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159341 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12resave with latest gladeCaolán McNamara
Change-Id: If01a98195581399e92b31cfe7caa4782a0b246a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159340 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12resave with latest gladeCaolán McNamara
Change-Id: I18c9a7c7fc5e86ef7faebc7273ca3b33d54a340c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12Gtk-WARNING Could not read property GtkBox:pack_type...Caolán McNamara
with value begin of type GtkPackType: Could not parse enum: 'begin' Change-Id: I27d74c4422eb4515c99a2ca834c62ef092ecf641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12Get the current view with SfxViewFrame::Current().Gökay Şatır
It was getting a null ptr for some reason. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Ib3e285dc86cd3918b631b6993e9afb221994bfab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158727 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 6c7fd1dc50cbc3f8e61c741367223a4b4aefc98b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12lok: a11y: corelog: removing LOK_INFO in attachRecursive (3)Marco Cecchetti
Change-Id: Ic2967d9fa24674ed61ab7a251bd2a584a74e4cea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158959 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 4e6848628cbff418896b7653eadac80c57ceaf25) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159336 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12lok: a11y: corelog: re-introducing LOK_INFO in attachRecursiveMarco Cecchetti
Change-Id: I5866e9990a4758fad4b1c2a5e26072c31658db89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158955 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit fd08e16e96cfd2d84b9eb4200f35fa6b4b4e3bd5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12lok: a11y: corelog: re-introducing LOK_WARN in viewshMarco Cecchetti
Change-Id: Ia76e079da1f532b0a4ce9ba24de1b058deef5a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158953 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 6a9c4306c9c8173ff99184199b18f24f05b35b51) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159334 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12lok: a11y: corelog: enable log in afterCallbackRegisteredMarco Cecchetti
Change-Id: I4706fc04ee651e46fb12fe0fa18dbf2762cf95aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158949 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 0e2df8c3f229e8807c7a6713ca3ea519411537bd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12lok: a11y: corelog: removing log from LOKDocumentFocusListenerMarco Cecchetti
Change-Id: I0194cd4548dbb44f9efce4c53c790c3eec938524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158940 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit e6caece707a7d6f3a3e397e6213be9af6054f148) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159332 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 72a81b01ebfa8e040433b6028b2177395d356a09 - Color Bar menu item is not in toolbars Change-Id: Iddf366cb873ae1c64f01bce5cc00ad525836dc99 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159342 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-11-11lok: a11y: implemented support for notifying core log to clientMarco Cecchetti
In this way core log can be printed to the browser console. This may help in understanding if some core event occurs earlier or later wrt a client event. Change-Id: I720ef9b149e98ddbc252aa069649019e79ef6cb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158780 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit d8dc138be7e69750d1a346b3b49cecc1201e8d46) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11[API CHANGE] Drop unused UserDefinedDriverSettings setGabor Kelemen
last mention of it was removed in 2009 by: commit b88a62cc97613e5dc00c806f59982cb57f9d1dc8 Change-Id: I9ab52b53bbbb77444f26e74c0cc76a78ec4c3c23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159298 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11sc: extend backcolor areaHenry Castro
If the filter background color is selected, the automatic selection area should include, the attribute of background cell color too. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I341c602247e7f71e3c9665e1b594177d8f5553b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158991 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 768433f07873eb608837630f85e7e1b375239fca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159238 Tested-by: Jenkins
2023-11-11[API CHANGE] Drop unused SpellAndGrammarDialogImage config keyGabor Kelemen
last mention of it was removed in 2011 by: commit da0bd7a50139b06e14c1917af044b37d10ebaf4f Change-Id: Iac4272025b0c995640a1da0f959cb7447d3c9b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158971 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused WriterCompatibilityVersion config groupGabor Kelemen
last mention of it was removed in 2013 by: commit f67d166b30dcba9e854716b29e1035693ef7481b Change-Id: I2207ce7a87805bb33bc3e81fd8da792ba033d844 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158976 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused kab.Driver config groupGabor Kelemen
last mention of it was removed in 2015 by: commit 72699595aaa3ecb8975050b6dfc6fde437770493 Change-Id: Iffdce3dfbabb20e92a61a0de83dfb4046ebb7ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158977 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused MozabDriver config groupGabor Kelemen
last mentions of it were removed in 2021 by: commit ee9ed2192b56c98e5b8ee9890ddb4c533117332a and in 2015 by: commit 4e3086da3e9873f53b5b9e1d5e511f9f77aaf62f Change-Id: Ic8c048f296c2c199fb43836a63a0c084196794cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158975 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused IncludedExtensions config keyGabor Kelemen
last mention of it was removed in 2018 by: commit e98bcfcc3cdad46620e3d59119b0ac262db88054 Change-Id: Ia36b86efcd47132dabc7206fd53a8661e013ac09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158970 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused ThesaurusDialogImage config keyGabor Kelemen
last mention of it was removed in 2011 by: commit b243afd8755c2a470c6aa0607f5773bedd026937 Change-Id: Ie48aecd0f2c30d7322dde774c84ce913a835a7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158972 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused PreventTips config keyGabor Kelemen
last mention of it was removed in 2012 by: commit 74970948bbd410278964bd02cb5741c6c87eb30d Change-Id: I1a576f94eca9ecb7fe0d580f50d20b1def79668e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158973 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused SimpleControlPoint LargeControlPoint config keysGabor Kelemen
last mentions of them were removed in 2011-2012 by: commit bbd638350fb83af2cadd85cdac2900de80bf7401 commit 6ea8ea456cf5df267284278ecda42aa9b089a682 commit ec4f69493b50c15861b0cdcc290ecedd00efb51d Change-Id: Iba3820806a761c12dead77ce6207c62f60f7055c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158974 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11find-unused-configkeys: check whether sets...Gabor Kelemen
are used at all, if they have an otherwise unused group as template TODO: Still gives some false positives if a group is only used as template of a set which is only used as template of another set which is actually used (MergeToolBarInstruction MergeStatusBarInstruction) Change-Id: Ia2f83c12a4e0bdcc88b1530bac4daaf456531f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159297 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11[API CHANGE] Drop unused ShowAlienFilterWarning config keyGabor Kelemen
last mention of it was removed in 2011 by: commit ebb3da4a2b47d719bce673ece53cd8ab09b361d0 Change-Id: I07a5e60f59781b9720543d436efede7b257cc872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159296 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-11ScriptForge (SFDatabases) new Dataset serviceJean-Pierre Ledure
A dataset represents a set of tabular data stored/produced by a database. To use datasets, the database instance must exist but the Base document may not be open. A Dataset instance is create either with - the (new) database.CreateDataset() method - from an existing dataset with the (new) dataset.CreateDataset() method. The proposed API supports next main purposes: - browse for- and backward thru the dataset to get its content - update any record with new values - create new records or delete some. In summary, the AKA "CRUD" operations (create, read, update, delete). The originality of the proposed API is the use of a dense syntax to make insertions and updates easy and readable: Example: (BASIC) Dim newID As Long newID = dataset.Insert("LastName", "Doe", "FirstName", "John") ' ... is equivalent to: Dim dict As Object, newID As Long Set dict = CreateScriptService("ScriptForge.Dictionary") dict.Add("LastName", "Doe") dict.Add("FirstName", "John") newID = dataset.Insert(dict) (PYTHON) - next statements are equivalent newid = dataset.Insert('LastName', 'Doe', 'FirstName', 'John') newid = dataset.Insert({'LastName': 'Doe', 'FirstName': 'John'}) newid = dataset.Insert(dict(LastName = 'Doe', FirstName = 'John')) newid = dataset.Insert(LastName = 'Doe', FirstName = 'John') You will notice that the returned value is the AutoValue primery key (when it exists) which makes it reuse as a foreign key immediate. The API is fully available both in Basic and Python user scripts. The new service will require its inclusion in the user documentation. Change-Id: I4f834c4234e5b96ec8fddfffbad791ecf31899df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159325 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-11-11On Linux dictionaries are packaged separatelyAndras Timar
Change-Id: Iadbd5a1411c3b2c72deb59ba91f86d889a34fdc3 (cherry picked from commit 135a474477d143ffbe877d95ba37c008c509e45f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11ofz#63845 Integer-overflowCaolán McNamara
Change-Id: Ic2396c92b53012642976e75fcfa42cf2737f3092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11Finally remove superfluous --with-theme=default optionMike Kaganski
... as suggested in commit 7524f45e0a2b86dc418f0eb76df89dbdbecfafd3 (remove superfluous --with-theme=default option, 2014-08-22). Change-Id: Iddd1e000039846023c3a4e2ebd73b0010d70c706 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159320 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11Simplify input theme filteringMike Kaganski
Change-Id: Iaa96feee79902f780409a19f97fed201793a66ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159319 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11When MPL subset needs to disable icon themes, suggest filtered inputMike Kaganski
A suggestion like "you wanted to have a, b, c, d; you need to exclude b; use e" makes little sense :-) Change-Id: I0212f0197b89c3e9d281fa5b24708672b82561b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159318 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11Remove exec bits on rtf fileAndrea Gelmini
Change-Id: I00f56edefeba01ab75fa504a074a5c99269bcef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159321 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-11Make the unit test linear and more explicitMike Kaganski
In the pevious state, the test would not even fail in case when import started to drop last paragraphs. Change-Id: Ic28d059ed41f88c9264743034a5ce5397fff0b2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159317 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11Fix Windows 64-bit build using VS 2022Mike Kaganski
... after commit fce18155052821756466ea043c638f4ed72f41d6, failing like C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x'] C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x'] C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x'] C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or 'built-in C++ operator==(int, sal_uInt32)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or 'built-in C++ operator==(int, sal_Int32)' C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int' C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color' C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or 'bool operator ==(T *,const VclPtr<reference_type> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or 'bool operator ==(const T *,const VclPtr<reference_type> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or 'bool operator ==(const VclPtr<reference_type> &,T *)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or 'bool operator ==(const VclPtr<reference_type> &,const T *)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color' C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or 'bool operator ==(const VclPtr<reference_type> &,const T *)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color' C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or 'bool operator ==(const VclPtr<reference_type> &,T *)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color' C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or 'bool operator ==(const T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'Color' C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or 'bool operator ==(T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'Color' C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color' C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int' C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: while trying to match the argument list '(int, Color)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x'] C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x'] C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x'] C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x'] C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x'] C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or 'built-in C++ operator==(int, sal_uInt32)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or 'built-in C++ operator==(int, sal_Int32)' C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int' C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color' C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int' C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or 'bool operator ==(T *,const VclPtr<reference_type> &)' C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int' ... Change-Id: Id976fe515287a4aa12d7ff8ca0ca09c31c65309f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159316 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11use more concrete type in ImpEditEngine::SetUndoManagerNoel Grandin
instead of dynamic_cast'ing to the type we want, and __ignoring__ the parameter if it is not, just adjust the type that we want, which luckily everything is already sending Change-Id: If083e11c9818cdcae199afc1261efbdb652e1c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-11Move user agent initialization to InitCurl_easyMike Kaganski
Places that didn't initialize it previously, would benefit automatically Change-Id: I2f1ff25fc58d9378462072bc92d7b37be2370fc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-11loplugin:fieldcast improvementsNoel Grandin
reduce false positives, and also check reinterpret_cast Change-Id: Ia6f214393f28451d18c16b764a3c2b149d29ba8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10tdf#158044 handling of paragraph attributes in RTF importOliver Specht
style attributes need to be repeated at the paragraph if not repeated then defaults have to be applied Change-Id: I4ee567e8006c240c046b7e7bb75eae92e5563776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158839 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-10Add missing license headersMike Kaganski
Change-Id: I4c94fb9d92b02b42b185d205887fa7bce1c45be6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10Fix packaging with --enable-mpl-subsetMike Kaganski
Change-Id: I1cae9e9a9837df968663b6f46bd1e0d369377126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159308 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10Fix packaging with --disable-curlMike Kaganski
Change-Id: I9c3c1f1953c4d59c5a2d4c6017e73768d93a7bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159307 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10Improve error logging in remove_Files_Without_SourcedirectoryMike Kaganski
Change-Id: I7ed7c08bd57bb5d1b11bc7c029decd571a6758f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10Fix the fixMike Kaganski
Commit 87f0da8023081398d72372367db11d4a97d91833 put the check into a wrong position Change-Id: I459c11e00babfc604c5d35aac4f7cd0ce3701c3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159237 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-10ofz#64065 Abrt on configCaolán McNamara
Change-Id: Idb76d58ab6036c9f38b0b76a3a240dcfb07d52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-10tdf#158169 take no actions in disposed incarnationArmin Le Grand (allotropia)
Using the described steps in the bug report it is possible to have an already disposed incarnation of ChildrenManagerImpl that gets called with notifyEvent. If exposed it is necessary not to execute actions, but to inform the caller by triggering a lang::DisposedException(). The SfxBaseModel::notifyEvent that executes this will then remove the instance from it's list. Change-Id: Ie39e37d6e55ea66f441e732b612774b18d7c3ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159306 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>