summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-25loplugin:casttovoid (clang-cl)Stephan Bergmann
Change-Id: Ic85ec91c64df6b28ca0d6fd8103c0997f61e852c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117837 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-25loplugin:finalclasses in svxNoel Grandin
Change-Id: I7dd8d1a900694687fbed3f3f29b0ea4bb11b7d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117790 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-25No need for a std::string_view hereStephan Bergmann
...where proc.name is of type OString. (Following up on eebd84b337506c8fff151493f9b51bd127dbc89f "loplugin:stringview (clang-cl)".) Change-Id: I9e465b431f253d316e8dbff26e6768f5544e91f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117835 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-25tdf#58250 - Show custom unicode separator in the csv import dialogAndreas Heinisch
Change-Id: I5924ba3c5b0b96a744e2c2e63632b383b371e485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117766 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-25gtk4: split out clipboard_content headerCaolán McNamara
Change-Id: I1b820c1cef2cc76a5fc748574c36ebdd4b28eef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-25tdf#143032: Check if the literal is emptyMike Kaganski
Change-Id: I19a3b1abbe9cda32e012be23fc98baa20108f532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117723 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-25gtk4: use css-cursors where it seems to fitCaolán McNamara
see: https://drafts.csswg.org/css-ui-3/#cursor and: https://bugzilla.gnome.org/show_bug.cgi?id=652085 Change-Id: I990b807b685283e12785c90c90cd0f8e658b062e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-25loplugin:finalclasses in sfx2Noel Grandin
Change-Id: I8125d5447e13a6dadfde9c19c8cab6004693589a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-25ScriptForge - (SF_Platform) new Printers propertyJean-Pierre Ledure
The SF_Platform.Printers property returns the list of available printers as a zero-based array. The default printer is put in the 1st position of the list (index = [0]). The property is available in Basic and Python. Change-Id: I3f02b1b5e37aa9866491d9285683fc45d17fb664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117776 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-06-25tdf#143047: When no properties for command, use those from item containerMike Kaganski
This allows to use the "Label" property defined by user for macro items, that indeed have no built-in command properties. Thus the resulting tooltip will be a concatenation of the label and mnemonic instead of only mnemonic as happened before. Change-Id: I79d933fecd09ca7d64b7a3e7db0ef194e42c1c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117787 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-25tdf#124176 Use pragma once instead of include guardsHarshita Nag
Change-Id: I5f0342f07f9227e45ef12c3c76015aeee4c2a0c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117833 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-06-25python3: update to 3.8.10Jan-Marek Glogowski
So we don't build 3.8.8rc1 anymore. I didn't look into 3.9. Change-Id: Ife7d898c913b9b164168b0ef23a055deea55815f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117757 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-25Resolves tdf#125868 - Insert dialog text in case of RTLHeiko Tietze
Change-Id: I28725b2ec685b320fd68117109bdeaa00db55a35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117740 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-25NFC: cleanup unnecessary variables, reduce scope.Justin Luth
This function look a LOT different way back at original import, and some of the refactoring since then left things a bit messy. The impetus for changing this was to see how m_nListLevel was being used, and having it assigned to a temporary const variable for no reason was annoying. Change-Id: Ia25397dbe4bce2fd7bdfbb1b3053bd271c08212a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114404 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-24cross-toolset: fix real cross help buildingJan-Marek Glogowski
Regression from commit 14069d84174ca7a4e60db4d75912903e9679b643 ("configure: Improve help-options handling"). We now must forward the help and extension configure options, as this is needed by the cross toolset to know, if it needs to build the HelpIndexer and HelpLinker executables. Also get rid of gb_Helper_optional_for_host. While it's in theory more correct, it makes gb_Helper_optional more complex, so we now rely on the fact, that the config_build.mk BUILD_TYPE is a subset of the config_host.mk BUILD_TYPE. This should fix the Windows Arm64 build, which currently seem to be the only cross-build including help. Change-Id: I8b90923c891b43cd2655b2578015c9bd579aae7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117758 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-24Revert: svp: always release SolarMutex on yieldJan-Marek Glogowski
Keeps the SolarMutexReleaser replacement. Seems a real fix for the original busy-lock problem needs further investigation. This reverts commit b9ea3467383ccdfe4be842e61267256f281487ee. Change-Id: I4bf6157e7236c30ecbf0b710d8bf9dc39d9ae5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117795 Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-24uitest: sc: move csv dialog tests to their own moduleXisco Fauli
Change-Id: Ib8456cb77b1c147856f378eb6198f69d380e18c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117775 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-24tdf#120629 ms formats: better exporting of hindiVowels etc.Justin Luth
The big problem was that hindiVowels was imported as CHARS_NEPALI, but CHARS_NEPALI was not exported in DOCX. Another easy win was to DOC export both LO forms of russianLower and both forms of russianUpper - just like DOCX. The page number field only allows a subset of formats. LO doesn't have support for Hex or DollarText formats. The Ordinal/Cardinal formats were an easy win for export, even though they don't import. [Import seems to be in ww8par5.cxx's GetNumTypeFromName(), except that is being passed an empty string.] Change-Id: I176a70e0e05967414337c17d8b4acc87e20ead73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117793 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-24gtk4: track underlying surface state for maximized/minimizedCaolán McNamara
Change-Id: Ia62d12f367555b409cb2a6ed491f65dca34baed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: start with initial window state of all unset bitsCaolán McNamara
Change-Id: I36fd31253a61308b2cf84d48d3e963af6c49118f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117783 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: finish dnd targetCaolán McNamara
we want to work with a GdkDrop not GtkDropTargetAsync to get the behaviour we expect Change-Id: If1f0904fec3a0bfd6dfba770db6c11774e4d23a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117774 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: gdk_drop_get_actions is a better matchCaolán McNamara
Change-Id: I3442f3498f83da8d4eef3004b79925099dd1306d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: unhighlight the parent like gtk3Caolán McNamara
Change-Id: I47a7a6f8e42d9032a9acfdda9376ef05e30e3e73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117771 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk[3|4] set what widget to highlight during dndCaolán McNamara
Change-Id: Iba808b2f11615a25463c2739e6347f3cc2a91bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117770 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: merge some common dnd and cnp blocksCaolán McNamara
Change-Id: I195eb7ae3fda492a36423f57139550cb7fef9b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117765 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24drop text_transfer_result and merge dnd and paste logicCaolán McNamara
Change-Id: Ia91e961d2d94bbd4baeb81647438a4026a4fce60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117764 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: reuse read_block_async_completed from dnd for cnpCaolán McNamara
Change-Id: I1acfa4c48ee59fd79b4a4b32afa732feef6348c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117761 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: simplify dnd "drop" signalCaolán McNamara
Change-Id: I2d4714194516c6b8270fa96c8c5a6b75d2d10b86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117760 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: unref stream when done with itCaolán McNamara
Change-Id: I3cb11918f0e85fcbc9557dc0211bc10f819f9064 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117749 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24gtk4: get dnd drop into LibreOffice from another app workingCaolán McNamara
Change-Id: I9519af009b479e51a3da556f26f3950c4930d618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117611 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24BmpScaleFlag::Super is deadNoel Grandin
ever since commit 2269ac65de127d33d41843ae15f6bece5bc778bc Author: Michael Meeks <michael.meeks@collabora.com> Date: Fri Nov 7 05:42:51 2014 +0000 icontest: remove hand-coded opengl path. Change-Id: Ida030be0e087353e20897a9e961c9ce1134b21e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24remove uno::Type move constructorNoel Grandin
not necessary for the optimisation I was going for, and actually less efficient than just using the copy constructor Change-Id: I0f2019a0bf032283fb6c8d5d834603ea7a5ce3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117762 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24Handle fancy webdav URI schemes on all platformsThorsten Behrens
Change-Id: I5cc16b0fdaf032e90aa0361df6f33c04a615abab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108016 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-06-24tdf#104239 doc import: accept outlineLvl0 == (listLvl = MAXLEVEL)Justin Luth
If listLvl is undefined, it is treated as level 0, so when testing that outlineLvl is equal to listLvl, then consider MAXLEVEL to be equivalent to zero. The opposite is not true. An undefined outlineLvl is not considered to be level 0. This doesn't fix bug 104239, but it is one step in the right direction. Two unit tests followed this path, (transparent-text.doc and tdf80635_pageLeft.doc) but neither one sets a numbering style, so they don't make good unit tests. Change-Id: I62cd7f5500fcd6dc06327900c33f12c129610a04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117745 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-24tdf#46626 Don't include footnote numbers in Navigator headingsJim Raykowski
Change-Id: I8c655c6ed1e1d05407dac27ef19f26c6ca8d8d54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117692 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-06-24tdf#142793 chart UI: fix option "Secondary Y Axis" on sidebarBalazs Varga
Attaching a data series to the secondary axis didn't enable the secondary axis at the right side of the chart using the sidebar (unlike in data series local menu -> Format Data Series... -> Options). Test: Click on the chart, select one of the data series, and enable Data Series -> Align Series to Axis -> Secondary Y Axis. Change-Id: I2cb99458af724471d4d04cac8c2c9013f41634fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117048 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-24Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 491af494a983aea54a24d68ff1bc1703d21f0a6c - update translations for 7.2 / master and force-fix errors using pocheck Change-Id: I5f3256dc0a6c1ada3a9a2358b3d4aba8f84b7252
2021-06-24Fix presumed race between executeAction and following asserts in UITestStephan Bergmann
...where I had observed UITest_calc_tests failing at least once with > ====================================================================== > FAIL: test_delete_more_sheets_at_once (calcSheetDelete.calcSheetDelete) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 107, in test_delete_more_sheets_at_once > self.assertEqual(document.Sheets.getCount(), nrSheets) > AssertionError: 7 != 1 > > ====================================================================== > FAIL: test_tdf105105_delete_lots_of_sheets_at_once (calcSheetDelete.calcSheetDelete) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 130, in test_tdf105105_delete_lots_of_sheets_at_once > self.assertEqual(document.Sheets.getCount(), nrSheets + 100) > AssertionError: 100 != 101 > > ====================================================================== > FAIL: test_tdf114228_insert_and_delete_sheet (calcSheetDelete.calcSheetDelete) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 37, in test_tdf114228_insert_and_delete_sheet > self.assertEqual(document.Sheets.getCount(), nrSheets) > AssertionError: 2 != 1 > > ====================================================================== > FAIL: test_tdf43078_insert_and_delete_sheet_insert_text (calcSheetDelete.calcSheetDelete) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 62, in test_tdf43078_insert_and_delete_sheet_insert_text > self.assertEqual(document.Sheets.getCount(), nrSheets + 2) > AssertionError: 2 != 3 Change-Id: Id757571c153b3305644f8e4a099c4dc31bca3c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-24should be using upper_bound hereNoel Grandin
after commit 1feb59c3dd9e5f714ce894f8de31bbb6869c9f3b Change-Id: I5dde1a776c11b9755e33cd7ccae54f29045b5ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 01e2e91dcfb2a6d07eec0f9188189213fa464592 - Fix localization in SF_Calc help page This patch silences a few strings for translantion. It also rephrases the first 2 paragraphs of the Calc service that were inaccurate. Change-Id: Ic2ce5e2c5e53134d80717cd97f63bec4bd726a9b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117641 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-24Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 00086866ecd2de7434f851bc4f5fdc8195b5f262 - Fix localization in SF_Base and SF_Basic Change-Id: Ibcd3826af1a89704bf32db833af63fb0b9564cb1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117568 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-24Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to a97fbc6bbfbfa214083615868ffccd3ccebf5d37 - Fix localization in SF_Document help page Change-Id: Ie1fb122ca7574aa28ab199ebebbba76975389fa2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117722 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-24breakpad: don't include the users's env in linux dumpsChristian Lohmaier
Change-Id: I004b862295686789c0a88dc678bd098d81c76421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117503 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-06-24tdf#135316 bypass 'existing style' check when importingNoel Grandin
trust the import filter to have already de-duplicated styles Shaves 5% off my load time Change-Id: I36b5196762483f629a38e00156d2fe9a1cb28c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24tdf#69207 - Use selected text delimiter to parse the provided csv dataAndreas Heinisch
Change-Id: Ie260cb57956cd450398746c7f51629d37d14a324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117750 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-24rename read_paste_result to read_transfer_resultCaolán McNamara
we'll reuse what worked for clipboard for dnd Change-Id: If8accc2d236253a734f48929e231bcecbb00741f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24error: unknown type name 'OStringBuffer'Caolán McNamara
Change-Id: I28a4a2581e6afb02aeb137932fbf884b109e4b5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24uno::Type needs a move operatorNoel Grandin
speeds up some operations where Type is stored in a vector Change-Id: Id7112e51d4e4707bc6d261313e994c6ffef54d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24SAL_WARN -> SAL_INFONoel Grandin
calling code is quite happy with this function returning a nullptr Change-Id: I79e6be31b6c30ee103a8dd0cba9e652ba93b744b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-24tdf#123405 doc import: inherit from all Outline stylesJustin Luth
Good - an example document that proves that inheritance needs to happen with more than the first 9 items which contain the Heading styles that are most often associated with Chapter Numbering. Change-Id: I69ab1dd3fdab4d54695d9b321b0d2970509090a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114403 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>