summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-28drop some unnecessary includesCaolán McNamara
Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#112215 null deref on missing optional ppd valueCaolán McNamara
Change-Id: Iba45437332df963e1aa213c587071ab293f36390 Reviewed-on: https://gerrit.libreoffice.org/64163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#121752 let scroll wheel change active notebook tabCaolán McNamara
Change-Id: If8437346a58ea14266f11293b94082740303e5a9 Reviewed-on: https://gerrit.libreoffice.org/64158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Let distclean remove all of generated config_build/ treeStephan Bergmann
Change-Id: I8d12454003c0bd23170007e30f96016b47820f5f Reviewed-on: https://gerrit.libreoffice.org/64157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Do not validate SSL cert in LOK caseAndras Timar
Currently we cannot tunnel interaction handler dialog, so if there is a problem with site's SSL cert, the operation (e.g. insert image) would silently fail. As a workaround, let's not validate the remote site's SSL cert, as we also do not validate the site's SSL cert when we download the file through WOPI from the site, in the first place. So this patch does not really make things worse, but makes it possible to use the insert image feature with a self signed cert in test environments. Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878 Reviewed-on: https://gerrit.libreoffice.org/64154 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-28On Windows, check for at least Visual Studio 2017 version 15.7Stephan Bergmann
...to further restrict the Windows MSVC baseline to not just VS 2017, but to the latest update (as the various updates bring significant improvements for C++11/ 14/17 support; see the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html> "Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)"). Change-Id: If6a1b62da1691ae8ae19edb4ed7b35e4b6e46501 Reviewed-on: https://gerrit.libreoffice.org/59209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Resolves: tdf#121746 block toplevels from closing...Caolán McNamara
while the extension manager is querying via a dialog. Reuse the isBusy for this. Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280 Reviewed-on: https://gerrit.libreoffice.org/64155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#94446 if this is a SQLException in disguise, throw that insteadCaolán McNamara
instead of the wrapper exception, so that dbaccess can apply its special handling for SQLException::ErrorCode of dbtools::ParameterInteractionCancelled in OLinkedDocumentsAccess::open if ParameterInteractionCancelled was the root cause Change-Id: I777893cf7355d8c4a9c48237284903176d81402d Reviewed-on: https://gerrit.libreoffice.org/64123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Require at least gperf 3.1, which no longer emits "register"Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..." Change-Id: I47b6d4a7b8370262ca942b4385e2c0e6f0adc613 Reviewed-on: https://gerrit.libreoffice.org/63953 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Require at least flex 2.6.0, which no longer emits "register"Stephan Bergmann
...according to <https://github.com/westes/flex/blob/ 83d5d1695a2ab1d69ea4d8e7df27146c644876fc/NEWS>. Its use is no longer allowed in C++17, so will start to cause build failures once we restrict builds to at least C++17. (The situation with gperf is similar, but instead of checking for a minimal known-good version that no longer emits "register", we instead check for it indirectly in configure.ac, by creating gperf-produced conftest.inc and including that in the program used to test which -std= value to use. We could have done something similar for flex, but creating suitable flex output for inclusion might be more work than it was for the simple gperf case.) Change-Id: I662c6795ea5fde1420d9712c0ec910c0cadbc350 Reviewed-on: https://gerrit.libreoffice.org/63713 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28-Werror=unused-but-set-variableNoel Grandin
after commit 19c56b3befae3a23f42f981de5057de380b4c5a0 loplugin:unusedfields in sw Change-Id: I67314e86695a399fd211a64bdcf4cc3f18ca133d
2018-11-28Related: tdf#121629: Some menu items do not follow the Title Case ruleSabri Unal
Change-Id: I6b071365ee1531c3ddba70a25e36d6bd98561ffc Reviewed-on: https://gerrit.libreoffice.org/64135 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121797 XHP extensions (Help part) WIP. This is the Help part. Extend the XML parser to include new incantations of the <paragraph> tag, namely <h1> to <h6> <note>, <tip> and <warning> Extension to the <item> tag: <menuitem>, <input>, <literal>, <widget> and <keycode> * removed test files Change-Id: I2a473ee8772606f5e84bb02e651bccc6749598f4 Reviewed-on: https://gerrit.libreoffice.org/63954 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28tdf#121697 XHP extensionsOlivier Hallot
This is the core part of the bug, and is WIP Extend the XML parser to include new incantations of the <paragraph> tag, namely <h1> to <h6> <note>, <tip> and <warning> Extension to the <item> tag: <menuitem>, <input>, <literal>, <widget> and <keycode> Change-Id: Idaed321cc8756fa6bcf4fbc170982365ff33d4d7 Reviewed-on: https://gerrit.libreoffice.org/63955 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121736 initial Help pages for Python scripts Work in progress, initial addition of help pages for python scripts in LO. Change-Id: Iee95b1340c821fdb08524fdedeca3817b0de1459 Reviewed-on: https://gerrit.libreoffice.org/64137 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28slideshow: get unit tests to work againThorsten Behrens
Change-Id: I7b5c7a20677ac0f720b41daf8ca59c3cc94f1283 Reviewed-on: https://gerrit.libreoffice.org/59964 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-28loplugin:unusedfieldsNoel Grandin
Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Resolves: tdf#121695 call save_valueCaolán McNamara
so get_value_changed_from_saved detects no-op Change-Id: I2b72bc7a6bc4093f9d942aa56f90542521e23cd9 Reviewed-on: https://gerrit.libreoffice.org/64130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28loplugin:unusedfields in swNoel Grandin
Change-Id: I7a9184511df96bf2a6c40e39091010a7e2974ed6 Reviewed-on: https://gerrit.libreoffice.org/64143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28tdf#90333 Dictionaries Path Cannot Be ChangedCaolán McNamara
PathSettings::impl_storePath wants to be able to nil the Dictionaries path in the old copy of properties Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f Reviewed-on: https://gerrit.libreoffice.org/64115 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28sw RtfStringBufferValue: make members privateMiklos Vajna
Change-Id: I82f8e96901312e91bbc9a2b5c93bea02e180e907 Reviewed-on: https://gerrit.libreoffice.org/64133 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-28oox smartart, accent process: handle followSib axis of forEachMiklos Vajna
Currently the accept process document creates 0 connectors. Instead, it creates empty custom shapes: this commit fixes the loop, so that only one of them is created. The whole purpose of the follow sibling axis is that N - 1 connectors are created for N shapes, not N connectors. Change-Id: I54244c7615b83f607ef53a4ff8d01d3c9594856e Reviewed-on: https://gerrit.libreoffice.org/64122 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-28loplugin:unusedmethodsNoel Grandin
Change-Id: Idbdf2d5d12fad894a3dfc3a86cae839502f42cf6 Reviewed-on: https://gerrit.libreoffice.org/64114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Colibre icons: add impress Slide tab iconsandreas kainz
Change-Id: Ia3d035d827c0f1b510f9ff3be8652f5bac69cead Reviewed-on: https://gerrit.libreoffice.org/64136 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-27Use HiDPI scaling to load scaled images.Michael Meeks
We render these at apparently the same pixel size as normal images, but the underlying canvas is larger so these then end up pixel-matching the true underlying grid. Change-Id: Ic4b749127e9c81da78d06b34d9f88c5635dc64b9 Reviewed-on: https://gerrit.libreoffice.org/64044 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27weld DataSourceDialogCaolán McNamara
Change-Id: I4d3eb8aa354043d3ff57b4996db7b28ad25e0262 Reviewed-on: https://gerrit.libreoffice.org/64072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27enable hiding gtk dialogs without ending their dialog loopCaolán McNamara
we need this to support reshowing dialog after an intermediate range selection dialog executes Change-Id: Ib6575e5d852bd1d29cc1a791a5dc2c19949b67a0 Reviewed-on: https://gerrit.libreoffice.org/64100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27Related: tdf#94446 set parent for dialogCaolán McNamara
Change-Id: I174ec605f40e7cafbcb44e492941dfc36a4df3f2 Reviewed-on: https://gerrit.libreoffice.org/64120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27Related: tdf#94446 don't assert on unsetting focus handlersCaolán McNamara
Change-Id: I7817f66974807eaf7d16a6d0dc30b4fbd6d366a5 Reviewed-on: https://gerrit.libreoffice.org/64118 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27Remove --enable-c++17 optionStephan Bergmann
...reverting 0f3b0ec973f06a98c75ef8acfa720a9973e4d2b5 "Avoid C++17 mode for Coverity Scan". As far as I understand, <https://lists.freedesktop.org/archives/libreoffice/2018-November/081454.html> "New Defects reported by Coverity Scan for LibreOffice" has been run against dd0e6849297c18aabe4fc29c0340a2ed1e474eaf "Temporarily drop --disable-c++17 from Coverity builds" but doesn't let issues like the one discussed at <https://lists.freedesktop.org/archives/libreoffice/2017-November/078966.html> "Re: New Defects reported by Coverity Scan for LibreOffice" reappear. So disabling C++17 for Coverity Scan builds appears to no longer be necessary. Change-Id: I22bfd9ad61da00e942a87aa5e1e0d1fab0004d49 Reviewed-on: https://gerrit.libreoffice.org/64121 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2018-11-27loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3e6424e10eade04951f8ab24bb61af4ce19d1204 Reviewed-on: https://gerrit.libreoffice.org/64113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27add EvaluateAsInt compat function for latest clangNoel Grandin
the old EvaluateAsInt method has been dropped as from current clang Change-Id: Ie30d1547ad8de777badff4b380d2fc9fb261e8fe Reviewed-on: https://gerrit.libreoffice.org/64107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27missing declarations/includesStephan Bergmann
Change-Id: I3a9b99011467bdfe34825da24ffdf9179a3bb194
2018-11-27KJ+elementary: Sync with ColibreRizal Muttaqin
Change-Id: I1d569983551d27b59fccfab84c0fc7b6bd86dc77 Reviewed-on: https://gerrit.libreoffice.org/64098 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-27Prepare to bundle the Liberation fonts with the iOS appTor Lillqvist
The way the iOS app is built (over in the online repo), any "resources" to be included need to be copied into the workdir/CustomTarget/ios folder. Change-Id: Ibac15b03dc447d6649e03404fe9a68ef3b4881b9
2018-11-27tdf#112195 Writer: page background covers whole pageLászló Németh
as in ODT implementation of Google Docs, and as in DOCX supporting basic requirements of creating digital and professional print media. This patch fixes DOCX import (tdf#121668) and it gives the required PDF export, too. In the case of solid color, color gradient, hatching, pattern and tiled bitmap (except stretched bitmap), this patch removes the obsolete white border around the text area, if the user modifies the page background. Note: likely the white border was good for home printing in former times, but now it forms only a serious barrier for most users to create de facto design standard whole page background formatting instead of its unacceptable poor man's version. Note 2: the OpenDocument standard refers XSL/CSS here, and browsers adapt background settings to the body margin area the same way, as Google Docs and fixed LibreOffice do. More information: tdf#112195 "(Whole-Page-Filling) - Allow page background to cover the whole page (reloaded)" tdf#33041 "Allow page background to cover the whole page, not only within page borders/margins" tdf#121668 "FILEOPEN DOCX Page Color created with Word disappears on the margins" ooo#9370 "Off-margin page background" (https://bz.apache.org/ooo/show_bug.cgi?id=9370) Change-Id: I7c6c96ceaf7102b38e3e5c1ed767db0ee63520ab Reviewed-on: https://gerrit.libreoffice.org/63914 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-11-27remove unused BorderWindowStyle enum valueNoel Grandin
Change-Id: I05ae398b75bbafe9b144a90e6735cf7d5e532ce4 Reviewed-on: https://gerrit.libreoffice.org/64097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27convert treeview::TVDom::Kind to scoped enumNoel Grandin
Change-Id: Ia505df60f5758d40dd55bc5b24886fd8aec327ce Reviewed-on: https://gerrit.libreoffice.org/64092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused EEControlBits enum valueNoel Grandin
Change-Id: Ic363903bb6e32c029f5aac6810f69d590df1bf79 Reviewed-on: https://gerrit.libreoffice.org/64091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused EVControlBits enum valuesNoel Grandin
Change-Id: I4e10f0a2f40f9e7b6cc40a810468f43b2ab97aa9 Reviewed-on: https://gerrit.libreoffice.org/64090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SfxObjectShellFlags enum valuesNoel Grandin
Change-Id: I945047c0955bc66602d1a5033197a7405a69a8d3 Reviewed-on: https://gerrit.libreoffice.org/64089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused GraphicsStateUpdateFlags enum valuesNoel Grandin
Change-Id: I1a83c897d93a29d38aebccdba33be7b70592922e Reviewed-on: https://gerrit.libreoffice.org/64096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SfxViewShellFlags enum valueNoel Grandin
Change-Id: Ie754752203dcb066c69dff6effb835d7e1db1753 Reviewed-on: https://gerrit.libreoffice.org/64088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused enum storeAccessMode valueNoel Grandin
Change-Id: I88a53e285cc3e8b6cc1c67b1e56322a918554de6 Reviewed-on: https://gerrit.libreoffice.org/64087 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused BrowserMode enum valuesNoel Grandin
Change-Id: I46eb4145bd79253c1c20b7a03d82b6873402d9ac Reviewed-on: https://gerrit.libreoffice.org/64086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SvxIconViewFlags enum valuesNoel Grandin
Change-Id: I31f810383fb92b2d0dbe9fa9162b77f137154e91 Reviewed-on: https://gerrit.libreoffice.org/64085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused RulerBorderStyle enum valuesNoel Grandin
Change-Id: I4f10e323293485e7a1969fd4c80873aa05971e6c Reviewed-on: https://gerrit.libreoffice.org/64084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused SvxLanguageListFlags enum valuesNoel Grandin
Change-Id: I89a6244c01be811bfdfc443f687708ed6aec8a10 Reviewed-on: https://gerrit.libreoffice.org/64083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27Add explicit API scaling via ImageTree API.Michael Meeks
Also add image scale to in-memory cache lookup. Change-Id: I1e84b922d4a9ab2f1723c5cb8a72f295c6940504 Reviewed-on: https://gerrit.libreoffice.org/64043 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27Preserve stock images until render time.Michael Meeks
This allows us to choose to render HiDPI images at the right time, when we have the DPI of the device to render to. The first step in a better, and more industry standard way of improving our UI for HiDPI via rendering level scaling that should retain a consistent look across the app with many fewer changes. Change-Id: I36681f3242cb650de4f0b2d0fcdffbe5618e30fc Reviewed-on: https://gerrit.libreoffice.org/64040 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-23 15:45:44 +0000