summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-02no need to allocate TargetsTable separatelyNoel Grandin
Change-Id: Ifc16a5c7137776c8375d83afb031999023a7424a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-02Fix viewsettings countSamuel Mehrbrodt
Was missed in d0cacf09a1105d89bf3df84b18623d790e3aeb82 Change-Id: I43c1c9b595a8fc8e2982027093695556e182074e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148081 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-03-02sw floattable: don't leave body in SwFrame::GetNextFlyLeaf()Miklos Vajna
- assert IsFlySplitAllowed() in SwFrame::GetNextFlyLeaf(), since the only caller is SwFrame::GetLeaf(), and it only checks this - extend the conditions where we reject a candidate, make sure that a master fly anchored in the body can't have a follow fly anchored in a footer - with this, the bugdoc is now of 2 pages, but still the position of the follow is incorrect Change-Id: Ibb02fe9cf741eecd60103179abcb44cee14e924d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148082 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-02Record loplugin:unreffun false positive caused by a Clang bugStephan Bergmann
(see the comments at <https://gerrit.libreoffice.org/c/core/+/146634/7#message-5164bcbdb4efa4711f001ce05b670b592392d853> "test: Use css::awt::XExtentdedToolkit::addTopWindowListener()" for how this caused an issue in the wild) Change-Id: Id5ec77885db45d039aedc7e13d714aaa96572e91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148076 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-02sw: fix undo comment of FN_UPDATE_BOOKMARKMiklos Vajna
It's an update and the name was not set. One has to dispatch .uno:UpdateBookmark to see this in action, which does something if the cursor is inside an exiting bookmark. Change-Id: Ib9c54a28c5410cc001468952cfd8577a9412d664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-02BaseMutex->std::mutex in SlideShowListenerProxyNoel Grandin
Change-Id: Iab518e2cb994372b5d601c5cd569f07531499804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-02BaseMutex->std::mutex in AccessibleSlideSorterViewNoel Grandin
Change-Id: I8aeb0d5ec44a938e58475368a3bf4ae60034042d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-02BaseMutex->std::mutex in DrawSubControllerInterfaceBaseNoel Grandin
Change-Id: Iba2bee0feeea7cd176c178ae20e6dfce1fe4af19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01tdf#62032 sw: make List Level UI experimentalJustin Luth
I think the UI is working fine, but now LO is doing things that it never used to do, so not all interactions are working properly - so hide the ability for now. Specifically, when changing the list level in a style, it is not being applied to the existing paragraphs. It only applies when the style is removed and re-added. Change-Id: I092ac0e5ec7bf296d1f3b62b75d4f7209db00045 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148066 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-03-01tdf#62032 sw: let paragraph UI set List LevelJustin Luth
In order for this to be at all useful, we need to be slightly confusing to the user by equating both of Outline Level's "Body Text" and "1" with List Level 1. So, while outline levels can be "turned off" with "Body Text", a user cannot "turn off" a list level, even though the listbox has the choice "same as outline level". The way to turn off the list is to pick "No List" in the other list box. That situation (Outline = Body Text, ListLevel = 1) is the default situation, and so if we don't make that connection, then the whole intention of STRONGLY advocating for keeping the two values in sync will be lost. Note that both selecting "No list" or changing list level in a style does not have immediate effect. It only applies when the style is assigned, not modified. (I assume this is because of internal auto-styles which are not being updated when the underlying style changes?) [Because of this "strangeness" a follow-up commit will make this an experimental feature.] Change-Id: Ib6a47b3265ccf71f45a43ce6f10b780b995c231d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148027 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-03-01CppunitTest_sw_rtfexport5: split in twoXisco Fauli
it already has 121 tests Change-Id: I7d7726b9f1c65d3f719517ab1a568cd888b2833b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148042 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01cid#1521560 Division or modulo by float zeroCaolán McNamara
and cid#1521558 Division or modulo by float zero Change-Id: I42a82f294950ea22a2557f76d4589b06b50d9d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148071 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01tdf#153784 account for initial vertical offset when toggled into multilineCaolán McNamara
Initially there is 1 line and the edit is vertically centered in the toolbar Later, if expanded then the vertical position of the edit will remain at that initial position, so when calculating the overall size of the expanded toolbar we have to include that initial offset in order to not make the edit overlap the RESIZE_HOTSPOT_HEIGHT area so that dragging to resize is still possible. Change-Id: Ic99e1cf4f3b1ca53c5d6feaa50d8bfac030f8124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01assert that Mutex exists at ctor timeCaolán McNamara
and drop the never can be hit throw Change-Id: I74c92f1ff50ef0f3f6f78a53057f121a3665ec3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01cid#1521559 pass arg as ref to prove no Dereference before null checkCaolán McNamara
and cid#1521561 Dereference before null check and drop pointless null check Change-Id: I2e99733eb5f1861bb02f6d8ec7a44ace4ded16cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01Related tdf#153344 - Resize Save icon in statusbar to 18pxHeiko Tietze
Also removed the "_14" from the yes/no icons Change-Id: Ic43219fe0e4555416b78831d45f9edc8060f73cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148063 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-01ofz#56382 sw: HTML import: init items with WhichIdMichael Stahl
(regression from commit db115bec9254417ef7a3faf687478fe5424ab378) Change-Id: Ib4865ad1423f0dafb20b376a9d00eaf450b8f271 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148049 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-03-01Teach INetURLObject about RFC 7230 URLs with no path but queryStephan Bergmann
While RFC 2616 "Hypertext Transfer Protocol -- HTTP/1.1" defined > http_URL = "http:" "//" host [ ":" port ] [ abs_path [ "?" query ]] RFC 7230 "Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing" defines > http-URI = "http:" "//" authority path-abempty [ "?" query ] > [ "#" fragment ] Change-Id: I83b1baa404d28bf3b28b1db812f8930bbc1aaf90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148064 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-01Remove duplicated includeAndrea Gelmini
Change-Id: I267f3655dcc41613db9de4952beceb34dffefbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148061 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01tdf#153669: sc_uicalc: Add unittestXisco Fauli
Change-Id: I2bf478ea4f0d1a35def2455ec1e6480170c9f1ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148047 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01Re-enable Skia in Flatpak buildsStephan Bergmann
...as requested at <https://github.com/flathub/org.libreoffice.LibreOffice/issues/213> "Can Skia be reenabled in the Flatpak build?" and implemented on Flathub for now with <https://github.com/flathub/org.libreoffice.LibreOffice/commit/372d036e9113b6080780669ad44fc11a172356ed> "Re-enable Skia". (This partially reverts 9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4 "Flatpak: Upgrade to 21.08 runtime, disable Skia".) Change-Id: I50039d431fd3e6ba4c0d859d71e42e744433806b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148054 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-01sc: move import tests where they belongXisco Fauli
and remove CppunitTest_sc_bugfix_test, which is no longer needed Change-Id: Idb1cff6580c621e325ce0b836695190d25467a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01tdf#153869 qt: Unminimize window when requestedMichael Weghorn
Remove the `Qt::WindowMinimized` state from the widget's window states if the `SalFrameToTop::RestoreWhenMin` flag is set to request restoring the minimized window. Change-Id: I0cb67f28c1e9c3f48a9a234702a4aaa7e3ffec8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148036 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-01allocate cached values inline in VDataSeriesNoel Grandin
to reduce pointer chasing - these values are all small Change-Id: I96782494f26666657bf35c06136b4b87f29fdd2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148039 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01no need to allocate Gradient separatelyNoel Grandin
it is only one pointer big Change-Id: I21afdeb8015c658c7b9d5db24bceeb8e43694272 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01oox: import directly into docmodel's Theme and ColorSetTomaž Vajngerl
This changes the import to directly fill values of a model::Theme and model::ColorSet, without filling the oox structs first. The goal is to get rid of the oox in the long run, but for now it is necessary to keep reading into both, which is a duplication. The next step is to also fill the FontScheme and FormatScheme structures. Change-Id: I488ec096cbc184bc70d24510ac9091a488540422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-01send theme info when changing color (in the picker) via UNO commandTomaž Vajngerl
Change-Id: I288f8fb3375e152b5ee746fab2c05d08150d6c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146817 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-01CppunitTest_sc_subsequent_filters_test: split in twoXisco Fauli
it already has 109 tests Change-Id: I2261fbf036862c8005db5a8bc15a1fd55a819319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148034 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01Fix typoAndrea Gelmini
Change-Id: I6bc3777231bada3a1abf2a1e57645d9ceb93acb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148048 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01no need to allocate ucbhelper::Content separately in SmartContentNoel Grandin
it is only one pointer big Change-Id: Ic7653a59ceebcc4cd7911fabdfc49537c244f960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01tdf#109214 - Highlight the favorites in the grid of special charactersAndreas Heinisch
Remove visual artifacts around the corners by using horizontal and vertical round. Change-Id: I9821103c43dfbd93e6f295034b05da8b74e802e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148040 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-01fontconfig: upgrade to release 2.14.2Taichi Haradaguchi
Change-Id: I5347580318c752517c9ef7a37d4175a2c6db36bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-01curl: upgrade to release 7.88.1Taichi Haradaguchi
Fixes CVE-2023-23916, 2 CVEs that probably don't affect LO. Reference: https://curl.se/docs/security.html Change-Id: If9b3fc7c5ce66bfe1027caff39ea2c1cf55df7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147673 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-01postgresql: upgrade to release 13.10Taichi Haradaguchi
Fixes CVE-2022-41862 Reference: https://www.postgresql.org/support/security/CVE-2022-41862/ Change-Id: I6075838972fec1c091f3150b19c5da4dc80ad6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147674 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-01git-hooks: overwrite the windows-links not with linux-linksJuergen Funk
Always when you call build or logerrit, then the windows-links overwrite with linux-links, but when you using GIT for Windows you need the windows-links. This patch made a check it is using GIT for Windows, and check what for link it is, when wrong link, it output the .git-hooks/README Improve the check for links, when a link is set not need to set the link anymore In .git-hooks/README improve the FOR with delete of the wrong link look here for GIT for Windows: https://wiki.documentfoundation.org/Development/BuildingOnWindows/de#Cygwin_and_git Change-Id: I9f6ef9aca316058ef74cb2b2d107236f03a2e2ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147458 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-03-01sw floattable: teach the UI about SwFormatFlySplitMiklos Vajna
- in SwFramePage, add a new m_xFlySplitCB and bind it to the flysplit from the UI description - map RES_FLY_SPLIT from the doc model to this new weld::CheckButton - disable the widget for anchor types other than to-para, also completely hide it, unless a frame contains a single table, which simplifies Word filters - add UITest for this Change-Id: I9ef44b5c66679b04c4818dc343870b92f1b6386d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148030 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-01MCGR: support ColorSteps in emf exportArmin Le Grand (allotropia)
Change-Id: I7a784587dd86efee0934fdead26f615ba7f396e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147960 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-03-01merge SfxDocTplService and SfxDocTplService_ImplNoel Grandin
no need for the pimpl pattern here Change-Id: I8b18df1dc4769bc6f3cc49c1d59910a0cd61d471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01Improve the LibreOfficeKit Document::paintThumbnail() APITor Lillqvist
No implementation yet. Change-Id: Ie1dc955bc8b589bd336af0545a2270cbe84a8b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148028 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-03-01sw floattable: update layout when enabling fly split via UNOMiklos Vajna
Changing e.g. the HoriOrientPosition property resulted in a layout update, but setting IsSplitAllowed to true had no effect on the layout. The problem seems to be that the new RES_FLY_SPLIT is not handled in any update notification. Fix the problem by initially handling this the same way as RES_FRM_SIZE is already done, that triggers a 2nd page when a large fly frame is newly allowed to split, for existing fly frames as well. Disabling needs more work, still. Change-Id: I2cba04213286e72384a56a28f2b321f7fd577639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148029 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-01sc: move export tests where they belongXisco Fauli
Change-Id: If2bc32cabcb0d1272b871e8b2676a8c2de05fc00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148015 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01CppunitTest_sc_subsequent_export_test: split in twoXisco Fauli
it already has 101 tests Change-Id: I2fb88e41313049fec649e3592d811a36e10440fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148013 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-01CppunitTest_sw_htmlexport: avoid EmbedImages magic in testEmbedImagesEnabledMiklos Vajna
Set the filter option explicitly, rather than inferring it from the test name. Change-Id: I4af0edce4316b7717512db70e8ad970126e2b3e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148018 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-01Fix typoAndrea Gelmini
Change-Id: I46f400646bc7d2b7456d294290dc2e159ba14874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147966 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01Fix typoAndrea Gelmini
Change-Id: I53e2a2f57ca1f00a07c62918e6e34c57a53fdcf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148022 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01Fix typoAndrea Gelmini
Change-Id: I7a1302f472473171b31a4c2b21c9bfbfe1517904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01Fix typoAndrea Gelmini
Change-Id: Ib620227c38d27d3de1a774f9c3aebfbcc5edd0a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-01Related: tdf#153842 {dsb-DE} group separator is '.' dot instead of NBSPEike Rathke
See also https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=dsb_DE Change-Id: I1f6797829812893aaab711ab670a722673a86a42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148025 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-01create a default theme when SdrPage and SdrModel are createdTomaž Vajngerl
For a document it is expected that it always has a theme available so we need to create a theme with some default attributes set (a default color scheme for now) when we create a SdrModel and SdrPage (only for Writer currently). This also changes some ColorSets, SdrPage, SdrModel methods, to use better return types (cost& instead of raw pointers and vice versa depending on the use case). Change-Id: I874247784b845109e42567e3f45647dda46ccf3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146816 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-02-28Resolves: tdf#153842 {hsb-DE} currency symbol follows amount with blankEike Rathke
Change-Id: Id8a86541d1f8299763274e048f36af95eee03d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148023 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-16 12:03:20 +0000