summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-26PPTX Fix export of rotated group shapesPaul Trojahn
The rotation is already applied to the child shapes and must not be added to the group. Change-Id: Ic564cbcf31a81a248878f0179fdd21144f076b61 Reviewed-on: https://gerrit.libreoffice.org/42765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26sw: fix ~SwIndexReg assert in DelFullPara() importing tdf108272-1.docxMichael Stahl
The code in DelFullPara() returns early if it can't move the rPam out of the to-be-deleted paragraph, but it only checks that the point of the rPam is outside; it then rather pointlessly assigns the 0 index in the node where the mark is, which leaves the mark on the to-be-deleted paragraph. In this modern day and age, after much technological progress, DeleteMark() actually does unregister its SwIndex, so just do that. Change-Id: Ia1643cf0b976857809ee4130efdec37ce831fdef
2017-09-26fail earlier on bad offsetsCaolán McNamara
Change-Id: Ifea7653435743bb652afa68d734ed553b04606d7 Reviewed-on: https://gerrit.libreoffice.org/42804 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#3154 check bounds of special sprmCaolán McNamara
Change-Id: I82566e2f2ad479c392f06ae7149e3781c0338e50 Reviewed-on: https://gerrit.libreoffice.org/41630 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#3457 Unknown ReadCaolán McNamara
similar to commit 35bac83ed2b5d48233c653cc7dc4eab5c234f7ac Date: Mon Aug 7 19:24:37 2017 +0100 ofz#2877: crash in SVTB16Short Change-Id: Idc2ca89647a5e17484effaca49afce349b98f0a3 Reviewed-on: https://gerrit.libreoffice.org/42622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#3186: wrong starting offset for JOHAB 0x6D blockCaolán McNamara
Change-Id: I4de6d9d781b2f2313d8fd338b34dcb31434efe91 Reviewed-on: https://gerrit.libreoffice.org/41638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#3121 check bounds betterCaolán McNamara
Change-Id: Ib1eacda7e4cdf1d0238532f4e38059a9c30556ac Reviewed-on: https://gerrit.libreoffice.org/41626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz timeouts in pptfuzzerCaolán McNamara
Change-Id: Id682c1078359db2e2883b71977efedc79235017c Reviewed-on: https://gerrit.libreoffice.org/42805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#3110 GeneratePLCF only generated word6 sized missing entriesCaolán McNamara
BTE was 2 bytes in word 7- but 4 bytes in word 8+ Change-Id: I24007d26fccc5edc104320bd2eb8f9c62399c988 Reviewed-on: https://gerrit.libreoffice.org/41623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz various timeouts in ww8fuzzerCaolán McNamara
Change-Id: Id633b031d2856dab49bbedc6faf45670a3762c51 Reviewed-on: https://gerrit.libreoffice.org/42801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26ofz#2980 timeoutCaolán McNamara
Change-Id: Id54a6ef74059885728c1dffec10d67c9f56ba684 Reviewed-on: https://gerrit.libreoffice.org/42797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26tdf#112446 ooxmlimport: Orient=NONE when distance is givenJustin Luth
Prior to commit 9920a0bf9d783978cd6f7b97f7528d8aa2571143 the style could only contain the default of NONE. So when a position was specified, it was always paired with HoriOrient == NONE. So it never caused problems until that commit when the Frame's style orientation started overriding the unset paragraph default. When a position is specified, that needs to be paired with an orientation of NONE in order to take effect. Change-Id: Iab0057810270ba708a8855c2ec6db291cef17cfb Reviewed-on: https://gerrit.libreoffice.org/42499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26Fix typosAndrea Gelmini
Change-Id: I9aaefa47399f35d563c1a4df364512dd29db41ce Reviewed-on: https://gerrit.libreoffice.org/42817 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-26Better way to detect Apple Xcode 9 ClangStephan Bergmann
...without also accidentally affecting any upstream Clang 9.0 Change-Id: Ie52413e2e53a2ce01f55b97677fe9878d498b076 Reviewed-on: https://gerrit.libreoffice.org/42809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-26Don't use RTL_TEXTENCODING_DONTKNOW in OUStringToOStringStephan Bergmann
CppunitTest_sc_subsequent_export_test would run into that as below, so better find a more suitable encoding here (similar to what RTFDocumentImpl::getEncoding in writerfilter/source/rtftok/rtfdocumentimpl.cxx does to "Guess based on locale"). > rtl::OUStringToOString(rtl::OUString const&, unsigned short, unsigned int) at include/rtl/ustring.hxx:3662 > XclExpHyperlink::XclExpHyperlink(XclExpRoot const&, SvxURLField const&, ScAddress const&) at sc/source/filter/excel/xecontent.cxx:370 > XclExpHyperlinkHelper::ProcessUrlField(SvxURLField const&) at sc/source/filter/excel/xehelper.cxx:307 > (anonymous namespace)::lclCreateFormattedString(XclExpRoot const&, EditEngine&, XclExpHyperlinkHelper*, unsigned short, unsigned short) at sc/source/filter/excel/xehelper.cxx:471 > XclExpStringHelper::CreateCellString(XclExpRoot const&, EditTextObject const&, ScPatternAttr const*, XclExpHyperlinkHelper&, unsigned short, unsigned short) at sc/source/filter/excel/xehelper.cxx:583 > XclExpLabelCell::XclExpLabelCell(XclExpRoot const&, XclAddress const&, ScPatternAttr const*, unsigned int, EditTextObject const*, XclExpHyperlinkHelper&) at sc/source/filter/excel/xetable.cxx:708 > XclExpCellTable::XclExpCellTable(XclExpRoot const&) at sc/source/filter/excel/xetable.cxx:2569 > ExcTable::FillAsTableXml() at sc/source/filter/excel/excdoc.cxx:589 > ExcDocument::ReadDoc() at sc/source/filter/excel/excdoc.cxx:771 > XclExpXmlStream::exportDocument() at sc/source/filter/excel/xestream.cxx:1113 > oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:495 > oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/filter/oox/excelfilter.cxx:169 > SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2380 > SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1500 > SfxObjectShell::DoSaveAs(SfxMedium&) at sfx2/source/doc/objstor.cxx:1889 > ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) at sc/qa/unit/helper/qahelper.cxx:669 > ScBootstrapFixture::saveAndReload(ScDocShell*, int) at sc/qa/unit/helper/qahelper.cxx:691 > ScExportTest::testTdf111876() at sc/qa/unit/subsequent_export-test.cxx:438 [...] Change-Id: Ia8a07336bc6fc39573676c227a551fbfe50a519e Reviewed-on: https://gerrit.libreoffice.org/42789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-26Special character dialog small fixesTamás Zolnai
Use stock button for OK and identation fixes. Followup changes to: 4020945651b4f3c636980e2103db440b5c55459c Change-Id: I3fe2f2f9a4528d38086db453d7ea71f7ac8b7a9a Reviewed-on: https://gerrit.libreoffice.org/42800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26EPUB export: test link handlingMiklos Vajna
Fails without commit 9480ff6a2b6057410940ff5c40828d5746898a0e (EPUB export: implement link support, 2017-08-17). Change-Id: Icee6ac04ff77d0e9ff66ca1f925d6973b4b342a2 Reviewed-on: https://gerrit.libreoffice.org/42786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26iOS, wrong app path.jan Iversen
changed tar backup path Change-Id: I4a1701d856bcdf6f20d3d869f1ba84a18c67b278
2017-09-26iOS, build instructions.jan Iversen
Added README with instruction on how to build for the different platforms, updated iOS files corresponding Change-Id: I8a85f808841d682bc09f1e3b039192e342ecc484
2017-09-26Call pyuno.private_initTestEnvironment() only onceStephan Bergmann
...instead of once for each class derived from CollectionsTestBase (as listed in pyuno/PythonTest_pyuno_pytests_testcollections.mk), causing the assert(!pSVData->maDeInitHook.IsSet()); in Application::setDeInitHook (vcl/source/app/svapp.cxx) to fire. This is probably far from being idiomatic Python code... Change-Id: I8cd1470c085b16b7b82468a308cfd1dead2db034
2017-09-26sw: convert that to assert, and remove a duplicate OSL_ENSUREMichael Stahl
Change-Id: Id454ed0efbb90cfe3ece0bdedf51f385962ee357
2017-09-26tdf#112574 sw: assert if a frame style contains a RES_ANCHORMichael Stahl
... in SwFrameFormat::Modify(). Change-Id: I3b7ea1493277d8d705bdf77c50fdff49872bac05
2017-09-26tdf#112574 sw: don't insert RES_ANCHOR into style item setsMichael Stahl
Styles don't have anchors, only frames have anchors. When using "New Style from Selection", clear the RES_ANCHOR from the style item set. Also, don't insert it in SwFramePage::DeactivatePage(). This was always broken and reportedly crashes since commit e07feb9457f2ffb373ae69b73dda290140e4005f Change-Id: I9320dbbcae980dfa0b00459b8cd808553d1a04f4
2017-09-26Fix typosAndrea Gelmini
Change-Id: Id8f863963cb2f34d81f2ad82353caaa2d03d59be Reviewed-on: https://gerrit.libreoffice.org/42807 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-26AddressSanitizer: undefined-behaviorCaolán McNamara
Change-Id: I55a92512ad9e1508c49ee3149394196f5be5f162 Reviewed-on: https://gerrit.libreoffice.org/42784 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26Cleanup unused strings in cuiMuhammet Kara
Change-Id: I7ab055f301785a73d189e58465056ac4b2e8b494 Reviewed-on: https://gerrit.libreoffice.org/42783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26loplugin:flatten in swNoel Grandin
Change-Id: I77d92e7adc9af5c88ca1930c25a0585713f9e0d3 Reviewed-on: https://gerrit.libreoffice.org/42788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Unexport the other SolarMutex*Guard templatesJan-Marek Glogowski
The logical follow-up on commit 6d1c8a43586503e703baebabc5330a1898f7ec43. Also complete inlined templates, so no need for explicit export, which actually can break the non-pch build on Windows. Change-Id: Ifebd7608673bba9f3530c01be30bab6414a66976
2017-09-26Unify hyphenator loading and ensure Unicode paths on WindowsMike Kaganski
Change-Id: I2f910194c541cb0b882c69d03b02749ef9b93d29 Reviewed-on: https://gerrit.libreoffice.org/42777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-26tdf#112647: Fixed line spacing is saved incorrectly to PPTXTamás Zolnai
The values were not converted to the right unit. Also the spcPts attribute means an exact value not a minimum one. Change-Id: Ia49683e66153611e96a830f821e3a2487adec505 Reviewed-on: https://gerrit.libreoffice.org/42763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26EPUB export: test not loosing nested list contentMiklos Vajna
Just focus on the content, no formatting yet. Change-Id: I109f049bafae6a20d6b617f3be6a9c4f237e782b Reviewed-on: https://gerrit.libreoffice.org/42785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26TSCP: refactor paragraph metadata field checkAshod Nakashian
This moves the logic into SwEditShell next to the exiting paragraph metadata infrastructure. Change-Id: I6c12bfca3d2e1b2bc8697f03f4de1b7c3e14b95a Reviewed-on: https://gerrit.libreoffice.org/42742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: cleanup more constant stringsAshod Nakashian
Change-Id: I244a3fc7899b3269cfdc76172f5dd57a2b987373 Reviewed-on: https://gerrit.libreoffice.org/42741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: cleanup constant stringsAshod Nakashian
Change-Id: I5c307db7ef1c5980c9ae7706ae95970b5705ab58 Reviewed-on: https://gerrit.libreoffice.org/42740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: paragraph signing implicitly done at cursorAshod Nakashian
Change-Id: I9fc01072373dac0cade7b30c3654827bd82d78cc Reviewed-on: https://gerrit.libreoffice.org/42739 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: sign paragraph from classification dialogAshod Nakashian
Change-Id: Iebd50de0abecb80a4de38257fa2eea10b81962b7 Reviewed-on: https://gerrit.libreoffice.org/42738 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: paragraph classification dialogAshod Nakashian
Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620 Reviewed-on: https://gerrit.libreoffice.org/42737 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#49634 Fix positioning of focus rectangle in Navigator content treeJim Raykowski
https://bugs.documentfoundation.org/show_bug.cgi?id=49634 Change-Id: I3beb41142281b2cda337b457ed287a2cc1f665a6 Reviewed-on: https://gerrit.libreoffice.org/42364 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-26sw: refactor updating paragraph signatureAshod Nakashian
Change-Id: If86e4b1664f88c9e51ab4ac2d819f8726991fa98 Reviewed-on: https://gerrit.libreoffice.org/42736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: refactor inserting paragraph signatureAshod Nakashian
And move signatures to the end of the paragraphs. Change-Id: I56cb501451a52a89dc256432823d10856a6e73dd Reviewed-on: https://gerrit.libreoffice.org/42735 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: move paragraph signature field to the endAshod Nakashian
This is both more readable (esp. at a glance) and for undoing. Change-Id: I817699b4eed15e05b0578d0f08ac451633b1d0dd Reviewed-on: https://gerrit.libreoffice.org/42734 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: improve undo handling of Paragraph SignatureAshod Nakashian
Change-Id: I46f395d5f9105d1d3dac6d2af6e9b43ae95ec78e Reviewed-on: https://gerrit.libreoffice.org/42733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#100065 Fix scale of transformationPaul Trojahn
The shape needs to be flipped to compensate the change of mbFlipH/mbFlipV. Change-Id: I7b680497fee6ae9ed7bbd6f4ed9089d1a25a1deb Reviewed-on: https://gerrit.libreoffice.org/42766 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26tdf#39468: Translate some random German comments and termsJens Carl
Change-Id: I5499676506a7570482388eb153f4667785b016ed Reviewed-on: https://gerrit.libreoffice.org/42770 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-26close sc and sw docshells tooCaolán McNamara
Change-Id: I2cf06762d50736debd63f385dcae3022412ac0c0
2017-09-26ofz#3483 Floating-point-exceptionCaolán McNamara
Change-Id: I3c8dc5e4ec9ce342d2da39459c49eeb0459f76d8
2017-09-26improve unnecessarycatchthrow pluginNoel Grandin
it is not legal to eliminate a catch/re-throw where the re-throw expliciting mentions the exception variable and the exception variable is a non-final class Change-Id: I7fd88b0d004d2efa66aef2c0876e07f203da3c28 Reviewed-on: https://gerrit.libreoffice.org/42782 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26oom in fodpfuzzerCaolán McNamara
Change-Id: Iba6ce63f21f9dfe7187eea81c6d76fad12ccc498
generated by cgit (git 2.34.1) at 2025-01-26 07:29:21 +0000