summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-26UpdateOle never called with a null ScViewData*Caolán McNamara
Change-Id: I5b2bdc633207ae0686e3bf30794b141c474f3f19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-26Fix typoAndrea Gelmini
Change-Id: I508a3ce14e8f02bd51055cc22ff29f44c522b7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103467 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typoAndrea Gelmini
It passed "make check" Change-Id: Ifdea79506b69c316869fff4b78e496a090f77c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103466 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I76287ff3309c78283947886882456a01cdc01725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103463 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: If5061bcbbeeed134fae784187598ce7ea04280c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103445 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ib55618ef7187f46143a0f4a514c608f8c499957e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103460 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I0d3bb7281b8b863d7a5eade7a4e37c6df106cfd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103452 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ic348406fd8b4dfff77687328dfd6824262af9f8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103424 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ic594ef08dbb389c5718202e1ec3408e18bf49b94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103423 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I9114b844b014d561464317ad6f54b54fe5a81d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103454 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I01fc9d96c9850c67d8eac65ed2cb2a76fed7706c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103447 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I61781bccc365630f15a9baef5224012b0775edbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103446 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ia508a9968a21fc8e316a3ec5bb1aa204c4dfc2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103453 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I66b0ea493386cb93780d52b76d5f035ecf7c6541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103451 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I9d95e990c77a7b40046990433b95fccdf0013fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103421 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Typo HANDLE_PRINTHIDENPAGES -> HANDLE_PRINTHIDDENPAGES (sd/UnoDocumentSettings)Julien Nabet
Change-Id: I62a7a92b478df42282ebf49410119cb6a408ffe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103468 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26tools::PolyPolygon -> basegfx in filterNoel Grandin
which needed an extra method on OutputDevice. Also add some utility methods to make future conversion work easier. Change-Id: I57c5bc7505e656a014f2e723fea2aa79271e6515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-26Writer Navigator hidden state fixesJim Raykowski
Document drop on Writer Navigator creates a hidden shell. This patch disallows context menu items that require non-hidden shell content. Change-Id: I25fd86f923c9187fe4c37215ba2b84f9d11912b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103363 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-09-26Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ad7239eb6689164dace222b321bc12f97c0d60b5 - tdf#69908 help for Expert Configuration adjustment of editing tip Change-Id: Iddc1ccbada95d9c66e0e6695daa1abfdddecd449 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103344 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-25tdf#136941 call focus in handler explicitlyCaolán McNamara
Change-Id: I64a6a9867aa34427caeaee3d6835b1fd2da35c1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25Correctly parse real numbers in PDFsFelix Wiegand
The current way of parsing real numbers was not conforming to the PDF standard ([1]), failing to recognize real numbers without a leading zero, such as .6, or numbers with a leading +. [1] PDF 1.7 standard, p. 14 Change-Id: I68eac4796b182f2632aa1152e58d63c054871581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25remove ImpClearVars, set values in the constructorTomaž Vajngerl
Change-Id: I8ff465d5755dae7098293702115ab08055814754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103403 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-25ImpGraphic::swapOutContent: remove chaning when writing to streamTomaž Vajngerl
Change-Id: I6f4428e0054c4697f7a15e2f318dc114d38dade0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103402 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-25change pointers to references where never possible to be nullptrsCaolán McNamara
and drop some null checks then shown not to be needed Change-Id: I2806eeb64f43072a34aecd46424dbd063a119b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25Related: tdf#136985 comment select all adds an undo action to the stackCaolán McNamara
so ctrl+a in an unmodified document causes the undo toolbar item to become active Change-Id: Ie9fe97d64c89d2ca1cacf2ec89408b9ca6e3b418 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25do not assert for slow alpha blending if mirroring is used (tdf#136223)Luboš Luňák
The blend calls obviously will be skipped if mirroring is involved. Given how long it took for somebody to notice, this is probably a rare case, so just alter the assert, until this functionality is actually needed to be fast. Change-Id: If1f558cd4a7aac2bb52b677b5901585d878c6543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103414 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25remove unused importsNoel Grandin
Change-Id: Ib4a334ad929a410d6a19d1f832b202d61cd29336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25tdf#128797 sc: fix invalid detective marks cellsTibor Nagy
If numeric value of cell formatted as text or not and validation set up as text length > 0 to ensure cells are filled. When the detective is used to mark invalid data, the value of cells are marked as invalid. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I3481a6c999871f9a5cf73669d2ac73df1fc0ca20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102322 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-25oox smartart: snake algo: consider child's aspect ratio request for cols/rowsMiklos Vajna
If the child's aspect ratio request will shrink the width, then take that into account when calculating how many rows / cols we need. This reduces the number of columns for the bugdoc from 4 to 3, which is needed, but not enough to render it correctly. Change-Id: I1d02df4834b8a2ce97d5e006db0e3135d3d42917 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103411 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-25forward axial and radial gradient types to VCL tooLuboš Luňák
VCL's drawGradient() can handle them all, at least using a fallback algorithm. And drawinglayer doesn't know which of them are handled directly by the VCL backend used. A catch is that the rendering of tdf#133477 is different, so keep using drawinglayer for the affected gradient types until somebody fixes that. Change-Id: I1719c67c15752c6d1c3431ddfa797ac94d039555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103376 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25headless/cairo drawGradient() fixesLuboš Luňák
Change-Id: I53913262f8f856bf265ce50fc355244445499089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103375 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25use vcl lin. gradient drawing in drawinglayer + cairo impl.Tomaž Vajngerl
This adds a divert for drawing of linear gradients drawing, which can be implemented natively with a much higher quality and speed. This also adds a implementation of drawing linear gradients with cairo. Change-Id: I8c39915c3579e6eb88cdce8ae4ac9694ffdb4957 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103374 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25Skia drawGradient() tweaksLuboš Luňák
Change-Id: Id16a714c19c42b7071162107cbaa96c4ea95674d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103373 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25rename stream variable in swapInContent, swapInTomaž Vajngerl
Change-Id: I7e055c3347682f09ffd2f6b0e287d3d12c22ec46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103401 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-25ImpGraphic: rename Impl{Read,Write}Embedded - used only in swappingTomaž Vajngerl
ImplReadEmbedded and ImplWriteEmbedded are used when swapping only so rename it to swapInContent and swapOutContent. In addition change the swapInFromStream to accept SvStream by reference and not pointer. Change-Id: I2c555c436fe5eb6583d83382a2da278f4890ee08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103400 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-25Related: tdf#136980 cairo: avoid linking to freetype-2.8-only ...Miklos Vajna
... FT_Get_Var_Design_Coordinates This is meant to help producing binaries which run on Ubuntu 16.04. Change-Id: I7fc965c265d2ac97a6836df0829d3d4cd0cc9333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103392 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-25Sidebar gallery updateandreas kainz
Change-Id: I0cbf409f01c0dffb8bad9d31264ab889ee887aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103361 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-25tdf#137014 Sidebar: Image section remove red/green/blue/gammaandreas kainz
Change-Id: Ia726ef0edbed9ee536c9df7b08901ff60e318b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103397 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-25remove unused codeNoel Grandin
Change-Id: I131958be81d56730fee2f4939cf3b70489f7f6e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25value and targetValue cannot be null at this pointNoel Grandin
Change-Id: I175da8a170fcddca083ed47b41c7241433e54db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25socket cannot be null at this pointNoel Grandin
Change-Id: I2027478d1dfa64a3841027d94d8eaa140fe319dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25fix compile error in java test codeNoel Grandin
likely caused by commit 89340fcb6509afd1bffea7b6060d5ff5a444b3f1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed May 20 13:45:07 2020 +0200 use for-range on Sequence in f* but since this code appears to be currently unused, was never caught Change-Id: I0e2f8eade9376ccd18ad9a63e6d5e3012a659938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25rhbz#1882616 move cursor one step at a time in the desired directionCaolán McNamara
until we get to the target position. The break iterator operates in graphemes so we can't just move Left/Right the amount of utf-16 we want to move. Change-Id: I25d4e9285deae374f85dcaadbf4601bc213a89de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 91a282844417fcfebcd4d496d8bac05026faff7a - tdf#98232 More on control points Add screenshot Add image Add contents on control points / shape handlers Change-Id: I135533b8265ec6305291415f5139512d18cf071b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103362 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-25cid#1448292 coverity has difficulty with css::uno::SequenceCaolán McNamara
current attempt isn't working, try a different approach to silence these warnings Change-Id: I0cc97df0897abc665dfbb683d7aa0df55f8affb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-25Sidebar Navigator fix padding and border stuffandreas kainz
Change-Id: I55896806c432710f5254e5e13adef43407e2c4ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103357 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-25don't write metafile action twice in DrawPolyLineDirect()Luboš Luňák
All other functions calling it already do so, so write it only when called from the outside. Change-Id: If17d973a5d6b3797db46e91a1ec36606a89c5d07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103353 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-25tdf#134351: do not apply autofilter if all entries are selectedXisco Fauli
Change-Id: I33cdfe07cc53b579bbe16486f302daf7bd3da841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103352 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-25tdf#136980 cairo: avoid linking to freetype-2.8 symbolsMiklos Vajna
This is meant to help producing binaries on CentOS 7 which run on Ubuntu 16.04, when using internal cairo. Change-Id: Ie4cd3fe707225a951ec8a5fb49a755064701dcfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103378 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-25xor drawing done twice in the same place should be a no-opLuboš Luňák
This extends the VCL backend unittest to check for this, and also fixes Skia to handle that properly. This makes tdf#132241 slow again. The problem there is that it does drawGradient() with xor enabled (for whatever strange reason), and since Skia does not implement drawGradient(), it gets drawn using polygons and their bounds overlap, causing applyXor() after each operation again. Implementing drawGradient() will handle that. Change-Id: Ibea433ad95f8c6d53049f4a49295e57a5aec184f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103280 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>