summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-29disable VSync for Skia/Vulkan on Linux/nVidiaLuboš Luňák
It causes freezes. This can be changed later to a blacklist of older drivers once fixed drivers are actually available. Change-Id: I6cc996aee2ae69d5c8fdd9eb5f9f336683350485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103554 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29blacklist Windows/nVidia for Skia/Vulkan (tdf#135370, tdf#136036, tdf#136407)Luboš Luňák
The bugreports all appear to be specific to Vulkan on Windows with nVidia drivers, and I do not have that OS/HW combination to debug this. So disable Vulkan use there until somebody can do something about it. Change-Id: I0dea7b87b0f72e393ea90985bd2cc64c89671181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29make it possible to blacklist just "windows"Luboš Luňák
OpenGL blacklisting is done only on Windows, so there "all" is fine, but Skia checks blacklisting on Linux too, so add a generic "windows". Change-Id: Ie331ae275d437061b4d185d766663ff3c09261cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103532 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29ensure SolarMutex is held for SkiaZoneLuboš Luňák
This is simply being lazy and requiring the mutex held for all Skia operations. With the effort to verify things it'd presumably be possible to make the code thread-safe. Change-Id: I748dbf2d5af66dcd140b5a9d6d57e9d848babf0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103564 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29add test for 'fix parsing of Vulkan version numbers'Luboš Luňák
Change-Id: I0b7195153354324a95ab438a35186660f1ea65a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103563 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29make vclcanvas try directly VCL for drawing stroked polygon (tdf#136933)Luboš Luňák
There's no point in trying to do all the stroking stuff manually if the VCL function can do it and better/faster. Change-Id: I9949637e2504d9b5d10ac77fbd5bd1f491ea6eee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103313 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29Revert "don't split polypolygon in canvas if not needed" (tdf#136933)Luboš Luňák
With the doc from tdf#136933 basegfx::utils::createNonzeroConform() gets called with huge polygons, which is very expensive. Revert this, I'll fix the Skia problem by directly trying to draw the stroked polygon with VCL. This reverts commit b0788ff11481568b413ff6e4c3ea4871984af974. Change-Id: I19b3435811b6ea38d83bea08056802aac76bf45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103312 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29disentangle AA and B2D use in VCL drawingLuboš Luňák
A number of powerful functions using B2D polygons such as OutputDevice::DrawPolyLineDirect() were used only if AA was enabled. So e.g. dashing for an AA-ed polyline could be drawn directly using the function, but with AA disabled had to be done manually by a number of polygon operations. Which doesn't make much sense, surely these powerful functions can also draw without AA if set so (and indeed that's mostly the case). And DrawPolyLineDirect() even had a flag to bypass the check. So simply try to use B2D-based drawing whenever possible, AA or not. The previous commit had already changed the naming of the AA option to not include B2D in the name. This seems to come from https://bz.apache.org/ooo/show_bug.cgi?id=88795, which doesn't explain why AA only. There are other bugreports such as https://bz.apache.org/ooo/show_bug.cgi?id=101491 and https://bz.apache.org/ooo/show_bug.cgi?id=98289 that are related, but there I cannot see any difference with this patch. And all unit tests pass. Change-Id: Ibb5938e8fff9b7452bac4bf12ed3e42fd3e5d645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103354 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-29tdf#136551 DOTX import: restore support for large XML attribute valuesMiklos Vajna
Regression from commit 82d08580e368afbc9d73da3613845a36a89b0a8c (switch saxparser from expat to libxml2, 2014-11-14), expat used to allow huge XML attribute values, while libxml2 defaults to rejecting values larger than 10MB. This looks like a sane limit, but the bugdoc has some fallback VML markup where the actual graphic content of the shape is base64-encoded in an XML attribute value. libxml2 has an XML_PARSE_HUGE flag to lift this limit, so use that. If this was not a problem with expat, then it should be no problem with libxml2, either. [ No testcase, adding a 10MB test document to the repo is not preferred. ] Change-Id: Ifcd0ce52d3cb95bef36c58aa073bb59bc07490d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103567 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-29Current sytem locale's CharClass for user defined names, tdf#137091 follow-upEike Rathke
Change-Id: I5f025a12ca183acb3f80d2a7527677aceb9ffbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-29Update liborcus to 0.16.1.Kohei Yoshida
Change-Id: I27e87278545c1d41381b1ab8a49f6f6a07681bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103590 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2020-09-29Resolves: tdf#137091 Use CharClass matching the formula languageEike Rathke
... not the current locale. Specifically important for uppercase/lowercase conversions that may yield different results for example in Turkish i with/without dot. Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-28Add extended tips for slant&corner radius tab pageOlivier Hallot
Control points 1 and 2. Change-Id: Ia932b6d938831fffb374db24e2c7906e1eb6db18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103484 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-28export HYPERLINK target in html clipboard exportCaolán McNamara
Change-Id: Ia77e4bd8a5b54636d0e9e561360128202a81420b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103557 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-28Related: tdf#136985 restore focus to doc it wasn't initially in the commentCaolán McNamara
after processing a menu command if we grabbed focus to a comment at the start of the the menu command processing Change-Id: I6cf4b59fc0c5d3e09578cb0466b15ae358cfb0ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103547 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Resolves: tdf#137038 set a max width for crash reporter labelCaolán McNamara
Change-Id: I13f21a1e5bce04191f672c545678c0a8611a34b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103543 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28tdf#137039 move the super long checkbox into the available whitespaceCaolán McNamara
sidestep the awkwardness of wrapping checkboxes and take advantage of the hectare of space to the left Change-Id: Ie2bbd3a1dde3c9d7a3a1d5e1af441183d23b03cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Adapt commentStephan Bergmann
...to b76e903ccc83d0ccf0c6548782622638dd8a0ee5 "dtrans/clipboard: create instances with uno constructors" and 9613165239ade3f0b4d3d06e238430aabc9fcff3 "WIN move dtrans code into vcl/win/dtrans" Change-Id: I65c6096199ee154fd5a1a242971b917c4abb11f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103561 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-28avoid touching system clipboard in testCaolán McNamara
Change-Id: Ie67255f027650676ff3ac7c9c0959cd39f7332b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28SwUndoSetFlyFormat: SwClient::Modify no moreBjoern Michaelsen
Change-Id: I366745a410c8b3f1e6198392d899a16c9ac36b9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103034 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-09-28Destroy CWinClipboard sufficiently earlyStephan Bergmann
At least with a local --host=i686-pc-cygwin --enable-dbgutil Windows `make unitcheck slowcheck` build (i.e., similar to <https://ci.libreoffice.org/job/gerrit_windows/>, which is often failing with aborted builds, presumably due to hung tests), I could once see a CppunitTest hang with just a main thread left at > ntdll.dll!77acc62c() > [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll] > KernelBase.dll!77492863() > rpcrt4.dll!773e55d9() > rpcrt4.dll!77466afb() > combase.dll!7576a02a() > combase.dll!7565072f() > combase.dll!7564b2dd() > combase.dll!7564b246() > combase.dll!756498a4() > combase.dll!757690ef() > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release() Line 166 > at C:\lo\core\include\systools\win32\comtools.hxx(166) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 101 > at C:\lo\core\include\systools\win32\comtools.hxx(101) > vclplug_winlo.dll!CAPNDataObject::~CAPNDataObject() Line 97 > at C:\lo\core\vcl\win\dtrans\APNDataObject.cxx(97) > vclplug_winlo.dll!CAPNDataObject::`scalar deleting destructor'(unsigned int) > vclplug_winlo.dll!CAPNDataObject::Release() Line 137 > at C:\lo\core\vcl\win\dtrans\APNDataObject.cxx(137) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release() Line 166 > at C:\lo\core\include\systools\win32\comtools.hxx(166) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 101 > at C:\lo\core\include\systools\win32\comtools.hxx(101) > vclplug_winlo.dll!CDOTransferable::~CDOTransferable() > vclplug_winlo.dll!CDOTransferable::`scalar deleting destructor'(unsigned int) > cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 > at C:\lo\core\cppuhelper\source\weak.cxx(233) > vclplug_winlo.dll!cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable,com::sun::star::datatransfer::XSystemTransferable>::release() Line 115 > at C:\lo\core\include\cppuhelper\implbase.hxx(115) > vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference<com::sun::star::datatransfer::XTransferable>() Line 110 > at C:\lo\core\include\com\sun\star\uno\Reference.hxx(110) > vclplug_winlo.dll!CWinClipboard::~CWinClipboard() Line 73 > at C:\lo\core\vcl\win\dtrans\WinClipboard.cxx(73) > vclplug_winlo.dll!CWinClipboard::`scalar deleting destructor'(unsigned int) > cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 > at C:\lo\core\cppuhelper\source\weak.cxx(233) > cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::release() Line 86 > at C:\lo\core\cppuhelper\source\implbase.cxx(86) > vclplug_winlo.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::datatransfer::clipboard::XSystemClipboard,com::sun::star::datatransfer::clipboard::XFlushableClipboard,com::sun::star::lang::XServiceInfo>::release() Line 86 > at C:\lo\core\include\cppuhelper\compbase.hxx(86) > vcllo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>::~Reference<com::sun::star::datatransfer::clipboard::XClipboard>() Line 110 > at C:\lo\core\include\com\sun\star\uno\Reference.hxx(110) > vcllo.dll!ImplSVData::~ImplSVData() Line 485 > at C:\lo\core\vcl\source\app\svdata.cxx(485) > vcllo.dll!`rtl::Static<ImplSVData,`anonymous namespace'::private_aImplSVData>::get'::`2'::`dynamic atexit destructor for 'instance''() > ucrtbased.dll!72f16942() > ucrtbased.dll!72f16523() > ucrtbased.dll!72f010ac() > ntdll.dll!77ad9476() > ntdll.dll!77ad9476() > ntdll.dll!77ad93f0() > ntdll.dll!77afcbd8() > ntdll.dll!77aefdc8() > kernel32.dll!77736a14() > ntdll.dll!77aeab4f() > ntdll.dll!77aeab1a() i.e., the ImplSVData::m_xSystemClipboard introduced by 974ea67a7c345a8be98c5aaa59baf9b07959b708 "tdf#129930: Dispose SystemClipboard service early enough" for some reason causing a COM issue when the static ImplSVData aImplSVData (vcl/source/app/svdata.cxx) gets destroyed during exit. And with this change to vcl/source/app/svmain.cxx, I could still see CppunitTests hang with just a main thread left at > [External Code] > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release() Line 166 > at C:\lo\core\include\systools\win32\comtools.hxx(166) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 101 > at C:\lo\core\include\systools\win32\comtools.hxx(101) > vclplug_winlo.dll!CAPNDataObject::~CAPNDataObject() Line 97 > at C:\lo\core\vcl\win\dtrans\APNDataObject.cxx(97) > [External Code] > vclplug_winlo.dll!CAPNDataObject::Release() Line 137 > at C:\lo\core\vcl\win\dtrans\APNDataObject.cxx(137) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release() Line 166 > at C:\lo\core\include\systools\win32\comtools.hxx(166) > vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 101 > at C:\lo\core\include\systools\win32\comtools.hxx(101) > [External Code] > cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 > at C:\lo\core\cppuhelper\source\weak.cxx(233) > vclplug_winlo.dll!cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable,com::sun::star::datatransfer::XSystemTransferable>::release() Line 115 > at C:\lo\core\include\cppuhelper\implbase.hxx(115) > vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference<com::sun::star::datatransfer::XTransferable>() Line 110 > at C:\lo\core\include\com\sun\star\uno\Reference.hxx(110) > vclplug_winlo.dll!CWinClipboard::~CWinClipboard() Line 73 > at C:\lo\core\vcl\win\dtrans\WinClipboard.cxx(73) > [External Code] > cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 > at C:\lo\core\cppuhelper\source\weak.cxx(233) > cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::release() Line 86 > at C:\lo\core\cppuhelper\source\implbase.cxx(86) > vclplug_winlo.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::datatransfer::clipboard::XSystemClipboard,com::sun::star::datatransfer::clipboard::XFlushableClipboard,com::sun::star::lang::XServiceInfo>::release() Line 86 > at C:\lo\core\include\cppuhelper\compbase.hxx(86) > vclplug_winlo.dll!rtl::Reference<CWinClipboard>::~Reference<CWinClipboard>() Line 113 > at C:\lo\core\include\rtl\ref.hxx(113) > [External Code] i.e., the static rtl::Reference<CWinClipboard> g_Instance (vcl/win/dtrans/WinClipboard.cxx) introduced by b76e903ccc83d0ccf0c6548782622638dd8a0ee5 "dtrans/clipboard: create instances with uno constructors" still causing the same COM issue during exit. Change-Id: Ib89d37a4fcb4b4a25e552a9dd14a96ade8e40309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103559 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-28Removed duplicated includeAndrea Gelmini
Change-Id: I0eb3ea540270dd2200c957762139c68eaedd9fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103538 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-09-28remove obsolete gtk2 codeLuboš Luňák
This presumably should have been removed with 1ae450504cf57457f97, and it went unnoticed because the #else matched with the include guard. Change-Id: Ib7a306bad4154b202c89e58cbaedac01c8366bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103558 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-09-28Resolves: tdf#136985 bogus undo steps added by comment manipulationCaolán McNamara
Change-Id: I33d699375dcb1f7a9ed4d30e3f60f7161620c9a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103546 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Related: tdf#136985 apparent phantom redo entries with cursor in commentCaolán McNamara
with a redo element in redo stack but the cursor in a comment the redo dropdown list appears empty even though the toolbar button is active. The problem doesn't appear in the undo case. This typo appears tobe there since original checkin of commit 9b67ca9c73b72a889811123269854ab2ca89d6a9 Date: Tue Feb 19 12:57:51 2008 +0000 INTEGRATION: CWS notes2 (1.1.2); FILE ADDED Change-Id: I8715989c3e9958e3d2a0041129fbed81501057ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103545 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b908b46979dcf004ee504ca95b64a0c9441a3164 - remove l10n on empty paragraph Change-Id: I4f736b14a97e9cefd893b3fee1a2a8e64156c439 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103438 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-28ofz#26000 don't bother with loop if nOrigPos is 0Caolán McNamara
Change-Id: I628bac1c06046155869417190c73d00140e85aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103539 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28move keep ratio checkbox left cause of long translations (german)andreas kainz
Change-Id: I70d09ac5fdd8443167c2cf1980dc64ee2228a8bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103530 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-28Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to eefef8231b5fbbb4148fa57a5a01b5c160a4ad9b - Keep logo text colour white even when visited Change-Id: I5cad9cdaf606b2b809c8e8a39a0dbf82ce15f919 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103548 Tested-by: Jenkins Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-28Resolves: tdf#137071 draw canvas under/over lines after backgroundCaolán McNamara
Change-Id: I066529af010ca4e34b370e462b3e9de1173e6096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103531 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28rename for disentangling AA and B2D use in VCL drawingLuboš Luňák
This renames AntialiasingFlags::EnableB2dDraw to just Enable, and the AntiAliasB2DDraw names to just AntiAlias. This is in preparation for a second commit that will actually separate the AA and B2D functionality of these flags. Change-Id: I9cc215c5752dfabce41e00e19d9074fc8dc3d4de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103416 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-28Fix SSE2 cpuid checksDr. David Alan Gilbert
As per afb62b0e96e9bf91ec99857cc16ddb094bcaa3be swing the actual check into a separate file and make only that file be compiled with the specific flag. Change-Id: If848a041fc3a26cfaa79f945d63f6c43f8cf3772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103497 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-28Fix SSSE3 cpuid checksDr. David Alan Gilbert
As per afb62b0e96e9bf91ec99857cc16ddb094bcaa3be swing the actual check into a separate file and make only that file be compiled with the specific flag. Change-Id: I7f75453f21271f38e0099bdf6b40f9138d8b4cff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103496 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-28adressbook->addressbookCaolán McNamara
Change-Id: Ic72f00a704b7cbb5d1f5639c1cf726cf4693b470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103536 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Related: tdf#137016 check if subcontrol has the focusCaolán McNamara
Change-Id: I632188bc0512c9d8935bd0898c96e066881ebeb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to b7dd30b210d1d080404aed2dc7cf2270a10d1260 - update translations for master and force-fix errors using pocheck Change-Id: Ifb5878eff9d322124054a88241a83402f35e2fa1
2020-09-28tdf#135916 just set the target table as selectionCaolán McNamara
don't save and restore the cursor when the format is applied Change-Id: I320b714193b604cb480a517add4a4a61f5a5128e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28'Jaket' -> EnvelopeCaolán McNamara
Change-Id: Idcf95141ca4169fa0c1580c99a7e51a3df77f640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28sw: prefix members of SwFrameChangesLeave, SwSidebarItem, ...Miklos Vajna
... SwSizeEnterLeave and SwTextAPIObject See tdf#94879 for motivation. Change-Id: Iea12ac975b68700488f7b39bbb3596a011159c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103528 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-28struct OHierarchyElement_Impl was apparently meant to be a classStephan Bergmann
Change-Id: Id95a70b38fae40a83f21df56f13b48b2dd0f7001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103526 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-28tdf#129471 change defaults on Find toolbarSeth Chaiklin
Conclusion from discussion in bug report: - Hide (but keep) "Navigate by" and controls by default on Find toolbar Change-Id: I09866887eaf1c92fa013945f71d1e197e80ff756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103429 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-09-28tdf#108059 Introduce compatibility key for pie chart orientationKelemen Gábor
There is no similar setting in MSO, it just always uses clockwise. LO on the other hand confuses users by using counterclockwise which turns to clockwise upon save to OOXML and reload. Eliminate this behavior by introducing a compatibility key for OOXML-heavy environments that: - sets the orientation to clockwise when pie chart type is selected - hides the checkbox that would have no effect after a save to OOXML Default value is false to keep current behavior Change-Id: I9e12ecad8e9978f960c921a521461aee023a5063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/82524 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-28upload libmwaw 0.3.17David Tardon
Change-Id: I24c6c5a5d93a76a9fcc2213cd48beb8e5a5ca479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103519 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2020-09-28Fix typo in codeAndrea Gelmini
Change-Id: Ifab76c880b1802740689704f929858b261e1f5bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103488 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-28Remove unused include list in filter/OleHandlerJulien Nabet
Change-Id: I5d83463a1e3095838d1255e763245cafb4b286ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103511 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-28Resolves: tdf#133812 Add the 'Result' style again used by the Subtotal toolEike Rathke
Necessary to also adapt the test case that checks for a defined number of styles. Regression from commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc and commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I3e47d8e24d375a64d9056e7a85197b89173c8e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103520 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-27Move default way to find Which to an inline functionBjoern Michaelsen
Change-Id: Ie3aa3f8a2c34c510a391d729f3dc2286f735111a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103066 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-09-27SwTable: Replace Modify with SwClientNotifyBjoern Michaelsen
Change-Id: Ia5eccf6d13bac6a15079ad3f8c7dcbaef519c317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103065 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-09-27never null ScViewData*Caolán McNamara
Change-Id: If5ad4c637a8c4db67ca4bfe99612e90ae6237ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 77cce026db5de5f8d25ee6fe05d084e4f1f1f11b - fix typo in text about master slide footer Change-Id: Icb2c55d9cb2f59462ff6113c95c67b3002b6d045 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103516 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>